October 2015 - Developers - lists.phpmyadmin.net

Removing plugins
by Isaac Bennetch 06 Nov '15

06 Nov '15

As you may recall from the last IRC meeting, I'm working on testing and documentation around issue #6137 [0] by removing some features/plugins/libraries and testing/documenting my success. So far I've had good luck with removing some things (for instance tcpdf), but I've discovered two noteworthy problems. 1) When js/jqplot/ is removed, "Status -> Query statistics" does not fail gracefully, it instead offers to submit a report to the error reporting server. 2) when libraries/gis/ is removed, "Visulize GIS data" does not fail gravefully, instead it gets stuck on saying "Loading..." In comparison, something that degrades very well is the removal of tcpdf; if the pdf library is missing the export dialog simply doesn't show PDF as an export type. So my question is what you think we should do about this -- this is clearly beyond the scope of what is normally expected; it's not normal for a user to remove libraries and code, but in order for this feature request to be improved I think the code should handle this better. Should we spend time on this? 0 - https://github.com/phpmyadmin/phpmyadmin/issues/6137

5 6

Refactoring a controller
by Marc Delisle 29 Oct '15

29 Oct '15

Hi Madhura and Atul, I was looking at indexAction() in DatabaseStructureController.class.php, which is 566 lines. I find it too long to be manageable, and PMD agrees [0]. Do you consider this method a work in progress? Does MVC mandate that indexAction() should remain that size? [0] http://ci.phpmyadmin.net/job/phpMyAdmin/1588/pmdResult/type.-385120790/file… -- Marc Delisle | phpMyAdmin

3 2

Adjust privileges: caching needed
by Marc Delisle 24 Oct '15

24 Oct '15

Hi Deven, after reading https://github.com/phpmyadmin/phpmyadmin/issues/11597 and looking at PMA_checkRequiredPrivilgesForAdjust() I am convinced that this function needs caching. Can you have a look at PMA_analyseShowGrant() and see how we use these functions: PMA_Util::cacheExists() PMA_Util::cacheGet() PMA_Util::cacheSet() -- Marc Delisle | phpMyAdmin

2 1

phpMyAdmin 4.5.1 and 4.4.15.1 are released
by Marc Delisle 23 Oct '15

23 Oct '15

Welcome to phpMyAdmin 4.5.1, a bugfix release containing also a minor security fix, and to 4.4.15.1, containing the same security fix. See https://www.phpmyadmin.net/files/4.5.1/ and https://www.phpmyadmin.net/files/4.4.15.1/ -- The phpMyAdmin team

1 0

Testing request for the upcoming 4.5.1
by Marc Delisle 21 Oct '15

21 Oct '15

Hi phpMyAdmin developers community, we recently started a schedule of monthly bugfix releases, and version 4.5.1 is due Oct 23 [0]. Starting from today, 4.5.1 is bugfix-frozen and due to the numerous fixes it contains [1], we ask for testers. The idea is to try as many features as possible, looking for regressions compared with 4.5.0. You can directly use the git branch MAINT_4_5_1 or download a zip archive [2]. Thanks! [0] https://github.com/phpmyadmin/phpmyadmin/milestones [1] https://github.com/phpmyadmin/phpmyadmin/issues?q=milestone%3A4.5.1+is%3Acl… [2] https://github.com/phpmyadmin/phpmyadmin/archive/MAINT_4_5_1.zip -- Marc Delisle | phpMyAdmin

2 1

Re: [phpMyAdmin Developers] Shortcut keys Implementation to pma.
by Abhishek Kanojia 21 Oct '15

21 Oct '15

Hello, Mine is different from #6068 and #6207 . It is not related to a navigating around the tables or changing ctrl + enter for query execution. Mine works like as follows : Ctrl + d-- takes you to databases. Ctrl + s-- opens the console Ctrl + u -- opens users Ctrl + e -- export database .... and so on. And there will be another key that will enable or disable the shortcuts. Say "ctrl + k". So that any time user want to disable the shortcut can switch back and forth to the feature. On Oct 17, 2015 4:40 PM, "Deven Bansod" <devenbansod.bits(a)gmail.com> wrote: > Hi Abhishek, > > On Sat, Oct 17, 2015 at 3:34 PM, Abhishek Kanojia < > abhishekka3193(a)gmail.com> wrote: > >> Hi , >> >> I have an idea of implementing shortcut keys to phpmyadmin, which is >> what i am currently working on. >> >> Benefits of shortcut keys: >> >> 1. Ease of access >> 2. Keyboard shortcut allows to work faster then simple navigating >> through the link. >> 3. Improves User Interaction with the application. >> >> Need some suggestions on this . >> >> > phpMyAdmin already has some of the shortcuts like Ctrl/Alt + Arrow keys > for > moving across the editable table cells (grid edit) (implemented for issue > #6068 <https://github.com/phpmyadmin/phpmyadmin/issues/6068>) > or 'Ctrl + Enter' for submitting the 'Insert Row' (on tbl_change.php) > form. > Another recent issue that was implemented for usability improvement was : > #6207 <https://github.com/phpmyadmin/phpmyadmin/issues/6207> > > Though these ones are already closed, you can take a look at these for > reference > or even find some more in the issue tracker. > > > Anyways, what type of keyboard shortcuts do you have in mind ? > Could you give an example? > > > > Regards, > Deven Bansod > * <f2012316(a)pilani.bits-pilani.ac.in>* > > _______________________________________________ > Developers mailing list > Developers(a)phpmyadmin.net > https://lists.phpmyadmin.net/mailman/listinfo/developers > >

4 4

Shortcut keys Implementation to pma.
by Abhishek Kanojia 17 Oct '15

17 Oct '15

Hi , I have an idea of implementing shortcut keys to phpmyadmin, which is what i am currently working on. Benefits of shortcut keys: 1. Ease of access 2. Keyboard shortcut allows to work faster then simple navigating through the link. 3. Improves User Interaction with the application. Need some suggestions on this .

2 1

Regarding ajax redirection and javascript functions.
by Abhishek Kanojia 17 Oct '15

17 Oct '15

Q.1 Is there any specific function defined for redirection of link using ajax ? Just working on a new feature stuck at point where redirection is to be made .I would like to know the name of function and its usage already defined for ajax redirection from one link to another. Q.2 For redirecting from one page to another say (from index.php to db_sql.php) , the parameters passed in url are "db","table", "server" and "token". I am able to access token parameter from session. how to access other parameters ? Q.3 How to display dismissible alert (the one that is used to display a change in row) ? Q.4 In which javascript file I should place my code so that it get included in each and every page ? I am using common.js file for this purpose .

2 1

Namespaces and autoloading
by Hugues Peccatte 07 Oct '15

07 Oct '15

Dear developers, The following PR is trying to use namespaces and autoloading for pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR seems to be quite stable now. As almost all PHP files had been updated, this is a huge work to test all cases, all configurations, all features. Would it be possible to have some testers please? Thanks to Marc and Isaac who already did a lot of tests. And thanks to new testers. Have a nice day, H.

3 8