Hi,
I'm designing SQL Query Console, thoughts below need suggestions.
1. Console goes buttom of body, just like this:
[image: 内嵌图片 1]
Is this design in a appropriate size? Or cover the lower part of
Navigation(I don't think)?
Scroll bar which close right screen edge will confuse users,
it's a page scroll bar, looks like a part of Console but doesn't
scroll Console. Is that doesn't matter?
Console is invisible at start, a button at top menu(or nav-panel?
I don't think) and a key shortcut can toggle it.
2. Console will use Code Mirror for make console basic, reference
Chrome dev-tools JS console. For browsers lt IE 8, Console will be
disabled(beacuse of Code Mirror).
Colors we using, for color blind users, such as Chrome did:
[image: 内嵌图片 2]
Should I find other colors instead for warnings and errors, or only
use black?
3.
Commits will push to [my branch], merge al last, is that OK?
Thanks and regards!
--
[my branch]: https://github.com/WhaleWatching/phpmyadmin/tree/console
--
Edward Cheng
Hi,
As the 1st phase of my GSoC project - "Refactoring: Designer/schema
integration", I've started the task 1, which is "Providing a single GUI
editor for schema".
As the "Designer" and "Edit relational schema" pages share overlapping
functionalities, the idea is to bring these two pages and have a more
improved page alone.Under this, functionalities of the "Designer" will be
improved in such a way, by combining features of the "Edit relational
schema" page.
For that I've created some mockups, and already published in my
blog<http://kbyashodha.blogspot.com/2014/05/first-week-of-gsoc-2014.html>
.
[image: Inline image 2]
As shown in the above figure, I've introduced two new buttons into the
"Designer" page, and followings are the functionalities:
*Edit page: *A user can edit/delete an existing page.
*Save as: *coordinates of the table layout can be saved to an existing page
or to a new page.
Apart from these two, while the user is loading the designer page,
- if there are previously saved pages exist, the the first page will be
loaded into the designer by default.
- if there are no such saved pages, then the default table layout will
be loaded.
I'd like to get feedbacks about the above mentioned enhancements.
Best Regards
Bimal.
Hi,
I have started working on Central List of Columns. I had to clarify few
things so writing here.
Central columns list will be stored per database, right ?
But while using all columns will be available to use from all databases to
users ?
Where do we keep "manage central columns list" tab ? I'm thinking Settings
menu tab will be a good place may be ?
This is what I have done till now:
1. config.inc.php - > added line $cfg['Servers'][$i]['central_columns'] =
'pma__central_columns';
how to commit config changes ? as its in git-ignore
2. examples/create_table.sql -> added the Table structure for table
`pma__central_columns`
3. In General settings block on landing page -> added "Manage central list
of columns link" that goes to
prefs_central_columns.php?token=XXXXXXXXXXXXXXXXXXXx
[1.png] As this is a new feature, users wont be knowing anything like that
exist so keeping a link at landing page that points to it should be good.
4. In the settings menu tab added another submenu "manage Central Columns
List" where user can choose columns to add to the list and delete from the
list.[2.png, 3.png]
For adding the columns, we'll give users a dropdown of all databases and
for selected database, checkboxes with columns name/definition to add to
central list.
let me know if any concerns?
Thanks and Regards
- Smita
Hi All,
I'm just exploring the issues raised by scrutinizer. It raise issues like,
variable is not initialized. Have a look at issue [0], complaining on code
segment [1].
Personally I like to initialize variables, before using it, even a value is
assigning at some point of the execution path. In this case we can
initialized it like $x=array('foo');
As I remember Marc mentioned different thought on this kind of situation
(at the LinuxTag booth). You may have good thoughts we should know.
So what we should do for this kind of issue ? Just ignore them since PHP
does not force, or fix them ? Appreciate your thoughts.
[0] : http://goo.gl/HNW8Be
[1] : http://goo.gl/vUj25O
Regards !
--
Chanaka Dharmarathna
*http://chanakaindrajith.blogspot.com/*<http://chanakaindrajith.blogspot.com/>
Hi,
Does this feature mean editing binary and blob fields should be done in
hexadecimals always?
And, even when table is browsed they should be shown in hexadecimal only?
If yes, then there is no need for this $cfg['DisplayBinaryAsHex']?
And for $cfg['ProtectBinary'], IMHO it should not be removed so that users
have and option to disable editing of binary fields to avoid accidental
changes to data (even though they can be edited in hexadecimal form). Also,
BLOB data can be very large and if we remove this config. var. then
whenever someone will try to edit row then every time that BLOB field data
will be displayed (which can be very very large) will have performance
issue as well as it can annoy the user.
Feature Request Link :
https://sourceforge.net/p/phpmyadmin/feature-requests/982/
--
Regards,
Chirayu Chiripal
phpMyAdmin Intern - Google Summer of Code 2014
https://chirayuchiripal.wordpress.com/
Hi Everyone,
This week I started developments on my project. I want to take community's
opinion on work I've done so far. Look at the commits [0] & [1].
Currently `common.inc.php` does all error handling initializations. All the
run time php errors are already being collected in an object of `
PMA_Error_Handler` pointed globally by `$GLOBALS['error_handler']`.
Now, to report all errors I have created a separate script named
'common_error_reporting.inc.php' which is intended to be included at the
end of all "*relevant*" scripts. Currently it dumps all collected errors in
a local-temporary file named "pma_error_log.txt" (which will be removed in
next week's work). To demonstrate the working of `
common_error_reporting.inc.php`, I've included that script at the end of `
index.php`. Please have a look at it at [0] & [1].
Is there any better way of doing the same? Please point out if I can
improve it any further. If there are no changes required in it then I would
do the same for all "*relevant*" scripts.
Another doubt I have is about the relevance of scripts. Which scripts
should be consider as relevant here?? I am thinking of considering all
scripts that are directly called by user/browser. I think error reporting
script does not need to be included at the end of class files and such
other library files. In my opinion, the error reporting script should be
included at the end of all scripts in project root directory and not in any
files inside `/libraries/` directory. Am I correct on this?
I also found that PMA triggers errors manually (using trigger_error()) for
all the missing extensions and to raise other such user warnings. These
warnings are also currently collected by error handler. Do we need to
report them?? Or should the errors of E_USER_WARNING type just be ignored
while sending reports?
Please provide your valuable suggestions and do correct me if I am wrong
anywhere. If possible do it at the earliest so that I can incorporate them
at an early stage.
[0]:
https://github.com/dhananjay92/phpmyadmin/commit/7bdad8efe33bed52d25e13ca1c…
[1]:
https://github.com/dhananjay92/phpmyadmin/commit/b137255bb617f7f00ac4b734d8…
Thanks,
Dhananjay Nakrani.
Hi, looking at [1], the Travis build failed in some cases, but it looks
to me as if it's just one of the strange Travis failures we have
(specifically the line "Server error occurred. status: 504 Gateway
Time-out" seems to me a testing server problem rather than a failing
test). Would someone with a better understanding of the test suite mind
confirming my understanding?
1 - https://github.com/phpmyadmin/phpmyadmin/pull/1183
On 5/10/14, Isaac Bennetch <bennetch(a)gmail.com> wrote:
> Hello,
>
> 6) The resulting data in the Monitor view (after selecting a region/time
> to focus on) is displayed in a table-like format but is not sortable.
> J.M. suggests that it should be.
>
I just checked on QA_4_2 and clicking on any column name area does
sort the table. But, yes the up and down arrows to provide sorting
hint are absent.
--
Atul Pratap Singh
http://blog.atulsisodia.in/