Since I catch uncaught exceptions there is a chance that the page
would be unusable. should I refresh the page or redirect to the
homepage or should I just leave it as is.
Using window.onerror I don't have access to the stacktrace. to get the
stacktrace I need to surround code by try and catch.
I may be able to use javascript to change all references to global
functions and surround them by try and catch statements. surrounding
each and every global function in the window namespace would probably
create a performance hit. however doing the same for only a subset of
functions may be easier. I may for example surround only functions
that start with PMA_ and the functions in the AJAX object.
According to this test [0] the performance hit is not that great so it
may not hurt to add try and catch to all methods but I don't like to
play with code that I donot own since it may cause problems that I may
not be able to understand.
What I am trying to ask is should I surround only PMA_ and AJAX
functions or should I add some extra functions (such as jquery
functions) to the list or should I skip this entirely and rely only on
line number and file name from the window.onerror
Hi devs,
I am refactoring sql.php and I realized in line 389 of file the check for
a call to a stored procedure is done by using regexp. I would like to know
is it ok to keep it like that or is there any better approach to handle
that.
Regards Supun.
See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3649/changes>
Changes:
[madhura.cj] Fix indentation
[weblate] Translated using Weblate (Traditional Chinese)
------------------------------------------
Started by GitHub push by madhuracj
Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@5143f787
Using strategy: Default
Last Built Revision: Revision 09e2cc1f0121140dfe410e63dbe037c4ce2d35f4 (origin/master)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 5ce7afdca41758bf43c1b215b41a5de6e88c98f5 (origin/master)
Checking out Revision 5ce7afdca41758bf43c1b215b41a5de6e88c98f5 (origin/master)
[workspace] $ /bin/sh -xe /tmp/hudson9036036752168794028.sh
+ ./scripts/generate-mo --quiet
po/zh_TW.po:10937: a format specification for argument 2, as in 'msgstr[0]', doesn't exist in 'msgid_plural'
po/zh_TW.po:10946: a format specification for argument 2, as in 'msgstr[0]', doesn't exist in 'msgid_plural'
msgfmt: found 2 fatal errors
Build step 'Execute shell' marked build as failure
[CHECKSTYLE] Skipping publisher since build result is FAILURE
[DRY] Collecting duplicate code analysis files...
[DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml
[DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
[DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 38 warnings.
[DRY] Computing warning deltas based on reference build #3648
[TASKS] Skipping publisher since build result is FAILURE
[ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3648
Recording plot data
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing PHPUnit-3.x (default)
[xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'.
[xUnit] [ERROR] - Test reports were found but not all of them are new. Did all the tests run?
* <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml> is 18 hr old
[xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated.
[xUnit] [INFO] - There are errors when processing test results.
[xUnit] [INFO] - Skipping tests recording.
[xUnit] [INFO] - Stop build.
I have attached some screenshots [0] of the current implementation of the
error report dialog. when an error occurs a small notification appears
at the bottom asking the user if he wants to submit an error report.
if he does the modal dialog is opened showing him the info that would
be sent and asking him for any additional info he might have.
what do you think?
[0] http://imgur.com/a/IJ7iW/all
Hi,
The navigation bar permits to navigate within a results set; it contains
the page number selector, the begin/previous/next/end arrows, etc.
Reading [0], I noticed that there is much room for improvement. Based on
this feature request, here are my recommendations:
1. Remove the "Headers every __ rows" dialog; it's too prominent, is not
often changed and is configurable via normal config and user prefs
2. Change the default number of rows from 30 to 25 (related to the next
suggestion)
3. Replace the input field in "Number of rows" with a dropdown
containing preset values 25/50/100/250/500. Selecting a value would
immediately have an effect. I never felt the need to display, say, 37
rows in a page. This flexibility harms usability.
4. Remove the "Show" button and the Start row dialog. I rarely have to
change the starting row value. Arrows and page selectors are sufficient
to navigate (not mentionning Search).
Comments are more than welcome.
[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1434/
--
Marc Delisle
http://infomarc.info
Hi,
I was writing some unit tests for the native string functions. However, since some of the functions are declared twice (with different implementations), for e.g., PMA_strlen, PMA_strpos, etc. have different implementations in string_mb.lib.php and string_native.lib.php, it causes phpunit to throw fatal errors of the form "Cannot redeclare function … already declared in …"
Possible solutions could be to use namespaces or to use polymorphism in some way.
Please advice.
Thanks.
--
Ayush Chaudhary
The javascript files seem to be cached pretty aggressively in my
phpmyadmin. I have to clear the cache on each code change so that it
is reflected. Is there some setting in phpmyadmin to help me with the
cache problem or is the problem with my server configuration