Hi all,
I am refactoring the server_binlog.php, I want to check whether my changes break something. but I don't how can I access binlog.php?
In other word, how can I see the server_binlog.php page ?
thanks
Bin Zu
Hi,
in AuthenticationCookie.class.php we verify whether $_COOKIE is empty,
because at this point we have sent some cookies. The goal is to warn
users about their browser not accepting cookies.
However, it's too early to do this verification, because "Once the
cookies have been set, they can be accessed on the next page load with
the $_COOKIE" (PHP manual).
We are not yet at the next page load. The result is that all browsers,
correctly set to accept cookies, when running phpMyAdmin for the first
time, show the "Cookies must be enabled past this point" message,
alerting users for nothing.
Maybe we could force a page reload after the initial cookies sending,
but I'm not sure it's a good solution.
I suggest to
- remove this verification
- in the "Cannot start session without errors" message (which can be
caused by a browser not accepting cookies), add a hint that not
accepting cookies is a possible cause
Comments?
--
Marc Delisle
http://infomarc.info
We are pleased to announce that phpMyAdmin has accepted 6
students/projects for Google Summer of Code 2013 [0] :
- AJAX error reporting : Mohamed Ashraf
- Automated Testing : Adam Kang
- Automated Testing : Ayush Chaudhary
- Interface improvements : Kasun Chathuranga
- Re-factoring: server view : Bin Zu
- Refactoring: SQL Executor, Column's Structure Manipulation : Supun Nakandala
Details about the projects can be found on our wiki [1].
We wish all students good luck and look forward to their contributions
to the project.
[0] https://www.google-melange.com/gsoc/homepage/google/gsoc2013
[1] http://wiki.phpmyadmin.net/pma/GSoC_2013_Projects
--
Kind regards,
Dieter Adriaenssens
GSoC 2013 org co-admin
Hi,
any objection to remove the text/plain: Sql transformation? It's used to
pretty-print SQL code located inside a column.
Not sure this is much used and we would have to adapt this to use
CodeMirror.
--
Marc Delisle
http://infomarc.info