Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Double-checking a commit
by Isaac Bennetch 17 May '13

17 May '13

Hi, I just merged the pull request for AES_ENCRYPT [1], which required a little bit of manual work to complete the merge. I thought everything went well, except the commit history [2] looks strange to me. Would someone mind double-checking that I didn't inadvertently do something wrong? I pretty much followed the GitHub instructions, but this is the first time I've done a merge where I committed back to the project repository rather than my private one, so I'm a bit extra cautious. Thanks 1 - https://github.com/phpmyadmin/phpmyadmin/pull/290 2 - https://github.com/phpmyadmin/phpmyadmin/commit/8fbad56812f0b5b0730b07961c7…

4 8

[Phpmyadmin-devel] Safari and image display/CSP
by Isaac Bennetch 16 May '13

16 May '13

Hi, On IRC this morning, the user brightbeat reported that using phpMyAdmin 4.0.0 and 4.0.1 with Safari 5.1.9 results in no images being displayed at the error message "Refused to load image from 'phpmyadmin/themes/pmahomme/img/logo_right.png' because of Content-Security-Policy' I also tested with 5.1.7 under Windows and, while at the moment I don't see any error message, every image is missing and seems to be displaying ./themes/dot.gif 1px by 1px. According to some random site I found on the internet, CSP support is a bit behind on Safari 5, so it seems reasonable to me to exclude support for Safari 5 if need be. I'll point out that Safari 5 is the latest version available for Windows and old MacOS versions, not really supported by Apple any more but still available. I don't know enough about how CSP works to know if this is an easy fix or what the problem is. Is it worth opening a bug ticket or should we depreciate support for Safari 5?

2 1

[Phpmyadmin-devel] Regarding Export plugin for sql
by ayush choubey 16 May '13

16 May '13

There were a couple of things that i wanted to know 1) I was going through the this feature request https://sourceforge.net/p/phpmyadmin/feature-requests/1387/ and i too wasn't able to figure out how to change database name. Has that feature been implemented 2) while exporting the database there is no create database sql statement for example : there is a db called test with certain number of tables. I selected the database, clicked on export, clicked custom and exported it. However only the tables were exported. There were no create statement Shouldn't the entire database be exported with create database statement? Is this a bug or was this not implemented intentionally

2 6

[Phpmyadmin-devel] phpMyAdmin 4.0.1 is released
by Marc Delisle 14 May '13

14 May '13

Welcome to phpMyAdmin 4.0.1, a bugfix version. Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] ready for 4.0.1?
by Marc Delisle 14 May '13

14 May '13

Hi, after 2630 downloads of -rc1, I bet that the time is ripe for 4.0.1. -- Marc Delisle http://infomarc.info

4 3

[Phpmyadmin-devel] WebDriver ?
by Marc Delisle 13 May '13

13 May '13

Hi, maybe WebDriver could be useful for UI testing. Look for WebDriver in [0]. [0] http://lwn.net/Articles/548474/ -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Feature request #1397 - Include fractional seconds in timestamp
by Kasun Chathuranga 12 May '13

12 May '13

Hi all, I am interested in the feature request #1397 [1], which requests that phpMyAdmin support fractional seconds in time, datetime and timestamp data types. After bit of research I found that these data types support trailing fractional seconds up to microseconds (6 digits). For example, the syntax for datetime including fractional seconds would be '2013-04-23 11:21:07.145236'. This syntax is supported from version 5.0 [2], however the fractional seconds were discarded when storing. From version 5.6.4 onwards these fractional seconds are stored and hence this feature request is important. I have looked into the code to implement this feature request and the major problem faced is the incompatibility of JavaScript timepicker used [4], which only supports up to milliseconds (3 digits). I have been improving this JS file to support microseconds, however it is a somewhat big change. I'd like to know whether I should simply alter the external JS file in phpMyAdmin code or I should send a pull request to the timepicker project, so it will be a part of the timepicker project as well. However, with the second option it might take some time till they (hopefully) accept the patch and do a release containing it. Your thoughts on this would be highly appreciated. [1] https://sourceforge.net/p/phpmyadmin/feature-requests/1397/ [2] https://dev.mysql.com/doc/refman/5.0/en/datetime.html [3] https://dev.mysql.com/doc/refman/5.6/en/datetime.html [4] http://trentrichardson.com/examples/timepicker/ -- Regards Kasun Chathuranga

2 5

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3352
by michal＠cihar.com 12 May '13

12 May '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3352/changes> Changes: [pe.chanaka.ck] Added missing semicolon ------------------------------------------ [...truncated 22 lines...] [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] PHPUnit 3.7.19 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.nocoverage> [exec] [exec] ............................................................[33;1mI[0m 61 / 1235 ( 4%) [exec] ............................................................. 122 / 1235 ( 9%) [exec] ............................................................. 183 / 1235 ( 14%) [exec] ............................................................. 244 / 1235 ( 19%) [exec] ............................................................. 305 / 1235 ( 24%) [exec] ............................................................. 366 / 1235 ( 29%) [exec] ............................................................. 427 / 1235 ( 34%) [exec] ............................................................. 488 / 1235 ( 39%) [exec] ......................................................[36;1mS[0m[36;1mS[0m[36;1mS[0m[36;1mS[0m... 549 / 1235 ( 44%) [exec] ............................................................. 610 / 1235 ( 49%) [exec] ............................................................. 671 / 1235 ( 54%) [exec] ............................................................. 732 / 1235 ( 59%) [exec] ............................................................. 793 / 1235 ( 64%) [exec] ............................................................. 854 / 1235 ( 69%) [exec] ............................................................. 915 / 1235 ( 74%) [exec] ............................................................. 976 / 1235 ( 79%) [exec] ............................................................. 1037 / 1235 ( 83%) [exec] ............................................................. 1098 / 1235 ( 88%) [exec] ............................................................. 1159 / 1235 ( 93%) [exec] ............................................................. 1220 / 1235 ( 98%) [exec] ..............[33;1mI[0m [exec] [exec] Time: 10 seconds, Memory: 68.00Mb [exec] [exec] There were 2 incomplete tests: [exec] [exec] 1) PMA_ConfigTest::testCheckPermissions [exec] This test has not been implemented yet. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Conf…>:797 [exec] /usr/bin/phpunit:46 [exec] [exec] 2) Environment_Test::testSession [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/Environment_test…>:83 [exec] /usr/bin/phpunit:46 [exec] [exec] -- [exec] [exec] [exec] There were 4 skipped tests: [exec] [exec] 1) PMA_HeaderLocation_Test::testSendHeaderLocationWithSidUrlWithQuestionMark [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:234 [exec] /usr/bin/phpunit:46 [exec] [exec] 2) PMA_HeaderLocation_Test::testSendHeaderLocationWithSidUrlWithoutQuestionMark [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:254 [exec] /usr/bin/phpunit:46 [exec] [exec] 3) PMA_HeaderLocation_Test::testSendHeaderLocationWithoutSidWithIis [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:280 [exec] /usr/bin/phpunit:46 [exec] [exec] 4) PMA_HeaderLocation_Test::testSendHeaderLocationWithoutSidWithoutIis [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:296 [exec] /usr/bin/phpunit:46 [exec] [30;43m[2KOK, but incomplete or skipped tests! [exec] [0m[30;43m[2KTests: 1235, Assertions: 2228, Incomplete: 2, Skipped: 4. [exec] [0m[2K phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 22 exact clones with 561 duplicated lines in 24 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-138 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2745-2751 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:140-257 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:145-262 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:206-213 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1868-1875 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:202-209 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:217-224 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:205-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:213-219 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:206-212 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:336-342 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:564-579 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:278-296 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:282-300 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:392-412 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:425-445 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:442-451 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:473-482 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:589-635 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:608-654 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:908-946 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:916-954 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:908-952 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:788-832 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:612-640 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:650-678 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:392-413 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Visi…>:232-253 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:442-451 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Visi…>:282-291 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:589-646 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Visi…>:389-446 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:757-823 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Visi…>:602-668 [exec] [exec] 0.39% duplicated lines out of 142688 total lines of code. [exec] [exec] Time: 10 seconds, Memory: 123.50Mb [exec] Result: 1 phpcs: [exec] Time: 01:41, Memory: 58.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 400 [exec] [exec] Lines of Code (LOC): 142688 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 44448 [exec] Non-Comment Lines of Code (NCLOC): 98240 [exec] [exec] Namespaces: 0 [exec] Interfaces: 2 [exec] Traits: 0 [exec] Classes: 198 [exec] Abstract: 26 (13.13%) [exec] Concrete: 172 (86.87%) [exec] Average Class Length (NCLOC): 213 [exec] Methods: 1572 [exec] Scope: [exec] Non-Static: 1316 (83.72%) [exec] Static: 256 (16.28%) [exec] Visibility: [exec] Public: 1175 (74.75%) [exec] Non-Public: 397 (25.25%) [exec] Average Method Length (NCLOC): 26 [exec] Cyclomatic Complexity / Number of Methods: 4.33 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 713 [exec] [exec] Constants: 163 [exec] Global constants: 107 [exec] Class constants: 56 jshint: [exec] Result: 1 BUILD SUCCESSFUL Total time: 2 minutes 17 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 3032 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3351 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 43 warnings. [DRY] Computing warning deltas based on reference build #3351 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 566 files to scan for tasks [TASKS] Found 206 open tasks. [TASKS] Computing warning deltas based on reference build #3351 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3351 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [INFO] - Check 'Failed Tests' threshold. [xUnit] [INFO] - Check 'Skipped Tests' threshold. [xUnit] [INFO] - Setting the build status to SUCCESS [xUnit] [INFO] - Stopping recording. ERROR: Publisher hudson.plugins.violations.ViolationsPublisher aborted due to exception java.io.EOFException: no more data available - expected end tags </file></jslint> to close start tag <file> from line 3 and start tag <jslint> from line 2, parser stopped on TEXT seen ...var/lib/jenkins/jobs/phpMyAdmin-continuous/workspace/js/OpenStreet... @3:81 at org.xmlpull.mxp1.MXParser.fillBuf(MXParser.java:3035) at org.xmlpull.mxp1.MXParser.more(MXParser.java:3046) at org.xmlpull.mxp1.MXParser.parseAttribute(MXParser.java:2026) at org.xmlpull.mxp1.MXParser.parseStartTag(MXParser.java:1799) at org.xmlpull.mxp1.MXParser.nextImpl(MXParser.java:1127) at org.xmlpull.mxp1.MXParser.next(MXParser.java:1093) at hudson.plugins.violations.parse.AbstractParser.skipToTag(AbstractParser.java:189) at hudson.plugins.violations.types.jslint.JsLintParser.execute(JsLintParser.java:29) at hudson.plugins.violations.parse.AbstractTypeParser.parse(AbstractTypeParser.java:57) at hudson.plugins.violations.ViolationsCollector.doType(ViolationsCollector.java:187) at hudson.plugins.violations.ViolationsCollector.invoke(ViolationsCollector.java:114) at hudson.plugins.violations.ViolationsCollector.invoke(ViolationsCollector.java:25) at hudson.FilePath.act(FilePath.java:904) at hudson.FilePath.act(FilePath.java:877) at hudson.plugins.violations.ViolationsPublisher.perform(ViolationsPublisher.java:74) at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:36) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:804) at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:776) at hudson.model.Build$BuildExecution.post2(Build.java:183) at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:726) at hudson.model.Run.execute(Run.java:1600) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:241)

1 0

[Phpmyadmin-devel] tabs greyed out but still working
by Marc Delisle 10 May '13

10 May '13

Hi, when discussing [0], a question arose. When phpMyAdmin thinks that there are no rows, some tabs are greyed out. However they can still be clicked , because by the time the page has been displayed, another process might have written some rows to this table. But clickable greyed out tabs is confusing for some users. Let's decide about this (for 4.1): 1. no longer grey out 2. grey out but not clickable 3. status quo [0] https://sourceforge.net/p/phpmyadmin/bugs/3904/ -- Marc Delisle http://infomarc.info

7 6

[Phpmyadmin-devel] phpMyAdmin 4.0.1-rc1 is released
by Marc Delisle 10 May '13

10 May '13

Welcome to the first release candidate for phpMyAdmin 4.0.1, a bugfix version. Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers