- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] phpMyAdmin 4.0.1-rc1 is released
by Marc Delisle 10 May '13

10 May '13

Welcome to the first release candidate for phpMyAdmin 4.0.1, a bugfix version. Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Patch for downstream
by Remi Collet 10 May '13

10 May '13

Please consider this patches for 4.0.1 1/ Allow to use system tcpdf (as for gettext) https://github.com/remicollet/phpmyadmin/commit/4eb620b13b29c566f868800b6ae… 2/ Compatibility with tcpdf 6.0 https://github.com/remicollet/phpmyadmin/commit/6d181676fab4c531f499cdafdc8… Regards, Remi. P.S. Sorry, I will not send any more PR, github is just a nightmare for an occasional contributor.

4 9

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3334
by michal＠cihar.com 10 May '13

10 May '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3334/changes> Changes: [michal] Better function names [michal] Wrap some long lines ------------------------------------------ Started by GitHub push by nijel Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@bdf6623 Using strategy: Default Last Built Revision: Revision 3e6466a60f09cc9a22858c37ca661d41e84911d1 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision 0b55726fa1945831fe2efbd673dd53464a5ca99e (origin/master) Checking out Revision 0b55726fa1945831fe2efbd673dd53464a5ca99e (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson1165547443056493986.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] PHP Parse error: syntax error, unexpected '.' in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/relation.li…> on line 773 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] Result: 255 phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 22 exact clones with 561 duplicated lines in 24 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-138 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2734-2740 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:135-252 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:135-252 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:206-213 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1868-1875 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:202-209 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:217-224 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:205-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:213-219 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:206-212 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:336-342 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:563-578 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:278-296 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:282-300 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:392-412 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:425-445 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:442-451 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:473-482 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:589-635 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:608-654 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:908-946 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:916-954 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:908-952 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:788-832 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:612-640 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:650-678 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:392-413 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Visi…>:232-253 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:442-451 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Visi…>:282-291 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:589-646 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Visi…>:389-446 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:757-823 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Visi…>:602-668 [exec] [exec] 0.39% duplicated lines out of 142485 total lines of code. [exec] [exec] Time: 8 seconds, Memory: 123.25Mb [exec] Result: 1 phpcs: [exec] Time: 01:29, Memory: 58.50Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 399 [exec] [exec] Lines of Code (LOC): 142485 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 44346 [exec] Non-Comment Lines of Code (NCLOC): 98139 [exec] [exec] Namespaces: 0 [exec] Interfaces: 2 [exec] Traits: 0 [exec] Classes: 198 [exec] Abstract: 26 (13.13%) [exec] Concrete: 172 (86.87%) [exec] Average Class Length (NCLOC): 213 [exec] Methods: 1572 [exec] Scope: [exec] Non-Static: 1316 (83.72%) [exec] Static: 256 (16.28%) [exec] Visibility: [exec] Public: 1175 (74.75%) [exec] Non-Public: 397 (25.25%) [exec] Average Method Length (NCLOC): 26 [exec] Cyclomatic Complexity / Number of Methods: 4.33 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 707 [exec] [exec] Constants: 163 [exec] Global constants: 107 [exec] Class constants: 56 jshint: [exec] Result: 1 BUILD SUCCESSFUL Total time: 1 minute 49 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2988 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3333 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 43 warnings. [DRY] Computing warning deltas based on reference build #3333 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 565 files to scan for tasks [TASKS] Found 206 open tasks. [TASKS] Computing warning deltas based on reference build #3333 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3333 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.x (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 1

[Phpmyadmin-devel] ready for 4.0.1-rc1?
by Marc Delisle 10 May '13

10 May '13

Hi, we have a nice pile of fixes in QA_4_0 and I think we are due for MAINT_4_0_1 and a 4.0.1-rc1 release. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] Bug Fixes and Proposal Edit
by Abhishek Kandoi 09 May '13

09 May '13

There is something that I would like to ask for... As my exams were going on, I was not able to fix many bugs, just one for the deadline thing. Now that my exams are over I am into this thing, and trying to fix more bugs. I would like the organisation to allow me to edit my proposal, so that I could include details about my contributions to the phpMyAdmin project. Thanking you -- Abhishek Kandoi First Year, Computer Science and Engineering Indian Institute of Technology Roorkee About Me : about.me/kandoiabhi

3 4

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3291
by michal＠cihar.com 09 May '13

09 May '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3291/changes> Changes: [weblate] Translated using Weblate (Azerbaijani) [weblate] Translated using Weblate (Catalan) [weblate] Translated using Weblate (Croatian) [weblate] Translated using Weblate (Danish) [weblate] Translated using Weblate (French) [weblate] Translated using Weblate (Italian) [weblate] Translated using Weblate (Japanese) [weblate] Translated using Weblate (Kazakh) [weblate] Translated using Weblate (Korean) [weblate] Translated using Weblate (Latvian) [weblate] Translated using Weblate (Malay) [weblate] Translated using Weblate (Persian) [weblate] Translated using Weblate (Portuguese (Brazil)) [weblate] Translated using Weblate (Serbian) [weblate] Translated using Weblate (Spanish) [weblate] Translated using Weblate (Tamil) [weblate] Translated using Weblate (Tatar) [weblate] Translated using Weblate (Thai) [weblate] Translated using Weblate (Traditional Chinese) [weblate] Translated using Weblate (Turkmen) [weblate] Translated using Weblate (Uzbek (latin)) [weblate] Translated using Weblate (Welsh) [marc] Bug #3908 Calendar widget improperly redirects to home fixed [marc] Code cleanup [marc] ChangeLog entry for bug #3908 [marc] Fix merge conflict ------------------------------------------ Started by GitHub push by weblate Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@108d02eb Using strategy: Default Last Built Revision: Revision 9cc9316238c3624fa9e30adcf015c71cf58343cb (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision fa16a717bca507ce3268cef1bef55b7e34d199a4 (origin/master) Checking out Revision fa16a717bca507ce3268cef1bef55b7e34d199a4 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson1279521022197684311.sh + ./scripts/generate-mo --quiet po/es.po:12546: missing `msgstr' section po/es.po:12547:2: syntax error po/es.po:12547: keyword "HEAD" unknown po/es.po:12561: duplicate message definition... po/es.po:6840: ...this is the location of the first definition po/es.po:12565: duplicate message definition... po/es.po:6844: ...this is the location of the first definition po/es.po:12569: duplicate message definition... po/es.po:6849: ...this is the location of the first definition po/es.po:12576: duplicate message definition... po/es.po:6855: ...this is the location of the first definition po/es.po:12580: duplicate message definition... po/es.po:6859: ...this is the location of the first definition po/es.po:15235:2: syntax error po/es.po:15235: keyword "QA_4_0" unknown msgfmt: found 10 fatal errors po/fr.po:12537: missing `msgstr' section po/fr.po:12538:2: syntax error po/fr.po:12538: keyword "HEAD" unknown po/fr.po:12539: keyword "HEAD" unknown po/fr.po:12543: keyword "QA_4_0" unknown po/fr.po:12546: keyword "QA_4_0" unknown msgfmt: found 6 fatal errors po/ms.po:140:2: syntax error po/ms.po:140: keyword "HEAD" unknown po/ms.po:147:2: syntax error po/ms.po:147: keyword "QA_4_0" unknown msgfmt: found 4 fatal errors po/th.po:727:2: syntax error po/th.po:727: keyword "HEAD" unknown po/th.po:729: missing `msgstr' section po/th.po:730:2: syntax error po/th.po:731: missing `msgstr' section po/th.po:732: keyword "QA_4_0" unknown po/th.po:781:2: syntax error po/th.po:781: keyword "HEAD" unknown po/th.po:786:2: syntax error po/th.po:790:2: syntax error po/th.po:790: keyword "QA_4_0" unknown po/th.po:6761: duplicate message definition... po/th.po:789: ...this is the location of the first definition msgfmt: found 12 fatal errors po/zh_TW.po:8634:2: syntax error po/zh_TW.po:8634: keyword "HEAD" unknown po/zh_TW.po:8640:2: syntax error po/zh_TW.po:8641: keyword "QA_4_0" unknown msgfmt: found 4 fatal errors Build step 'Execute shell' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 45 warnings. [DRY] Computing warning deltas based on reference build #3290 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3290 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [ERROR] - Test reports were found but not all of them are new. Did all the tests run? * <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml> is 2 hr 5 min old [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

4 3

[Phpmyadmin-devel] "Find and Replace" feature
by Sampath Liyanage 08 May '13

08 May '13

Hi. I have sent a pull request for "find and replace" feature. http://sourceforge.net/p/phpmyadmin/feature-requests/1405/ https://github.com/phpmyadmin/phpmyadmin/pull/343/files Your comments are welcome. Thank you Sampath Liyanage Dept. of Computer Science and Engineering, Faculty of Engineering, University of Moratuwa.

1 0

[Phpmyadmin-devel] Inserting known invalid data
by Isaac Bennetch 07 May '13

07 May '13

Hi, Can I get some thoughts on [1]? The way the code exists currently, you can insert bad data (you'll get a standard MySQL warning after the insert). For example, inserting the output of the MD5() function in to a TINYINT column. This pull request implements the AES_ENCRYPT function, but silently fails to show the salt form field in the event the user tries to insert to an invalid column type...so it looks broken in the case the user is trying to do something that's a bad idea. In keeping with the current system, I thought it should always show the salt field and proceed with the insert regardless of the column type, however that isn't the most user-friendly idea. To keep users most happy, I wondered if we should implement some sanity checks for some column types and show an inline warning as needed (similar to the recently merged warning when creating a new user with the same username). Some of the functions require or suggest certain column types which we could easily check, but I'm not sure it's phpMyAdmin's responsibility to constantly warn the user in this case. Regardless, the question at hand is whether this pull request can be merged as-is or if we should change the behavior in the case of an invalid column type. Thanks! 1 - https://github.com/phpmyadmin/phpmyadmin/pull/290#issuecomment-17281963

2 5

[Phpmyadmin-devel] Green light for 4.0.0 ?
by Marc Delisle 03 May '13

03 May '13

Hi, even if [0] looks curious (and I can reproduce the problem with the sample table), I believe it's an isolated case. Browsing a table is so frequently done that we would have got more error reports. So I see no show-stopper for 4.0.0. Comments? [0] https://sourceforge.net/p/phpmyadmin/bugs/3902/ -- Marc Delisle http://infomarc.info

4 3

[Phpmyadmin-devel] phpMyAdmin 4.0.0 is released
by Marc Delisle 03 May '13

03 May '13

Welcome to phpMyAdmin 4.0.0. With this version, the HTML frames are gone and the navigation panel now presents a tree. This version requires Javascript. Version 4.0 contains many bug fixes and smaller new features; moreover, the documentation has a new look and contains an index. Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

3 3