- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Relational view interface improvements
by Kasun Chathuranga 21 Jun '13

21 Jun '13

Hi all, I have been working on this feature during the last couple of days and I've sent a pull request [1] containing what I've done. With the changes the long dropdown to select foreign column has been split to two dropdowns, one to select the foreign table and the other to select the foreign column. I have also extended this to support cross database relations with an additional dropdown to select the foreign database. So when the user selects the database, the entries in the table dropdown are filtered only to show tables in that database and column dropdown is filtered in a similar manner when a table is selected. Own database is selected by default as it's more common to setup relations inside the same database. Checking relational integrity feature was already supporting cross database relations. I've added table name to the displayed text to make it clearer. I have also updated a couple of FAQs in the documentation related to these features. I would be grateful if you could check out this feature and suggest any improvements. [1] https://github.com/phpmyadmin/phpmyadmin/pull/438 -- Regards Kasun Chathuranga

1 0

[Phpmyadmin-devel] collecting info for error report
by Mohamed Ashraf 20 Jun '13

20 Jun '13

When an error report happens now I collect certain relevant info about the error and current phpmyadmin configuration. I currently collect error message, line number, file_name, stacktrace if available, phpmyadmin version, user browser name and version, user os and steps for reproduction by the user. do you think any other thing is relevant to the report. I can easily add any more info if required I just cant seem to find what is important for debugging. I thought I would ask you since you have a lot of experience debugging problems in phpmyadmin

2 3

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3665
by michal＠cihar.com 20 Jun '13

20 Jun '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3665/changes> Changes: [weblate] Translated using Weblate (Indonesian) [weblate] Translated using Weblate (Traditional Chinese) [weblate] Translated using Weblate (Traditional Chinese) [weblate] Translated using Weblate (Indonesian) ------------------------------------------ Started by GitHub push by nijel Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@3d6396f5 Using strategy: Default Last Built Revision: Revision fd9588b37277e2e50c9bc984e52a971795b229c9 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision a605fe4afc607ff683ac4dfcc78993538c106de2 (origin/master) Checking out Revision a605fe4afc607ff683ac4dfcc78993538c106de2 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson798490033146419449.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] Not supported query: SHOW GRANTS [exec] PHP Notice: Undefined variable: cfg in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/charset_con…> on line 18 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] PHP 12. require_once() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_ch…>:12 [exec] PHP Notice: Undefined variable: cfg in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/charset_con…> on line 32 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] PHP 12. require_once() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_ch…>:12 [exec] PHP Notice: Undefined variable: cfg in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/charset_con…> on line 39 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] PHP 12. require_once() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_ch…>:12 [exec] PHPUnit 3.7.19 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.nocoverage> [exec] [exec] .....................................................[31;1mE[0m......[33;1mI[0m 61 / 1412 ( 4%) [exec] ........................................[41;37mF[0m.................... 122 / 1412 ( 8%) [exec] ............................................................. 183 / 1412 ( 12%) [exec] ............................................................. 244 / 1412 ( 17%) [exec] ...................................... [exec] Result: 255 phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 20 exact clones with 425 duplicated lines in 23 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-138 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2778-2784 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:140-257 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:145-262 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-215 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1871-1878 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:205-211 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:341-347 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:597-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:615-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-955 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:924-962 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-961 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:796-840 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:453-460 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:654-682 [exec] [exec] 0.30% duplicated lines out of 143689 total lines of code. [exec] [exec] Time: 18 seconds, Memory: 125.50Mb [exec] Result: 1 phpcs: [exec] Time: 01:54, Memory: 58.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 409 [exec] [exec] Lines of Code (LOC): 143689 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 44962 [exec] Non-Comment Lines of Code (NCLOC): 98727 [exec] [exec] Namespaces: 0 [exec] Interfaces: 3 [exec] Traits: 0 [exec] Classes: 200 [exec] Abstract: 26 (13.00%) [exec] Concrete: 174 (87.00%) [exec] Average Class Length (NCLOC): 225 [exec] Methods: 1728 [exec] Scope: [exec] Non-Static: 1467 (84.90%) [exec] Static: 261 (15.10%) [exec] Visibility: [exec] Public: 1334 (77.20%) [exec] Non-Public: 394 (22.80%) [exec] Average Method Length (NCLOC): 26 [exec] Cyclomatic Complexity / Number of Methods: 4.26 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 629 [exec] [exec] Constants: 168 [exec] Global constants: 108 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 2 minutes 55 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2851 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3664 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 38 warnings. [DRY] Computing warning deltas based on reference build #3664 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 598 files to scan for tasks [TASKS] Found 197 open tasks. [TASKS] Computing warning deltas based on reference build #3664 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3664 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [ERROR] - The result file '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml'> for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 0

[Phpmyadmin-devel] redirect after js error caught
by Mohamed Ashraf 19 Jun '13

19 Jun '13

Since I catch uncaught exceptions there is a chance that the page would be unusable. should I refresh the page or redirect to the homepage or should I just leave it as is.

2 2

[Phpmyadmin-devel] surrounding functions by try and catch
by Mohamed Ashraf 19 Jun '13

19 Jun '13

Using window.onerror I don't have access to the stacktrace. to get the stacktrace I need to surround code by try and catch. I may be able to use javascript to change all references to global functions and surround them by try and catch statements. surrounding each and every global function in the window namespace would probably create a performance hit. however doing the same for only a subset of functions may be easier. I may for example surround only functions that start with PMA_ and the functions in the AJAX object. According to this test [0] the performance hit is not that great so it may not hurt to add try and catch to all methods but I don't like to play with code that I donot own since it may cause problems that I may not be able to understand. What I am trying to ask is should I surround only PMA_ and AJAX functions or should I add some extra functions (such as jquery functions) to the list or should I skip this entirely and rely only on line number and file name from the window.onerror

1 1

[Phpmyadmin-devel] Identifying a call to a stored procedure
by Supun Nakandala 19 Jun '13

19 Jun '13

Hi devs, I am refactoring sql.php and I realized in line 389 of file the check for a call to a stored procedure is done by using regexp. I would like to know is it ok to keep it like that or is there any better approach to handle that. Regards Supun.

2 5

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3649
by michal＠cihar.com 19 Jun '13

19 Jun '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3649/changes> Changes: [madhura.cj] Fix indentation [weblate] Translated using Weblate (Traditional Chinese) ------------------------------------------ Started by GitHub push by madhuracj Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@5143f787 Using strategy: Default Last Built Revision: Revision 09e2cc1f0121140dfe410e63dbe037c4ce2d35f4 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision 5ce7afdca41758bf43c1b215b41a5de6e88c98f5 (origin/master) Checking out Revision 5ce7afdca41758bf43c1b215b41a5de6e88c98f5 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson9036036752168794028.sh + ./scripts/generate-mo --quiet po/zh_TW.po:10937: a format specification for argument 2, as in 'msgstr[0]', doesn't exist in 'msgid_plural' po/zh_TW.po:10946: a format specification for argument 2, as in 'msgstr[0]', doesn't exist in 'msgid_plural' msgfmt: found 2 fatal errors Build step 'Execute shell' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 38 warnings. [DRY] Computing warning deltas based on reference build #3648 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3648 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [ERROR] - Test reports were found but not all of them are new. Did all the tests run? * <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml> is 18 hr old [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build.

1 2

[Phpmyadmin-devel] error report form mockup
by Mohamed Ashraf 18 Jun '13

18 Jun '13

I have attached some screenshots [0] of the current implementation of the error report dialog. when an error occurs a small notification appears at the bottom asking the user if he wants to submit an error report. if he does the modal dialog is opened showing him the info that would be sent and asking him for any additional info he might have. what do you think? [0] http://imgur.com/a/IJ7iW/all

3 6

[Phpmyadmin-devel] Improving the navigation bar in 4.1
by Marc Delisle 18 Jun '13

18 Jun '13

Hi, The navigation bar permits to navigate within a results set; it contains the page number selector, the begin/previous/next/end arrows, etc. Reading [0], I noticed that there is much room for improvement. Based on this feature request, here are my recommendations: 1. Remove the "Headers every __ rows" dialog; it's too prominent, is not often changed and is configurable via normal config and user prefs 2. Change the default number of rows from 30 to 25 (related to the next suggestion) 3. Replace the input field in "Number of rows" with a dropdown containing preset values 25/50/100/250/500. Selecting a value would immediately have an effect. I never felt the need to display, say, 37 rows in a page. This flexibility harms usability. 4. Remove the "Show" button and the Start row dialog. I rarely have to change the starting row value. Arrows and page selectors are sufficient to navigate (not mentionning Search). Comments are more than welcome. [0] https://sourceforge.net/p/phpmyadmin/feature-requests/1434/ -- Marc Delisle http://infomarc.info

3 2

[Phpmyadmin-devel] Overriding functions
by Ayush Chaudhary 18 Jun '13

18 Jun '13

Hi, I was writing some unit tests for the native string functions. However, since some of the functions are declared twice (with different implementations), for e.g., PMA_strlen, PMA_strpos, etc. have different implementations in string_mb.lib.php and string_native.lib.php, it causes phpunit to throw fatal errors of the form "Cannot redeclare function … already declared in …" Possible solutions could be to use namespaces or to use polymorphism in some way. Please advice. Thanks. -- Ayush Chaudhary

3 3