Developers

developers@phpmyadmin.net

5 participants
7032 discussions

by Supun Nakandala

Hi, I am refactoring the sql.php script. In line 235 there is a condition for GLOBALS['grid_edit']==true. According to what I found this will be set only when the field has "truncated" or "transformed" css classes. I was trying to find some test cases where these classes are added to the fields, but I was not successful. I would appreciate if someone can help me to find some test cases where these classes will be added. Thank you

11 years, 2 months

Re: [Phpmyadmin-devel] test case for global var grid_edit in sql.php

by Dieter Adriaenssens

2013/7/9 Supun Nakandala <supun.nakandala(a)gmail.com>: > Hi, > I am refactoring the sql.php script. In line 235 there is a condition for > GLOBALS['grid_edit']==true. According to what I found this will be set only > when the field has "truncated" or "transformed" css classes. I was trying to > find some test cases where these classes are added to the fields, but I was > not successful. I would appreciate if someone can help me to find some test > cases where these classes will be added. > > Thank you Hi Supun, Please use a subject when sending a mail, this will make it easier for other people to know what your message will be about and to follow the thread later on. -- Kind regards, Dieter Adriaenssens

11 years, 2 months

Re: [Phpmyadmin-devel] SQLValidator

by Dieter Adriaenssens

2013/7/3 Ayush Chaudhary <ayushchd(a)gmail.com>: > Hi, > > Is there a reason why validation.lib.php is not a class with public static > method? Is it okay to convert it to a class with all methods' access > specifier as public static? Did you mean the PMA_SQLValidator class in libraries/sqlvalidator.class.php? I didn't find a validation.lib.php, or something similar, in the PMA codebase, that contains a class. (libraries/config/validate.lib.php doesn't contain a class) Assuming you mean PMA_SQLValidator, this is not a static class, ie. it has to be instanciated (= turned into an object), so it can't have static methods. [1] To use (or test) this class, you have to create an instance and call the methods from that instance, fe. $validator = new PMA_SQLValidator(); $validator->start(); (see libraries/sqlvalidator.lib.php for an example on how to instanciate and use the PMA_SQLValidator class) BTW : Testing a class instance can sometimes be tricky, especially if it communicates with, or uses another class. If this is the case, you will have to use Mock objects [0] and Stubs to simulate the expected behaviour of the other class. I hope this helps. [0] http://phpunit.de/manual/3.0/en/mock-objects.html [1] explanation of instances and static members. It's explained for Java so the syntax doesn't match 100% with PHP, but the concept is analogous : http://docs.oracle.com/javase/tutorial/java/javaOO/classvars.html Kind regards, Dieter > -- > Ayush Chaudhary > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Kind regards, Dieter Adriaenssens

11 years, 2 months

Re: [Phpmyadmin-devel] SQLValidator

by Dieter Adriaenssens

2013/7/8 point dynamic <pointdynamicsix(a)gmail.com>: > hi can i have 2 actions on 1 form in php? Please use a new thread for a new topic.

11 years, 2 months

[Phpmyadmin-devel] Error reporting server configuration

by Mohamed Ashraf

As it turns out some of the asset urls need to be hardcoded. So I was wondering what will the server configuration be. like what is the domain name. will it be hosted on the root path or will it be inside a sub path like example.com vs example.com/error-reporting.

11 years, 2 months

[Phpmyadmin-devel] Unexpected javascript execution behaviour

by Supun Nakandala

Hi Devs, I am experiencing an unexpected behavior with respect to the following two cases. 1. Deleting a row from browse page. 2. Deleting a row after searching In the first case the request goes through the sql.js ajax handler. But in the second case the request doesn't go through it and the request is not an ajax request. But in both cases the tag is same ("<a class='delete_row ajax") and in both cases sql.js file is added to the responses which are displaying the results. I tried to find what is going wrong here for sometime now and I couldn't find it. I would appreciate if you can provide me some help to figure this problem. Thank You

11 years, 2 months

[Phpmyadmin-devel] Renaming proxy credentials variables

by Mohamed Ashraf

Currently all variables that store proxy credentials have the prefix 'VersionCheck' assuming because this was the only part of phpmyadmin that uses these variables. However I also require those variables in my error reporting code and I did not want to use the same variable names since it is a misnomer at that point. I renamed the variables and removed all the VersionCheck prefixes so they became ProxyUrl, ProxyUser and ProxyPass. I made the changes in the version_check.php code and in the docs. I just wanted to inform you of this change since this may affect others once the error reporting system is merged with master

11 years, 2 months

[Phpmyadmin-devel] (no subject)

by Supun Nakandala

Hi Marc, I identified seven situations where the method PMA_sendResponseForNoResultsReturned runs. 1-> When browsing an empty table 2-> When executing a query on a non empty table which returns zero results 3-> When executing a query on an empty table 4-> When executing an INSERT, UPDATE, DELETE query from the SQL tab 5-> When deleting a row from BROWSE tab 6-> When searching using the SEARCH tab which returns zero results 7-> When changing the structure of the table except change operation In the first case the $goto variable is not initialized. But in the second, third and fourth cases it is initialized to tbl_sql.php. In the third, fourth and fifth cases the $goto variable is initialized with sql.php itself with certain other url parameters. In the 7 th case $goto variable is set to $tbl_structure.php But I identified all these cases send Ajax responses where $goto variable or sending header location were never used. I would like to know whether my test scenarios are comprehensive if so shall I remove the redundant code segments.

11 years, 2 months

[Phpmyadmin-devel] (no subject)

by Ayush Chaudhary

Hi, Is there a reason why validation.lib.php is not a class with public static method? Is it okay to convert it to a class with all methods' access specifier as public static? -- Ayush Chaudhary

11 years, 2 months

[Phpmyadmin-devel] Icons for Find and replace

by Isaac Bennetch

Hi, Kasun has implemented the Find and replace feature and since then, we have been discussing the icon to use. I've attached here the best we've come up with, which is basically the Edit and Search icons merged. If anyone has any comments or anything better, please feel free to speak up. Thanks

11 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers