Hi,
I was working on a few things with the wiki today and came across two questions:
In Documentation.html, the placement/order where AjaxEnable and VersionCheck were placed seem off -- I would prefer to have it above MaxDbList. That way, MaxDbList and MaxTableList are grouped together and continue on to MaxCharactersInDisplayedSQL...keeping that series of Max values together. If you look at the wiki (http://wiki.phpmyadmin.net/pma/Config#Other_core_phpMyAdmin_settings) you'll better see what I prefer. Is it okay to make that change in Documentation.html as well?
Secondly, in ./libraries/config.default.php the default value of $cfg['VersionCheck'] is VERSION_CHECK_DEFAULT (which in turn is defined to be true). I'm not sure how to document that in the wiki...should we state that the default value is true, which is mostly true anyway, or is it better to be verbose about explaining the default value?
Regards ~isaac
Hi
Dne Sat, 12 Feb 2011 14:09:09 -0500 Isaac Bennetch bennetch@gmail.com napsal(a):
In Documentation.html, the placement/order where AjaxEnable and VersionCheck were placed seem off -- I would prefer to have it above MaxDbList. That way, MaxDbList and MaxTableList are grouped together and continue on to MaxCharactersInDisplayedSQL...keeping that series of Max values together. If you look at the wiki (http://wiki.phpmyadmin.net/pma/Config#Other_core_phpMyAdmin_settings) you'll better see what I prefer. Is it okay to make that change in Documentation.html as well?
I think it makes sense. I've added VersionCheck just after AjaxEnable and did not much look for the context.
Secondly, in ./libraries/config.default.php the default value of $cfg['VersionCheck'] is VERSION_CHECK_DEFAULT (which in turn is defined to be true). I'm not sure how to document that in the wiki...should we state that the default value is true, which is mostly true anyway, or is it better to be verbose about explaining the default value?
The reason for this is that Linux distributions will most likely will want to disable this check. They distribute security checks mostly by patching version they have, so there is no reason to notify user about this.
So in most cases default will be true, but for example in Debian it will be false.
Le 2011-02-12 14:09, Isaac Bennetch a écrit :
Hi,
I was working on a few things with the wiki today and came across two questions:
In Documentation.html, the placement/order where AjaxEnable and VersionCheck were placed seem off -- I would prefer to have it above MaxDbList. That way, MaxDbList and MaxTableList are grouped together and continue on to MaxCharactersInDisplayedSQL...keeping that series of Max values together. If you look at the wiki (http://wiki.phpmyadmin.net/pma/Config#Other_core_phpMyAdmin_settings) you'll better see what I prefer. Is it okay to make that change in Documentation.html as well?
Yes. In the past, we tried to use the same order in Documentation.html than in the configuration file but I'm not sure if we still do this or even if it's the best order.
-
Isaac Bennetch -
Marc Delisle -
Michal Čihař