[Phpmyadmin-devel] MaxTableUiprefs

I know I'm a bit late to be mentioning this now, but shouldn't $cfg['Servers'][$i]['MaxTableUiprefs'] instead be $cfg['Servers'][$i]['MaxTableUiPrefs'] (not "Prefs" versus "prefs")? And in turn, perhaps $cfg['Servers'][$i]['table_uiprefs'] $cfg['Servers'][$i]['table_uiPrefs']?

Isaac Bennetch a écrit :
I know I'm a bit late to be mentioning this now, but shouldn't $cfg['Servers'][$i]['MaxTableUiprefs'] instead be $cfg['Servers'][$i]['MaxTableUiPrefs'] (not "Prefs" versus "prefs")?
And in turn, perhaps $cfg['Servers'][$i]['table_uiprefs'] $cfg['Servers'][$i]['table_uiPrefs']?
The suggested table name in scripts/create_tables.sql is pma_table_uiprefs and all these suggested table names use lowercases. So we have two different name styles to match, not easy. -- Marc Delisle http://infomarc.info

Hi all, On 7 Sep 2011, at 19:43, Marc Delisle <marc@infomarc.info> wrote:
Isaac Bennetch a écrit :
I know I'm a bit late to be mentioning this now, but shouldn't $cfg['Servers'][$i]['MaxTableUiprefs'] instead be $cfg['Servers'][$i]['MaxTableUiPrefs'] (not "Prefs" versus "prefs")?
And in turn, perhaps $cfg['Servers'][$i]['table_uiprefs'] $cfg['Servers'][$i]['table_uiPrefs']?
The suggested table name in scripts/create_tables.sql is pma_table_uiprefs and all these suggested table names use lowercases.
So we have two different name styles to match, not easy.
Yes, as stated by Marc, I also prefer to use the same lowercase namestyle for the cfg keys, to match the suggested tables' name style. -- Aris Feryanto

Aris Feryanto a écrit :
Hi all,
On 7 Sep 2011, at 19:43, Marc Delisle <marc@infomarc.info> wrote:
Isaac Bennetch a écrit :
I know I'm a bit late to be mentioning this now, but shouldn't $cfg['Servers'][$i]['MaxTableUiprefs'] instead be $cfg['Servers'][$i]['MaxTableUiPrefs'] (not "Prefs" versus "prefs")?
And in turn, perhaps $cfg['Servers'][$i]['table_uiprefs'] $cfg['Servers'][$i]['table_uiPrefs']? The suggested table name in scripts/create_tables.sql is pma_table_uiprefs and all these suggested table names use lowercases.
So we have two different name styles to match, not easy.
Yes, as stated by Marc, I also prefer to use the same lowercase namestyle for the cfg keys, to match the suggested tables' name style.
Aris, the table name is lowercase (pma_table_uiprefs) but the cfg key is mixed case (MaxTableUiprefs); this is to follow our convention on cfg keys. So, not everything is lowercase. -- Marc Delisle http://infomarc.info
participants (3)
-
Aris Feryanto
-
Isaac Bennetch
-
Marc Delisle