Hi there,
I rewrote the navigation frame resize handler and I'm looking for some feedback and opinions. The new handler keeps navigation frame width synchronised and there is an option to collapse the frame. I made a video [1] that showcases the functionality and there are a few words about it in my blog [2] and of course, it can be seen ion action on my demo site [3].
Rouslan
[1]: http://www.youtube.com/watch?v=o-MFX3i3tQ0 [2]: http://roccivic.blogspot.com/2011/07/report-for-week-10.html [3]: http://demo.phpmyadmin.net/gsoc-rouslan/
On Mon, Aug 1, 2011 at 2:34 AM, Rouslan Placella rouslan@placella.com wrote:
I would still find it nice to have just one collapse/expand button in the middle, but therefore bigger. Though we might need to check that the expand button doesn't overlap other content too much. Also having it animated, even if it is a bit laggy, gives a more fluent experience instead of having it flash in and out, imho.
And lastly, frame resize still doesn't work in Chrome.
On Mon, 2011-08-01 at 09:26 +0300, Tyron Madlener wrote:
I put the collapse buttons at the top and bottom of the screen exactly for that reason: keeping them out of the way. Let's see what others think about this.
Also having it animated, even if it is a bit laggy, gives a more fluent experience instead of having it flash in and out, imho.
The animation for the frame collapse is _too_ laggy IMO. Most of the time there is too much content in the main frame for a smooth transition. So I animated the buttons instead :D
And lastly, frame resize still doesn't work in Chrome.
Apparently it's a well known bug. Frame resize is only possible on chrome if the frameborder attribute is set to 1. Of course, setting frameborder to 1 makes the navigation look ugly in a every other browser. I guess that we could conditionally set frameborder to 1 for chrome only...
Rouslan
On Mon, Aug 1, 2011 at 1:04 PM, Rouslan Placella rouslan@placella.com wrote:
Or maybe it's time to throw away the pma frames altogether :-)
On Mon, 2011-08-01 at 13:27 +0300, Tyron Madlener wrote:
Is it? Getting rid of frames would mean that if JS or ajax is disabled in PMA, then a whole page must be refreshed in order to refresh the navigation or even to browse the navigation tree. Don't get me wrong, I'm the first one to say that frames suck, but I just don't see how we can deliver content efficiently without them.
Rouslan
On Mon, Aug 1, 2011 at 1:38 PM, Rouslan Placella rouslan@placella.com wrote:
Yes that is very true. All the Ajax/JS features have to be really stable and be widely accepted before we can remove frames then. That probably will still take 1-5 years.
Hi,
On 8/1/2011 7:06 AM, Tyron Madlener wrote:
Given the outcry about the new AJAX features, I'd warn against doing this any time soon. Some people love it, some people hate it, but at least right now they can use DisableAjax which seems to keep everyone happy. I know frames present their own problems, but right now they seem to be the best solution taking everyone's needs in to account.
On Mon, Aug 1, 2011 at 1:04 PM, Rouslan Placella rouslan@placella.com wrote:
The same applies to manual resizing, however.
On 08/01/2011 01:34 AM, Rouslan Placella wrote:
Having it resizeable seems nice. But I'm not sure that the synchronisation between tabs is useful. When I would resize to fit some specific table names this does not mean that I need the same space for an other tab where I might have a different database. And I'm not really a fan of polling, specially when it's just for this.
On Mon, 2011-08-01 at 14:24 +0200, Herman van Rink wrote:
I was thinking of adding a configuration option to disable this.
And I'm not really a fan of polling, specially when it's just for this.
Well, some browsers don't fire the onresize event for frames. Polling is the only reliable way here.
On Mon, Aug 1, 2011 at 3:31 PM, Rouslan Placella rouslan@placella.com wrote:
I agree with Herman, this feature seems rather like an inconvenience than a feature to me. And this would be the very first setting/configuration in phpMyAdmin that is synchronized - why does it deserve that status? ;)
On Mon, 2011-08-01 at 15:39 +0300, Tyron Madlener wrote:
Not sure what you are saying here... What status is there to deserve?
Anyway, I meant a configuration setting for disabling this feature, not synchronising the actual setting. And the synchronisation of the frame widths occurs via a cookie, not via the pma configuration...
But yeah, I see how you could label it a nuissance and I have no problem getting rid of the feature for synchronising widths across frames and reverting to the old, somewhat flawed, logic for handling the frame widths.
On Mon, Aug 1, 2011 at 3:54 PM, Rouslan Placella rouslan@placella.com wrote:
How about just adding your new code without cross frame sync?
On Mon, Aug 8, 2011 at 2:22 PM, Rouslan Placella rouslan@placella.com wrote:
Ok, thanks for the update. I'll remove my implementation of the resizer from my branch then.
-
Herman van Rink -
Isaac Bennetch -
Rouslan Placella -
Tyron Madlener