[Phpmyadmin-devel] possible patch for 4.3.0: PHP OpenSSL support
Hi, Robert Scheck from Fedora would like his patch to be merged in time for 4.3.0. I feel that we should have a look at it even if we said we froze 4.3.x for new features. Here is his email. ----- Hello Marc, when I read your e-mail regarding phpMyAdmin 4.3.0-alpha1, I remembered back to my patch to add PHP OpenSSL support (additionally to MCrypt and phpseclib) at https://sourceforge.net/p/phpmyadmin/feature-requests/1537/ again. Is there any chance for a decision for 4.3.0 series? I guess this (hopefully) not much work for an experienced PHP developer to review and maybe to adapt slightly if needed. My main reason for asking you is that (especially RHEL) doesn't contain PHP MCrypt while PHP OpenSSL is even faster (if I can believe Roundcube Webmail developers). Indeed PHP MCrypt is available via a separate repo for RHEL/CentOS users but that causes some mixed feelings from time to time again. The goal would be to additionally support PHP OpenSSL without dropping any other existing MCrypt and phpseclib support. Thanks, Robert -- Marc Delisle | phpMyAdmin
Marc Delisle a écrit :
Hi,
Robert Scheck from Fedora would like his patch to be merged in time for 4.3.0. I feel that we should have a look at it even if we said we froze 4.3.x for new features.
Here is his email. -----
Hello Marc,
when I read your e-mail regarding phpMyAdmin 4.3.0-alpha1, I remembered back to my patch to add PHP OpenSSL support (additionally to MCrypt and phpseclib) at https://sourceforge.net/p/phpmyadmin/feature-requests/1537/ again. Is there any chance for a decision for 4.3.0 series? I guess this (hopefully) not much work for an experienced PHP developer to review and maybe to adapt slightly if needed.
My main reason for asking you is that (especially RHEL) doesn't contain PHP MCrypt while PHP OpenSSL is even faster (if I can believe Roundcube Webmail developers). Indeed PHP MCrypt is available via a separate repo for RHEL/CentOS users but that causes some mixed feelings from time to time again. The goal would be to additionally support PHP OpenSSL without dropping any other existing MCrypt and phpseclib support.
Thanks, Robert
The patch looks fine to me, apart from a minor addition I made to avoid a warning (see the feature request). I would appreciate that someone else review the patch. Any feedback on the process of adding this feature to 4.3.0 ? -- Marc Delisle (phpMyAdmin)
On Nov 17, 2014, at 4:00 PM, Marc Delisle <marc@infomarc.info> wrote:
Marc Delisle a écrit :
Hi,
Robert Scheck from Fedora would like his patch to be merged in time for 4.3.0. I feel that we should have a look at it even if we said we froze 4.3.x for new features.
Here is his email. -----
Hello Marc,
when I read your e-mail regarding phpMyAdmin 4.3.0-alpha1, I remembered back to my patch to add PHP OpenSSL support (additionally to MCrypt and phpseclib) at https://sourceforge.net/p/phpmyadmin/feature-requests/1537/ again. Is there any chance for a decision for 4.3.0 series? I guess this (hopefully) not much work for an experienced PHP developer to review and maybe to adapt slightly if needed.
My main reason for asking you is that (especially RHEL) doesn't contain PHP MCrypt while PHP OpenSSL is even faster (if I can believe Roundcube Webmail developers). Indeed PHP MCrypt is available via a separate repo for RHEL/CentOS users but that causes some mixed feelings from time to time again. The goal would be to additionally support PHP OpenSSL without dropping any other existing MCrypt and phpseclib support.
Thanks, Robert
The patch looks fine to me, apart from a minor addition I made to avoid a warning (see the feature request). I would appreciate that someone else review the patch.
Any feedback on the process of adding this feature to 4.3.0 ?
I have no objection but have not thoroughly reviewed the code. This doesn't seem to negatively affect any situation so it's fine with me.
-- Marc Delisle (phpMyAdmin)
------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Dne Mon, 17 Nov 2014 16:00:30 -0500 Marc Delisle <marc@infomarc.info> napsal(a):
Marc Delisle a écrit :
Hi,
Robert Scheck from Fedora would like his patch to be merged in time for 4.3.0. I feel that we should have a look at it even if we said we froze 4.3.x for new features.
Here is his email. -----
Hello Marc,
when I read your e-mail regarding phpMyAdmin 4.3.0-alpha1, I remembered back to my patch to add PHP OpenSSL support (additionally to MCrypt and phpseclib) at https://sourceforge.net/p/phpmyadmin/feature-requests/1537/ again. Is there any chance for a decision for 4.3.0 series? I guess this (hopefully) not much work for an experienced PHP developer to review and maybe to adapt slightly if needed.
My main reason for asking you is that (especially RHEL) doesn't contain PHP MCrypt while PHP OpenSSL is even faster (if I can believe Roundcube Webmail developers). Indeed PHP MCrypt is available via a separate repo for RHEL/CentOS users but that causes some mixed feelings from time to time again. The goal would be to additionally support PHP OpenSSL without dropping any other existing MCrypt and phpseclib support.
Thanks, Robert
The patch looks fine to me, apart from a minor addition I made to avoid a warning (see the feature request). I would appreciate that someone else review the patch.
Any feedback on the process of adding this feature to 4.3.0 ?
I think it's fine, the patch looks sane, but IMHO it should come with tests that ensure that encrypted data is compatible with other implementations (we currently only have one test which expects same behavior regardless implementation see PMA_AuthenticationCookie_Test::testCookieEncrypt/testCookieDecrypt). -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Michal Čihař a écrit :
Hi
Dne Mon, 17 Nov 2014 16:00:30 -0500 Marc Delisle <marc@infomarc.info> napsal(a):
Marc Delisle a écrit :
Hi,
Robert Scheck from Fedora would like his patch to be merged in time for 4.3.0. I feel that we should have a look at it even if we said we froze 4.3.x for new features.
Here is his email. -----
Hello Marc,
when I read your e-mail regarding phpMyAdmin 4.3.0-alpha1, I remembered back to my patch to add PHP OpenSSL support (additionally to MCrypt and phpseclib) at https://sourceforge.net/p/phpmyadmin/feature-requests/1537/ again. Is there any chance for a decision for 4.3.0 series? I guess this (hopefully) not much work for an experienced PHP developer to review and maybe to adapt slightly if needed.
My main reason for asking you is that (especially RHEL) doesn't contain PHP MCrypt while PHP OpenSSL is even faster (if I can believe Roundcube Webmail developers). Indeed PHP MCrypt is available via a separate repo for RHEL/CentOS users but that causes some mixed feelings from time to time again. The goal would be to additionally support PHP OpenSSL without dropping any other existing MCrypt and phpseclib support.
Thanks, Robert
The patch looks fine to me, apart from a minor addition I made to avoid a warning (see the feature request). I would appreciate that someone else review the patch.
Any feedback on the process of adding this feature to 4.3.0 ?
I think it's fine, the patch looks sane, but IMHO it should come with tests that ensure that encrypted data is compatible with other implementations (we currently only have one test which expects same behavior regardless implementation see PMA_AuthenticationCookie_Test::testCookieEncrypt/testCookieDecrypt).
Good point. Also, testAuthSetUser() is failing. -- Marc Delisle (phpMyAdmin)
Marc Delisle a écrit :
Michal Čihař a écrit :
Hi
Dne Mon, 17 Nov 2014 16:00:30 -0500 Marc Delisle <marc@infomarc.info> napsal(a):
Marc Delisle a écrit :
Hi,
Robert Scheck from Fedora would like his patch to be merged in time for 4.3.0. I feel that we should have a look at it even if we said we froze 4.3.x for new features.
Here is his email. -----
Hello Marc,
when I read your e-mail regarding phpMyAdmin 4.3.0-alpha1, I remembered back to my patch to add PHP OpenSSL support (additionally to MCrypt and phpseclib) at https://sourceforge.net/p/phpmyadmin/feature-requests/1537/ again. Is there any chance for a decision for 4.3.0 series? I guess this (hopefully) not much work for an experienced PHP developer to review and maybe to adapt slightly if needed.
My main reason for asking you is that (especially RHEL) doesn't contain PHP MCrypt while PHP OpenSSL is even faster (if I can believe Roundcube Webmail developers). Indeed PHP MCrypt is available via a separate repo for RHEL/CentOS users but that causes some mixed feelings from time to time again. The goal would be to additionally support PHP OpenSSL without dropping any other existing MCrypt and phpseclib support.
Thanks, Robert
The patch looks fine to me, apart from a minor addition I made to avoid a warning (see the feature request). I would appreciate that someone else review the patch.
Any feedback on the process of adding this feature to 4.3.0 ? I think it's fine, the patch looks sane, but IMHO it should come with tests that ensure that encrypted data is compatible with other implementations (we currently only have one test which expects same behavior regardless implementation see PMA_AuthenticationCookie_Test::testCookieEncrypt/testCookieDecrypt).
Good point. Also, testAuthSetUser() is failing.
I adapted the patch for 4.3.0, please review. https://sourceforge.net/p/phpmyadmin/feature-requests/_discuss/thread/1a25ee... -- Marc Delisle (phpMyAdmin)
Marc Delisle a écrit :
Marc Delisle a écrit :
Michal Čihař a écrit :
Hi
Dne Mon, 17 Nov 2014 16:00:30 -0500 Marc Delisle <marc@infomarc.info> napsal(a):
Marc Delisle a écrit :
Hi,
Robert Scheck from Fedora would like his patch to be merged in time for 4.3.0. I feel that we should have a look at it even if we said we froze 4.3.x for new features.
Here is his email. -----
Hello Marc,
when I read your e-mail regarding phpMyAdmin 4.3.0-alpha1, I remembered back to my patch to add PHP OpenSSL support (additionally to MCrypt and phpseclib) at https://sourceforge.net/p/phpmyadmin/feature-requests/1537/ again. Is there any chance for a decision for 4.3.0 series? I guess this (hopefully) not much work for an experienced PHP developer to review and maybe to adapt slightly if needed.
My main reason for asking you is that (especially RHEL) doesn't contain PHP MCrypt while PHP OpenSSL is even faster (if I can believe Roundcube Webmail developers). Indeed PHP MCrypt is available via a separate repo for RHEL/CentOS users but that causes some mixed feelings from time to time again. The goal would be to additionally support PHP OpenSSL without dropping any other existing MCrypt and phpseclib support.
Thanks, Robert
The patch looks fine to me, apart from a minor addition I made to avoid a warning (see the feature request). I would appreciate that someone else review the patch.
Any feedback on the process of adding this feature to 4.3.0 ? I think it's fine, the patch looks sane, but IMHO it should come with tests that ensure that encrypted data is compatible with other implementations (we currently only have one test which expects same behavior regardless implementation see PMA_AuthenticationCookie_Test::testCookieEncrypt/testCookieDecrypt). Good point. Also, testAuthSetUser() is failing.
I adapted the patch for 4.3.0, please review.
https://sourceforge.net/p/phpmyadmin/feature-requests/_discuss/thread/1a25ee...
I also changed the tests, which work when openssl is active or inactive. -- Marc Delisle (phpMyAdmin)
participants (3)
-
Isaac Bennetch -
Marc Delisle -
Michal Čihař