Hi

On Tue, Jan 8, 2019 at 6:45 PM Isaac Bennetch bennetch@gmail.com wrote:

Hi team,

Our library project version numbers are a bit of a mess right now. We maintain sql-parser, motranslator, and shapefile.

For sql-parser, we use git tags of the style "v4.3.1" and I'd like to get rid of the "v" so tags are simply "5.0.0" and so on. This might require a tweak to our infrastructure to create the GitHub release (https://github.com/phpmyadmin/sql-parser/releases).

The other two use x.y style release names, and I'd like to add a patch version so all tags moving forward are three numbers (x.y.z).

Any comments, support, or objections

I agree.

Maurício

Hi

On Tue, 2019-01-08 at 15:44 -0500, Isaac Bennetch wrote:

Our library project version numbers are a bit of a mess right now. We maintain sql-parser, motranslator, and shapefile.

For sql-parser, we use git tags of the style "v4.3.1" and I'd like to get rid of the "v" so tags are simply "5.0.0" and so on. This might require a tweak to our infrastructure to create the GitHub release (https://github.com/phpmyadmin/sql-parser/releases).

The code strips "v" prefix if present, so no change should be needed:

https://github.com/phpmyadmin/scripts/blob/380d37a255ed1efaf95612747ec3d191a...

The other two use x.y style release names, and I'd like to add a patch version so all tags moving forward are three numbers (x.y.z).

Any comments, support, or objections?

Sounds good to make it consistent.