Hi,
I'm sorry for being yet not submitted any patches, but I'm so busy having exams since the SoC registration opened. I'm checking bug tracker now to fix some bugs, but I need help on how to prepare the patch, and how to submit it, I couldn't find any post/submit tab on patch tracker, or any writing/coding rules on how to make a patch. On the developer wiki, it is said that some bugs are for juniors who don't have knowledge with the code base..then I need to read the code base anyway, right? Then, how and from where to start reading the code?
Best Regards,,
Hi,
I'm sorry for being yet not submitted any patches, but I'm so busy having exams since the SoC registration opened. I'm checking bug tracker now to fix some bugs, but I need help on how to prepare the patch, and how to submit it, I couldn't find any post/submit tab on patch tracker, or any writing/coding rules on how to make a patch. On the developer wiki, it is said that some bugs are for juniors who don't have knowledge with the code base..then I need to read the code base anyway, right? Then, how and from where to start reading the code?
Best Regards,,
For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Ahmed,
Regarding how to submit patches
1. First of all, clone the phpMyAdmin Git repository (see [1]). 2. Make sure to set your Git username and email settings properly (see [2]). 3. Then, prepare your code changes as you normally would. 4. Next, commit the changes to go into your patch to your local repo clone. 5. Subsequently, tell git to create a patch for you (see [3]). 6. Last, send us your patch file (see [4]), or create a pull request at Github. About the "post/submit tab": There is a (very) small "Add new" link on top of the bug tracker. :)
[1] http://git.io/pma [2] http://book.git-scm.com/2_setup_and_initialization.html [3] http://schacon.github.com/git/git-format-patch.html [4] https://sourceforge.net/tracker/?func=add&group_id=23067&atid=377410
About reading the code base, it’s best starting to scan through main.php (this is the 2-column file showing the language and theme switchers and the server versions you’re running) and the libraries folder—just to get a basic idea of how phpMyAdmin works internally. For fixing small bugs, it’s usually best to investigate the code in the files affected or loaded by the page that contains the error.
-- mynetx (Jo Michael)
Thanks Jo, Another question: how to test my code locally to see if it works? I have phpMyAdmin installed, i the same time I'll work on the copy I pulled from GIT, then how would I try my fixes? would I try the copy of PMA from GIT after I edit the code? or can I merge that code to the PMA I already installed?
Best Regards,,
Another question: how to test my code locally to see if it works? I have phpMyAdmin installed, i the same time I'll work on the copy I pulled from GIT, then how would I try my fixes? would I try the copy of PMA from GIT after I edit the code? or can I merge that code to the PMA I already installed?
The easiest way to test your code is by cloning Github’s phpMyAdmin master branch. You should create your Git repository for phpMyAdmin inside the document root of your local webserver, so you can reach the cloned folder by accessing a subfolder of localhost in your browser. Then, do your code changes in the local copy, and test them in the browser. As soon as the bug that you’re working on is fixed, stage (add) the files in Git and commit them with a proper commit message.
-- mynetx (Jo Michael)
well, and this cloned copy won't need any configuration(i.e: database or something) as when I install PMA for personal usage?
well, and this cloned copy won't need any configuration(i.e: database or something) as when I install PMA for personal usage?
Each copy of phpMyAdmin that’s intended to be used, so the cloned one as well, needs a configuration file.
However, throw a peek into the root folder .gitignore file. You will find that the custom config.inc.php that you need to create is ignored by Git and won’t get added to your commits.
As for the database, if you want to test the local installation, a local mySQL server is best. Provided that your firewall allows outgoing access on port 3306, and that you have a remote mySQL server allowing access from your local phpMyAdmin server IP, you may specify any server you want to, in config.inc.php. It doesn’t necessarily have to be a localhosted mySQL server (which in turn speeds up any communication).
-- mynetx (Jo Michael)
-
Ahmed Waheed -
J.M.