Hi, there have been changes this week about HTTP headers handling for Ajax, in particular due to bug [0]. I have just pushed commit 67339bab2aa1cc20b0ba0d55d7d6b5feb538607d as an attempt to rectify the remaining problems but I have doubts.
I would like testers for Ajax features in current master.
For a list of things to test, look at [1] (however this list has not been updated to indicate what has been implemented).
[0] http://sourceforge.net/tracker/?func=detail&aid=3183548&group_id=230...
[1] http://wiki.phpmyadmin.net/pma/AJAXify_Interface#Actions_to_be_Ajaxified_on_...
Regards,
On 2/19/2011 8:04 AM, Marc Delisle wrote:
Hi, there have been changes this week about HTTP headers handling for Ajax, in particular due to bug [0]. I have just pushed commit 67339bab2aa1cc20b0ba0d55d7d6b5feb538607d as an attempt to rectify the remaining problems but I have doubts.
I would like testers for Ajax features in current master.
For a list of things to test, look at [1] (however this list has not been updated to indicate what has been implemented).
[0] http://sourceforge.net/tracker/?func=detail&aid=3183548&group_id=230...
[1] http://wiki.phpmyadmin.net/pma/AJAXify_Interface#Actions_to_be_Ajaxified_on_...
1 - Not directly related, but when adding a new user the dialog box is movable, is resizable, and has a scrollbar. When editing a user, it's a different type of dialog and isn't movable or directly scrollable. To scroll in that window, one must use the regular window's scrollbar to the far right. I prefer the first method, but either way they (and all of our dialogs, I think) should match in style.
2 - When running an SQL query (from the main page, SQL tab), the query seems to run successfully but a new query window appears briefly, then is hidden and replaced with "Show query box" -- when it's shown, the same content is now shown in two different query boxes.
3 - Perhaps related to (2), there's a "Hide query box" link on the SQL tab which can be clicked...and then the page is essentially blank other than the navigation tabs and "Show query box" (which sits too close to the navigation bar anyway). I'm not sure what this link is for and it seems weird to allow hiding of the only thing shown on a page.
4 - When running an SQL query from the SQL tab, the drop down notice says "Loading..." for quite a while, then disappears; it never says "Finished" or "Query run successfully" or "query run in 0.4352 seconds" or anything like that. I'd prefer to see notification that it's finished it's work, like in the add user dialog.
That's all I've had time to see so far. Which shall I file bug reports about?
Le 2011-02-19 08:42, Isaac Bennetch a écrit :
Thanks Isaac,
1 - Not directly related, but when adding a new user the dialog box is movable, is resizable, and has a scrollbar. When editing a user, it's a different type of dialog and isn't movable or directly scrollable. To scroll in that window, one must use the regular window's scrollbar to the far right. I prefer the first method, but either way they (and all of our dialogs, I think) should match in style.
Fixed; if you see other dialogs which need this improvement, tell me...
2 - When running an SQL query (from the main page, SQL tab), the query seems to run successfully but a new query window appears briefly, then is hidden and replaced with "Show query box" -- when it's shown, the same content is now shown in two different query boxes.
I cannot see same content in two different query boxes. Tested with FF 3.6.13 on Vista (after clearing my cache):
- main page, click SQL - enter "SELECT VERSION();" - click Go - click Show query box
3 - Perhaps related to (2), there's a "Hide query box" link on the SQL tab which can be clicked...and then the page is essentially blank other than the navigation tabs and "Show query box" (which sits too close to the navigation bar anyway). I'm not sure what this link is for and it seems weird to allow hiding of the only thing shown on a page.
Agreed, will fix.
4 - When running an SQL query from the SQL tab, the drop down notice says "Loading..." for quite a while, then disappears; it never says "Finished" or "Query run successfully" or "query run in 0.4352 seconds" or anything like that. I'd prefer to see notification that it's finished it's work, like in the add user dialog.
That's all I've had time to see so far. Which shall I file bug reports about?
I'll tell you later what I did not have time to fix.
Le 2011-02-19 10:51, Marc Delisle a écrit :
Le 2011-02-19 08:42, Isaac Bennetch a écrit :
3 - Perhaps related to (2), there's a "Hide query box" link on the SQL tab which can be clicked...and then the page is essentially blank other than the navigation tabs and "Show query box" (which sits too close to the navigation bar anyway). I'm not sure what this link is for and it seems weird to allow hiding of the only thing shown on a page.
Agreed, will fix.
"Hide query box" no longer appears in this situation. Still looking for a way to add some space between the navigation bar and the link.
On 2/19/2011 10:51 AM, Marc Delisle wrote:
Le 2011-02-19 08:42, Isaac Bennetch a écrit :
2 - When running an SQL query (from the main page, SQL tab), the query seems to run successfully but a new query window appears briefly, then is hidden and replaced with "Show query box" -- when it's shown, the same content is now shown in two different query boxes.
I cannot see same content in two different query boxes. Tested with FF 3.6.13 on Vista (after clearing my cache):
- main page, click SQL
- enter "SELECT VERSION();"
- click Go
- click Show query box
My report was slightly off; I was mistaken and the results do differ slightly. I think it's only when an empty result set is returned. -- Main page, click SQL -- query as below: CREATE USER 'query'@'%'; GRANT USAGE ON * . * TO 'query'@'%'; -- [end query] -- click go -- the page returned shows this in the query box, already revealed: CREATE USER 'query'@'%';#MySQL returned an empty result set (i.e. zero rows). GRANT USAGE ON * . * TO 'query'@'%';#MySQL returned an empty result set (i.e. zero rows). -- [end results] -- Above this query box is the "Show query box" link, clicking it reveals the original query.
Your test as well as others that return actual results, such as SHOW DATABASES; do work properly.
Le 2011-02-19 14:51, Isaac Bennetch a écrit :
On 2/19/2011 10:51 AM, Marc Delisle wrote:
Le 2011-02-19 08:42, Isaac Bennetch a écrit :
My report was slightly off; I was mistaken and the results do differ slightly. I think it's only when an empty result set is returned. -- Main page, click SQL -- query as below: CREATE USER 'query'@'%'; GRANT USAGE ON * . * TO 'query'@'%'; -- [end query] -- click go -- the page returned shows this in the query box, already revealed: CREATE USER 'query'@'%';#MySQL returned an empty result set (i.e. zero rows). GRANT USAGE ON * . * TO 'query'@'%';#MySQL returned an empty result set (i.e. zero rows). -- [end results] -- Above this query box is the "Show query box" link, clicking it reveals the original query.
Your test as well as others that return actual results, such as SHOW DATABASES; do work properly.
Confirmed and now logged as https://sourceforge.net/tracker/?func=detail&aid=3187141&group_id=23...
Le 2011-02-19 08:42, Isaac Bennetch a écrit :
4 - When running an SQL query from the SQL tab, the drop down notice says "Loading..." for quite a while, then disappears; it never says "Finished" or "Query run successfully" or "query run in 0.4352 seconds" or anything like that. I'd prefer to see notification that it's finished it's work, like in the add user dialog.
Isaac, What kind of query? If I enter for example SELECT * FROM ACTOR
I get the expected "Showing rows... " and "Query took x sec". Admittedly, for a quick query the "Loading" stays there a little too long.
Hi Marc,
I just saw the thread and sorry for the delay.
1 - Not directly related, but when adding a new user the dialog box is movable, is resizable, and has a scrollbar. When editing a user, it's a different type of dialog and isn't movable or directly scrollable. To scroll in that window, one must use the regular window's scrollbar to the far right. I prefer the first method, but either way they (and all of our dialogs, I think) should match in style.
This is true when clicking the "Add a new user" link provided under the host name(as an example localhost->). But when we select a specific database (as an example localhost->test )and then click on the "Add a new user" link the Ajaxyfied window is not appear. Instead of that it directs to a new window. Is that a feature. Please check on that.
Regards, Thilanka.
Hi Marc,
I went through some other Ajaxify features listed in the wiki and noted some points regarding those.
1. In the left navigation bar "Create new table" allows to create quick new tables in the database. But it doesn't refresh the navigation menu and show only the earlier tables. 2. In Table operations Move Table , Copy Table, Table Maintenance reloads and does not auto get back to the Table Operations tab. Do we require fully reload of the page or instead of that we can show the sql execution results in the same tab as in "Alter table oder by" and "Table options" (Stay in the same tab after the execution).
Please can you pay your attention on those areas. I could not find any other issues related to the options listed in the wiki. Thank you.
Regards, Thilanka.
Le 2011-02-20 00:10, Thilanka Kaushalya a écrit :
Hi Marc,
I went through some other Ajaxify features listed in the wiki and notedsome points regarding those.
- In the left navigation bar "Create new table" allows to create quick
new tables in the database. But it doesn't refresh the navigation menu and show only the earlier tables.
Fixed. For now the interface stays there to create a second table (not sure what's best at this point).
Le 2011-02-20 00:10, Thilanka Kaushalya a écrit :
Hi Marc, 2. In Table operations Move Table , Copy Table, Table Maintenance reloads and does not auto get back to the Table Operations tab. Do we require fully reload of the page or instead of that we can show the sql execution results in the same tab as in "Alter table oder by" and "Table options" (Stay in the same tab after the execution).
Indeed this needs improvement (behavior was the same in 3.3). Reported as https://sourceforge.net/tracker/?func=detail&aid=3187428&group_id=23...
Please can you pay your attention on those areas. I could not find anyother issues related to the options listed in the wiki. Thank you.
Thanks for your testing time.
Le 2011-02-19 22:41, Thilanka Kaushalya a écrit :
Hi Marc,
I just saw the thread and sorry for the delay.1 - Not directly related, but when adding a new user the dialog box is movable, is resizable, and has a scrollbar. When editing a user, it's a different type of dialog and isn't movable or directly scrollable. To scroll in that window, one must use the regular window's scrollbar to the far right. I prefer the first method, but either way they (and all of our dialogs, I think) should match in style.
This is true when clicking the "Add a new user" link provided under the host name(as an example localhost->). But when we select a specific database (as an example localhost->test )and then click on the "Add a new user" link the Ajaxyfied window is not appear. Instead of that it directs to a new window. Is that a feature. Please check on that.
Regards, Thilanka.
Correct. I updated http://wiki.phpmyadmin.net/pma/AJAXify_Interface#Actions_to_be_Ajaxified_on_...
On 2/19/2011 5:53 PM, Marc Delisle wrote:
Le 2011-02-19 08:42, Isaac Bennetch a écrit :
4 - When running an SQL query from the SQL tab, the drop down notice says "Loading..." for quite a while, then disappears; it never says "Finished" or "Query run successfully" or "query run in 0.4352 seconds" or anything like that. I'd prefer to see notification that it's finished it's work, like in the add user dialog.
Isaac, What kind of query? If I enter for example SELECT * FROM ACTOR
I get the expected "Showing rows... " and "Query took x sec". Admittedly, for a quick query the "Loading" stays there a little too long.
Okay, it took a while to track down what I was seeing (because I was having trouble reproducing it). I'm less worried about this now than I was before, it seems minor. Maybe related to the multipart query in my third example below.
I can get it to not show the text "Your SQL query has been executed successfully" isn't shown, nor "Showing rows 0-29 ( 200 total, Query took 0.002 sec)
From the main page SQL tab try these four queries and observe the results: - select * from sakila.actor; - show databases; - create user 'foo'@'%'; grant usage on * . * to 'foo'@'%'; -- no success feedback - create user 'bar'@'%';
note that the third query gives no results or direct feedback, but if the two statements are run separately it does give the typical "Your SQL query has been executed successfully ( Query took 0.003 sec)
It's kind of late so I hope I'm expressing it clearly. I'm sure you'll let me know if I'm not :-)
Le 2011-02-20 01:04, Isaac Bennetch a écrit :
On 2/19/2011 5:53 PM, Marc Delisle wrote:
Le 2011-02-19 08:42, Isaac Bennetch a écrit :
4 - When running an SQL query from the SQL tab, the drop down notice says "Loading..." for quite a while, then disappears; it never says "Finished" or "Query run successfully" or "query run in 0.4352 seconds" or anything like that. I'd prefer to see notification that it's finished it's work, like in the add user dialog.
Isaac, What kind of query? If I enter for example SELECT * FROM ACTOR
I get the expected "Showing rows... " and "Query took x sec". Admittedly, for a quick query the "Loading" stays there a little too long.
Okay, it took a while to track down what I was seeing (because I was having trouble reproducing it). I'm less worried about this now than I was before, it seems minor. Maybe related to the multipart query in my third example below.
I can get it to not show the text "Your SQL query has been executed successfully" isn't shown, nor "Showing rows 0-29 ( 200 total, Query took 0.002 sec)
From the main page SQL tab try these four queries and observe the results:
- select * from sakila.actor;
- show databases;
- create user 'foo'@'%'; grant usage on * . * to 'foo'@'%'; -- no
success feedback
- create user 'bar'@'%';
note that the third query gives no results or direct feedback, but if the two statements are run separately it does give the typical "Your SQL query has been executed successfully ( Query took 0.003 sec)
It's kind of late so I hope I'm expressing it clearly. I'm sure you'll let me know if I'm not :-)
Yes it's clear. This is not a behavior specific to our Ajax implementation: I get the same results if Ajax is disabled.
I get "Your SQL query has been executed successfully" for the SHOW DATABASES, and the list of databases. This the last query that returns results.
AFAIK this is the way phpMyAdmin behaves when running multiple queries from one submit.
-
Isaac Bennetch -
Marc Delisle -
Thilanka Kaushalya