Hi Michal,
I had my semester exams for last two weeks. Today onward I can give priority to my GSoC project. I'll start writing the test cases for mail libraries. Any re-factored classes committed to the master branch? If so I can straight away start writing the test cases for those classes.
Regards,
Hi
Dne Mon, 21 May 2012 16:22:15 +0530 yasitha pandithawatta yasitha4@gmail.com napsal(a):
Hi Michal,
I had my semester exams for last two weeks. Today onward I can give priority to my GSoC project. I'll start writing the test cases for mail libraries.
For mail libraries? I'm not aware of any mail libraries in phpMyAdmin...
Any re-factored classes committed to the master branch? If so I can straight away start writing the test cases for those classes.
I don't think anything was merged so far. Anyway best start would be improving code coverage for existing libraries, which will not be that moving target.
On Mon, May 21, 2012 at 5:37 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Mon, 21 May 2012 16:22:15 +0530 yasitha pandithawatta yasitha4@gmail.com napsal(a):
Hi Michal,
I had my semester exams for last two weeks. Today onward I can give priority to my GSoC project. I'll start writing the test cases for mail libraries.
For mail libraries? I'm not aware of any mail libraries in phpMyAdmin...
Any re-factored classes committed to the master branch? If so I can straight away start writing the test cases for those classes.
I don't think anything was merged so far. Anyway best start would be improving code coverage for existing libraries, which will not be that moving target.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi,
Sorry, I mean "main" libraries. Then I will start improving the code coverage for them.
Hi
Dne Mon, 21 May 2012 18:30:38 +0530 yasitha pandithawatta yasitha4@gmail.com napsal(a):
Sorry, I mean "main" libraries. Then I will start improving the code coverage for them.
Okay then, I did not realize it could be so simple typo :-).
On Mon, May 21, 2012 at 6:33 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Mon, 21 May 2012 18:30:38 +0530 yasitha pandithawatta yasitha4@gmail.com napsal(a):
Sorry, I mean "main" libraries. Then I will start improving the code coverage for them.
Okay then, I did not realize it could be so simple typo :-).
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi,
I am getting following error in "/libraries/common/PMA_buildActionTitles_test.php"
PHP Fatal error: Call to undefined function __() in ...
It seems to be an error with i18n package. Does PMA support i18n? Any libraries to be installed?
Regards, Yasitha
Le 2012-05-27 13:12, yasitha pandithawatta a écrit :
Hi,
I am getting following error in "/libraries/common/PMA_buildActionTitles_test.php"
PHP Fatal error: Call to undefined function __() in ...
It seems to be an error with i18n package. Does PMA support i18n? Any libraries to be installed?
Regards, Yasitha
Yasitha, please give more details, such as: - the github reference of the tree you are testing - the command you are using to produce the error
I cannot reproduce your error. More details about gettext on [0].
[0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers
On Mon, May 28, 2012 at 5:01 PM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-27 13:12, yasitha pandithawatta a écrit :
Hi,
I am getting following error in "/libraries/common/PMA_buildActionTitles_test.php"
PHP Fatal error: Call to undefined function __() in ...
It seems to be an error with i18n package. Does PMA support i18n? Any libraries to be installed?
Regards, Yasitha
Yasitha, please give more details, such as:
- the github reference of the tree you are testing
- the command you are using to produce the error
I cannot reproduce your error. More details about gettext on [0].
[0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi,
I created test suit for common library and add all the test cases there. Then the above issue was no longer there. But I encounter another issue in test/libraries/common/PMA_ajaxResponse_test.php.
Try to run the test case using following command.
$ phpunit test/libraries/common/PMA_ajaxResponse_test.php
The following error was encountered.
*PHP Fatal error: Call to undefined function PMA_sanitize() in /var/www/phpmyadmin-dev/libraries/Message.class.php on line 585* * * Same error occured in /PMA_cheackParameters_test.php
This should be an error in the base code.
Hi
Dne Mon, 28 May 2012 22:44:36 +0530 yasitha pandithawatta yasitha4@gmail.com napsal(a):
I created test suit for common library and add all the test cases there.
You don't need to do such thing - just run phpunit without parameters in phpMyAdmin's checkout, it will run all the tests. Check phpunit's documentation for more details.
Then the above issue was no longer there. But I encounter another issue in test/libraries/common/PMA_ajaxResponse_test.php.
Try to run the test case using following command.
$ phpunit test/libraries/common/PMA_ajaxResponse_test.php
The following error was encountered.
*PHP Fatal error: Call to undefined function PMA_sanitize() in /var/www/phpmyadmin-dev/libraries/Message.class.php on line 585*
Same error occured in /PMA_cheackParameters_test.php
This should be an error in the base code.
This is error in the test case - some of them do not include all required libraries to be run standalone, they only work as part of the testsuite. It would be great to fix that.