[Phpmyadmin-devel] Re: [Phpmyadmin-cvs] CVS: phpMyAdmin config.inc.php,2.53,2.54

Hi Robin!
$cfg['InsertDropdownOrder'] = FALSE; // Ordering for elements in dropdown.
I'm afraid this description "InsertDropdownOrder" seems a bit odd; if I didn't read the sourcecode I wouldn't know what the option is for. I'd rename it to "ForeignKeyDropdownOrder" = array('content-id', 'id-content'); Then people can either change the order in the array, or even strip "id-content" or "content-id" completely to only have one-way order (some people seem to get confused by it). Opinions?
+ $cfg['SetOperators'] = array( + 'IN', + 'NOT IN' + ); +
What's that for? Regards, Garvin -- ++ Garvin Hicking | Web-Entwickler [PHP] | www.garv.in | ICQ 21392242 ++ Developer of | www.phpMyAdmin.net | www.s9y.org ++ Make me happy | http://wishes.garv.in -- Garvin Hicking | Web-Entwickler | Make me happy: www.supergarv.de | #ICQ 21392242 | http://wishes.garv.info/

On Wed, Jun 22, 2005 at 07:09:53PM +0200, Garvin Hicking wrote:
Hi Robin!
$cfg['InsertDropdownOrder'] = FALSE; // Ordering for elements in dropdown.
I'm afraid this description "InsertDropdownOrder" seems a bit odd; if I didn't read the sourcecode I wouldn't know what the option is for.
I'd rename it to
"ForeignKeyDropdownOrder" = array('content-id', 'id-content');
Then people can either change the order in the array, or even strip "id-content" or "content-id" completely to only have one-way order (some people seem to get confused by it).
Opinions? +1 for doing this way instead. I'll write this up while at the LAMP area this afternoon or tomorrow.
+ $cfg['SetOperators'] = array( + 'IN', + 'NOT IN' + ); + What's that for? Rest of the commit coming later, those functions weren't in the dropdown list when you had a SET type.
-- Robin Hugh Johnson E-Mail : robbat2@orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639 GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
participants (2)
-
Garvin Hicking
-
Robin H. Johnson