Hi, I had a look at the bug tracker and found no new bugs introduced in 3.3.0 that are still unfixed. Release candidate 1 got more than 10000 downloads so I think that this week-end we could release the final 3.3.0 (and skip releasing 3.2.6).
On 02/24/2010 06:04 PM, Marc Delisle wrote:
I filed a bug for the import progressbar code today :(
Since it's a new feauture in 3.3 that breaks the basic functionality I would like to fix this before releasing 3.3.0
Hi,
Could you please test import progress bar again? I've just pushed patch to git repo. Apparently, I used wrong branch (or no branch at all), can anyone help me with that one please?
Log from IRC: "tomas.srnka master * rRELEASE_2_9_0-2245-g1283f4a phpmyadmin/ (3 files in 2 dirs): Import progress bar fix - needs testing"
Thank you.
Best Regards, Tomas
On Thu, Feb 25, 2010 at 11:16 AM, Marc Delisle marc@infomarc.info wrote:
Tomas Srnka wrote:
Although I see the 2.9 tag it seems to be in the master branch, maybe Michal can enlighten us.
My first basic test was a success, both firefox and opera were now able to import a .sql file without errors.
A second test with a larger dataset did not go smoothly, but I have to investigate what went wrong there. Hopefully I'll have dome time for that later today or tomorrow.
Hi
Dne Mon, 01 Mar 2010 12:38:23 +0100 Herman van Rink rink@initfour.nl napsal(a):
The reason is that 2.9.0 is the last tag on master branch...
...and the description of commit is generated based on last tag + number of commits (2245 commits after 2.9.0 tag) + commit id (1283f4a).
Hi
Dne Mon, 1 Mar 2010 13:09:40 +0100 Michal Čihař michal@cihar.com napsal(a):
...and the description of commit is generated based on last tag + number of commits (2245 commits after 2.9.0 tag) + commit id (1283f4a).
What can be easily fixed by merging changes back properly [1]. For now I merged QA_3_3 and MAINT_3_3_0 into master so they see 3.3.0 tags.
[1]:http://wiki.phpmyadmin.net/pma/Devel:Git#Committing_fixes_to_several_branche...
Herman van Rink wrote:
When the server has the uploadprogress module it went well, and when I added the proper apc config that scenario also worked.
I added a link to faq item 2.9 after the ImportUploadInfoNotAvailable text, committed to both git and svn trunk. I'll port it to QA_3_3 and MAINT_3_3_0 later today if no more issues arise.
Might it be an idea to move the conditional JS code to the libraries/import/upload/ files?
Herman van Rink wrote:
I've committed the uploadprogress part of rev 13423 and 13424 to QA_3_3 and MAINT_3_3_0 after some additional testing.
13423 also included changes to the following files, which I've not included. Tomas, could you indicate if/where these should be ported?
trunk/phpMyAdmin/libraries/server_synchronize.lib.php trunk/phpMyAdmin/server_synchronize.php
Hello,
Those are only small UI changes/improvements for synchronization module, I think they can be ported into PMA3_3.
I'm sorry for not describing them in the comment.
Tomas
On Wed, Mar 3, 2010 at 10:10 AM, Herman van Rink rink@initfour.nl wrote:
I think it's a good idea, display_import.lib.php will look cleaner.
On Wed, Mar 3, 2010 at 11:36 AM, Herman van Rink rink@initfour.nl wrote:
Herman van Rink a écrit :
I guess this one means that we are ready for 3.3.0-rc2?
Hi
Dne Mon, 1 Mar 2010 12:12:26 +0100 Tomas Srnka tomas.srnka@gmail.com napsal(a):
Could you please test import progress bar again? I've just pushed patch to git repo.
The Git repository is there just for testing purposes for now. The development is still being done in SVN.
Apparently, I used wrong branch (or no branch at all), can anyone help me with that one please?
For Git see http://wiki.phpmyadmin.net/pma/Devel:Git#Working_with_branches
-
Herman van Rink -
Marc Delisle -
Michal Čihař -
Tomas Srnka