[Phpmyadmin-devel] character "1" appears at top and bottom of pages in master
Hi, In the current master -- "Git revision: 0954bfb from master branch, committed on Jun 16, 2012 at 01:02 AM by Marc Delisle", I see the character 1 at the top of both the navigation frame, near the top of the main frame, and also at the bottom of the main frame. I'm away from my main system at the moment, so I'm afraid I can't 'git-bisect' to the problem commit, sorry. Regards
Le 2012-06-15 17:32, Isaac Bennetch a écrit :
Hi,
In the current master -- "Git revision: 0954bfb from master branch, committed on Jun 16, 2012 at 01:02 AM by Marc Delisle", I see the character 1 at the top of both the navigation frame, near the top of the main frame, and also at the bottom of the main frame.
Hi Isaac, with the same revision, I don't see this character. -- Marc Delisle http://infomarc.info
On Jun 16, 2012, at 6:30 AM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-15 17:32, Isaac Bennetch a écrit :
Hi,
In the current master -- "Git revision: 0954bfb from master branch, committed on Jun 16, 2012 at 01:02 AM by Marc Delisle", I see the character 1 at the top of both the navigation frame, near the top of the main frame, and also at the bottom of the main frame.
Hi Isaac, with the same revision, I don't see this character.
-- Marc
Maybe it's specific to the demo server, then; that's where I first noticed it. You do see that at http://www.phpmyadmin.net/master, I hope? I apologize for not mentioning that in my first message.
Le 2012-06-16 07:36, Isaac Bennetch a écrit :
On Jun 16, 2012, at 6:30 AM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-15 17:32, Isaac Bennetch a écrit :
Hi,
In the current master -- "Git revision: 0954bfb from master branch, committed on Jun 16, 2012 at 01:02 AM by Marc Delisle", I see the character 1 at the top of both the navigation frame, near the top of the main frame, and also at the bottom of the main frame.
Hi Isaac, with the same revision, I don't see this character.
-- Marc
Maybe it's specific to the demo server, then; that's where I first noticed it. You do see that at http://www.phpmyadmin.net/master, I hope? I apologize for not mentioning that in my first message.
Yes, I see it on http://demo.phpmyadmin.net/master. -- Marc Delisle http://infomarc.info
Hi Dne Fri, 15 Jun 2012 17:32:57 -0400 Isaac Bennetch <bennetch@gmail.com> napsal(a):
In the current master -- "Git revision: 0954bfb from master branch, committed on Jun 16, 2012 at 01:02 AM by Marc Delisle", I see the character 1 at the top of both the navigation frame, near the top of the main frame, and also at the bottom of the main frame.
It's not caused by above commit, it's caused by appending return value of ob_end_clean after processing custom header. I see this error in several places in current code. The ob_end_clean function returns TRUE on success or FALSE on failure. I've just fixed this in master. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
participants (3)
-
Isaac Bennetch -
Marc Delisle -
Michal Čihař