Hi Michal,
Though I started to writing test cases for common library I came to know Chanaka is re-factoring it. So it is worthless of writing tests for current code. So I moved in to core library. I want to know any re-factoring going on core library.
One more thing. Whats the best way to update our forked repository? Using git pull or git fetch and merge it? Or doesn't have much difference?
Regards,
Hi
Dne Sat, 16 Jun 2012 13:28:22 +0530 yasitha pandithawatta yasitha4@gmail.com napsal(a):
Though I started to writing test cases for common library I came to know Chanaka is re-factoring it. So it is worthless of writing tests for current code. So I moved in to core library. I want to know any re-factoring going on core library.
Well refactoring of common lib is rather side effect of Chanaka's project, than main goal and it might happen elsewhere as well. But working on other library is fine as well. I've also merged both your and Chanaka's changes to main repo, so you should be able to work on these changes now as well.
One more thing. Whats the best way to update our forked repository? Using git pull or git fetch and merge it? Or doesn't have much difference?
I believe git pull is actually git fetch + merge so it should not make any difference.
Hi Michal,
I got a same kind of error when running following test classes.
Error - Use of undefined constant GETTEXT_INC - assumed 'GETTEXT_INC' in /var/www/phpmyadmin-dev/libraries/select_lang.lib.php on line 387
- PMA_fatalError_test.php - PMA_getTableCount_test.php - PMA_headerLocation_test.php
This is because of it refers a constant GETTEXT_INC which actually string path defined in vendor_config.php I include vendor_config.php as well as referred file. But still getting that error. Any suggestions?
Regards,
Hi
Dne Sat, 23 Jun 2012 10:24:29 +0530 yasitha pandithawatta yasitha4@gmail.com napsal(a):
I got a same kind of error when running following test classes.
Error - Use of undefined constant GETTEXT_INC - assumed 'GETTEXT_INC' in /var/www/phpmyadmin-dev/libraries/select_lang.lib.php on line 387
- PMA_fatalError_test.php
- PMA_getTableCount_test.php
- PMA_headerLocation_test.php
This is because of it refers a constant GETTEXT_INC which actually string path defined in vendor_config.php I include vendor_config.php as well as referred file. But still getting that error. Any suggestions?
I've fixed the first test, it needed more adjustments. You can look at the changes I've made and possibly fix others.