[Phpmyadmin-devel] GSoC 2011: Support for Routines
Hi there, I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks. Also my report for this week is available on my blog [3]. Rouslan [1]: http://demo.phpmyadmin.net/gsoc-rouslan/ [2]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte [3]: http://roccivic.blogspot.com/2011/06/week-2-report.html
On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
Hi there,
I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks.
Also my report for this week is available on my blog [3].
Rouslan
Hi there, This week I got the "Support for Routines" functionality mostly coded in. There are still a few outstanding bugs that I'm aware of, like problems with special characters in routine and parameter names. But other than those and the need for more code refactoring and tidying up, I think that the interface is pretty much finished. If you have time I'd appreciate if you test this functionality out and let me know what you make of it. The demo server [1] and GIT repo [2] are at their usual locations. The report for this week is also available on my blog [3]. Thanks for any help. Bye, Rouslan [1]: http://demo.phpmyadmin.net/gsoc-rouslan/ [2]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte [3]: http://roccivic.blogspot.com/2011/06/repor-for-week-3.html
2011/6/12 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
Hi there,
I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks.
Hi Rouslan, Looks good. I was able to add, edit, execute, export and drop a routine. Few remarks : * when adding a routine, it is not added to the list of routines (a reload of the page is required) * it might be just me, but it's not really clear that there are other parameters (like 'Definer', 'Security Type', ...) to consider following 'Definition', because they are not visible until you scroll down. Is there a way of making the scroll bar stand out more, or make it more clear that there is more to fill in after 'Definition'. Kind regards, Dieter
Also my report for this week is available on my blog [3].
Rouslan
Hi there,
This week I got the "Support for Routines" functionality mostly coded in. There are still a few outstanding bugs that I'm aware of, like problems with special characters in routine and parameter names. But other than those and the need for more code refactoring and tidying up, I think that the interface is pretty much finished. If you have time I'd appreciate if you test this functionality out and let me know what you make of it. The demo server [1] and GIT repo [2] are at their usual locations. The report for this week is also available on my blog [3]. Thanks for any help.
Bye, Rouslan
[1]: http://demo.phpmyadmin.net/gsoc-rouslan/ [2]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte [3]: http://roccivic.blogspot.com/2011/06/repor-for-week-3.html
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Groetjes, Dieter Adriaenssens
2011/6/12 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>:
2011/6/12 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
Hi there,
I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks.
Hi Rouslan,
Looks good. I was able to add, edit, execute, export and drop a routine. Few remarks :
* when adding a routine, it is not added to the list of routines (a reload of the page is required) * it might be just me, but it's not really clear that there are other parameters (like 'Definer', 'Security Type', ...) to consider following 'Definition', because they are not visible until you scroll down. Is there a way of making the scroll bar stand out more, or make it more clear that there is more to fill in after 'Definition'.
BTW : Tested with Chrome 12.0.742.91 on Linux
On Sun, 2011-06-12 at 21:19 +0200, Dieter Adriaenssens wrote:
2011/6/12 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
Hi there,
I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks.
Hi Rouslan,
Looks good. I was able to add, edit, execute, export and drop a routine. Few remarks :
* when adding a routine, it is not added to the list of routines (a reload of the page is required)
Odd, it works just fine for me in Chrome/Linux and the routine is added to the list straight away via JS. I'll have another look at any possible issues in the code that adds the new entry to the list. But, could you please double-check that it indeed is not working? Thanks
* it might be just me, but it's not really clear that there are other parameters (like 'Definer', 'Security Type', ...) to consider following 'Definition', because they are not visible until you scroll down. Is there a way of making the scroll bar stand out more, or make it more clear that there is more to fill in after 'Definition'.
The "Go" button could go to the bottom of the form (it was there until last week), so that the user is forced to scroll, but I thought that the disadvantage (scrolling when you don't need to) outweighs the benefits. I'll have a look at styling scrollbars later, anyway. We'll see if anything nice comes out of that. Thanks for your feedback, Dieter.
Kind regards,
Dieter
Also my report for this week is available on my blog [3].
Rouslan
Hi there,
This week I got the "Support for Routines" functionality mostly coded in. There are still a few outstanding bugs that I'm aware of, like problems with special characters in routine and parameter names. But other than those and the need for more code refactoring and tidying up, I think that the interface is pretty much finished. If you have time I'd appreciate if you test this functionality out and let me know what you make of it. The demo server [1] and GIT repo [2] are at their usual locations. The report for this week is also available on my blog [3]. Thanks for any help.
Bye, Rouslan
[1]: http://demo.phpmyadmin.net/gsoc-rouslan/ [2]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte [3]: http://roccivic.blogspot.com/2011/06/repor-for-week-3.html
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Sun, 2011-06-12 at 21:19 +0200, Dieter Adriaenssens wrote:
2011/6/12 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
Hi there,
I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks.
Hi Rouslan,
Looks good. I was able to add, edit, execute, export and drop a routine. Few remarks :
* when adding a routine, it is not added to the list of routines (a reload of the page is required)
Odd, it works just fine for me in Chrome/Linux and the routine is added to the list straight away via JS. I'll have another look at any possible issues in the code that adds the new entry to the list. But, could you please double-check that it indeed is not working? Thanks
* it might be just me, but it's not really clear that there are other parameters (like 'Definer', 'Security Type', ...) to consider following 'Definition', because they are not visible until you scroll down. Is there a way of making the scroll bar stand out more, or make it more clear that there is more to fill in after 'Definition'.
The "Go" button could go to the bottom of the form (it was there until last week), so that the user is forced to scroll, but I thought that the disadvantage (scrolling when you don't need to) outweighs the benefits. I'll have a look at styling scrollbars later, anyway. We'll see if anything nice comes out of that. Thanks for your feedback, Dieter.
Kind regards,
Dieter
Also my report for this week is available on my blog [3].
Rouslan
Hi there,
This week I got the "Support for Routines" functionality mostly coded in. There are still a few outstanding bugs that I'm aware of, like problems with special characters in routine and parameter names. But other than those and the need for more code refactoring and tidying up, I think that the interface is pretty much finished. If you have time I'd appreciate if you test this functionality out and let me know what you make of it. The demo server [1] and GIT repo [2] are at their usual locations. The report for this week is also available on my blog [3]. Thanks for any help.
Bye, Rouslan
[1]: http://demo.phpmyadmin.net/gsoc-rouslan/ [2]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte [3]: http://roccivic.blogspot.com/2011/06/repor-for-week-3.html
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2011/6/13 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-12 at 21:19 +0200, Dieter Adriaenssens wrote:
2011/6/12 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
Hi there,
I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks.
Hi Rouslan,
Looks good. I was able to add, edit, execute, export and drop a routine. Few remarks :
* when adding a routine, it is not added to the list of routines (a reload of the page is required)
Odd, it works just fine for me in Chrome/Linux and the routine is added to the list straight away via JS. I'll have another look at any possible issues in the code that adds the new entry to the list. But, could you plese double-check that it indeed is not working? Thanks
It seems to work when there is already a routine in the list, but not when the list of routines was empty. Other issue : when trying to add a routine with an error, a message is shown, but it seems to me it goes away too fast. The first time I was not able to read the complete message before it dissappeared. But I guess this issue is not limited to your project, but relates to every (error) message that is shown in AJAX mode.
* it might be just me, but it's not really clear that there are other parameters (like 'Definer', 'Security Type', ...) to consider following 'Definition', because they are not visible until you scroll down. Is there a way of making the scroll bar stand out more, or make it more clear that there is more to fill in after 'Definition'.
The "Go" button could go to the bottom of the form (it was there until last week), so that the user is forced to scroll, but I thought that the disadvantage (scrolling when you don't need to) outweighs the benefits. I'll have a look at styling scrollbars later, anyway. We'll see if anything nice comes out of that.
Thanks for your feedback, Dieter.
Kind regards,
Dieter
Also my report for this week is available on my blog [3].
Rouslan
Hi there,
This week I got the "Support for Routines" functionality mostly coded in. There are still a few outstanding bugs that I'm aware of, like problems with special characters in routine and parameter names. But other than those and the need for more code refactoring and tidying up, I think that the interface is pretty much finished. If you have time I'd appreciate if you test this functionality out and let me know what you make of it. The demo server [1] and GIT repo [2] are at their usual locations. The report for this week is also available on my blog [3]. Thanks for any help.
Bye, Rouslan
[1]: http://demo.phpmyadmin.net/gsoc-rouslan/ [2]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte [3]: http://roccivic.blogspot.com/2011/06/repor-for-week-3.html
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Groetjes, Dieter Adriaenssens
On Mon, 2011-06-13 at 00:21 +0200, Dieter Adriaenssens wrote:
2011/6/13 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-12 at 21:19 +0200, Dieter Adriaenssens wrote:
2011/6/12 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
Hi there,
I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks.
Hi Rouslan,
Looks good. I was able to add, edit, execute, export and drop a routine. Few remarks :
* when adding a routine, it is not added to the list of routines (a reload of the page is required)
Odd, it works just fine for me in Chrome/Linux and the routine is added to the list straight away via JS. I'll have another look at any possible issues in the code that adds the new entry to the list. But, could you plese double-check that it indeed is not working? Thanks
It seems to work when there is already a routine in the list, but not when the list of routines was empty.
Oh, yes, it is indeed a bug. I'll have it fixed soon.
Other issue : when trying to add a routine with an error, a message is shown, but it seems to me it goes away too fast. The first time I was not able to read the complete message before it dissappeared. But I guess this issue is not limited to your project, but relates to every (error) message that is shown in AJAX mode.
I've noticed that, too. I'll look into this and post a patch on the tracker if I will find a solution. Again, thanks for your feedback :)
* it might be just me, but it's not really clear that there are other parameters (like 'Definer', 'Security Type', ...) to consider following 'Definition', because they are not visible until you scroll down. Is there a way of making the scroll bar stand out more, or make it more clear that there is more to fill in after 'Definition'.
The "Go" button could go to the bottom of the form (it was there until last week), so that the user is forced to scroll, but I thought that the disadvantage (scrolling when you don't need to) outweighs the benefits. I'll have a look at styling scrollbars later, anyway. We'll see if anything nice comes out of that.
Thanks for your feedback, Dieter.
Kind regards,
Dieter
Also my report for this week is available on my blog [3].
Rouslan
Hi there,
This week I got the "Support for Routines" functionality mostly coded in. There are still a few outstanding bugs that I'm aware of, like problems with special characters in routine and parameter names. But other than those and the need for more code refactoring and tidying up, I think that the interface is pretty much finished. If you have time I'd appreciate if you test this functionality out and let me know what you make of it. The demo server [1] and GIT repo [2] are at their usual locations. The report for this week is also available on my blog [3]. Thanks for any help.
Bye, Rouslan
[1]: http://demo.phpmyadmin.net/gsoc-rouslan/ [2]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte [3]: http://roccivic.blogspot.com/2011/06/repor-for-week-3.html
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
----- Original Message -----
From: Rouslan Placella <rouslan@placella.com>
On Mon, 2011-06-13 at 00:21 +0200, Dieter Adriaenssens wrote:
2011/6/13 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-12 at 21:19 +0200, Dieter Adriaenssens wrote:
2011/6/12 Rouslan Placella <rouslan@placella.com>:
On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
Hi there,
I've had good progress this week with my work on support for routines and if you guys have some time I'd be very grateful if you could check out the currently implemented functionality on my demo server [1] and, if you have extra time on your hands, also the code in my repo [2]. Currently the "Add", "Edit", "Export" and "Drop" functionalities work well and are already integrated with AJAX. But the execute functionality is unfinished and doesn't really work too well yet with or without AJAX - it's what I'll be working on next week. Any feedback is most welcome! Thanks.
Hi Rouslan,
Looks good. I was able to add, edit, execute, export and drop a routine.
Hi Rouslan, The edit and drop not work for me in the demo server. But, when I checkout your code and test it locally, it just work fine. The scenario: - In the demo server, I goto sakila db - Under Routines, click Edit in "inventory_in_stock" - Add some comment - Click "Go" button And I got error: Query "DROP FUNCTION `inventory_in_stock`; " failed MySQL said: #1146 - Table 'mysql.columns_priv' doesn't exist -- Aris Feryanto
Hi Dne Tue, 14 Jun 2011 04:56:35 -0700 (PDT) Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
The edit and drop not work for me in the demo server. But, when I checkout your code and test it locally, it just work fine.
The scenario: - In the demo server, I goto sakila db - Under Routines, click Edit in "inventory_in_stock" - Add some comment - Click "Go" button
And I got error:
Query "DROP FUNCTION `inventory_in_stock`; " failed MySQL said: #1146 - Table 'mysql.columns_priv' doesn't exist
This pretty much looks like the mysql database was broken by some user, such problems shall disappear within 10-15 minutes. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On 14 Jun 2011, at 18:59, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Tue, 14 Jun 2011 04:56:35 -0700 (PDT) Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
The edit and drop not work for me in the demo server. But, when I checkout your code and test it locally, it just work fine.
The scenario: - In the demo server, I goto sakila db - Under Routines, click Edit in "inventory_in_stock" - Add some comment - Click "Go" button
And I got error:
Query "DROP FUNCTION `inventory_in_stock`; " failed MySQL said: #1146 - Table 'mysql.columns_priv' doesn't exist
This pretty much looks like the mysql database was broken by some user, such problems shall disappear within 10-15 minutes.
Hi, I tried again and it works correctly now in the demo server. One thing on the UI: the table header for edit, execute, export, and drop can be merged into just one cell, to match existing style of phpMyAdmin. -- Aris Feryanto
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Wed, 2011-06-15 at 09:16 +0700, Aris Feryanto wrote:
On 14 Jun 2011, at 18:59, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Tue, 14 Jun 2011 04:56:35 -0700 (PDT) Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
The edit and drop not work for me in the demo server. But, when I checkout your code and test it locally, it just work fine.
The scenario: - In the demo server, I goto sakila db - Under Routines, click Edit in "inventory_in_stock" - Add some comment - Click "Go" button
And I got error:
Query "DROP FUNCTION `inventory_in_stock`; " failed MySQL said: #1146 - Table 'mysql.columns_priv' doesn't exist
This pretty much looks like the mysql database was broken by some user, such problems shall disappear within 10-15 minutes.
Hi,
I tried again and it works correctly now in the demo server.
One thing on the UI: the table header for edit, execute, export, and drop can be merged into just one cell, to match existing style of phpMyAdmin.
Good idea, I did that :) Thanks for your feedback. Rouslan
participants (4)
-
Aris Feryanto -
Dieter Adriaenssens -
Michal Čihař -
Rouslan Placella