[Phpmyadmin-devel] concatenate locales
Hi, $strTable . ' ' . htmlspecialchars($table) . ' ' . $strHasBeenAltered; should become sprintf($strTableAlteredSuccessfully, $table); 'Table %1 has been altered successfully' or? (i know in English it makes no difference, but in other foreign languages it could) for Example in German it sounds better to use 'Die Tabelle' (the table) instead of just 'Tabelle' (table) in this case -- Sebastian
Sebastian Mendel wrote:
Hi,
$strTable . ' ' . htmlspecialchars($table) . ' ' . $strHasBeenAltered;
should become
sprintf($strTableAlteredSuccessfully, $table);
'Table %1 has been altered successfully'
or?
(i know in English it makes no difference, but in other foreign languages it could)
for Example in German it sounds better to use 'Die Tabelle' (the table) instead of just 'Tabelle' (table) in this case
-- Sebastian
I second that, it will sound better (at least in german). But what about "htmlspecialchars" ? -- View this message in context: http://www.nabble.com/concatenate-locales-tf4611715.html#a13171693 Sent from the phpmyadmin-devel mailing list archive at Nabble.com.
Jürgen Wind schrieb:
Sebastian Mendel wrote:
Hi,
$strTable . ' ' . htmlspecialchars($table) . ' ' . $strHasBeenAltered;
should become
sprintf($strTableAlteredSuccessfully, $table);
'Table %1 has been altered successfully'
or?
(i know in English it makes no difference, but in other foreign languages it could)
for Example in German it sounds better to use 'Die Tabelle' (the table) instead of just 'Tabelle' (table) in this case
I second that, it will sound better (at least in german). But what about "htmlspecialchars" ?
of course htmlspecialchars() will also be applied the above was just an example how it should be applied, i would use it like: $message = PMA_Message::success('strTableAlteredSuccessfully'); $message->addParam(htmlspecialchars($table)); -- Sebastian
Sebastian Mendel a écrit :
Hi,
$strTable . ' ' . htmlspecialchars($table) . ' ' . $strHasBeenAltered;
should become
sprintf($strTableAlteredSuccessfully, $table);
'Table %1 has been altered successfully'
or?
(i know in English it makes no difference, but in other foreign languages it could)
for Example in German it sounds better to use 'Die Tabelle' (the table) instead of just 'Tabelle' (table) in this case
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages. When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them! Marc
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them!
$strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated; -- Sebastian
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them!
$strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated;
$strDeletedRows . ' ' . $num_rows $strAffectedRows . ' ' . $num_rows; $strInsertedRows . ' ' . $num_rows; $strInsertedRowId . ' ' . ($insert_id + $num_rows - 1) -- Sebastian
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them! $strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated;
$strDeletedRows . ' ' . $num_rows $strAffectedRows . ' ' . $num_rows; $strInsertedRows . ' ' . $num_rows; $strInsertedRowId . ' ' . ($insert_id + $num_rows - 1)
In English, should we rephrase like this? $strDeletedRows = '%1$d deleted rows.'; or keep the traditional: $strDeletedRows = 'Deleted rows: %1$d';
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them! $strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated; $strDeletedRows . ' ' . $num_rows $strAffectedRows . ' ' . $num_rows; $strInsertedRows . ' ' . $num_rows; $strInsertedRowId . ' ' . ($insert_id + $num_rows - 1)
In English, should we rephrase like this?
$strDeletedRows = '%1$d deleted rows.';
or keep the traditional:
$strDeletedRows = 'Deleted rows: %1$d';
$strRowsDeleted = '%1$d rows deleted.'; $strRowDeleted = '1 row deleted.'; $strRowsDeleted = '%1$d row(s) deleted.'; i think i would prefer the last one ?? -- Sebastian
Hi On Thu, 18 Oct 2007 07:17:56 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
$strRowsDeleted = '%1$d rows deleted.'; $strRowDeleted = '1 row deleted.';
$strRowsDeleted = '%1$d row(s) deleted.';
i think i would prefer the last one
How about using gettext support in PHP for localisation? I just migrated one my tiny project from similar system like phpMyAdmin uses to gettext one and it was quite easy [*]. With gettext we can use ngettext calls, which are exactly designed for getting correct localized translation of these strings. This way we can get correct wording for all possibilities in different languages. For example in Czech correct would be something like this: Smazán 1 záznam. Smazány 2 záznamy. Smazány 3 záznamy. Smazány 4 záznamy. Smazáno 5 záznamů. [*] I hacked two simple python scripts to migrate code and translation data: http://viewsvn.cihar.com/viewvc.cgi/ukolovnik/trunk/admin/locales-convert?re... http://viewsvn.cihar.com/viewvc.cgi/ukolovnik/trunk/admin/locales-data-migra... -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Hi
On Thu, 18 Oct 2007 07:17:56 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
$strRowsDeleted = '%1$d rows deleted.'; $strRowDeleted = '1 row deleted.';
$strRowsDeleted = '%1$d row(s) deleted.';
i think i would prefer the last one
How about using gettext support in PHP for localisation? I just migrated one my tiny project from similar system like phpMyAdmin uses to gettext one and it was quite easy [*].
With gettext we can use ngettext calls, which are exactly designed for getting correct localized translation of these strings. This way we can get correct wording for all possibilities in different languages. For example in Czech correct would be something like this:
Smazán 1 záznam. Smazány 2 záznamy. Smazány 3 záznamy. Smazány 4 záznamy. Smazáno 5 záznamů.
[*] I hacked two simple python scripts to migrate code and translation data: http://viewsvn.cihar.com/viewvc.cgi/ukolovnik/trunk/admin/locales-convert?re... http://viewsvn.cihar.com/viewvc.cgi/ukolovnik/trunk/admin/locales-data-migra...
Add another extension as a requirement?... I don't know :/
Hi On Thu, 18 Oct 2007 01:50:59 -0400 Marc Delisle <Marc.Delisle@cegepsherbrooke.qc.ca> wrote:
Add another extension as a requirement?... I don't know :/
I completely understand this. I'm definitely not convinced that phpMyAdmin should use gettext. I just wanted to show that it is an option, which can provide better translations that current system. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Thu, 18 Oct 2007 15:32:40 +0900 Michal Čihař <michal@cihar.com> wrote:
I completely understand this. I'm definitely not convinced that phpMyAdmin should use gettext. I just wanted to show that it is an option, which can provide better translations that current system.
There seems to be also option of bundling PHP gettext[1] with phpMyAdmin, however I don't know anything about this project except that I googled it today ;-). [1]: https://savannah.nongnu.org/projects/php-gettext/ -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař schrieb:
On Thu, 18 Oct 2007 15:32:40 +0900 Michal Čihař <michal@cihar.com> wrote:
I completely understand this. I'm definitely not convinced that phpMyAdmin should use gettext. I just wanted to show that it is an option, which can provide better translations that current system.
There seems to be also option of bundling PHP gettext[1] with phpMyAdmin, however I don't know anything about this project except that I googled it today ;-).
looks interesting -- Sebastian
Michal Čihař schrieb:
Hi
On Thu, 18 Oct 2007 07:17:56 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
$strRowsDeleted = '%1$d rows deleted.'; $strRowDeleted = '1 row deleted.';
$strRowsDeleted = '%1$d row(s) deleted.';
i think i would prefer the last one
How about using gettext support in PHP for localisation? I just migrated one my tiny project from similar system like phpMyAdmin uses to gettext one and it was quite easy [*].
With gettext we can use ngettext calls, which are exactly designed for getting correct localized translation of these strings. This way we can get correct wording for all possibilities in different languages. For example in Czech correct would be something like this:
Smazán 1 záznam. Smazány 2 záznamy. Smazány 3 záznamy. Smazány 4 záznamy. Smazáno 5 záznamů.
[*] I hacked two simple python scripts to migrate code and translation data: http://viewsvn.cihar.com/viewvc.cgi/ukolovnik/trunk/admin/locales-convert?re... http://viewsvn.cihar.com/viewvc.cgi/ukolovnik/trunk/admin/locales-data-migra...
yes, gettext would really be nice, but reading through http://php.net/gettext makes me nervous ... do you know any not so special application that uses gettext and works "out of the box" like phpMyAdmin does? -- Sebastian
Hi On Thu, 18 Oct 2007 08:03:40 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
yes, gettext would really be nice, but reading through http://php.net/gettext makes me nervous ...
do you know any not so special application that uses gettext and works "out of the box" like phpMyAdmin does?
I don't know any application. However Drupal is using gettext like translation - same source translation files, but they manage it somehow themself, I didn't investigate the details. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them! $strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated; $strDeletedRows . ' ' . $num_rows $strAffectedRows . ' ' . $num_rows; $strInsertedRows . ' ' . $num_rows; $strInsertedRowId . ' ' . ($insert_id + $num_rows - 1) In English, should we rephrase like this?
$strDeletedRows = '%1$d deleted rows.';
or keep the traditional:
$strDeletedRows = 'Deleted rows: %1$d';
$strRowsDeleted = '%1$d rows deleted.'; $strRowDeleted = '1 row deleted.';
$strRowsDeleted = '%1$d row(s) deleted.';
i think i would prefer the last one
??
Me too.
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them!
$strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated;
$strTable . ' ' . $table . ' ' . $strHasBeenCreated;
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them!
$strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated;
$strIndexesSeemEqual . ' ' . $each_index_name . ', ' . $first_column['Key_name']
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
$strIndexesSeemEqual . ' ' . $each_index_name . ', ' . $first_column['Key_name']
Rephrase as this? $strIndexesSeemEqual = 'The indexes %1$s and %2$s seem to be equal and one of them should be removed.';
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
$strIndexesSeemEqual . ' ' . $each_index_name . ', ' . $first_column['Key_name']
Rephrase as this?
$strIndexesSeemEqual = 'The indexes %1$s and %2$s seem to be equal and one of them should be removed.';
ok "... and one of them could possibly removed." ? -- Sebastian
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
$strIndexesSeemEqual . ' ' . $each_index_name . ', ' . $first_column['Key_name'] Rephrase as this?
$strIndexesSeemEqual = 'The indexes %1$s and %2$s seem to be equal and one of them should be removed.';
ok
"... and one of them could possibly removed." ?
"... and one of them could possibly be removed." :)
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them!
$strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated;
$strForeignKeyError . ' : ' . $master_field
Sebastian Mendel schrieb:
Marc Delisle schrieb:
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them!
$strDatabase . ' ' . htmlspecialchars($db) . ' ' . $strHasBeenCreated;
how about: strFileNameTemplateDescriptionServer strFileNameTemplateDescriptionDatabase strFileNameTemplateDescriptionTable '__SERVER__/' . $strFileNameTemplateDescriptionServer changing to: '%1$s/server name'
participants (4)
-
Jürgen Wind -
Marc Delisle -
Michal Čihař -
Sebastian Mendel