Hi,
$strTable . ' ' . htmlspecialchars($table) . ' ' . $strHasBeenAltered;
should become
sprintf($strTableAlteredSuccessfully, $table);
'Table %1 has been altered successfully'
or?
(i know in English it makes no difference, but in other foreign languages it could)
for Example in German it sounds better to use 'Die Tabelle' (the table) instead of just 'Tabelle' (table) in this case
Sebastian Mendel wrote:
I second that, it will sound better (at least in german). But what about "htmlspecialchars" ?
Sebastian Mendel a écrit :
Yes. In the first years of phpMyAdmin we added some concatenated messages instead of those short messages that don't read correctly in most other languages.
When we prepare a feature release (like now for PMA 3.0) it's time to find those and improve them!
Marc
Hi
On Thu, 18 Oct 2007 07:17:56 +0200 Sebastian Mendel lists@sebastianmendel.de wrote:
How about using gettext support in PHP for localisation? I just migrated one my tiny project from similar system like phpMyAdmin uses to gettext one and it was quite easy [*].
With gettext we can use ngettext calls, which are exactly designed for getting correct localized translation of these strings. This way we can get correct wording for all possibilities in different languages. For example in Czech correct would be something like this:
Smazán 1 záznam. Smazány 2 záznamy. Smazány 3 záznamy. Smazány 4 záznamy. Smazáno 5 záznamů.
[*] I hacked two simple python scripts to migrate code and translation data: http://viewsvn.cihar.com/viewvc.cgi/ukolovnik/trunk/admin/locales-convert?re... http://viewsvn.cihar.com/viewvc.cgi/ukolovnik/trunk/admin/locales-data-migra...
Hi
On Thu, 18 Oct 2007 01:50:59 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Add another extension as a requirement?... I don't know :/
I completely understand this. I'm definitely not convinced that phpMyAdmin should use gettext. I just wanted to show that it is an option, which can provide better translations that current system.
On Thu, 18 Oct 2007 15:32:40 +0900 Michal Čihař michal@cihar.com wrote:
There seems to be also option of bundling PHP gettext[1] with phpMyAdmin, however I don't know anything about this project except that I googled it today ;-).
[1]: https://savannah.nongnu.org/projects/php-gettext/
Michal Čihař schrieb:
yes, gettext would really be nice, but reading through http://php.net/gettext makes me nervous ...
do you know any not so special application that uses gettext and works "out of the box" like phpMyAdmin does?
Hi
On Thu, 18 Oct 2007 08:03:40 +0200 Sebastian Mendel lists@sebastianmendel.de wrote:
I don't know any application. However Drupal is using gettext like translation - same source translation files, but they manage it somehow themself, I didn't investigate the details.