Hi,
i will now (or at least in a few minutes) checkin the new 'queryboxes'
affected by this checkin are:
all queryboxes/sql tabs: - server_sql.php - db_details.php - table_prperties.php - table_prperties_structure.php
and the querywindow, of course
changes are as follows:
- tables replaced by fieldset - changed all fieldset background-color like the new import - moved the whole code into a new lib file - moved any style relevant html and css into phpmyadmin.css.php - tbl_query_box.php deprecated
PLEASE test all!
Sebastian Mendel a écrit :
Hi,
i will now (or at least in a few minutes) checkin the new 'queryboxes'
affected by this checkin are:
all queryboxes/sql tabs:
- server_sql.php
- db_details.php
- table_prperties.php
- table_prperties_structure.php
and the querywindow, of course
changes are as follows:
- tables replaced by fieldset
- changed all fieldset background-color like the new import
- moved the whole code into a new lib file
- moved any style relevant html and css into phpmyadmin.css.php
- tbl_query_box.php deprecated
PLEASE test all!
Good work. Seems to work well.
While working on this, I think we could remove the "Or" that introduces the sections "Location of the text file" and "Bookmarked SQL query" (and maybe others on this page that I'm not seeing at the moment).
This "Or" is also seen on the table search page, but not anywhere else AFAIK. For example, in Operations we can do many things but we don't put "Or" to introduce them.
Comments?
Marc
On Tue 27. 9. 2005 19:34, Marc Delisle wrote:
While working on this, I think we could remove the "Or" that introduces the sections "Location of the text file" and "Bookmarked SQL query" (and maybe others on this page that I'm not seeing at the moment).
This "Or" is also seen on the table search page, but not anywhere else AFAIK. For example, in Operations we can do many things but we don't put "Or" to introduce them.
Comments?
Sounds reasonable to me. What about file import part, should it stay on SQL tab or not?
Michal Čihař a écrit :
On Tue 27. 9. 2005 19:34, Marc Delisle wrote:
While working on this, I think we could remove the "Or" that introduces the sections "Location of the text file" and "Bookmarked SQL query" (and maybe others on this page that I'm not seeing at the moment).
This "Or" is also seen on the table search page, but not anywhere else AFAIK. For example, in Operations we can do many things but we don't put "Or" to introduce them.
Comments?
Sounds reasonable to me. What about file import part, should it stay on SQL tab or not?
I would go with your suggestion of removing it.
Another question that we discussed a few years ago: do we still need to keep the features of the SQL tab, on the Structure page?
It would be cleaner to remove them. I rarely find the need to type some queries or recall a bookmark when checking the structure, and also the query window is always available.
Marc
On Tue 27. 9. 2005 20:08, Marc Delisle wrote:
Another question that we discussed a few years ago: do we still need to keep the features of the SQL tab, on the Structure page?
It would be cleaner to remove them. I rarely find the need to type some queries or recall a bookmark when checking the structure, and also the query window is always available.
Let's drop it, even in case I want to use it, I rather switch to SQL tab than scroll down over structure ;-).
Anyway when we're at SQL box.
What the hell should "Show this query here again" do? It's query window only, isn't it?
Michal Čihař a écrit :
Anyway when we're at SQL box.
What the hell should "Show this query here again" do? It's query window only, isn't it?
Let's say you enter an INSERT query in the box. If you tick this option, your INSERT query will be displayed again in the box. If not, then it won't.
I don't think this works for a SELECT.
Still useful? I don't know.
Marc
On Tue 27. 9. 2005 21:26, Marc Delisle wrote:
Let's say you enter an INSERT query in the box. If you tick this option, your INSERT query will be displayed again in the box. If not, then it won't.
I get it displayed in both cases. The checkbox value is used only in query window and nowhere else.
Michal Čihař a écrit :
On Tue 27. 9. 2005 21:26, Marc Delisle wrote:
Let's say you enter an INSERT query in the box. If you tick this option, your INSERT query will be displayed again in the box. If not, then it won't.
I get it displayed in both cases. The checkbox value is used only in query window and nowhere else.
Yes, this is the current behavior in HEAD. In 2.6.4 it did what I described.
Marc
On Tue 27. 9. 2005 21:53, Marc Delisle wrote:
Yes, this is the current behavior in HEAD. In 2.6.4 it did what I described.
Current behaviour looks logical to me, except the checkbox for nothing, what do you think?
Michal Čihař a écrit :
On Tue 27. 9. 2005 21:53, Marc Delisle wrote:
Yes, this is the current behavior in HEAD. In 2.6.4 it did what I described.
Current behaviour looks logical to me, except the checkbox for nothing, what do you think?
Ok to remove it in the SQL tabs.
In the query window, I don't see any effect for this checkbox?
Marc
On Tue 27. 9. 2005 22:20, Marc Delisle wrote:
In the query window, I don't see any effect for this checkbox?
Well I don't know whether there is any real effect, but at least there is following code:
/** * Defines the query to be displayed in the query textarea */ if ( ! empty( $show_query ) ) { $query_to_display = $sql_query; } else { $query_to_display = ''; }
Michal Čihař schrieb:
On Tue 27. 9. 2005 22:20, Marc Delisle wrote:
In the query window, I don't see any effect for this checkbox?
Well I don't know whether there is any real effect, but at least there is following code:
/**
- Defines the query to be displayed in the query textarea
*/ if ( ! empty( $show_query ) ) { $query_to_display = $sql_query; } else { $query_to_display = ''; }
so i dont have to check later for the presence of $query_to_display, i can just use it
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel