[Phpmyadmin-devel] Color of error messages in pmahomme theme
Hi, I find it difficult to read error messages (white text on "pink" background). Text color red would be fine, IMO. -- Marc Delisle http://infomarc.info
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Monday, April 18, 2011 7:52 AM To: phpmyadmin-devel@lists.sf.net Subject: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Hi,
I find it difficult to read error messages (white text on "pink" background).
Hi, Not sure where "pink on white" shows up. I've only seen "pink on black". Could I get a screenshot or steps to repro?
Text color red would be fine, IMO.
-- Marc Delisle http://infomarc.info
---------------------------------------------------------------------------- --
Benefiting from Server Virtualization: Beyond Initial Workload Consolidation - - Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On 4/18/11 9:26 PM, Mike Homme wrote:
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Monday, April 18, 2011 7:52 AM To: phpmyadmin-devel@lists.sf.net Subject: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Hi,
I find it difficult to read error messages (white text on "pink" background).
Hi,
Not sure where "pink on white" shows up. I've only seen "pink on black".
Could I get a screenshot or steps to repro?
Try the demo server master branch, I see both -- the white text warns of missing PMA configuration storage features and the black text warns of root with no password. The black text on pink background doesn't bother me much, but the white text does. Or Marc's suggestion of red text with a slightly off color background. ~isaac
Text color red would be fine, IMO.
-- Marc Delisle http://infomarc.info
-----Original Message----- From: Isaac Bennetch [mailto:bennetch@gmail.com] Sent: Monday, April 18, 2011 9:35 PM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
On 4/18/11 9:26 PM, Mike Homme wrote:
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Monday, April 18, 2011 7:52 AM To: phpmyadmin-devel@lists.sf.net Subject: [Phpmyadmin-devel] Color of error messages in pmahomme
theme
Hi,
I find it difficult to read error messages (white text on "pink" background).
Hi,
Not sure where "pink on white" shows up. I've only seen "pink on black".
Could I get a screenshot or steps to repro?
Try the demo server master branch, I see both -- the white text warns of missing PMA configuration storage features and the black text warns of root with no password.
The black text on pink background doesn't bother me much, but the white text does. Or Marc's suggestion of red text with a slightly off color background.
~isaac
Thanks, Isaac. My latest commit includeds: .notice: which was yellow-ish, is now a light blue. .warning: is now the yellow-ish color that "notice" was. .error: changed to the pinkish background with black (not red) text. .success: background stays the green color. I think this addresses the hard to read colors, and also puts colors in a more standard "order of importance", if there is such a thing. ; ) Mike
Text color red would be fine, IMO.
-- Marc Delisle http://infomarc.info
---------------------------------------------------------------------------- --
Benefiting from Server Virtualization: Beyond Initial Workload Consolidation - - Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Mike Homme a écrit :
My latest commit includeds:
.notice: which was yellow-ish, is now a light blue. .warning: is now the yellow-ish color that "notice" was. .error: changed to the pinkish background with black (not red) text. .success: background stays the green color.
I think this addresses the hard to read colors, and also puts colors in a more standard "order of importance", if there is such a thing. ; )
Mike
Mike, The light blue of ".notice" can be confused with the color of links. See for example the server Status page. For ".error", I'm happy with your change. For ".success", I see a yellow background #EBF8A4 with green border #A2D246, with this what you meant? -- Marc Delisle http://infomarc.info
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, April 19, 2011 7:15 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
My latest commit includeds:
.notice: which was yellow-ish, is now a light blue. .warning: is now the yellow-ish color that "notice" was. .error: changed to the pinkish background with black (not red) text. .success: background stays the green color.
I think this addresses the hard to read colors, and also puts colors in a more standard "order of importance", if there is such a thing. ; )
Mike
Mike,
The light blue of ".notice" can be confused with the color of links. See for example the server Status page.
I see what you mean, will fix.
For ".error", I'm happy with your change.
Err, well, now I'm not. : ) On the demo server (Home screen), I see two messages at the bottom. One is ".warning" and the other is ".error". I'd suggest the two styles be identical (which is what I meant to do) . Would making them the same work well with other user cases in the app? Or does .error and .warning have specific meanings and they should look different?
For ".success", I see a yellow background #EBF8A4 with green border #A2D246, with this what you meant?
. I actually haven't changed the .success style since I "toned them down" about a month ago, per user feedback. So yes, it's greenish to me but, I'm OK with it as-is.
-- Marc Delisle http://infomarc.info
---------------------------------------------------------------------------- --
Benefiting from Server Virtualization: Beyond Initial Workload Consolidation - - Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-04-20 23:24, Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, April 19, 2011 7:15 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
My latest commit includeds:
.notice: which was yellow-ish, is now a light blue. .warning: is now the yellow-ish color that "notice" was. .error: changed to the pinkish background with black (not red) text. .success: background stays the green color.
I think this addresses the hard to read colors, and also puts colors in a more standard "order of importance", if there is such a thing. ; )
Mike
Mike,
The light blue of ".notice" can be confused with the color of links. See for example the server Status page.
I see what you mean, will fix.
Great.
For ".error", I'm happy with your change.
Err, well, now I'm not. : )
On the demo server (Home screen), I see two messages at the bottom. One is ".warning" and the other is ".error". I'd suggest the two styles be identical (which is what I meant to do) . Would making them the same work well with other user cases in the app? Or does .error and .warning have specific meanings and they should look different?
The idea was that an error is "worst" and needs more immediate attention than a warning; however the choice of error/warning is of course open to interpretation. In the original theme, the icon is different. A warning is "softened" with the icon containing an exclamation mark but is still considered a somewhat problematic message. Now I suspect that we could have only three levels, to remove the "open to interpretation" problem. success: a confirmation that all is fine ("Table has been copied", "Bookmark created"). notice: a neutral message to inform of something ("Inserted row id", "Query took 0.01 seconds"). error: this is a problem (would cover the current errors and warnings).
For ".success", I see a yellow background #EBF8A4 with green border #A2D246, with this what you meant?
. I actually haven't changed the .success style since I "toned them down" about a month ago, per user feedback. So yes, it's greenish to me but, I'm OK with it as-is.
OK. -- Marc Delisle http://infomarc.info
Hi Dne Thu, 21 Apr 2011 07:00:15 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
The idea was that an error is "worst" and needs more immediate attention than a warning; however the choice of error/warning is of course open to interpretation.
In the original theme, the icon is different. A warning is "softened" with the icon containing an exclamation mark but is still considered a somewhat problematic message.
Now I suspect that we could have only three levels, to remove the "open to interpretation" problem.
success: a confirmation that all is fine ("Table has been copied", "Bookmark created").
notice: a neutral message to inform of something ("Inserted row id", "Query took 0.01 seconds").
error: this is a problem (would cover the current errors and warnings).
It pretty much makes sense. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Hi
Dne Thu, 21 Apr 2011 07:00:15 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
The idea was that an error is "worst" and needs more immediate attention than a warning; however the choice of error/warning is of course open to interpretation.
In the original theme, the icon is different. A warning is "softened" with the icon containing an exclamation mark but is still considered a somewhat problematic message.
Now I suspect that we could have only three levels, to remove the "open to interpretation" problem.
success: a confirmation that all is fine ("Table has been copied", "Bookmark created").
notice: a neutral message to inform of something ("Inserted row id", "Query took 0.01 seconds").
error: this is a problem (would cover the current errors and warnings).
It pretty much makes sense.
I'll work on this. -- Marc Delisle http://infomarc.info
Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, April 19, 2011 7:15 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
My latest commit includeds:
.notice: which was yellow-ish, is now a light blue. .warning: is now the yellow-ish color that "notice" was. .error: changed to the pinkish background with black (not red) text. .success: background stays the green color.
I think this addresses the hard to read colors, and also puts colors in a more standard "order of importance", if there is such a thing. ; )
Mike Mike,
The light blue of ".notice" can be confused with the color of links. See for example the server Status page.
I see what you mean, will fix.
Hi Mike, can you fix it this week? -- Marc Delisle http://infomarc.info
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, May 03, 2011 7:48 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, April 19, 2011 7:15 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
My latest commit includeds:
.notice: which was yellow-ish, is now a light blue. .warning: is now the yellow-ish color that "notice" was. .error: changed to the pinkish background with black (not red) text. .success: background stays the green color.
I think this addresses the hard to read colors, and also puts colors in a more standard "order of importance", if there is such a thing. ; )
Mike Mike,
The light blue of ".notice" can be confused with the color of links. See for example the server Status page.
I see what you mean, will fix.
Hi Mike, can you fix it this week?
Yes, tomorrow afternoon I should be able to get this in. I'll also sync up the .error and .warning styles to be the same.
-- Marc Delisle http://infomarc.info
---------------------------------------------------------------------------- --
WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-05-03 20:07, Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, May 03, 2011 7:48 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, April 19, 2011 7:15 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
My latest commit includeds:
.notice: which was yellow-ish, is now a light blue. .warning: is now the yellow-ish color that "notice" was. .error: changed to the pinkish background with black (not red) text. .success: background stays the green color.
I think this addresses the hard to read colors, and also puts colors in a more standard "order of importance", if there is such a thing. ; )
Mike Mike,
The light blue of ".notice" can be confused with the color of links. See for example the server Status page.
I see what you mean, will fix.
Hi Mike, can you fix it this week?
Yes, tomorrow afternoon I should be able to get this in.
I'll also sync up the .error and .warning styles to be the same.
.warning won't be used anymore. -- Marc Delisle http://infomarc.info
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Wednesday, May 04, 2011 5:41 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Le 2011-05-03 20:07, Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, May 03, 2011 7:48 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, April 19, 2011 7:15 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in
pmahomme
theme
Mike Homme a écrit :
My latest commit includeds:
.notice: which was yellow-ish, is now a light blue. .warning: is now the yellow-ish color that "notice" was. .error: changed to the pinkish background with black (not red) text. .success: background stays the green color.
I think this addresses the hard to read colors, and also puts colors in a more standard "order of importance", if there is such a thing. ; )
Mike Mike,
The light blue of ".notice" can be confused with the color of links. See for example the server Status page.
I see what you mean, will fix.
Hi Mike, can you fix it this week?
Yes, tomorrow afternoon I should be able to get this in.
I'll also sync up the .error and .warning styles to be the same.
.warning won't be used anymore.
Cool, did we update all class ref's in PMA and remove/replace warning? Just changed light blue to black on .notice. I think that helps distinguish. Committed.
-- Marc Delisle http://infomarc.info
---------------------------------------------------------------------------- --
WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-05-05 20:46, Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Wednesday, May 04, 2011 5:41 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Le 2011-05-03 20:07, Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, May 03, 2011 7:48 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in pmahomme theme
Mike Homme a écrit :
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Tuesday, April 19, 2011 7:15 AM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] Color of error messages in
pmahomme
theme
Mike Homme a écrit :
> My latest commit includeds: > > .notice: which was yellow-ish, is now a light blue. > .warning: is now the yellow-ish color that "notice" was. > .error: changed to the pinkish background with black (not red) text. > .success: background stays the green color. > > I think this addresses the hard to read colors, and also puts > colors in a more standard "order of importance", if there is such a thing. > ; > ) > > Mike Mike,
The light blue of ".notice" can be confused with the color of links. See for example the server Status page.
I see what you mean, will fix.
Hi Mike, can you fix it this week?
Yes, tomorrow afternoon I should be able to get this in.
I'll also sync up the .error and .warning styles to be the same.
.warning won't be used anymore.
Cool, did we update all class ref's in PMA and remove/replace warning?
Yes.
Just changed light blue to black on .notice. I think that helps distinguish.
Committed.
Now please push. -- Marc Delisle http://infomarc.info
participants (4)
-
Isaac Bennetch -
Marc Delisle -
Michal Čihař -
Mike Homme