[Phpmyadmin-devel] Updating metro theme for PMA v4.4
Hi all, As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed. [1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master -- Thanks and Regards, Madhura Jayaratne
Hi Madhura, I have worked on Metro theme and developed a few projects on Metro theme from scratch. I would like to contribute to this. Please let me know on which part I can contribute to this metro theme. Thanks. On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- With best regards, Kushagra Pandey, B.Tech. Part-IV, Electrical Engineering, IIT (BHU), Varanasi.
On Fri, Mar 13, 2015 at 4:07 PM, Kushagra Pandey <kushagra4296@gmail.com> wrote:
Hi Madhura,
I have worked on Metro theme and developed a few projects on Metro theme from scratch. I would like to contribute to this. Please let me know on which part I can contribute to this metro theme.
What do you mean "developed a few projects on Metro theme"? You mean you've developed a new theme based on metro? If that is the case please submit it at http://sourceforge.net/p/phpmyadmin/themes/
-- Thanks and Regards, Madhura Jayaratne
No, I haven't made any theme for phpmyadmin, but I have made Metro UI themes for other projects. As I have experience in metro (flat) design, I just wanted to contribute to the metro theme of phpmyadmin. Sorry for the confusion. So let me know if there is some part of the theme that needs to be worked upon and so, and I'd contribute on that. On Fri, Mar 13, 2015 at 4:21 PM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
On Fri, Mar 13, 2015 at 4:07 PM, Kushagra Pandey <kushagra4296@gmail.com> wrote:
Hi Madhura,
I have worked on Metro theme and developed a few projects on Metro theme from scratch. I would like to contribute to this. Please let me know on which part I can contribute to this metro theme.
What do you mean "developed a few projects on Metro theme"? You mean you've developed a new theme based on metro? If that is the case please submit it at http://sourceforge.net/p/phpmyadmin/themes/
-- Thanks and Regards,
Madhura Jayaratne
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- With best regards, Kushagra Pandey, B.Tech. Part-IV, Electrical Engineering, IIT (BHU), Varanasi. M: +91-9616079370 Email: kushagra4296@gmail.com kushagra.pandey.eee11@iitbhu.ac.in
On Fri, Mar 13, 2015 at 4:27 PM, Kushagra Pandey <kushagra4296@gmail.com> wrote:
No, I haven't made any theme for phpmyadmin, but I have made Metro UI themes for other projects. As I have experience in metro (flat) design, I just wanted to contribute to the metro theme of phpmyadmin. Sorry for the confusion. So let me know if there is some part of the theme that needs to be worked upon and so, and I'd contribute on that.
OK. I should be able to fix the layout problems probably by Monday (won't be working on weekend). I think you can then help with the aesthetics of the theme. This is to avoid any duplicate work and possible merge conflicts.
P.S. Please use bottom posting on this mailing list. -- Thanks and Regards, Madhura Jayaratne
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs, I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback. [1] https://github.com/madhuracj/metro/ -- Thanks and Regards, Madhura Jayaratne
Hi Madhura, On 3/18/15 6:26 AM, Madhura Jayaratne wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com <mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
Great progress! Very nice job. I have some thoughts: * On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there. * On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see it with pmahomme * From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns" * The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better. * The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox? Again, great work. ~isaac
On 3/18/15 9:58 AM, Isaac Bennetch wrote:
Hi Madhura,
On 3/18/15 6:26 AM, Madhura Jayaratne wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com <mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
Great progress! Very nice job. I have some thoughts:
* On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there.
* On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see it with pmahomme
* From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns"
* The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better.
* The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox?
Again, great work. ~isaac
Also, for some reason I don't see a tool tip for the MySQL documentation when I hover over that icon, but I do see it with the other two themes.
Hi Issac On Wed, Mar 18, 2015 at 7:31 PM, Isaac Bennetch <bennetch@gmail.com> wrote:
On 3/18/15 9:58 AM, Isaac Bennetch wrote:
Hi Madhura,
On 3/18/15 6:26 AM, Madhura Jayaratne wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <
madhura.cj@gmail.com
<mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
Great progress! Very nice job. I have some thoughts:
* On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there.
Seems somehow IcoMoon font didn't load on your system. Kindly refresh. It's a user icon there.
* On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see it with pmahomme
* From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns"
* The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better.
* The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox?
No such issues on my Chrome.
Again, great work. ~isaac
Also, for some reason I don't see a tool tip for the MySQL documentation when I hover over that icon, but I do see it with the other two themes.
Well, other icons <a> tag have a title attribute, but the MySQL documentation <a> is missing the title attribute. Other themes are showing the tooltips on the <img> tag (child of <a> tag), but this theme is showing the <a>'s title attribs. Should I add the 'title' attrib to this <a> in phpmyadmin code?
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- With best regards, Kushagra Pandey, B.Tech. Part-IV, Electrical Engineering, IIT (BHU), Varanasi. M: +91-9616079370 Email: kushagra4296@gmail.com kushagra.pandey.eee11@iitbhu.ac.in
On Wed, Mar 18, 2015 at 10:56 PM, Kushagra Pandey <kushagra4296@gmail.com> wrote:
Hi Issac
On Wed, Mar 18, 2015 at 7:31 PM, Isaac Bennetch <bennetch@gmail.com> wrote:
On 3/18/15 9:58 AM, Isaac Bennetch wrote:
Hi Madhura,
On 3/18/15 6:26 AM, Madhura Jayaratne wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <
madhura.cj@gmail.com
<mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
Great progress! Very nice job. I have some thoughts:
* On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there.
Seems somehow IcoMoon font didn't load on your system. Kindly refresh. It's a user icon there.
* On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see it with pmahomme
* From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns"
* The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better.
* The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox?
No such issues on my Chrome.
Again, great work. ~isaac
Also, for some reason I don't see a tool tip for the MySQL documentation when I hover over that icon, but I do see it with the other two themes.
Well, other icons <a> tag have a title attribute, but the MySQL documentation <a> is missing the title attribute. Other themes are showing the tooltips on the <img> tag (child of <a> tag), but this theme is showing the <a>'s title attribs. Should I add the 'title' attrib to this <a> in phpmyadmin code?
Hi Kushagra, You may submit a pull request against QA_4_4 branch. Also, since the layout seems to be ok now, you are most welcome to work on improving the theme. -- Thanks and Regards, Madhura Jayaratne
On Thu, Mar 19, 2015 at 7:55 AM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
On Wed, Mar 18, 2015 at 10:56 PM, Kushagra Pandey <kushagra4296@gmail.com> wrote:
Hi Issac
On Wed, Mar 18, 2015 at 7:31 PM, Isaac Bennetch <bennetch@gmail.com> wrote:
On 3/18/15 9:58 AM, Isaac Bennetch wrote:
Hi Madhura,
On 3/18/15 6:26 AM, Madhura Jayaratne wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <
madhura.cj@gmail.com
<mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
Great progress! Very nice job. I have some thoughts:
* On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there.
Seems somehow IcoMoon font didn't load on your system. Kindly refresh. It's a user icon there.
* On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see
it
with pmahomme
* From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns"
* The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better.
* The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox?
No such issues on my Chrome.
Again, great work. ~isaac
Also, for some reason I don't see a tool tip for the MySQL documentation when I hover over that icon, but I do see it with the other two themes.
Well, other icons <a> tag have a title attribute, but the MySQL documentation <a> is missing the title attribute. Other themes are showing the tooltips on the <img> tag (child of <a> tag), but this theme is showing the <a>'s title attribs. Should I add the 'title' attrib to this <a> in phpmyadmin code?
Hi Kushagra,
You may submit a pull request against QA_4_4 branch. Also, since the layout seems to be ok now, you are most welcome to work on improving the theme.
Hi Madhura, I have submitted a pull request here:
https://github.com/phpmyadmin/phpmyadmin/pull/1595 Let me know if something needs to be changed. I changed "documentation" to "MySQL Documentation" for clarity. I have been little occupied with trying something to do (bug fix/feature implementation) for GSOC - so once I get free, I will contribute to the theme, as I guess contribution to theme will not be counted as one for GSOC. With regards, Kushagra.
-- Thanks and Regards,
Madhura Jayaratne
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Thu, Mar 19, 2015 at 3:18 PM, Kushagra Pandey <kushagra4296@gmail.com> wrote:
On Thu, Mar 19, 2015 at 7:55 AM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
On Wed, Mar 18, 2015 at 10:56 PM, Kushagra Pandey <kushagra4296@gmail.com
wrote:
Hi Issac
On Wed, Mar 18, 2015 at 7:31 PM, Isaac Bennetch <bennetch@gmail.com> wrote:
On 3/18/15 9:58 AM, Isaac Bennetch wrote:
Hi Madhura,
On 3/18/15 6:26 AM, Madhura Jayaratne wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <
madhura.cj@gmail.com
<mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
Great progress! Very nice job. I have some thoughts:
* On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there.
Seems somehow IcoMoon font didn't load on your system. Kindly refresh. It's a user icon there.
* On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see
it
with pmahomme
* From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns"
* The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better.
* The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox?
No such issues on my Chrome.
Again, great work. ~isaac
Also, for some reason I don't see a tool tip for the MySQL documentation when I hover over that icon, but I do see it with the other two themes.
Well, other icons <a> tag have a title attribute, but the MySQL documentation <a> is missing the title attribute. Other themes are showing the tooltips on the <img> tag (child of <a> tag), but this theme is showing the <a>'s title attribs. Should I add the 'title' attrib to this <a> in phpmyadmin code?
Hi Kushagra,
You may submit a pull request against QA_4_4 branch. Also, since the layout seems to be ok now, you are most welcome to work on improving the theme.
Hi Madhura, I have submitted a pull request here:
https://github.com/phpmyadmin/phpmyadmin/pull/1595 Let me know if something needs to be changed. I changed "documentation" to "MySQL Documentation" for clarity. I have been little occupied with trying something to do (bug fix/feature implementation) for GSOC - so once I get free, I will contribute to the theme, as I guess contribution to theme will not be counted as one for GSOC.
AFAIK, it is not counted unless your GSoC project is in the same area.
Others can verify this. -- Thanks and Regards, Madhura Jayaratne
Madhura Jayaratne a écrit :
On Thu, Mar 19, 2015 at 3:18 PM, Kushagra Pandey <kushagra4296@gmail.com> wrote:
On Thu, Mar 19, 2015 at 7:55 AM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
On Wed, Mar 18, 2015 at 10:56 PM, Kushagra Pandey <kushagra4296@gmail.com
wrote: Hi Issac
On Wed, Mar 18, 2015 at 7:31 PM, Isaac Bennetch <bennetch@gmail.com> wrote:
On 3/18/15 9:58 AM, Isaac Bennetch wrote:
Hi Madhura,
On 3/18/15 6:26 AM, Madhura Jayaratne wrote: > > On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne < madhura.cj@gmail.com > <mailto:madhura.cj@gmail.com>> wrote: > > Hi all, > > As per the discussion on the recent team meeting [1] I have started > working on updating metro theme to be compatible with phpMyAdmin 4.4 > and you can find what I've done so far at [2]. I am basically going > through all the commits that had some style/image change since 2013 > and adapting them to metro them to make sure nothing is missed. > > [1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes > [2] https://github.com/madhuracj/metro/commits/master > > -- > Thanks and Regards, > > Madhura Jayaratne > > > Hi devs, > > I think the theme is in a reasonable state now. Would appreciate if you > could get the theme from [1] and try it with phpMyAdmin version 4.4 (in > Beta) and give feedback. > > [1] https://github.com/madhuracj/metro/ Great progress! Very nice job. I have some thoughts:
* On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there.
Seems somehow IcoMoon font didn't load on your system. Kindly refresh. It's a user icon there.
* On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see it with pmahomme
* From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns"
* The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better.
* The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox? No such issues on my Chrome.
Again, great work. ~isaac
Also, for some reason I don't see a tool tip for the MySQL documentation when I hover over that icon, but I do see it with the other two themes.
Well, other icons <a> tag have a title attribute, but the MySQL documentation <a> is missing the title attribute. Other themes are showing the tooltips on the <img> tag (child of <a> tag), but this theme is showing the <a>'s title attribs. Should I add the 'title' attrib to this <a> in phpmyadmin code?
Hi Kushagra,
You may submit a pull request against QA_4_4 branch. Also, since the layout seems to be ok now, you are most welcome to work on improving the theme.
Hi Madhura, I have submitted a pull request here:
https://github.com/phpmyadmin/phpmyadmin/pull/1595 Let me know if something needs to be changed. I changed "documentation" to "MySQL Documentation" for clarity. I have been little occupied with trying something to do (bug fix/feature implementation) for GSOC - so once I get free, I will contribute to the theme, as I guess contribution to theme will not be counted as one for GSOC.
AFAIK, it is not counted unless your GSoC project is in the same area.
Others can verify this.
Indeed we noticed in the past that developing a theme is not eligible for GSoC. -- Marc Delisle (phpMyAdmin)
On Wed, Mar 18, 2015 at 7:28 PM, Isaac Bennetch <bennetch@gmail.com> wrote:
Hi Madhura,
On 3/18/15 6:26 AM, Madhura Jayaratne wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com <mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
Great progress! Very nice job. I have some thoughts:
Hi Isaac, Thanks for the feedback.
* On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there.
Looks like the IconMoon font did not load. It should look like the attached image.
* On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see it with pmahomme
Thanks for bringing this to notice. It seems like this theme supports multiple schemes. You can switch between them by changing the 'scheme' parameter in layout.inc.php. I just tried some other schemes and even though layout is correct, some color adjustments is needed for other schemes.
* From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns"
Yes, this needs to be fixed.
* The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better.
I agree. I will update the color.
* The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox?
IconMoon font issue again.
Again, great work. ~isaac
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Thanks and Regards, Madhura Jayaratne
On 3/18/15 10:22 PM, Madhura Jayaratne wrote:
On Wed, Mar 18, 2015 at 7:28 PM, Isaac Bennetch <bennetch@gmail.com <mailto:bennetch@gmail.com>> wrote:
Hi Madhura,
On 3/18/15 6:26 AM, Madhura Jayaratne wrote: > > > On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com <mailto:madhura.cj@gmail.com> > <mailto:madhura.cj@gmail.com <mailto:madhura.cj@gmail.com>>> wrote: > > Hi all, > > As per the discussion on the recent team meeting [1] I have started > working on updating metro theme to be compatible with phpMyAdmin 4.4 > and you can find what I've done so far at [2]. I am basically going > through all the commits that had some style/image change since 2013 > and adapting them to metro them to make sure nothing is missed. > > [1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes > [2] https://github.com/madhuracj/metro/commits/master > > -- > Thanks and Regards, > > Madhura Jayaratne > > > Hi devs, > > I think the theme is in a reasonable state now. Would appreciate if you > could get the theme from [1] and try it with phpMyAdmin version 4.4 (in > Beta) and give feedback. > > [1] https://github.com/madhuracj/metro/
Great progress! Very nice job. I have some thoughts:
Hi Isaac,
Thanks for the feedback.
* On the login page, there's a large 'a' displayed. I don't remember much about the metro theme from times past, so maybe the original designer had some motivation for it, but I'd rather see a p or our logo or something there.
Looks like the IconMoon font did not load. It should look like the attached image.
I was able to resolve this; it had to do with the folder name of the theme on my disk which has to match exactly 'metro'. Mine had been named 'metro-master' and apparently everything works except the icomoon icons. So it's resolved, thanks for the tips. ~isaac
* On the main page, I see something extra after the Theme selection dropdown: "Scheme: win" do you have thoughts about that? I do not see it with pmahomme
Thanks for bringing this to notice. It seems like this theme supports multiple schemes. You can switch between them by changing the 'scheme' parameter in layout.inc.php. I just tried some other schemes and even though layout is correct, some color adjustments is needed for other schemes.
* From a table structure page, under the list of columns there's the list of actions; Print view, Propose table structure, etc. The spacing between the first three (Print view, Propose table structure, and Track table) look okay, but then the rest seem to be squished closer together. This is particularly noticeable because the 'e' from "Track table" seems to be slightly covered by the icon for "Move columns"
Yes, this needs to be fixed.
* The green color used, for instance, when showing a successful query "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit bright for the tone of the rest of the theme. It's currently #01A31C, perhaps something like #77BB77 would fit better.
I agree. I will update the color.
* The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL documentation, and Reload navigation frame -- none of the icons are appearing for me. For Home I see an exclamation point, and the rest of them have the appearance of unsupported unicode characters. Is this a problem with my Firefox?
IconMoon font issue again.
Again, great work. ~isaac
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net <mailto:Phpmyadmin-devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Thanks and Regards,
Madhura Jayaratne
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Wed, Mar 18, 2015 at 3:56 PM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
[1] https://github.com/madhuracj/metro/
Hi all,
Since the theme did not have all the icon files I had to manually extract them from sprites.png one by one [1]. However, when I generated sprites again [2] some icons looked faded. I suspect something is wrong with my sprites generation and would appreciate if someone can confirm that (and generate sprites correctly) [1] https://github.com/madhuracj/metro/commit/5b07eb3b9ca4791b261269bb5bb8ad4c88... [2] https://github.com/madhuracj/metro/commit/8edfa12be3b4d348fb46b21c2c0597c163... -- Thanks and Regards, Madhura Jayaratne
Le 2015-03-20 22:50, Madhura Jayaratne a écrit :
On Wed, Mar 18, 2015 at 3:56 PM, Madhura Jayaratne <madhura.cj@gmail.com <mailto:madhura.cj@gmail.com>> wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com <mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
[1] https://github.com/madhuracj/metro/
Hi all,
Since the theme did not have all the icon files I had to manually extract them from sprites.png one by one [1]. However, when I generated sprites again [2] some icons looked faded. I suspect something is wrong with my sprites generation and would appreciate if someone can confirm that (and generate sprites correctly)
[1] https://github.com/madhuracj/metro/commit/5b07eb3b9ca4791b261269bb5bb8ad4c88... [2] https://github.com/madhuracj/metro/commit/8edfa12be3b4d348fb46b21c2c0597c163...
-- Thanks and Regards,
Madhura Jayaratne
Hi Madhura, is the attached file better? -- Marc Delisle | phpMyAdmin
On Sat, Mar 21, 2015 at 9:27 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2015-03-20 22:50, Madhura Jayaratne a écrit :
On Wed, Mar 18, 2015 at 3:56 PM, Madhura Jayaratne <madhura.cj@gmail.com <mailto:madhura.cj@gmail.com>> wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com <mailto:madhura.cj@gmail.com>> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
[1] https://github.com/madhuracj/metro/
Hi all,
Since the theme did not have all the icon files I had to manually extract them from sprites.png one by one [1]. However, when I generated sprites again [2] some icons looked faded. I suspect something is wrong with my sprites generation and would appreciate if someone can confirm that (and generate sprites correctly)
[1]
https://github.com/madhuracj/metro/commit/5b07eb3b9ca4791b261269bb5bb8ad4c88...
[2] https://github.com/madhuracj/metro/commit/8edfa12be3b4d348fb46b21c2c0597c163...
-- Thanks and Regards,
Madhura Jayaratne
Hi Madhura, is the attached file better?
Hi Marc,
Thanks a lot. However, still the first couple of icons look faded. I will look further into this. -- Thanks and Regards, Madhura Jayaratne
On Wed, Mar 18, 2015 at 3:56 PM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:
Hi all,
As per the discussion on the recent team meeting [1] I have started working on updating metro theme to be compatible with phpMyAdmin 4.4 and you can find what I've done so far at [2]. I am basically going through all the commits that had some style/image change since 2013 and adapting them to metro them to make sure nothing is missed.
[1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes [2] https://github.com/madhuracj/metro/commits/master
-- Thanks and Regards,
Madhura Jayaratne
Hi devs,
I think the theme is in a reasonable state now. Would appreciate if you could get the theme from [1] and try it with phpMyAdmin version 4.4 (in Beta) and give feedback.
I have submitted the theme at https://sourceforge.net/p/phpmyadmin/themes/89/ -- Thanks and Regards, Madhura Jayaratne
participants (4)
-
Isaac Bennetch -
Kushagra Pandey -
Madhura Jayaratne -
Marc Delisle