Eduardo wrote:
>Having it in such an easily-accessible place doesn't seem
>safe to me. I suppose you might say the same about empty,
>though.
Well, in a way you're right and that's the reason why I added
more space between this link and the other ones in the version
I commited a few minuts ago.
But I wonder how safe need to be this script. Protect databases
as far as possible is a evidence, but for tables...
>Fair enough. Maybe then we should have the links at the top,
>then when the table has more than 20 fields another could be
>added below.
Good idea. I'll work on this.
>Maybe we should have two separate variables then; one for
>BLOBs, and one for varchar binary / char binary.
Maybe, but there is already so many configuration settings...
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hi Ignacio & List!
>I would get rid of the "Drop" link on the top of the page,
Hum, why?
>get rid of the BSID links in the middle,
Done
>then move the BSID links from above the table properties
>to below the table properties.
Their current position is more convenient IMHO: if you have
a table with many fields and just want to insert a row, it's no
really an amazing game to scroll and scroll and scroll... the
page till you reach the bottom of the table properties.
On the opposite, having these links at top do not really
change anything with many fields: even without this "command
line", you'll have to scrool down to see a field near the end of
the field list.
[Splitting lib.inc.php3]
I'll do it tomorrow (of course, I'll do what Marc suggested but
there is not much things used only by a script in this library.
>I thought we had already discussed that char binary and
>varchar binary fields don't necessarily hold binary data;
Neither do BLOB fields, isn't it?
And since we have a setting in the configuration file to protect
binary blobs....
[About the strange and vanishing parse error]
Steve wrote me he'll have a look at it tomorrow. But that's
really stange indeed!
Regards,
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hi List!
Here is a little list of question I need your advice about:
1) In the table properties page do we really need the
browse/select/insert/delete and drop table links at the
middle and the bottom of the page since they are already
at the top?
2) I'm about to add a "libs" sub-directory where will be
stored all the libraries because I think we should split
the big "lib.inc.php3" in three smallest files:
- one with common stuff (its name would be
"common.inc.php3"... or "lib.inc.php3");
- one with the functions used to display table
("display_table.inc.php3");
- and the last one with the functions used to build dump
files ("dump.inc.php3").
This way loading the common stuff (this is required by
all the scripts) will be faster and somtimes the server
will love it ;)
Do you agree this idea? (I've already received a reply
from Olivier & Marc about it: they say yes)
3) About the cfgShowBlob variable I wonder if it's the
right limitation. I mean if the problem is to hide
binary data, we should also test other column types and
flags (varchar binary....) and rename this setting to
cfgShowBinary.
4) A more annoying thing: please have a look here:
http://sourceforge.net/forum/forum.php?thread_id=137826&forum_id=72908
Steve faced the same problem but I can't reproduce it.
Does anyone else faced it and may find where the error
is?
Regards,
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hi List!
I've been reported some bugs with the last script
version I commited yesterday. I want to fix them
but can't use cvs from here :(
It would be nice if one of the dev. may do this for
me. Here are the list of changes:
- in main.php3, the line 220 should be:
"mysql_free_result($rs_usr);"
- in tbl_properties.php3, line 456 the parameter
of the "show_docu" function should be :
"manual_MySQL_Optimization#MySQL_indexes"
Don't bother about the changeLog, I'll update it
tonight.
Thanks,
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hello,
FYI, if you're not comfortable with cvs, every few days,
there is an up-to-date version of the package under
http://phpmyadmin.sourceforge.net/cvs/
To use at your own risks :)
Olivier
--
_________________________________________________________________
Olivier Mueller - om(a)8304.ch - PGPkeyID: 0E84D2EA - Switzerland
qmail projects: http://omail.omnis.ch - http://webmail.omnis.ch
>Thanks, it works now for my (ordinary) CSV case.
>Will you apply it?
Yep, I'll do it as soon as:
- the new icons for Full/partial text button are ready ;)
- I'm at home.
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Marc wrote:
>Is there a reason to force the double-quotes?
Not at all. With the note Benjamin sent yesterday,
this part of the script should be rewritten this way:
// Handles the "separator" and the optionnal "enclosed by" characters
if (!isset($sep)) {
$sep = '';
} else if ($what == 'excel') {
$sep = ';';
} else {
if (get_magic_quotes_gpc()) {
$sep = stripslashes($sep);
}
$sep = str_replace('\\t', "\011", $sep);
}
if (!isset($enc_by)) {
$enc_by = '';
} else if ($what == 'excel') {
$enc_by = '"';
} else if (get_magic_quotes_gpc()) {
$enc_by = stripslashes($enc_by);
}
if (!isset($esc_by)) {
$enc_by = '';
} else if (($esc_by == '' && $enc_by !='')
|| $what == 'excel') {
// double the "enclosed by" character
$esc_by = $enc_by;
} else if (get_magic_quotes_gpc()) {
$esc_by = stripslashes($esc_by);
}
At least, I think so!
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hi,
In 2.2.0 and cvs, even if we remove the double-quote for "Fields enclosed by", all fields in CSV
data are enclosed by double-quotes.
in get_table_csv, from lib.inc.php3 v1.89:
if (empty($enc_by) || $what == 'excel') {
$enc_by = '"';
}
Is there a reason to force the double-quotes?
Marc
Hi Graziano & list!
Easy fix for that problem: at line 109 of lib.inc.php3,
just remove the "=" sign in the conditionnal test, ie
"if (PHP_INT_VERSION > 30009)"
So sorry....
Graziano: I'm doing some more tests with the
account you creted for me. Do not remove it
now please.
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
