December 2005 - Developers - lists.phpmyadmin.net

Re: [Phpmyadmin-devel] Re: globals
by Michal Čihař 10 Jan '06

10 Jan '06

Hi I guess this should go to the list :-) On Thu, 22 Dec 2005 08:16:41 +0100 Sebastian Mendel <lists(a)sebastianmendel.de> wrote: > Michal Čihař schrieb: > > I don't see much benefit of this. This would mean to split files into > > smaller ones, what means more maintenance. For most things splitting > > will be tricky or will end in main category. > > with templates PMA will not include the text itself, but its name > > <?php > ... > $strings['CouldNotLoadExtension'] = null; > $template->append_by_ref( 'errors', $strings['CouldNotLoadExtension'] ); > ... > > ... > // load strings from DB > $sql = 'SELECT `id`, `string` FROM `cz` WHERE `id` IN (\'' . > implode(array_keys($strings)) . '\')'; > $strings = PMA_DBI_fetch_result($sql, 'id', 'string'); > ... > > ... > $template->display(); > ... > ?> Yes, templates would be great, but I still do not see advantage of db stored strings ;-). -- Michal Čihař | http://cihar.com

4 4

[Phpmyadmin-devel] phpMyAdmin 2.7.0-pl2 is released
by Marc Delisle 27 Dec '05

27 Dec '05

Hi, This is patch level 2 for phpMyAdmin 2.7.0; in some MySQL 4.0.x installations, the dialog to create a table was not displayed. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Re: PMA db copy and InnoDB
by Michal Čihař 23 Dec '05

23 Dec '05

Hi Marc replying to devel list as I thing it belongs there. On Thu, 22 Dec 2005 13:46:20 -0500 Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote: > Can you confirm that there remains some work to do, to be able to copy a > db containing innodb constraints? The constraints creation must be done > after all necessary tables have been created. If you copy one table, you have to handle constraints manually. While copying whole database, it should work (if there are not possible cross db relations, what I don't know right now). > Also, what's the goal of "Add constraints" ? I see that if someone does > not tick it, it's a way to copy a db without an error about constraints, > but what's next for the user? Manual constraints creation on the copy? Yes, currently you can use this to copy table without constraints. > A user cannot choose to copy "constraints only". If he could, this would > be interesting for him because he can do the full db copy in 2 passes > (assuming PMA does not let him do it in one pass). This should be easy to add, is it really needed? Shouldn't we provide tool for copying all dependent tables? -- Michal Čihař | http://cihar.com

2 4

[Phpmyadmin-devel] Merry Christmas and a Happy new Year
by Sebastian Mendel 23 Dec '05

23 Dec '05

Merry Christmas and a Happy new Year, to all! see you next year! -- Sebastian Mendel www.sebastianmendel.de

3 2

[Phpmyadmin-devel] A non-privileged user cannot change his password?
by Marc Delisle 23 Dec '05

23 Dec '05

Hi, I would like to know if this was discussed: $cfg['ShowChgPassword'] = $is_superuser = PMA_isSuperuser(); in http://cvs.sourceforge.net/viewcvs.py/phpmyadmin/phpMyAdmin/main.php?r1=2.9… I think that a non-privileged user should be able to change his password. Anyway, this code implies that there would be no reason for this parameter. Marc

2 1

[Phpmyadmin-devel] problem with $goto_whitelist
by Marc Delisle 18 Dec '05

18 Dec '05

Hi, in the bookmarks creation dialog, we have a hidden goto that contains "sql.php?db=mybase&table=mytable" and some other parameters. Current logic in common.lib.php: if (isset($_REQUEST['goto']) && in_array($_REQUEST['goto'], $goto_whitelist)) { fails in this case because the white list contains sql.php and we are comparing with a $_REQUEST['goto'] containing sql.php plus parameters. Same problem could happen for other parameters like $back, I'm not sure. Is there another function like in_array() but able to compare a substring? If not, we'll have to do something like: if (isset($_REQUEST['goto']) && in_array(substr($_REQUEST['goto'],0,strpos($_REQUEST['goto'] . '?','?')), $goto_whitelist)) { Marc

1 0

[Phpmyadmin-devel] current HEAD and charsets
by Marc Delisle 16 Dec '05

16 Dec '05

Hi, can you reproduce this? I create a table named école and after the CREATE TABLE, the name is corrupted (the name is internally encoded in UTF-8 by MySQL 4.1.x but it's not properly decoded when displayed in PMA). Then I can no longer work with the table (insert, search, etc). Same problem happens when connecting to a MySQL 4.0.x or 5.0.x server. This must be caused by a recent change in HEAD. Marc

2 2

[Phpmyadmin-devel] config.inc.php - world readable
by Sebastian Mendel 16 Dec '05

16 Dec '05

Hi, what exactly is the problem with config.inc.php being world readable? issnt every file readable by the web server 'somehow' world readable? and issnt it so if /www is only user and group readable that /www/myweb/config.inc.php is secure enough? or is this just a sf.net specific problem, cause all webroots are world readable? (btw. i am a little bit annoyed by the fact that i have now set my read only flag for config.inc.php after every change on it on my developer machine (Windows)) -- Sebastian Mendel www.sebastianmendel.de www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet

3 2

[Phpmyadmin-devel] RTL: 'left' frame to the right?
by Sebastian Mendel 14 Dec '05

14 Dec '05

Hi, wouldn't it be consequential to move the 'left' frame to the right for RTL languages? -- Sebastian Mendel www.sebastianmendel.de www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet

2 3

[Phpmyadmin-devel] weird characters in common.lib.php
by Marc Delisle 12 Dec '05

12 Dec '05

Some weird characters have been merged in common.lib.php, lines 1975 and 1978. Looks like some utf-8. Marc

1 0