May 2011 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Create Table in navigation panel
by Thilanka Kaushalya 10 May '11

10 May '11

Hi Marc, I started working with my first task which is *"**Create table in navigation panel** - Currently this option loads new create table window. Instead of that we can provide a pop up dialog appears for creating table. (A dialog window which looks as table create options at the database operation section)".* So I went through the current "create table" option in the database operation section and found how it works. It uses the "display_create_table.lib.php" form to get the name and the number of fields of the table. Then after it get submitted, it uses the jquery coding which is in the functions.js file to pop up the jquery dialog of the create user form. How should I design the js functionality for new feature. I can add the js code to navigation.js file and use it to pop up the dialog, or else I have to use the same code which is in the functions.js file. But I think its better to add the code the navigation.js file because it is a navigation functionality. Please comment on this issue. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

3 4

[Phpmyadmin-devel] view icon for navi panel (pmahomme)
by Marc Delisle 10 May '11

10 May '11

Hi, what about this icon for views in navi panel? -- Marc Delisle http://infomarc.info

3 3

Re: [Phpmyadmin-devel] Recently Used Tables
by Aris Feryanto 09 May '11

09 May '11

Hi, I've fixed the problem below and implement some suggestions. I've just pushed my commits, so the demo server should be updated in about an hour. On 8 Mei 2011, at 17:49, Marc Delisle <marc(a)infomarc.info> wrote: > Le 2011-05-07 20:53, Aris Feryanto a écrit : > Hi Aris, > > On the positive side, the new feature works well, both with or without > pma_recent. > > On the negative side, I can no longer browse any table (no data is shown > and there are warnings at the bottom of the browse page). > This is fixed. I used variable $result, which is used by other part of code. I've changed the variable name to $tmp_result. > Missing feature: > - in /setup I don't see how to define pma_recent > Added. > Suggestions: > - in saveToDb() you could use REPLACE INTO instead of a SELECT then > UPDATE or INSERT, see http://dev.mysql.com/doc/refman/5.1/en/replace.html Added. > > - in getHtmlSelect() please use jQuery instead of the onchange event; > this is the direction we are taking about js in this project I use onchange event, because the js code need a value generated from php ($GLOBALS['cfg']['LeftDefaultTabTable'], i.e. where the main frame will jump to when a recent table is selected). Should we change this to jQuery? I think that the code will be separated; the jQuery event in .js and the generated value in <script> tag in php. > > - about syntax, please write "if (! isset" instead of "if (!isset" (add > a space after the exclamation point) Updated. But, I did a searching and found many parts of existing code use "if (!isset". > > Keep up the good work. > > -- > Marc Delisle > http://infomarc.info -- Aris Feryanto

2 2

[Phpmyadmin-devel] Coding standards - Line length
by Madhura Jayaratne 09 May '11

09 May '11

Hi all, Although we have chosen PEAR coding standards[1] as the coding standard for phpMyAdmin[2], there are quite a number of occasions where the standard is being violated, especially the line length recommendation. For example in display_tbl.lib.php I can see lines with 282 character while the recommended limit is 75-85[3]. However, I feel that this limit is bit too restrictive given that some lines have indentation of about 32 spaces. So I think it's better to set the limit bit leniently (at least for those files) and adhering to it rather than ignoring the line length limit altogether. Any thoughts? With things clarified all the GSoCers would be able to produce quality code during this summer. -- Thanks and Regards, Madhura Jayaratne [1] http://pear.php.net/manual/en/standards.php [2] http://wiki.phpmyadmin.net/pma/Coding_guidelines [3] http://pear.php.net/manual/en/standards.indenting.php

4 3

Re: [Phpmyadmin-devel] Recently Used Tables
by Aris Feryanto 08 May '11

08 May '11

Hi all, I've pushed commits improving the "recently used tables" in my repo and would like to ask for comments before I proceed further. The demo have been updated, so you can try it through [0]. What I've done so far: - Added configuration 'LeftRecentTable' ("Settings" -> "Navigation frame" -> "Navigation frame" tab -> "Recently used tables") - Added a new class ./libraries/RecentTable.class.php for managing recent tables - Added configuration ['Servers'][$i]['recent'], table in pma database for "persistent" recent tables - Added SQL commands to create 'pma_recent' table in scripts/create_tables.sql others: - Added 'recent' feature in ./libraries/relation.lib.php - Modified some CSS to prettify navigation frame What next to be done: - Write documentation about configuration LeftRecentTable - Write documentation about table pma_recent in Documentation.html [0] http://demo.phpmyadmin.net/gsoc-aris/ Regards, -- Aris Feryanto

2 1

[Phpmyadmin-devel] Color of error messages in pmahomme theme
by Marc Delisle 06 May '11

06 May '11

Hi, I find it difficult to read error messages (white text on "pink" background). Text color red would be fine, IMO. -- Marc Delisle http://infomarc.info

4 13

Re: [Phpmyadmin-devel] Charts colors and git question
by Michal Čihař 05 May '11

05 May '11

Hi Dne Thu, 5 May 2011 13:50:57 +0200 Tyron Madlener <tyronx(a)gmail.com> napsal(a): > By the way, I just saw that with themes that don't have the chart > colors defined the charts display will be broken. Should I put some > default values into pma_pchart_chart.php? I've fixed all themes supporting 3.4, so that should be okay. PS: Keep the discussion on the list, it's usually better. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

2 1

[Phpmyadmin-devel] Demo server for GSoC
by Michal Čihař 05 May '11

05 May '11

Hi I've just set up demo server for all GSoC projects which had git link on the wiki page (Ammar Yasir is missing). You can find links to demos at: http://wiki.phpmyadmin.net/pma/GSoC_2011_Projects As with regular demos, code is updated hourly. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

3 3

[Phpmyadmin-devel] ready for QA_3_4 branch?
by Marc Delisle 05 May '11

05 May '11

Hi, Some can disagree but looking at the bug tracker, I don't find bugs major enough to block the 3.4.0 release. I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there only the fixes about which we are sure, with the goal of preparing 3.4.0-rc3 which should be the last candidate. -- Marc Delisle http://infomarc.info

5 12

[Phpmyadmin-devel] Charts colors and git question
by Tyron Madlener 05 May '11

05 May '11

I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key. After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong? Thanks in advance.

6 12