May 2011 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Question on i18n
by Tyron Madlener 23 May '11

23 May '11

In most files language strings are being included directly with the __() function, however in server_status.php in the first lines of code are a huge amount of variables being set to the language strings, that are later used. Like those: $strShowStatusDelayed_writesDescr = __('The number of INSERT DELAYED rows written.'); $strShowStatusFlush_commandsDescr = __('The number of executed FLUSH statements.'); $strShowStatusHandler_commitDescr = __('The number of internal COMMIT statements.'); Does that have any particular reason?

2 5

Re: [Phpmyadmin-devel] tracker item
by Herman van Rink 23 May '11

23 May '11

On 23-05-11 12:52, Zarubin Stas wrote: > Hi. > > Thanks. Can you assign this issue to me? I currently can't since your not a member of the sf.net project. I'm not entirely sure but I don't think last years students were added. But to keep updated on the tracker item you can just use the "Monitor" link. > > For the problem with paths - I think the best way to solve it is get > rid of the "./" and "../" in the include/require statements. > And put phpMyAdmin include dir into xml configuration or bootstrap.php I'd prefer as little hard coded configuration as possible. I think the main problem was that sometimes the current corking directory was ./test and sometimes the project root. A good piece of documentation could go along way here... > > -- > Zarubin Stas > > > 23.05.11 13:33, Herman van Rink написав(ла): >> Hi, >> >> >> Could you have a look at: >> https://sourceforge.net/tracker/index.php?func=detail&aid=3170421&group_id=… >> >> >> > -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions

1 0

[Phpmyadmin-devel] PMA_DBI_get_columns/fields - which is deprecated?
by Piotr Przybylski 20 May '11

20 May '11

2011/5/19 Dieter Adriaenssens <dieter.adriaenssens(a)gmail.com>: > 2011/5/19 Crack <piotrprz(a)gmail.com>: >> 2011/5/19 Dieter Adriaenssens <dieter.adriaenssens(a)gmail.com>: >> >>> commit 9c170511179 >>> >>> I'm not sure about replacing the obsolete function. I remember Marc >>> telling something about not using 'columns' but 'fields', last summer, >>> so I guess removing the function is a move in the opposite direction. >>> Can you check on the developers mailing list what should be done with >>> this function? >> >> In code comments I saw 'fields' marked as deprecated [1], with >> function's comment telling me to use one of 'columns' variants... > > Yes, I noticed the 'deprecated' status too, but seeing it I remembered > Marc's comment, so I started wondering if this deprecation, or at > least the function name, is still correct. > >> [1] http://repo.or.cz/w/phpmyadmin/crack.git/blobdiff/7d3cd879a496adc27e5e827ef… >> Going public with this, maybe someone will remember :) -- Regards, Piotr Przybylski

3 6

[Phpmyadmin-devel] phpMyAdmin 3.4.1 and 3.3.10.1 are released
by Marc Delisle 20 May '11

20 May '11

Welcome to phpMyAdmin 3.4.1, a bugfix and security release and to phpMyAdmin 3.3.10.1, a security release. Please refer to the upcoming PMASA-2011-3 and PMASA-2011-4 announcements on http://www.phpmyadmin.net/home_page/security/. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] OpenGIS and Flot
by Tyron Madlener 20 May '11

20 May '11

Madhura Jayaratne is implementing his OpenGIS project with flot, the jquery plotting library. Will this library be included in pma releases in the future? If yes, I would also use flot for the charts on the status page. It seems more clever to generate the graphs on the client, rather than creating png files on the server and transfer them. It would reduce server load and allows for a lot more possibilities on the client-side.

3 8

[Phpmyadmin-devel] Content security policy on demo server
by Piotr Przybylski 20 May '11

20 May '11

Hi, demo server should have its CSP changed to allow scripts from more domains. Currently Firefox 4 reports these warnings (copied from Firebug console): CSP: Directive "img-src http://demo.phpmyadmin.net data://*:*" violated by http://api.flattr.com/button/button-compact-static-100x17.png return typeof jQuery !== "undefine... jQuery.event.triggered !== e.type) ? jquery...5555394 (line2559) CSP: Directive "script-src http://demo.phpmyadmin.net www.phpmyadmin.net" violated by http://cdn1.adbard.net/js/ab2.js CSP: Directive "script-src http://demo.phpmyadmin.net www.phpmyadmin.net" violated by http://www.google-analytics.com/ga.js CSP: Directive "script-src http://demo.phpmyadmin.net www.phpmyadmin.net" violated by http://stats.cihar.com/piwik.js -- Piotr Przybylski

2 1

Re: [Phpmyadmin-devel] Status page
by Tyron Madlener 20 May '11

20 May '11

On Fri, May 20, 2011 at 1:05 PM, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: > 2011/5/20 Tyron Madlener <tyronx(a)gmail.com>: >> On Fri, May 20, 2011 at 12:14 PM, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: >>> 2011/5/20 Tyron Madlener <tyronx(a)gmail.com>: >>>> On Mon, May 16, 2011 at 8:07 PM, Tyron Madlener <tyronx(a)gmail.com> wrote: >>>> >>>> What I've implemented now quick'n'dirty: >>>> >>>> - Word filtering on the variables page >>>> >>>> - Server status page: >>>> - filtering by category >>>> - when filtering by category, or typing a category name it will >>>> display related links which formerly were at the bottom of each table >>>> - i've added a jquery table sorter (12k unminified) to allow table >>>> sorting (currently sorting indicators are missing) >>>> - i've added the jquery cookie plugin (3.6k unminified) to allow >>>> cookie persistence for jquery tabs >>>> [...] >>> >>> Do we really need this? If so, at least change cookie name from >>> "ui-tabs-1" to something more descriptive. >> >> I've added those two jquery plugins more like for demonstrational >> reasons. It only requires 2 small changes to remove either plugin. But >> counter question: Why we shouldn't use it? If a person checks up on a >> server variable several times, we save him a mouse click. Save a >> second, save a life ;) > > Ok, I can't argue with that :) > >> But when talking about whether we really need this: >> - From what I can see there's lots of jQuery UI components included >> that are not used. We could remove those. >> - We can delete jquery/timepicker.js because it's redundant. I just >> deleted it and removed the includes in tbl_change.php and >> tbl_select.php - the datepicker still works since its included in >> jquery-ui-1.8.custom.js. > > I'm not sure how this custom version was generated but if you are > removing jQuery UI features, add some docs which will let the next > person that generates jquery-ui-*-custom.js get the components we > require. Or is there already such a list somewhere? Not that I know of. Who included it in the first place? Probably a good idea to start a page on the wiki for that. As for now, I removed timepicker.js from my branch. > >> Unfortunately I cannot change the cookie name that easily. Naming is >> done through the jquery tab plugin. >> > > Then maybe it is based on tab control's id or something similar? If > it's done by plugin, I believe there has to be an easy way to > influence this. Otherwise, you are limited to one tab per domain, > which seems silly. > > If the automatic way doesn't work correctly, try submitting a bug > report to jQuery UI, or use tab's show event to set cookie. Oh right. Looking at the code, you can actually can pass a cookie name to it. My bad, I must have overlooked it. > > -- > Piotr Przybylski >

1 0

Re: [Phpmyadmin-devel] Status page
by Tyron Madlener 20 May '11

20 May '11

On Mon, May 16, 2011 at 8:07 PM, Tyron Madlener <tyronx(a)gmail.com> wrote: > On Mon, May 16, 2011 at 7:57 PM, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: >> 2011/5/16 Tyron Madlener <tyronx(a)gmail.com>: >>> The first version of this feature is now implemented and pushed to my >>> repository, so it should show up on the demo >>> (http://demo.phpmyadmin.net/gsoc-tyron) anytime soon. No i18n yet. >> >> Check whether reassigning of "even"/"odd" css classes to rows after >> filtering is doable (i.e. works fast enough), otherwise looks good :) > > Yea, that should be no problem. > >> It would be useful to have similar filtering on server Variables tab, >> will you do it? > > I was thinking of the same actually. I add it there too, its fairly > easy to make. > >> >>> Also the query chart loads with ajax now, which is way faster. >>> (ignores the ajax setting atm though) >> >> There should be some "Loading..." text indicating that something is >> being loaded in background (the same UI as when executing SQL query >> via AJAX). >> > > Oh, yes. I was actually thinking of replacing the text link with an > ajax clock once the link has been clicked. That way the user can still > read all the text while its loading. > >> >> -- >> Regards, >> Piotr Przybylski >> > What I've implemented now quick'n'dirty: - Word filtering on the variables page - Server status page: - filtering by category - when filtering by category, or typing a category name it will display related links which formerly were at the bottom of each table - i've added a jquery table sorter (12k unminified) to allow table sorting (currently sorting indicators are missing) - i've added the jquery cookie plugin (3.6k unminified) to allow cookie persistence for jquery tabs - the query chart loads asynchronly when loading the page. What I would love to do next: - replace pchart with javascript charting using jflot to easily switch between a query chart versus statement chart for a good fix of: http://sourceforge.net/tracker/?func=detail&aid=3242060&group_id=23067&atid… and also to get rid of those odd caching bugs that don't refresh the chart. - proper i18n and CSS styling (for which I asked a question about earlier on this mailing list) once the general direction i am heading to is okay for everyone I'd be thankful to have some advice on this, aswell as my flot & css questions so I can continue working on it. Michal? :-) Changes are pushed to my repos and ready to test on the demo page.

2 1

Re: [Phpmyadmin-devel] Recently Used Tables
by Aris Feryanto 20 May '11

20 May '11

On 16 Mei 2011, at 01:33, Tyron Madlener <tyronx(a)gmail.com> wrote: > On Sun, May 15, 2011 at 6:56 PM, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: >> >> >> On 15 Mei 2011, at 16:17, Tyron Madlener <tyronx(a)gmail.com> wrote: >> >>> On Fri, May 13, 2011 at 10:06 PM, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: >>>> Hi, >>>> The recently used tables is now using ajax. I've just pushed to my repo, so >>>> the demo [0] will be available in an hour later. Comment and suggestion are >>>> welcome, mainly regarding the ajax-related code: >>>> - ajax request in navigation.js >>>> - ajax response in navigation.php >>>> - ajax trigger in header.inc.php (the triggering is done by adding <script> >>>> tag to call js function in the navigation frame, any better way?) >>>> [0] http://demo.phpmyadmin.net/gsoc-aris/ >>>> Cheers, >>>> -- >>>> Aris Feryanto >>> >>> What if, instead of a 'recently used tables drop down list' there >>> would be a bunch of icons that allow (ajax request-)sorting of >>> tables/databases by different criterias such as: >>> - most recently used >>> - most commonly used >>> - table/db size >> >> I think we can add sorting criteria in settings page. But, IMO, list is still more intuitive than using icons. >> >>> >>> Similar to chromes omnibar that suggests addresses that are most >>> commonly used, this seems somehow more intuitive than a drop down >>> list. >>> >> >> So, users must type table's name in order to jump to a table? I think this is not convenient, since users may have table names with same prefix. > > Yea I think this was a bad example. What I meant is, those 3 Icons > (and saving the last sort order in a cookie) sorting the list, thus > having the list of tables/dbs just once (not in the list + partially > in the drop down list), feel more intuitive for me. And saves the user > a additional mouse click once the table is sorted to his liking. > The intention of providing recently used tables is to make users able to jump between tables (they used recently) in different databases. I don't think this can be achieved by sorting the main list, since: 1. Current navigation frame has two kind of views: light version (dbs list first, then if you click one db, it will display the tables list of that db) and complete version (all dbs + tables in one list). In the light version, it will displays only tables of one db (tables from other dbs are not shown). So, we can't jump between tables in different dbs. In the full version, list of tables are grouped by their dbs. Sorting will messed up the list. 2. The users will be confused by the "always changing" dbs/tables list. -- Aris Feryanto

4 8

[Phpmyadmin-devel] Status page
by Tyron Madlener 20 May '11

20 May '11

Originally I was thinking of putting each status section table into its own jQuery tab, but I realize that wouldn't really help with anything. When I think of typical use cases such as: - looking up a particular value - checking for error values (the ones which are currently marked red) ...it probably would be more useful to have all values in one table and offer some 'find as you type' feature. Meaning, you get a textbox where you can type the name, and when you e.g. type 'c', you get all values that contain a word that starts with 'c'. So these values for example would be shown: Innodb_pages_created, Threads_connected, Created_tmp_files And then I'd add one select list to filter by category and another to filter for bad values (the ones currently marked as red). If all values are loaded at the beginning, like it is now, the find-as-you-type feature would be without delay / really fast. Opinions/Ideas?

4 5