May 2012 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1493
by michal＠cihar.com 23 May '12

23 May '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1493/changes> Changes: [weblate] Translated using Weblate. [mcihar] Wrap some long lines [mcihar] Calcualte include path only once [mcihar] Calculate function name only once ------------------------------------------ Started by an SCM change Started by an SCM change Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@1494a05c Using strategy: Default Last Built Revision: Revision def75ac09f904b1f796dbdb1569b5825be8d0fd7 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision d54c77b613888f101cc680bb1f03cb8434194937 (origin/master) Checking out Revision d54c77b613888f101cc680bb1f03cb8434194937 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson3321461921807073330.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit: [exec] PHPUnit 3.6.10 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.dist> [exec] [exec] .......... [exec] Result: 139 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 13 exact clones with 549 duplicated lines in 8 files: [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-479 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:628-653 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Svg_Relation_Schema.class.php:391-407 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Svg_Relation_Schema.class.php:441-449 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-657 [exec] /libraries/schema/Svg_Relation_Schema.class.php:588-638 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-663 [exec] /libraries/schema/Visio_Relation_Schema.class.php:375-431 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:577-598 [exec] [exec] - /themes/original/css/common.css.php:1265-1286 [exec] /themes/original/css/common.css.php:1269-1290 [exec] [exec] - /themes/original/css/common.css.php:1209-1317 [exec] /themes/pmahomme/css/common.css.php:1583-1691 [exec] [exec] - /themes/original/css/common.css.php:1265-1460 [exec] /themes/pmahomme/css/pmd.css.php:47-242 [exec] [exec] 0.45% duplicated lines out of 122051 total lines of code. [exec] [exec] Time: 8 seconds, Memory: 101.25Mb [exec] Result: 1 phpcs: [exec] Time: 01:52, Memory: 57.00Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 323 [exec] [exec] Lines of Code (LOC): 122051 [exec] Cyclomatic Complexity / Lines of Code: 0.15 [exec] Comment Lines of Code (CLOC): 36398 [exec] Non-Comment Lines of Code (NCLOC): 85653 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 82 [exec] Abstract: 2 (2.44%) [exec] Concrete: 80 (97.56%) [exec] Average Class Length (NCLOC): 219 [exec] Methods: 778 [exec] Scope: [exec] Non-Static: 683 (87.79%) [exec] Static: 95 (12.21%) [exec] Visibility: [exec] Public: 634 (81.49%) [exec] Non-Public: 144 (18.51%) [exec] Average Method Length (NCLOC): 23 [exec] Cyclomatic Complexity / Number of Methods: 3.75 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 797 [exec] [exec] Constants: 121 [exec] Global constants: 105 [exec] Class constants: 16 BUILD SUCCESSFUL Total time: 2 minutes 9 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 7961 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1492 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 24 warnings. [DRY] Computing warning deltas based on reference build #1492 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 432 files to scan for tasks [TASKS] Found 188 open tasks. [TASKS] Computing warning deltas based on reference build #1492 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1492 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-05-23_14-33-22/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml'> for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 1

[Phpmyadmin-devel] Replacing Highcharts
by Marc Delisle 22 May '12

22 May '12

Hi, due to a licensing issue with Highcharts (which we started to use in 3.5.x), we have to think about replacing it with another library. Otherwise, distros like Debian won't accept 3.5. We'll need: 1. ideas for a replacement library (GPL) 2. volunteers to do the switch (I am volunteer) The goal is to do the replacement in 3.5.x, not 4.0. -- Marc Delisle http://infomarc.info

4 10

[Phpmyadmin-devel] GSoC Git repos
by Michal Čihař 21 May '12

21 May '12

Hi all (especially students) I've made some clarifications to GSoC student guide about git repositories [1]. To make it short: We want to merge your code as soon as possible. So try to keep your repository in good shape all the time and whenever you've completed some bigger part, just file a pull request on Github or tell your mentor to merge your changes. [1]:http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide#Publish_a_Git_rep… -- Michal Čihař | http://cihar.com | http://blog.cihar.com

1 0

[Phpmyadmin-devel] GSoC: github tree
by Alex Marin 21 May '12

21 May '12

Hello, I have a question regarding [1]. In our tree, should we only add our own commits regarding the GSoC project we are assigned? The problem I see here is that there are chances that the files we modify in our tree will also be modified in PMA/master, so merge conflicts will appear that will have to be solved at the final merge at the end of GSoC. And also, the local tree will be a little out of date. The alternative would be to merge [2] continuously to our tree and mix our commits with the ones from the PMA master branch, but then again if someone modifies a file you committed changes to, you have to locally solve conflicts or rebase your commit. Will the final merge be safe in this case? Or is there no such thing as a final merge, and our good commits will be merged to PMA/master periodically? I can imagine that would be more difficult in some cases where some functionalities can't be partially merged if they are more complex. [1] http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide#Publish_a_Git_reposi… [2] https://github.com/phpmyadmin/phpmyadmin/commits/master Thanks, Alex

2 1

[Phpmyadmin-devel] Duplicate code in CSS themes
by Michal Čihař 19 May '12

19 May '12

Hi all I think it is pretty obvious that all themes will share quite big load of CSS. Originally I though about extracting these bits to Theme class methods, but now I think it would make things even harder to maintain. What I feel would be better to create core CSS file, which would be always included and theme authors will just override/extend it. This way, we can make changes in core without breaking older themes too much - maybe some things will not look 100% intergrated, but at least the layout won't be broken. Currently original and pmahomme themes share about 2500 lines, they differ in 1000/500 (pmahomme/original) lines. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 6

[Phpmyadmin-devel] Table zoom search option is broken
by Atul Pratap Singh 16 May '12

16 May '12

Hi Madhura, The Table zoom search option is broken after function name fixes done in the commit 60f84a045ec53be94c4cb837d8f70ad210990f7a. Please fix the function names in tbl_zoom_select.php (line 178). Regards -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.

2 1

[Phpmyadmin-devel] refactoring insert/edit: BLOB upload
by Marc Delisle 15 May '12

15 May '12

Thilina, I made an insert test with a table that contains a BLOB; the maximum size for the upload is not displayed. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Naming convention standard for methods
by Chanaka Dharmarathna 13 May '12

13 May '12

Hi All, While I'm refactoring some files relating to display query results (currently display_tbl.lib.php, common.lib.php), I can method names are used regardless of the inside functionality. Ex :- "PMA_displayHtmlRadio" in common.lib.php method return a string of HTML content. But the name tells the function displays HTML itself. As I feel these things should be modified. As library files, they never should render HTML inside the functions themselves. Better thing is to return a string of PHP having the HTML content. So my suggestion is to use the phrase "get" for the every method which return any data type. So that developer can understand it returns something just looking at the name. Following are some suggested names. (Some of them are already discussed in this mailing list) Ex: PMA_displayHtmlRadio -> PMA_getRadioFields PMA_generateSliderEffect -> PMA_getDivForSliderEffect PMA_generateHtmlDropdown -> PMA_getDropdown PMA_displayTableNavigationButton -> getTableNavigationButton (All above functions return strings) Hope to join a discussion on this. Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

2 4

[Phpmyadmin-devel] Duplicate CSS print files?
by Rouslan Placella 12 May '12

12 May '12

Hi all, Just a quick question about the printing-related CSS files that we have in the code base. We have "print.css" which is globally included and then we also have a "theme_print.css.php" file in each theme. So couldn't we just drop the latter? Or am I missing something? Bye, Rouslan

4 4

[Phpmyadmin-devel] Can't log in to pma?
by Tyron Madlener 12 May '12

12 May '12

After a update on my server I can't seem to log in to phpMyAdmin. Whatever user or pass I type in, it just reloads the page without showing any errors. It seems as if the session is not being saved, because I can see a new token being generated every time. Anyone had a similar problem like this?

2 2