Hi,
due to a licensing issue with Highcharts (which we started to use in
3.5.x), we have to think about replacing it with another library.
Otherwise, distros like Debian won't accept 3.5.
We'll need:
1. ideas for a replacement library (GPL)
2. volunteers to do the switch (I am volunteer)
The goal is to do the replacement in 3.5.x, not 4.0.
--
Marc Delisle
http://infomarc.info
Hi all (especially students)
I've made some clarifications to GSoC student guide about git
repositories [1].
To make it short: We want to merge your code as soon as possible.
So try to keep your repository in good shape all the time and whenever
you've completed some bigger part, just file a pull request on Github
or tell your mentor to merge your changes.
[1]:http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide#Publish_a_Git_rep…
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
Hello,
I have a question regarding [1]. In our tree, should we only add
our own commits regarding the GSoC project we are assigned?
The problem I see here is that there are chances that the files
we modify in our tree will also be modified in PMA/master,
so merge conflicts will appear that will have to be solved at
the final merge at the end of GSoC. And also, the local tree
will be a little out of date.
The alternative would be to merge [2] continuously to our tree
and mix our commits with the ones from the PMA master branch,
but then again if someone modifies a file you committed changes
to, you have to locally solve conflicts or rebase your commit.
Will the final merge be safe in this case?
Or is there no such thing as a final merge, and our good commits
will be merged to PMA/master periodically? I can imagine that
would be more difficult in some cases where some functionalities
can't be partially merged if they are more complex.
[1] http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide#Publish_a_Git_reposi…
[2] https://github.com/phpmyadmin/phpmyadmin/commits/master
Thanks,
Alex
Hi all
I think it is pretty obvious that all themes will share quite big load
of CSS. Originally I though about extracting these bits to Theme class
methods, but now I think it would make things even harder to maintain.
What I feel would be better to create core CSS file, which would be
always included and theme authors will just override/extend it.
This way, we can make changes in core without breaking older themes too
much - maybe some things will not look 100% intergrated, but at least
the layout won't be broken.
Currently original and pmahomme themes share about 2500 lines, they
differ in 1000/500 (pmahomme/original) lines.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi Madhura,
The Table zoom search option is broken after function name fixes done in
the commit 60f84a045ec53be94c4cb837d8f70ad210990f7a.
Please fix the function names in tbl_zoom_select.php (line 178).
Regards
--
Atul Pratap Singh
Senior Undergraduate Student
Institute Of Technology,
Banaras Hindu University, Varanasi,
India.
Thilina,
I made an insert test with a table that contains a BLOB; the maximum
size for the upload is not displayed.
--
Marc Delisle
http://infomarc.info
Hi All,
While I'm refactoring some files relating to display query results
(currently display_tbl.lib.php, common.lib.php), I can method names are
used regardless of the inside functionality.
Ex :- "PMA_displayHtmlRadio" in common.lib.php method return a string of
HTML content.
But the name tells the function displays HTML itself.
As I feel these things should be modified.
As library files, they never should render HTML inside the functions
themselves.
Better thing is to return a string of PHP having the HTML content.
So my suggestion is to use the phrase "get" for the every method which
return any data type.
So that developer can understand it returns something just looking at the
name.
Following are some suggested names. (Some of them are already discussed in
this mailing list)
Ex:
PMA_displayHtmlRadio -> PMA_getRadioFields
PMA_generateSliderEffect -> PMA_getDivForSliderEffect
PMA_generateHtmlDropdown -> PMA_getDropdown
PMA_displayTableNavigationButton -> getTableNavigationButton
(All above functions return strings)
Hope to join a discussion on this.
Regards !
--
____________________________________
Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________
Hi all,
Just a quick question about the printing-related CSS files that we have
in the code base. We have "print.css" which is globally included and
then we also have a "theme_print.css.php" file in each theme. So
couldn't we just drop the latter? Or am I missing something?
Bye,
Rouslan
After a update on my server I can't seem to log in to phpMyAdmin. Whatever
user or pass I type in, it just reloads the page without showing any errors.
It seems as if the session is not being saved, because I can see a new
token being generated every time. Anyone had a similar problem like this?