May 2012 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Refactoring tbl_zoom_select.php
by Atul Pratap Singh 11 Jun '12

11 Jun '12

Hi Marc, While looking at "tbl_zoom_select.php":- Line 191-201 if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] != 'pma_null')) { $flag = 2; for ($i = 0 ; $i < 4 ; $i++) { if ($inputs[$i] != 'pma_null') { $key = array_search($inputs[$i], $fields_list); $tbl_fields_type[$i] = $fields_type[$key]; $tbl_fields_collation[$i] = $fields_collation[$key]; $tbl_fields_null[$i] = $fields_null[$key]; } } } As the condition would be true in cases when post param $inputs is set and has index 0 or 1 set to some column name. It would mostly happen if a half or full filled search form is submitted, but there seems to be no further use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type gets used afterwards with indexes >= 4. I think as a result after the zoom plot is displayed, clicking at "show search criteria" doesn't show any previously filled criteria. I also didn't understand the use of $flag variable. Thanks -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.

2 13

[Phpmyadmin-devel] LAMP appliance with phpmyadmin
by Jordi Massaguer Pla 30 May '12

30 May '12

Dear phpmyadmin developers, I've created a LAMP software appliance with SUSEStudio that includes phpmyadmin as well as webalizer for apache statistics and webyast for managing the appliance itself. Moreover this appliance contains the most popular php extensions including xcache and memcached for performance and xdebug for debugging. It would be really great to get some feedback from you as I would like to use this appliance as a base for other php appliances (i.e. drupal, joomla, wordpress, moodle, ...) Feel free to try it online at: http://susestudio.com/a/61bKK8/lamp-server-32bit Just press the "Testdrive" and you'll be able to try it on your browser. Click on "Enable networking" and you'll see the instructions for accessing phpmyadmin. You do not have to download it to test it, but if you like, you can download it as USB, liveCD, preload iso, ovf, vmware, Hyper-V or Xen images, or even start it on amazon. You can see some screenshots at http://jordimassaguerpla.blogspot.com.es/2012/05/lamp-appliance-phpmyadmin.… Thanks in advance, Looking forward to your answer, Jordi Massaguer Pla

2 2

[Phpmyadmin-devel] GSOC Removal of Frames
by Dieter Adriaenssens 30 May '12

30 May '12

Hi Rouslan, I had a look at your latest commits in your github branch and made some small comments to the code on github. When reviewing your code during the weekend I came along a static function doing something that is now handled by your new class, but when going over your seperate commits to write the comments I didn't find that occurence again, so I can't tell you the name of the function. But it seems it's now obsolete, or at least deprecated. I'll let you know when I find it again. Anyway, will you be using your frames-removal branch during GSoc, or are there other branch I should track? -- Kind regards, Dieter Adriaenssens

2 1

[Phpmyadmin-devel] problem adding a column
by Marc Delisle 29 May '12

29 May '12

Hi, after: commit 292f83e382b219c49004d7e19761696c6658d7ca Author: Madhura Jayaratne <madhura.cj(a)gmail.com> Date: Thu May 10 00:31:15 2012 +0530 Coding style improvements ---------- I get this when adding a column: Notice in ./libraries/tbl_properties.inc.php#647 Undefined index: Field Backtrace ./tbl_addfield.php#231: include_once(./libraries/tbl_properties.inc.php) Notice in ./libraries/tbl_properties.inc.php#647 Undefined index: Backtrace ./tbl_addfield.php#231: include_once(./libraries/tbl_properties.inc.php) -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] Coding style update
by Michal Čihař 29 May '12

29 May '12

Hi all though phpcs with PMAStandard does already cover this, it seems to be necessary to mention it explicitely: Please don't wrap translatable strings to fit into 85 chars width limits. It just causes further troubles (the strings are translated with newlines and indentation what looks weird). The PMAStandard should ignore such lines from checking for line length (if it does not please tell me, it's a bug in the rules). -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 4

[Phpmyadmin-devel] Git commits
by Michal Čihař 29 May '12

29 May '12

Hi as I've noticed that some of GSoC students do quite huge commits, I'd like to mention, that creating big commits is always bad :-). Try to commit small functional blocks as soon as you have finished, this way you can benefit from version control as well (it's easier to find what is wrong in few lines diff than in something what spans over few pages). -- Michal Čihař | http://cihar.com | http://blog.cihar.com

1 0

[Phpmyadmin-devel] Automated Testing - GSoC 2012
by yasitha pandithawatta 29 May '12

29 May '12

Hi Michal, I had my semester exams for last two weeks. Today onward I can give priority to my GSoC project. I'll start writing the test cases for mail libraries. Any re-factored classes committed to the master branch? If so I can straight away start writing the test cases for those classes. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka

3 7

[Phpmyadmin-devel] Refactoring: Displaying query results
by Chanaka Dharmarathna 25 May '12

25 May '12

Hi Michal, I'm identifying the refactoring points in 'display_tbl.lib.php' file. I am trying to break the tasks on following areas. * As a library file this should not render the HTML codes in functions it selves. First, all the HTML content in functions stored in string and render at the bottom of the function. Next, return the string having the HTML content, instead of rendering it inside the function itself and, from the calling end render that content. Probably method names will be modified with adding 'get' phrase. * Some naming conventions are used incorrectly. For method name in lib file, naming convention is used generally used as 'PMA_methodName'. But some are not following this. While correcting them, suggested conventions in my proposal [0] is going to applied. * There are several functions having more than 200 lines. I'm intending to divide those functions to smaller ones. (PMA_displayTableNavigation(), PMA_displayTableHeaders(), PMA_displayTableBody(), PMA_displayVerticalTable(), PMA_displayTable()) I am looking for your suggestions to identify more important points and modifications on suggested points. So that I can do more research by digging code more. As well, I'm using NetBeans IDE with PHP support, meld tool, Mozilla Firefox with Firebug, command line git client in Linux environment. Are there any other special tools which are more useful ? [0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka7… Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

5 53

[Phpmyadmin-devel] GSoC: Refactoring Table search, Db search, Multi-table query
by Atul Pratap Singh 25 May '12

25 May '12

Hi Marc, Now that my exams are finished :), I have started to look at the script "tbl_select.php" for planning the refactoring. As the script is used for searching a table using a form in the UI, it contains two sections:- 1. If block that "displays the selection form". 2. else to do the search work. Looking at the search form display part, it is done using raw HTML-PHP mix with calls to functions from some library files, so first main concern should be to handle the HTML-PHP mix and convert the code into functions. About that I saw the wiki page for Roadmap to 4.0 [0] :- "The current <html> and <?php> mix will be cleaned up in the process. The <html> output will be moved to lib/include files which can be called by either the index page or by the specific files (which can still be referenced separately)." So, to move HTML to lib/include files, slicing proper reusable HTML blocks from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the way, I should proceed ? [0] http://wiki.phpmyadmin.net/pma/FOSDEM_2012_Meeting Regards -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.

2 11

[Phpmyadmin-devel] Refactoring insert-edit
by Thilina Buddika Abeyrathna 23 May '12

23 May '12

Hi Marc, when I'm writing functions for columns of insertForm I need to pass all the following parameters to the functions. $field, $backup_field, $field_name_appendix, $unnullify_trigger, $tabindex, $tabindex_for_value, $idindex, $data So function signature is very long which is somewhat ugly, Is it ok to have a global parameter array for insert_edit.lib.php file. Does this break the refactoring? -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.

4 31