May 2012 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] refactoring and superglobals
by Marc Delisle 11 May '12

11 May '12

Hi, We previously had a script called grab_globals.lib.php, which created global variables from a few superglobals arrays. When this script was removed a few weeks ago, we added at the beginning of other scripts some code, for example in tbl_change.php: if (isset($_REQUEST['where_clause'])) { $where_clause = $_REQUEST['where_clause']; } In the upcoming refactoring efforts, we should avoid this, because, looking at the code further in the script, it's difficult to see the origin of $where_clause. So, we should only refer to $_REQUEST['where_clause'] (except in the situations where the global is modified afterwards). Another benefit is that this variable would not need to be passed as a parameter to functions. -- Marc Delisle http://infomarc.info

3 4

[Phpmyadmin-devel] Configurations for phpMyAdmin Demo Server project
by Chanaka Dharmarathna 10 May '12

10 May '12

Hi, I'm working on "Refactoring: Displaying query results" [0] project idea under GSoC 2012. In my demo server project [1] the configurations for extended features like "Creation of PDFs", "Browser transformation", "Bookmarked SQL query" etc are already done *without "User preferences".* As well a new user "pma" is already created there, but with a different password instead of general "pmapass". In my local machine I just enable these all extended features and "error displaying" by introducing "config.inc.php" file. And set the control user (pma) password to general one (pmapass). If I commit this configuration file, the demo server project configurations will be override. ("error displaying" , "User preferences", "control user password" will change) So is it a good idea to commit these changes ? Your suggestions are welcome. [0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka7… [1] : http://demo.phpmyadmin.net/gsoc-chanaka/ Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

3 6

[Phpmyadmin-devel] refactoring tbl_change.php
by Marc Delisle 09 May '12

09 May '12

Thilina, please move all your functions from tbl_change.php to libraries/insert_edit.lib.php. I suspect that other functions from refactoring tbl_replace.php and tbl_replace_fields.inc.php will go there as well. -- Marc Delisle http://infomarc.info

3 4

[Phpmyadmin-devel] refactoring insert/edit
by Marc Delisle 09 May '12

09 May '12

Thilina, with commit 1d7f48b966c66b06f9a9ef6e5c78178d645d4bdf I still see this problem: 1. Browse a table 2. Click the checkbox for two rows 3. At the botton, click the With selected...change link -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1422
by michal＠cihar.com 08 May '12

08 May '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1422/changes> Changes: [rouslan] Return strings from functions, instead of using 'echo()' [rouslan] Drop output buffering from PMA_showMessage() [rouslan] Fixed test cases ------------------------------------------ Started by an SCM change Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@17586ed7 Using strategy: Default Last Built Revision: Revision 46ae483553bf1c76821c623e847ec9b33a313bf1 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision c2233effad7b010fb00317d99256fb24822f995b (origin/master) Checking out Revision c2233effad7b010fb00317d99256fb24822f995b (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson5048249461980676629.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit: [exec] PHP Parse error: syntax error, unexpected '}' in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/common…> on line 26 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:139 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:671 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:776 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:848 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:419 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:358 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:79 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 14 exact clones with 1037 duplicated lines in 7 files: [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-479 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:628-653 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Svg_Relation_Schema.class.php:391-407 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Svg_Relation_Schema.class.php:441-449 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-657 [exec] /libraries/schema/Svg_Relation_Schema.class.php:588-638 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-663 [exec] /libraries/schema/Visio_Relation_Schema.class.php:375-431 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:577-598 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1282 [exec] /themes/original/css/theme_right.css.php:1265-1286 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1691 [exec] /themes/original/css/theme_right.css.php:2393-2823 [exec] [exec] - /themes/original/css/theme_right.css.php:1205-1313 [exec] /themes/pmahomme/css/theme_right.css.php:1584-1692 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1514 [exec] /themes/pmahomme/css/theme_right.css.php:3097-3350 [exec] [exec] 0.86% duplicated lines out of 121160 total lines of code. [exec] [exec] Time: 30 seconds, Memory: 101.00Mb [exec] Result: 1 phpcs: [exec] Time: 01:40, Memory: 57.00Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 321 [exec] [exec] Lines of Code (LOC): 121160 [exec] Cyclomatic Complexity / Lines of Code: 0.15 [exec] Comment Lines of Code (CLOC): 35717 [exec] Non-Comment Lines of Code (NCLOC): 85443 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 82 [exec] Abstract: 2 (2.44%) [exec] Concrete: 80 (97.56%) [exec] Average Class Length (NCLOC): 216 [exec] Methods: 779 [exec] Scope: [exec] Non-Static: 684 (87.80%) [exec] Static: 95 (12.20%) [exec] Visibility: [exec] Public: 638 (81.90%) [exec] Non-Public: 141 (18.10%) [exec] Average Method Length (NCLOC): 22 [exec] Cyclomatic Complexity / Number of Methods: 3.74 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 762 [exec] [exec] Constants: 124 [exec] Global constants: 109 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 20 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 8667 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1421 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 26 warnings. [DRY] Computing warning deltas based on reference build #1421 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 429 files to scan for tasks [TASKS] Found 203 open tasks. [TASKS] Computing warning deltas based on reference build #1421 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1421 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-05-08_18-10-55/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 0

[Phpmyadmin-devel] GSoC: refactoring Insert/Edit
by Marc Delisle 07 May '12

07 May '12

Hi Thilina, I have written some comments for your commit [0], you should have received an email about these. Please confirm that you got it, so I can assume that it's a good way to communicate. [0] https://github.com/thilinaa/phpmyadmin/commit/a86ca38f925a39847348fcb794974… -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] duplicate line in libraries/import/shp.php
by Dieter Adriaenssens 06 May '12

06 May '12

Hi Madhura, In a file you introduced (libraries/import/shp.php), on line 166, the same method with similar parameters is called as the line above : function _loadHeaders() { $this->recordNumber = loadData("N", readFromBuffer(4)); //We read the length of the record $tmp = loadData("N", readFromBuffer(4)); $this->shapeType = loadData("V", readFromBuffer(4)); } nothing happens with the $tmp afterwards, so I'm wondering if this duplicate method call can be removed? Or is there a reason for calling this method twice? -- Kind regards, Dieter Adriaenssens

2 1

[Phpmyadmin-devel] Gsoc 2012 - Refactoring Insert/edit, Operations, Privilege and Structure sections in phpMyAdmin
by Thilina Buddika Abeyrathna 05 May '12

05 May '12

Hi Marc, I'm trying to start refactoring for Insert/edit section. There are main three scripts to refactor. But before that, I need your suggestion to start coding. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.

2 12

[Phpmyadmin-devel] about the "\n"
by Marc Delisle 04 May '12

04 May '12

Hi, When touching a piece of code, if you see a "\n" generated for HTML, it's pretty much safe to remove it (if proven otherwise, we'll build a wiki page documenting those cases). The reason was to generate more readable HTML code; now that we (hopefully) use Firebug to look at the generated HTML, these "\n" are no longer needed. -- Marc Delisle http://infomarc.info

4 16

[Phpmyadmin-devel] Tracking Availability per User basis
by Dimitrakakis Georgios 03 May '12

03 May '12

Hello! Could someone help me with the implementation of the following (taken from users-list) ? Regards, G. >> >> >>> Le 2012-05-02 20:12, Dimitrakakis Georgios a écrit : >>>> Hello all! >>>> >>>> I am a relatively new user of PMA and this is my first post to this >>>> list so please excuse my ignorance. I am looking to config PMA to not >>>> show "Tracking" depending on which user has been logged in. I will try >>>> to describe what I want to do. I want when a "super"user logs in to >>>> have the ability to enable/disable tracking and all the other >>>> functions. But when a "standard" user logs in to not be able to do >>>> anything! Even better to hide completely the tracking option for him. >>>> Is something like this possible? Could someone give me a hand? >>>> >>>> Best, >>>> >>>> G. >>> >>> Hi, >>> I don't believe that this is configurable with the current version. Of >>> course, the super-user could use another instance of phpMyAdmin, >>> configured differently. >>> >>> Otherwise, you have to change the source code to implement this feature. >>> >>> -- >>> Marc Delisle >>> http://infomarc.info >>> >>> >> >> >> Hi Marc so you mean that I could have two instances of PMA under the >> same path or should I have to put the second one somewhere else? Any >> ideas (or even better links) on how to do this? >> >> On the other hand, I would be very interested in implementing this >> feature in the source code but I would like some guidance where to >> start looking. >> >> Best, >> >> G. >> >> ---------------------------------------------------------------- >> This message was sent using IMP, the Internet Messaging Program. ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.

1 0