Developers May 2014

developers@phpmyadmin.net

18 participants
60 discussions

[Phpmyadmin-devel] Initialize or Not
by Chanaka Dharmarathna 18 May '14

18 May '14

Hi All, I'm just exploring the issues raised by scrutinizer. It raise issues like, variable is not initialized. Have a look at issue [0], complaining on code segment [1]. Personally I like to initialize variables, before using it, even a value is assigning at some point of the execution path. In this case we can initialized it like $x=array('foo'); As I remember Marc mentioned different thought on this kind of situation (at the LinuxTag booth). You may have good thoughts we should know. So what we should do for this kind of issue ? Just ignore them since PHP does not force, or fix them ? Appreciate your thoughts. [0] : http://goo.gl/HNW8Be [1] : http://goo.gl/vUj25O Regards ! -- Chanaka Dharmarathna *http://chanakaindrajith.blogspot.com/*<http://chanakaindrajith.blogspot.com/>

4 5

[Phpmyadmin-devel] RFE #982 : Support for editing binary fields in hexadecimal
by Chirayu Chiripal 17 May '14

17 May '14

Hi, Does this feature mean editing binary and blob fields should be done in hexadecimals always? And, even when table is browsed they should be shown in hexadecimal only? If yes, then there is no need for this $cfg['DisplayBinaryAsHex']? And for $cfg['ProtectBinary'], IMHO it should not be removed so that users have and option to disable editing of binary fields to avoid accidental changes to data (even though they can be edited in hexadecimal form). Also, BLOB data can be very large and if we remove this config. var. then whenever someone will try to edit row then every time that BLOB field data will be displayed (which can be very very large) will have performance issue as well as it can annoy the user. Feature Request Link : https://sourceforge.net/p/phpmyadmin/feature-requests/982/ -- Regards, Chirayu Chiripal phpMyAdmin Intern - Google Summer of Code 2014 https://chirayuchiripal.wordpress.com/

2 3

[Phpmyadmin-devel] Suggestions on Work of Week-1 | php Error Reporting Project
by Dhananjay Nakrani 16 May '14

16 May '14

Hi Everyone, This week I started developments on my project. I want to take community's opinion on work I've done so far. Look at the commits [0] & [1]. Currently `common.inc.php` does all error handling initializations. All the run time php errors are already being collected in an object of ` PMA_Error_Handler` pointed globally by `$GLOBALS['error_handler']`. Now, to report all errors I have created a separate script named 'common_error_reporting.inc.php' which is intended to be included at the end of all "*relevant*" scripts. Currently it dumps all collected errors in a local-temporary file named "pma_error_log.txt" (which will be removed in next week's work). To demonstrate the working of ` common_error_reporting.inc.php`, I've included that script at the end of ` index.php`. Please have a look at it at [0] & [1]. Is there any better way of doing the same? Please point out if I can improve it any further. If there are no changes required in it then I would do the same for all "*relevant*" scripts. Another doubt I have is about the relevance of scripts. Which scripts should be consider as relevant here?? I am thinking of considering all scripts that are directly called by user/browser. I think error reporting script does not need to be included at the end of class files and such other library files. In my opinion, the error reporting script should be included at the end of all scripts in project root directory and not in any files inside `/libraries/` directory. Am I correct on this? I also found that PMA triggers errors manually (using trigger_error()) for all the missing extensions and to raise other such user warnings. These warnings are also currently collected by error handler. Do we need to report them?? Or should the errors of E_USER_WARNING type just be ignored while sending reports? Please provide your valuable suggestions and do correct me if I am wrong anywhere. If possible do it at the earliest so that I can incorporate them at an early stage. [0]: https://github.com/dhananjay92/phpmyadmin/commit/7bdad8efe33bed52d25e13ca1c… [1]: https://github.com/dhananjay92/phpmyadmin/commit/b137255bb617f7f00ac4b734d8… Thanks, Dhananjay Nakrani.

2 3

[Phpmyadmin-devel] Travis help, maybe
by Isaac Bennetch 16 May '14

16 May '14

Hi, looking at [1], the Travis build failed in some cases, but it looks to me as if it's just one of the strange Travis failures we have (specifically the line "Server error occurred. status: 504 Gateway Time-out" seems to me a testing server problem rather than a failing test). Would someone with a better understanding of the test suite mind confirming my understanding? 1 - https://github.com/phpmyadmin/phpmyadmin/pull/1183

3 2

Re: [Phpmyadmin-devel] [Phpmyadmin-team] Long list of notes from meeting with people
by Atul Pratap Singh 16 May '14

16 May '14

On 5/10/14, Isaac Bennetch <bennetch(a)gmail.com> wrote: > Hello, > > 6) The resulting data in the Monitor view (after selecting a region/time > to focus on) is displayed in a table-like format but is not sortable. > J.M. suggests that it should be. > I just checked on QA_4_2 and clicking on any column name area does sort the table. But, yes the up and down arrows to provide sorting hint are absent. -- Atul Pratap Singh http://blog.atulsisodia.in/

1 0

[Phpmyadmin-devel] Long list of notes from meeting with people
by Isaac Bennetch 16 May '14

16 May '14

Hello, These are some items that came up today from talking with users. I thought some of these points deserve further discussion before opening a feature request or bug report. What do you think of these? 1) User suggestion that we add a link to the Export page to "Save this as default for export preferences". This would probably tie in to the User Preference module somehow since some of these preferences are already set there (or in config.inc.php). ~~This might be nice if it can be done without making things overly complex. 2) User suggestion that we have an SQL formatter. This would be a way to take a long string of SQL and have it pretty-printed without actually running the query. ~~There exist other tools to do this (plus we do it if a query is run) and I don't really see a need to incorporate that functionality here. 3) The same user told us that he does not like the blue row highlight when mousing over a row while browsing. "I already know where my mouse is, I don't need the blue highlight to show me," he said. So we should discuss whether this should be continued or removed. ~~This is configurable already, so he just has to edit his config.inc.php or User Preferences to enable/disable it. 4) The same user again stated that he does not care for the underline style for showing a column with a key (in the Structure tab). The suggestion is to instead put a small key icon in front or behind the name of the column to indicate that it's a key. 5) J.M. suggests that we allow a calendar/time picker in the Monitor window. Once you drag to highlight an area on the chart, a dialog pops up displaying the start and end time plus two checkboxes for picking details about what to display. Those date/time fields do not currently have the date/time picker widget. 6) The resulting data in the Monitor view (after selecting a region/time to focus on) is displayed in a table-like format but is not sortable. J.M. suggests that it should be. 7) Again in the Monitor view, after selecting some amount of time and displaying the logs, a dialog appears saying "Loading logs. Log data loaded. Queries executed in this time span: Select: 10 Total: 10" J.M. said this scrolls and should not scroll. 8) Again thanks to J.M., when in Browse mode and viewing table data, you can apply multiple sort options. The only way to remove a column from the sort is to shift-click it. J.M. suggests that we should have a way to quickly remove all sorting, so that if a user sorts by for instance first name, last name, and actor_id that we can allow them to quickly clear all three sort options in one click. That's all for now. Thank you for your thoughts. ~isaac

5 5

Re: [Phpmyadmin-devel] [Phpmyadmin-team] Long list of notes from meeting with people
by Atul Pratap Singh 16 May '14

16 May '14

On 5/15/14, Atul Pratap Singh <atulpratapsingh05(a)gmail.com> wrote: > On 5/10/14, Isaac Bennetch <bennetch(a)gmail.com> wrote: >> Hello, >> >> I thought some of these points deserve further discussion before opening >> a feature request or bug report. What do you think of these? >> >> 1) User suggestion that we add a link to the Export page to "Save this >> as default for export preferences". This would probably tie in to the >> User Preference module somehow since some of these preferences are >> already set there (or in config.inc.php). >> >> This might be nice if it can be done without making things overly >> complex. >> >> 2) User suggestion that we have an SQL formatter. This would be a way to >> take a long string of SQL and have it pretty-printed without actually >> running the query. >> >> There exist other tools to do this (plus we do it if a query is run) and >> I don't really see a need to incorporate that functionality here. >> >> 3) The same user told us that he does not like the blue row highlight >> when mousing over a row while browsing. "I already know where my mouse >> is, I don't need the blue highlight to show me," he said. So we should >> discuss whether this should be continued or removed. >> >> 4) The same user again stated that he does not care for the underline >> style for showing a column with a key (in the Structure tab). The >> suggestion is to instead put a small key icon in front or behind the >> name of the column to indicate that it's a key. >> >> 5) J.M. suggests that we allow a calendar/time picker in the Monitor >> window. Once you drag to highlight an area on the chart, a dialog pops >> up displaying the start and end time plus two checkboxes for picking >> details about what to display. Those date/time fields do not currently >> have the date/time picker widget. >> Added in https://github.com/phpmyadmin/phpmyadmin/commit/1a3c958f394e1aa214321b3f4a8… -- Atul Pratap Singh http://blog.atulsisodia.in/

1 0

[Phpmyadmin-devel] phpMyAdmin 4.2.1 is released
by Marc Delisle 14 May '14

14 May '14

Welcome to phpMyAdmin 4.2.1, a bugfix release. Details will appear on http://phpmyadmin.net. You can also visit https://sourceforge.net/projects/phpmyadmin/files to download. The phpMyAdmin team

1 0

[Phpmyadmin-devel] RFE #1487 "Browse foreign values" should be a modal dialog
by Chirayu Chiripal 12 May '14

12 May '14

Hi, I have few doubts about this feature. Should it open dialog when clicked on link shown in : 1) 1.png (i.e. some foreign value) or 2) 2.png (i.e. when clicked on "Browse foreign values") or 3) Both of them. -- Regards, Chirayu Chiripal phpMyAdmin Intern - Google Summer of Code 2014 https://chirayuchiripal.wordpress.com/

1 0

[Phpmyadmin-devel] Yet another automated checker
by Michal Čihař 11 May '14

11 May '14

Hi all I've just enabled another automated checker tool on our repository - scrutinizer-ci.com The checks might need some tuning, but the nice thing is that it comments on pull requests and says changes caused by it. I believe this can further improve our patch review process. You can see current results here: https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/ https://scrutinizer-ci.com/g/phpmyadmin/error-reporting-server/ -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers May 2014