May 2014 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] about a message for central columns
by Marc Delisle 28 May '14

28 May '14

Hi Smita, about this message: "Add unique columns to central list", could you clarify the meaning? Is this about adding all columns on which there is a unique index, to the central list? -- Marc Delisle (phpMyAdmin)

2 5

[Phpmyadmin-devel] Scrutinizer's false alarms
by Marc Delisle 28 May '14

28 May '14

Hi, I found out that some bug reports by Scrutinizer are wrong. For example, in [0], the PHP Analyzer reports that you cannot assign a return value because mysqli_init() always returns null, which is not the case. [0] https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libr… -- Marc Delisle (phpMyAdmin)

4 3

[Phpmyadmin-devel] Separate page to manage central list of columns
by Smita 27 May '14

27 May '14

Hi I think we need to make a separate page as well to manage the central columns list. Where user will be able to view the complete list of columns and add/remove/edit some if needed. I have few question regarding the same: 1. Do We really need a separate page ? or add/remove options on db_structure and tbl_structure page is sufficient? but no edit option we'll have in this case. 2. How the page should look ? Similar to tbl_structure page with option to edit and remove a column from the list ? but this can be very long as one database in total may have lots many columns. introduce pagination ? Please share if any other idea ? Thanks and Regards - Smita

2 1

[Phpmyadmin-devel] about the central columns table
by Marc Delisle 25 May '14

25 May '14

Hi Smita, I have a doubt, looking at the structure you chose for this table: db_name column_list This structure implies that, for any change, you have to load a potentially big row, decode it and encode it. Imagine that there are hundreds or thousands of column definitions for this db. I suggest something like: db_name column_name column_attributes -- Marc Delisle | phpMyAdmin

2 8

Re: [Phpmyadmin-devel] Drag and drop sql import
by Minhaz A V 24 May '14

24 May '14

Hi I need some help here, to implement a drag and drop I need to do some UI tweak, like there need to be a <div> to be shown in case of dragover event, and we need another to show the upload status! Also I need help with design here: How I'm planning it is: 1. User drops a file at any page! (logged in) 2. the dropped files if (sql) are uploaded asynchronously and the status of upload is shown somewhere in bottom right corner. 3. At the backend the uploaded sql is parsed and output is sent back as JSON and once the object has been received, the pagecontent is replaced with the received output! (as happens for any other request in PMA) I need help with which file I might need to edit, to add a div to the common UI! for js part I'll add codes to AJAX.js Also I sent few attachments to the same thread, but I guess moderator needs to allow it first. It had screenshots of UI I was planning! Minhaz, minhaz.cistoner.org || cistoner.org

1 0

[Phpmyadmin-devel] Regarding RFE: #706
by Ashutosh Dhundhara 24 May '14

24 May '14

Hi, I was looking into RFE: #706. I have attached an image showing a rough idea about its implementation in which we can select multiple databases from the select list. Please comment. Also I wanted to know if we need this text field next to database select box, after this feature? Regards, Ashutosh Dhundhara

2 1

[Phpmyadmin-devel] adding an icon
by Marc Delisle 24 May '14

24 May '14

Hi developers and especially GSoC students, if you add an icon, have a look at [0] to learn how to regenerate the sprites. [0] https://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage -- Marc Delisle (phpMyAdmin)

4 5

[Phpmyadmin-devel] central columns list and synching
by Marc Delisle 23 May '14

23 May '14

Hi Smita, I was under the impression that the central list of columns would be authoritative, regarding the column attributes. Currently, it seems that the table itself has priority. For example, if a column is described in the central list as being VARCHAR(40), and the same column name exists in a table, but with VARCHAR(45), I would expect a sync operation to adjust the column's size to the "official" 40. On the contrary, the central list is modified when doing the sync. Or, am I mistaken with the goal of the sync feature? -- Marc Delisle (phpMyAdmin)

2 4

[Phpmyadmin-devel] Drag and drop sql import
by Minhaz A V 22 May '14

22 May '14

Hi, A random idea came to my mind, I don't know if its applicable or not, I thought I'd send it in mailing list before sending a feature request! *Its an improvement to the import feature that exists currently: * If a user drags and drop a *.sql* file to the pma interface (anywhere) the interface should import it and execute it. There should not be a condition that user drops it to import page only. In case db is not selected, we can show a custom error, otherwise, upload the file asynchronously and execute the query just like it happens when import is done. I can't think of a false positive here, as if this feature is implemented no user is going to accidently drop a sql file into the page! I'd like to know your opinions about this. Minhaz, minhaz.cistoner.org || cistoner.org

2 3

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-4.2 #70
by Jenkins Daemon 21 May '14

21 May '14

See <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/70/changes> Changes: [phpMyAdmin] Code style fixes [phpMyAdmin] Comment that missing break statement is intended [phpMyAdmin] Rename OptionsPropertyOneItem::$_force overwritten from parent [phpMyAdmin] Extrace query cache total blocks value correctly [phpMyAdmin] Add missing break in # comment detection switch ------------------------------------------ Started by GitHub push by ZweiSteinSoft [EnvInject] - Loading node environment variables. Building in workspace <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/> > git rev-parse --is-inside-work-tree Fetching changes from the remote Git repository > git config remote.origin.url git://github.com/phpmyadmin/phpmyadmin.git Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git > git --version > git fetch --tags --progress git://github.com/phpmyadmin/phpmyadmin.git +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/QA_4_2^{commit} Checking out Revision 5facff36bd4e4215072aac4abbd163f0159120d5 (origin/QA_4_2) > git config core.sparsecheckout > git checkout -f 5facff36bd4e4215072aac4abbd163f0159120d5 > git rev-list 5ddd0c1990ebd54722fb95c156866d0ef25eccfc [workspace] $ /bin/sh -xe /tmp/hudson6087488846137958422.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit pdepend phpmd phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build.xml> clean: [delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/api> [delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/code-browser> [delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/coverage> [delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/logs> [delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/pdepend> [mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/api> [mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/code-browser> [mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/coverage> [mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/logs> [mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/pdepend> phpunit: [exec] Enabling headers testing using runkit... [exec] PHP Parse error: syntax error, unexpected ';', expecting ')' in <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/test/libraries/PMA_tbl_colu…> on line 971 BUILD FAILED <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build.xml>:27: exec returned: 255 Total time: 2 seconds Build step 'Invoke Ant' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [JSLINT] Skipping publisher since build result is FAILURE [PMD] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Computing warning deltas based on reference build #69 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #69 Recording plot data Publishing Clover coverage report... No Clover report will be published due to a Build Failure [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/'> for the testing framework 'PHPUnit-3.x (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.x (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. [JDepend] JDepend plugin is ready [JDepend] Couldn't generate JDepend file at 'build/logs/jdepend.xml'java.io.FileNotFoundException: <https://ci.phpmyadmin.net/job/phpMyAdmin-4.2/ws/build/logs/jdepend.xml> (No such file or directory)

1 0