Developers February 2017

developers@phpmyadmin.net

10 participants
16 discussions

About support for the themes repository
by Isaac Bennetch 21 Feb '17

21 Feb '17

Hi, On the Themes web page, we say: > Support for themes > > Themes are provided by third parties and the phpMyAdmin team does > not provide any support for them, please contact original authors > for improvements or security fixes." But since we now host the theme repository with a related issue tracker and ability to receive pull requests, we may want to revisit the phrasing of this. I'm not sure if we should continue to refer users to the original author, or if we should encourage authors to monitor the issue tracker on Github. Part of the problem here is that, if a theme author has their own repository, it makes it more difficult to submit pull requests against our repository; if a user wishes to make a change to a theme, do they suggest it to the original author (who may be unreachable or not interested) or directly to our themes repository. I propose that themes should remain unsupported by the official team and that the themes repository should be the official place to submit pull requests or issues. If a theme author has provided their email address, users can also contact them directly, but by maintaining our repository as the official source, users can easily submit improvements without having to track down the original author. Besides, we seem to do some work updating themes anyway; it's better to do it in one place. Therefore, the language of the themes page can be changed to: > Support for themes > > Themes are provided by third parties and the phpMyAdmin team does not > officially provide support for them. However, to maintain a > consistent experience, bugs or suggestions can be made at the [issue > tracker] and theme authors are encouraged to subscribe to > notifications from this repository. [Pull requests] are also > welcome. Any opinions about this?

2 1

Difficulty understanding ic_b_primary in mhn.icons.css.php
by Isaac Bennetch 20 Feb '17

20 Feb '17

Hi, I'm working on updating some of the themes for 4.7, but have encountered a difficulty. I'm looking at the mhn theme, on the Table Structure tab, at the icons representing a primary key. This seems to me to be a style applied by the class ic_b_primary. That class is defined in mhn.icons.css.php. I actually want to take the grey/inactive icon from the "Action" area and use it again as b_key.png, the indicator. The problem for me is that ic_b_primary isn't a .png in the img directory, so I can't just copy the file, and I'm not having any luck moving b_key in to mhn.icons.css.php. Anyone have a tip for me? Thanks, Isaac

2 1

Fwd: Re: Js/AJAX Fatal Error on Linux x86_64
by Isaac Bennetch 20 Feb '17

20 Feb '17

We got this email report from a user about trouble with phpMyAdmin 4.2.12, which is the old version packaged with Debian Stable. I suppose we should inform him that the version is no longer supported by us. Any other thoughts about this report? -------- Forwarded Message -------- Subject: Re: Js/AJAX Fatal Error on Linux x86_64 Date: Sat, 11 Feb 2017 21:10:13 +0100 From: Alessandro Majorino To: Isaac Bennetch <bennetch(a)gmail.com> I selected two table rows and clicked on edit. Then the editing page was displayed correctly but with a warning <div> included at the bottom. Again Alessandro Il 11 feb 2017 9:03 PM, "Isaac Bennetch" <bennetch(a)gmail.com <mailto:bennetch@gmail.com>> ha scritto: Hi Alessandro, Could you tell us a bit about what you did before the error occurred? What steps can I use to reproduce this? Best wishes, Isaac > Hello, > I just encountered a "JS fatal error" using phpmyadmin. Here it is the log: > > { > "exception": { > "mode": "onerror", > "message": "TypeError: AJAX.source is null", > "stack": [ > { > "line": 319, > "func": "?", > "context": [ > " AJAX.cache.add(", > " data._selflink,", > " data._scripts,", > " data._menuHash,", > " data._params,", > " AJAX.source.attr('rel')", > " );", > " }", > " if (data._params) {", > " PMA_commonParams.setAll(data._params);", > " }" > ], > "filename": "ajax.js" > } > ], > "useragent": "Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0", > "name": "TypeError", > "uri": "sql.php?target=" > }, > "script_name": "sql.php", > "pma_version": "4.2.12deb2+deb8u2", > "browser_name": "FIREFOX", > "browser_version": "45.0", > "user_os": "Linux", > "server_software": "Apache/2.4.10 (Debian)", > "user_agent_string": "Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0", > "locale": "en", > "configuration_storage": "enabled", > "php_version": "5.6.30-0+deb8u1", > > current index = 1; > > > > Cheers, > > Alessandro

2 1

Build failed in Jenkins: phpMyAdmin-continuous #12713
by Jenkins Daemon 13 Feb '17

13 Feb '17

See <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/12713/changes> Changes: [weblate] Translated using Weblate (Japanese) [Michal Čihař] Fixed rendering of foreign key browsing [Michal Čihař] Sort column names as well [Michal Čihař] Fixed manipulation with GIS data having zero coordinates [Michal Čihař] Use standard way for getting token value in designer ------------------------------------------ [...truncated 20.34 KB...] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 37) PMA_SeleniumExportTest::testServerImport with data set #2 ('JSON', array('[{"id":"1","val":"2"}]')) [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 38) PMA_SeleniumExportTest::testDbExport with data set #0 ('CSV', array('"1","2"')) [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 39) PMA_SeleniumExportTest::testDbExport with data set #1 ('SQL', array('CREATE TABLE IF NOT EXISTS `t...table`', 'INSERT INTO `test_table` (`id...VALUES', '(1, 2);')) [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 40) PMA_SeleniumExportTest::testDbExport with data set #2 ('JSON', array('[{"id":"1","val":"2"}]')) [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 41) PMA_SeleniumExportTest::testTableExport with data set #0 ('CSV', array('"1","2"')) [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 42) PMA_SeleniumExportTest::testTableExport with data set #1 ('SQL', array('CREATE TABLE IF NOT EXISTS `t...table`', 'INSERT INTO `test_table` (`id...VALUES', '(1, 2);')) [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 43) PMA_SeleniumExportTest::testTableExport with data set #2 ('JSON', array('[{"id":"1","val":"2"}]')) [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 44) PMA_SeleniumImportTest::testServerImport [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 45) PMA_SeleniumImportTest::testDbImport [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 46) PMA_SeleniumImportTest::testTableImport [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 47) PMA_SeleniumLoginTest::testSuccessfulLogin [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 48) PMA_SeleniumLoginTest::testLoginWithWrongPassword [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 49) PMA_SeleniumNormalizationTest::testNormalizationTo1NF [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 50) PMA_SeleniumPrivilegesTest::testChangePassword [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 51) PMA_SeleniumSettingsTest::testHideDatabase [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 52) PMA_SeleniumSettingsTest::testSettingsTabsAreDisplayed [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 53) PMA_SeleniumSettingsTest::testHideLogo [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 54) PMA_SeleniumTableBrowseTest::testSortRecords [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 55) PMA_SeleniumTableBrowseTest::testChangeRecords [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 56) PMA_SeleniumTableBrowseTest::testChangeRecordsByDoubleClick [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 57) PMA_SeleniumTableBrowseTest::testCopyRecords [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 58) PMA_SeleniumTableBrowseTest::testSearchRecords [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 59) PMA_SeleniumTableBrowseTest::testDeleteRecords [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 60) PMA_SeleniumTableCreateTest::testCreateTable [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] 61) PMA_SeleniumTableInsertTest::testAddData [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:29 [exec] [exec] 62) PMA_SeleniumTableOperationsTest::testChangeTableOrder [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 63) PMA_SeleniumTableOperationsTest::testMoveTable [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 64) PMA_SeleniumTableOperationsTest::testRenameTable [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 65) PMA_SeleniumTableOperationsTest::testCopyTable [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 66) PMA_SeleniumTableOperationsTest::testTruncateTable [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 67) PMA_SeleniumTableOperationsTest::testDropTable [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 68) PMA_SeleniumTableStructureTest::testAddColumn [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 69) PMA_SeleniumTableStructureTest::testChangeColumn [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 70) PMA_SeleniumTableStructureTest::testDropColumns [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 71) PMA_SeleniumTrackingTest::testTrackingData [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 72) PMA_SeleniumTrackingTest::testDeactivateTracking [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 73) PMA_SeleniumTrackingTest::testDropTracking [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 74) PMA_SeleniumTrackingTest::testStructureSnapshot [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:28 [exec] [exec] 75) PMA_SeleniumXSSTest::testQueryTabWithNullValue [exec] Selenium testing not configured. [exec] [exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:168 [exec] [exec] FAILURES! [exec] Tests: 2271, Assertions: 6229, Failures: 2, Skipped: 75, Incomplete: 5, Risky: 1. BUILD FAILED <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml>:33: exec returned: 1 Total time: 15 seconds Build step 'Invoke Ant' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [JSLINT] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Computing warning deltas based on reference build #12712 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #12712 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [INFO] - Check 'Failed Tests' threshold. [xUnit] [INFO] - Check 'Skipped Tests' threshold. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 6

Theme for 4.7
by Michal Čihař 02 Feb '17

02 Feb '17

Hi all I know it's a bit late, but some time ago I filled https://github.com/phpmyadmin/phpmyadmin/issues/12373 where I wanted to start theme selection for 4.7. Unfortunately this really did not happen. Why I'm opening this question is that we got another report about shipped themes: https://github.com/phpmyadmin/phpmyadmin/issues/12916 It would be great if you can look at the issue and comment your feelings about theme change. -- Michal Čihař | https://cihar.com/ | https://weblate.org/

3 4

Default host name with different connect types
by Isaac Bennetch 02 Feb '17

02 Feb '17

When a user does not define `$cfg['Servers'][$i]['host']` but does set `$cfg['Servers'][$i]['connect_type'] = 'tcp';`, the default host of 'localhost' is used, forcing the connection over socket because of how MySQL interprets the host. Would it be helpful to detect when the user specifies 'tcp' and use a default host of '127.0.0.1' instead of 'localhost', or is that getting to be too much guessing about what the user wants?

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers February 2017