Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Plugins and OOP
by Alex Marin 28 Jun '12

28 Jun '12

Hi everyone, I have implemented a good deal of the object oriented plugins system. All of the plugins can be found in the /libraries/plugins/ folder in my git repo [1]. There are two important things that are missing right now: - The update() methods in the Observer pattern. - Serious testing. I think that my code is safe to be merged now. There are probably still a few bugs left, but more people having them will pop them out faster. I hope there are not so many, though. And I also believe that new development can be done over my classes without problems. What do you think? Also, I was thinking that, maybe, Yasitha, is there any way you can work with me and integrate some tests for the import, export, transformations and auth plugins with your GSoC project? And, of course, any suggestions are welcome. [1] https://github.com/alexukf/phpmyadmin/tree/plugins-and-OOP -- Alex

2 4

[Phpmyadmin-devel] ready for 3.5.2-rc1 ?
by Marc Delisle 27 Jun '12

27 Jun '12

Hi, I hoped to completely remove usage of Highcharts for 3.5.2 but I am stuck on a problem. Therefore I suggest to release 3.5.2-rc1 with the current state of QA_3_5 branch. -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] phpMyAdmin 3.5.2-rc1 is released
by Marc Delisle 26 Jun '12

26 Jun '12

Welcome to the first release candidate for phpMyAdmin 3.5.2, a bugfix release. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] testing PHP 5.4-based upload progress
by Marc Delisle 25 Jun '12

25 Jun '12

Hi Jo, I'm using PHP 5.4.4 and testing your newest commits. After the POST to import.php, I immediately see GET import_status.php with this JSON response: {"id":"4fe8b2f19bc80","finished":true,"percent":100,"total":0,"complete":0,"plugin":"PHP_SESSION_UPLOAD_PROGRESS"} Then, another GET to import_status.php which does not return. Meanwhile, I see in my upload directory the file still being received. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Cross framing protection
by Rouslan Placella 25 Jun '12

25 Jun '12

Hi Dieter, I've just dropped the cross_framing_protection.js script in my branch. However there is the below bit of code from Header.class.php that I'm not too sure what to do with. > /* Prevent against ClickJacking by allowing frames only from same origin */ > if (! $GLOBALS['cfg']['AllowThirdPartyFraming']) { > header( > "X-Content-Security-Policy: allow 'self'; " > . "options inline-script eval-script; " > . "frame-ancestors 'self'; img-src 'self' data:; " > . "script-src 'self' http://www.phpmyadmin.net" > ); > header( > "X-WebKit-CSP: allow 'self' http://www.phpmyadmin.net; " > . "options inline-script eval-script" > ); > } I'm guessing that we need CSP for the version checker (or do we?), but we don't really need the configuration directive for it. Not sure how to proceed here. Any help appreciated, thanks. Bye, Rouslan

2 2

[Phpmyadmin-devel] Automated Testing - GSoC 2012
by yasitha pandithawatta 25 Jun '12

25 Jun '12

Hi Michal, Though I started to writing test cases for common library I came to know Chanaka is re-factoring it. So it is worthless of writing tests for current code. So I moved in to core library. I want to know any re-factoring going on core library. One more thing. Whats the best way to update our forked repository? Using git pull or git fetch and merge it? Or doesn't have much difference? Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka

2 3

[Phpmyadmin-devel] Refactoring db_search.php
by Atul Pratap Singh 19 Jun '12

19 Jun '12

Hi Marc, While taking a look at the Db-search functionality I noticed a bug. Steps: 1. Open db-search tab for a database. 2. Make a search by entering a keyword and selecting all tables. 3. From the 'browse' and 'delete' links in search results, select 'delete' for any table. 4. Notice that a DELETE query is sent to sql.php. But no actual deletion happens. Regards -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.

3 12

[Phpmyadmin-devel] AjaxEnable directive
by Rouslan Placella 19 Jun '12

19 Jun '12

Hi Dieter, as I just wrote in my blog post, I'm considering dropping the $cfg['AjaxEnable'] directive as in my opinion it will considerably complicate the processing of some pages and doesn't seem to any real benefits. Your thoughts on this appreciated. Bye, Rouslan

4 8

[Phpmyadmin-devel] Writing useful docblocks
by Michal Čihař 19 Jun '12

19 Jun '12

Hi all, especially GSoC students just a quick reminder, that docblocks are meant to document function and it's parameters, so writing docblocks as following is quite useless: /** * * @param type $srid * @param type $scale_data * @param type $output */ - You should describe what the function is supposed to do - You should document actual types of parameters instead of writing there "type" - You should document parameter meaning Thank you for your cooperation in making readable and easy to understand code. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 1

[Phpmyadmin-devel] GSoC - Removal of frames
by Dieter Adriaenssens 19 Jun '12

19 Jun '12

Hi Rouslan, I went through your latest commits in your GSoC branch, see github for the small remarks. You did a great job on creating the different classes (PMA_Header, PMA_Footer, PMA_Response, ...) moving functionality from other library files into it, and integrating these new classes in the current code base. I think you've come to a point where these changes are ready to be merged with master. What do you think? -- Kind regards, Dieter Adriaenssens

4 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers