- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Refactoring: Displaying query results
by Chanaka Dharmarathna 14 Jul '12

14 Jul '12

Hi All, I have a doubt of using *@see* tag in Docblock comments for functions. In the comments of functions PMA_getTable() and PMA_getTableBody() in display_tbl.lib.php file, @see tag is used for different purposes. As I feel PMA_getTableBody() used that corrrectly. What should be the actual behavior ? Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

8 48

[Phpmyadmin-devel] Changelog and list of dropped config options
by Dieter Adriaenssens 13 Jul '12

13 Jul '12

Hi Rouslan, While going through your commits I didn't notice any updates of the Changelog so far. Are you keeping a list of changes, in particular a list of config options you are dropping (like 'AllowThirdPartyFraming')? -- Kind regards, Dieter Adriaenssens

2 1

[Phpmyadmin-devel] phpMyAdmin 3.5.2 is released
by Marc Delisle 11 Jul '12

11 Jul '12

Welcome to phpMyAdmin 3.5.2, a bugfix release. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

3 4

[Phpmyadmin-devel] about setCommonFunctions()
by Marc Delisle 10 Jul '12

10 Jul '12

Hi, can someone explain the goal of this method? AFAIK it's never called. -- Marc Delisle http://infomarc.info

3 8

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1671
by michal＠cihar.com 10 Jul '12

10 Jul '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1671/changes> Changes: [pe.chanaka.ck] Break _getTableHeaders function in PMA_DisplayResults class, to sub functions [pe.chanaka.ck] Break _getTableHeaders function in PMA_DisplayResults class, to more sub functions [pe.chanaka.ck] Break _getTableBody function in PMA_DisplayResults class, to sub functions [pe.chanaka.ck] Break _getTable function in PMA_DisplayResults class, to sub functions [pe.chanaka.ck] Reduce the use of superglobal variables in PMA_DisplayResults class [pe.chanaka.ck] Use class varables without passing them to functions in PMA_DisplayResults class [pe.chanaka.ck] Add get set magic methods for PMA_DisplayResults class [pe.chanaka.ck] Remove setCommonFunctions [weblate] Translated using Weblate. [weblate] Translated using Weblate. [pe.chanaka.ck] Fix defect in print view when vertical mode is on [weblate] Translated using Weblate. [weblate] Translated using Weblate. ------------------------------------------ Started by an SCM change Started by an SCM change Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@4ed990db Using strategy: Default Last Built Revision: Revision 351891c835496792367539dfb122f3965d797517 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 41ca99badbfbfef05488b111f012952748134791 (origin/master) Checking out Revision 41ca99badbfbfef05488b111f012952748134791 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson1773030079178980403.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit: [exec] PHPUnit 3.6.11 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.dist> [exec] [exec] ..........Compile Error [exec] ................................FI........II.....E.E. 63 / 971 ( 6%) [exec] E.EFE....EEEE............................F..............E...... 126 / 971 ( 12%) [exec] ............................F.........................F..E..... 189 / 971 ( 19%) [exec] ...F.........F.......F..F......F............................... 252 / 971 ( 25%) [exec] .......................................................F....... 315 / 971 ( 32%) [exec] ............................................................... 378 / 971 ( 38%) [exec] ............................................E [exec] PHP Fatal error: Class 'PMA_OutputBuffering' not found in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/Response.cl…> on line 92 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_TestRunner->doRun() /usr/share/php/PHPUnit/TextUI/Command.php:192 [exec] PHP 5. PHPUnit_Framework_TestSuite->run() /usr/share/php/PHPUnit/TextUI/TestRunner.php:325 [exec] PHP 6. PHPUnit_Framework_TestSuite->run() /usr/share/php/PHPUnit/Framework/TestSuite.php:705 [exec] PHP 7. PHPUnit_Framework_TestSuite->run() /usr/share/php/PHPUnit/Framework/TestSuite.php:705 [exec] PHP 8. PHPUnit_Framework_TestSuite->runTest() /usr/share/php/PHPUnit/Framework/TestSuite.php:745 [exec] PHP 9. PHPUnit_Framework_TestCase->run() /usr/share/php/PHPUnit/Framework/TestSuite.php:772 [exec] PHP 10. PHPUnit_Framework_TestResult->run() /usr/share/php/PHPUnit/Framework/TestCase.php:751 [exec] PHP 11. PHP_Invoker->invoke() /usr/share/php/PHPUnit/Framework/TestResult.php:647 [exec] PHP 12. call_user_func_array() /usr/share/php/PHP/Invoker.php:93 [exec] PHP 13. PHPUnit_Framework_TestCase->runBare() /usr/share/php/PHP/Invoker.php:93 [exec] PHP 14. PHPUnit_Framework_TestCase->runTest() /usr/share/php/PHPUnit/Framework/TestCase.php:804 [exec] PHP 15. ReflectionMethod->invokeArgs() /usr/share/php/PHPUnit/Framework/TestCase.php:942 [exec] PHP 16. PMA_fatalError_test->testFatalErrorMessageWithArgs() /usr/share/php/PHPUnit/Framework/TestCase.php:942 [exec] PHP 17. PMA_fatalError() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:59 [exec] PHP 18. include() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/core.lib.php>:234 [exec] PHP 19. PMA_Response::getInstance() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/error.inc.p…>:18 [exec] PHP 20. PMA_Response->__construct() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/Response.cl…>:117 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 11 exact clones with 364 duplicated lines in 9 files: [exec] [exec] - /libraries/plugins/export/ExportLatex.class.php:130-143 [exec] /libraries/plugins/export/ExportOdt.class.php:85-98 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:629-655 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:704-730 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:425-446 [exec] /libraries/schema/Svg_Relation_Schema.class.php:392-413 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:473-482 [exec] /libraries/schema/Svg_Relation_Schema.class.php:442-451 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:608-658 [exec] /libraries/schema/Svg_Relation_Schema.class.php:589-639 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:425-446 [exec] /libraries/schema/Visio_Relation_Schema.class.php:223-244 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:608-664 [exec] /libraries/schema/Visio_Relation_Schema.class.php:376-432 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:753-774 [exec] /libraries/schema/Visio_Relation_Schema.class.php:578-599 [exec] [exec] - /themes/original/css/common.css.php:1271-1292 [exec] /themes/original/css/common.css.php:1275-1296 [exec] [exec] - /themes/original/css/common.css.php:1215-1323 [exec] /themes/pmahomme/css/common.css.php:1574-1682 [exec] [exec] 0.27% duplicated lines out of 132901 total lines of code. [exec] [exec] Time: 7 seconds, Memory: 109.00Mb [exec] Result: 1 phpcs: [exec] Time: 02:38, Memory: 179.00Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 26 [exec] Files: 350 [exec] [exec] Lines of Code (LOC): 132901 [exec] Cyclomatic Complexity / Lines of Code: 0.14 [exec] Comment Lines of Code (CLOC): 40512 [exec] Non-Comment Lines of Code (NCLOC): 92389 [exec] [exec] Namespaces: 0 [exec] Interfaces: 2 [exec] Classes: 156 [exec] Abstract: 20 (12.82%) [exec] Concrete: 136 (87.18%) [exec] Average Class Length (NCLOC): 243 [exec] Methods: 1447 [exec] Scope: [exec] Non-Static: 1273 (87.98%) [exec] Static: 174 (12.02%) [exec] Visibility: [exec] Public: 1063 (73.46%) [exec] Non-Public: 384 (26.54%) [exec] Average Method Length (NCLOC): 26 [exec] Cyclomatic Complexity / Number of Methods: 4.19 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 545 [exec] [exec] Constants: 154 [exec] Global constants: 102 [exec] Class constants: 52 BUILD SUCCESSFUL Total time: 3 minutes 19 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 8310 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1670 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 21 warnings. [DRY] Computing warning deltas based on reference build #1670 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 469 files to scan for tasks [TASKS] Found 200 open tasks. [TASKS] Computing warning deltas based on reference build #1670 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1670 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-07-10_09-02-48/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml'> for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 0

[Phpmyadmin-devel] Automated Testing - GSoC 2012
by yasitha pandithawatta 06 Jul '12

06 Jul '12

Hi Michal, I have fixed the failing test cases of CommonFunctions.class.php. But the following two test files still having issues. - PMA_showMessage_test_disabled.php Test method of this class recursively calling many functions and going through several layers. Since CommonFunctions.class.php having private construct it is not possible to mock the class also. - PMA_checkParameters_test.php When I include the database_interface.lib.php I failed to configure the required configurations. If you have any suggestions let me know. Also is there a method to run all the test cases under /test/libraries/common/ ? Since CommonFunctions.class.php has several test classes it is difficult to genarate the whole class code coverage. *phpunit test/libraries/common/* command won't work. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka

1 0

[Phpmyadmin-devel] Status of Writing Test Cases for CommonFunctions.class php and Displayresults.class.php
by yasitha pandithawatta 06 Jul '12

06 Jul '12

Hi Chanaka/Thilina, Any body working on writing test cases for above mentioned two classes. If What is the status? I can see some test cases are failing in common library test cases after re-factoring. Any body fix those failing test cases in your fork? Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka

2 1

[Phpmyadmin-devel] undefined PMA_getPlugin()
by Marc Delisle 06 Jul '12

06 Jul '12

Hi, with current upstream master (15ab6eea39880983f1bc2b0e08d679a33a457876), I get an error trying to copy a table via Operations. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] ESRI and docSQL Import Plugins
by Alex Marin 05 Jul '12

05 Jul '12

Hi, Madhura, I saw that last year your wrote the plug-in for importing ESRI Shape files. I found a short description of the format, and I wrote it here [1], but I'm not sure if that corresponds. Could you please check? Also, is there any way you can provide me with a sample .shp file to test the new import plugin? :) On a related note, Michal, do you think docSQL is still supported? I saw that their last update was in 2009, and their website is not available [2]. I downloaded the archive, but their English readme is in Deutsch, and their Deutsch readme is in English, but still not very helpful, so I did not manage to get around it. Do you think we should keep this import format? [1] http://wiki.phpmyadmin.net/pma/import [2] http://sourceforge.net/projects/docsql/ -- Alex

2 4

[Phpmyadmin-devel] Error when editing user preferences on wiki
by Alex Marin 04 Jul '12

04 Jul '12

Hi, I was trying to edit a page on the wiki [1], and it tells me that I don't have the necessary permissions and asks me to: "set and validate your e-mail address through your user preferences." But when accessing [2], I get the following error: A database query syntax error has occurred. This may indicate a bug in the software. The last attempted database query was: (SQL query hidden) from within function "SpecialOpenID::getUserOpenIDInformation". \ Database returned error "1054: Unknown column 'uoi_user_registration' in 'field list' (192.168.2.4)". Any ideas why? [1] http://wiki.phpmyadmin.net/pma/Import_(development) [2] http://wiki.phpmyadmin.net/pma/Special:Preferences -- Alex

2 1