Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Refactoring tbl_zoom_select.php
by Atul Pratap Singh 11 Jun '12

11 Jun '12

Hi Marc, While looking at "tbl_zoom_select.php":- Line 191-201 if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] != 'pma_null')) { $flag = 2; for ($i = 0 ; $i < 4 ; $i++) { if ($inputs[$i] != 'pma_null') { $key = array_search($inputs[$i], $fields_list); $tbl_fields_type[$i] = $fields_type[$key]; $tbl_fields_collation[$i] = $fields_collation[$key]; $tbl_fields_null[$i] = $fields_null[$key]; } } } As the condition would be true in cases when post param $inputs is set and has index 0 or 1 set to some column name. It would mostly happen if a half or full filled search form is submitted, but there seems to be no further use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type gets used afterwards with indexes >= 4. I think as a result after the zoom plot is displayed, clicking at "show search criteria" doesn't show any previously filled criteria. I also didn't understand the use of $flag variable. Thanks -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.

2 13

[Phpmyadmin-devel] Search refactoring: problem when editing a point
by Marc Delisle 10 Jun '12

10 Jun '12

Hi Atul, here is a bug that happens in your tree but not in upstream master. On a table with some columns being nullable, do a zoom search, then click on a data point to edit something. You'll see that the generated UPDATE statement incorrectly sets all nullable columns to NULL. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Insert/edit refactoring bug
by Marc Delisle 10 Jun '12

10 Jun '12

Hi Thilina, just in case you missed my comment [0] about bug [1]. There was also another comment just above this one. [0] https://github.com/thilinaa/phpmyadmin/commit/98cbdfc2b348f21955e9c34bb9f4d… [1] https://sourceforge.net/tracker/?func=detail&aid=3532005&group_id=23067&ati… -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Confirmation before tab close while inserting data on editing a column/data
by Gopi Ramena 04 Jun '12

04 Jun '12

I am wondering why doesn't phpmyadmin have a confirmation on close of tab or browser while the user in inserting/editing a column. It can be easily done by adding a piece of javascript code as in this fiddle http://jsfiddle.net/gopi1410/yWs7P/4/ -- - Gopi Ramena http://stackoverflow.com/users/1135703/gopi1410 http://careers.stackoverflow.com/gopi1410

2 3

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1535
by michal＠cihar.com 04 Jun '12

04 Jun '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1535/changes> Changes: [mcihar] Add method for generating update SQLs [mcihar] Remove unused parameter [mcihar] Single place to handle table renaming for configuration storage [mcihar] This code is broken anyway (see comment above) [mcihar] Missing doc [mcihar] Correct wrapping [mcihar] Add documentation [mcihar] Better name for function [mcihar] Add missing comment [mcihar] Wrap some long lines ------------------------------------------ Started by an SCM change Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@28892a87 Using strategy: Default Last Built Revision: Revision 2d73225a19b65d2a55084ebe993f6d0ef594d0af (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision e544705e3c9a959ee93fc596ebcd002c1dba0cdf (origin/master) Checking out Revision e544705e3c9a959ee93fc596ebcd002c1dba0cdf (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson660717312419598174.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit: [exec] PHP Fatal error: Cannot redeclare PMA_REL_renameTable() (previously declared in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/relation.li…>:1264) in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/relation.li…> on line 1358 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:139 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:671 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:776 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:848 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:419 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:358 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:79 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:95 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 12 exact clones with 354 duplicated lines in 7 files: [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-479 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:628-653 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Svg_Relation_Schema.class.php:391-407 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Svg_Relation_Schema.class.php:441-449 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-657 [exec] /libraries/schema/Svg_Relation_Schema.class.php:588-638 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-663 [exec] /libraries/schema/Visio_Relation_Schema.class.php:375-431 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:577-598 [exec] [exec] - /themes/original/css/common.css.php:1276-1297 [exec] /themes/original/css/common.css.php:1280-1301 [exec] [exec] - /themes/original/css/common.css.php:1220-1328 [exec] /themes/pmahomme/css/common.css.php:1582-1690 [exec] [exec] 0.28% duplicated lines out of 125128 total lines of code. [exec] [exec] Time: 8 seconds, Memory: 102.25Mb [exec] Result: 1 phpcs: [exec] Time: 02:16, Memory: 177.50Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 326 [exec] [exec] Lines of Code (LOC): 125128 [exec] Cyclomatic Complexity / Lines of Code: 0.15 [exec] Comment Lines of Code (CLOC): 37088 [exec] Non-Comment Lines of Code (NCLOC): 88040 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 82 [exec] Abstract: 2 (2.44%) [exec] Concrete: 80 (97.56%) [exec] Ave [exec] rage Class Length (NCLOC): 218 [exec] Methods: 781 [exec] Scope: [exec] Non-Static: 686 (87.84%) [exec] Static: 95 (12.16%) [exec] Visibility: [exec] Public: 637 (81.56%) [exec] Non-Public: 144 (18.44%) [exec] Average Method Length (NCLOC): 22 [exec] Cyclomatic Complexity / Number of Methods: 3.73 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 854 [exec] [exec] Constants: 121 [exec] Global constants: 105 [exec] Class constants: 16 BUILD SUCCESSFUL Total time: 2 minutes 31 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 7593 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1534 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 22 warnings. [DRY] Computing warning deltas based on reference build #1534 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 435 files to scan for tasks [TASKS] Found 186 open tasks. [TASKS] Computing warning deltas based on reference build #1534 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1534 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-06-04_13-20-36/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 1

[Phpmyadmin-devel] Contributing in phpmyadmin
by Gopi Ramena 03 Jun '12

03 Jun '12

Hi all, I wanted to contribute to phpmyadmin. Basically I am an experienced php, javascript web developer but have very less idea about contributing in open source. I have seen the source on github, so in order to contribute something, do I just fork the repository, commit changes & send pull requests? Is that contributing in open source community of phpmyadmin? Thanks, Gopi

3 2

[Phpmyadmin-devel] Contributing to phpmyadmin
by Gopi Ramena 03 Jun '12

03 Jun '12

1 0

[Phpmyadmin-devel] LAMP appliance with phpmyadmin
by Jordi Massaguer Pla 30 May '12

30 May '12

Dear phpmyadmin developers, I've created a LAMP software appliance with SUSEStudio that includes phpmyadmin as well as webalizer for apache statistics and webyast for managing the appliance itself. Moreover this appliance contains the most popular php extensions including xcache and memcached for performance and xdebug for debugging. It would be really great to get some feedback from you as I would like to use this appliance as a base for other php appliances (i.e. drupal, joomla, wordpress, moodle, ...) Feel free to try it online at: http://susestudio.com/a/61bKK8/lamp-server-32bit Just press the "Testdrive" and you'll be able to try it on your browser. Click on "Enable networking" and you'll see the instructions for accessing phpmyadmin. You do not have to download it to test it, but if you like, you can download it as USB, liveCD, preload iso, ovf, vmware, Hyper-V or Xen images, or even start it on amazon. You can see some screenshots at http://jordimassaguerpla.blogspot.com.es/2012/05/lamp-appliance-phpmyadmin.… Thanks in advance, Looking forward to your answer, Jordi Massaguer Pla

2 2

[Phpmyadmin-devel] GSOC Removal of Frames
by Dieter Adriaenssens 30 May '12

30 May '12

Hi Rouslan, I had a look at your latest commits in your github branch and made some small comments to the code on github. When reviewing your code during the weekend I came along a static function doing something that is now handled by your new class, but when going over your seperate commits to write the comments I didn't find that occurence again, so I can't tell you the name of the function. But it seems it's now obsolete, or at least deprecated. I'll let you know when I find it again. Anyway, will you be using your frames-removal branch during GSoc, or are there other branch I should track? -- Kind regards, Dieter Adriaenssens

2 1

[Phpmyadmin-devel] problem adding a column
by Marc Delisle 29 May '12

29 May '12

Hi, after: commit 292f83e382b219c49004d7e19761696c6658d7ca Author: Madhura Jayaratne <madhura.cj(a)gmail.com> Date: Thu May 10 00:31:15 2012 +0530 Coding style improvements ---------- I get this when adding a column: Notice in ./libraries/tbl_properties.inc.php#647 Undefined index: Field Backtrace ./tbl_addfield.php#231: include_once(./libraries/tbl_properties.inc.php) Notice in ./libraries/tbl_properties.inc.php#647 Undefined index: Backtrace ./tbl_addfield.php#231: include_once(./libraries/tbl_properties.inc.php) -- Marc Delisle http://infomarc.info

2 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers