- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] problem adding a column
by Marc Delisle 29 May '12

29 May '12

Hi, after: commit 292f83e382b219c49004d7e19761696c6658d7ca Author: Madhura Jayaratne <madhura.cj(a)gmail.com> Date: Thu May 10 00:31:15 2012 +0530 Coding style improvements ---------- I get this when adding a column: Notice in ./libraries/tbl_properties.inc.php#647 Undefined index: Field Backtrace ./tbl_addfield.php#231: include_once(./libraries/tbl_properties.inc.php) Notice in ./libraries/tbl_properties.inc.php#647 Undefined index: Backtrace ./tbl_addfield.php#231: include_once(./libraries/tbl_properties.inc.php) -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] Coding style update
by Michal Čihař 29 May '12

29 May '12

Hi all though phpcs with PMAStandard does already cover this, it seems to be necessary to mention it explicitely: Please don't wrap translatable strings to fit into 85 chars width limits. It just causes further troubles (the strings are translated with newlines and indentation what looks weird). The PMAStandard should ignore such lines from checking for line length (if it does not please tell me, it's a bug in the rules). -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 4

[Phpmyadmin-devel] Git commits
by Michal Čihař 29 May '12

29 May '12

Hi as I've noticed that some of GSoC students do quite huge commits, I'd like to mention, that creating big commits is always bad :-). Try to commit small functional blocks as soon as you have finished, this way you can benefit from version control as well (it's easier to find what is wrong in few lines diff than in something what spans over few pages). -- Michal Čihař | http://cihar.com | http://blog.cihar.com

1 0

[Phpmyadmin-devel] Automated Testing - GSoC 2012
by yasitha pandithawatta 29 May '12

29 May '12

Hi Michal, I had my semester exams for last two weeks. Today onward I can give priority to my GSoC project. I'll start writing the test cases for mail libraries. Any re-factored classes committed to the master branch? If so I can straight away start writing the test cases for those classes. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka

3 7

[Phpmyadmin-devel] Refactoring: Displaying query results
by Chanaka Dharmarathna 25 May '12

25 May '12

Hi Michal, I'm identifying the refactoring points in 'display_tbl.lib.php' file. I am trying to break the tasks on following areas. * As a library file this should not render the HTML codes in functions it selves. First, all the HTML content in functions stored in string and render at the bottom of the function. Next, return the string having the HTML content, instead of rendering it inside the function itself and, from the calling end render that content. Probably method names will be modified with adding 'get' phrase. * Some naming conventions are used incorrectly. For method name in lib file, naming convention is used generally used as 'PMA_methodName'. But some are not following this. While correcting them, suggested conventions in my proposal [0] is going to applied. * There are several functions having more than 200 lines. I'm intending to divide those functions to smaller ones. (PMA_displayTableNavigation(), PMA_displayTableHeaders(), PMA_displayTableBody(), PMA_displayVerticalTable(), PMA_displayTable()) I am looking for your suggestions to identify more important points and modifications on suggested points. So that I can do more research by digging code more. As well, I'm using NetBeans IDE with PHP support, meld tool, Mozilla Firefox with Firebug, command line git client in Linux environment. Are there any other special tools which are more useful ? [0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka7… Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

5 53

[Phpmyadmin-devel] GSoC: Refactoring Table search, Db search, Multi-table query
by Atul Pratap Singh 25 May '12

25 May '12

Hi Marc, Now that my exams are finished :), I have started to look at the script "tbl_select.php" for planning the refactoring. As the script is used for searching a table using a form in the UI, it contains two sections:- 1. If block that "displays the selection form". 2. else to do the search work. Looking at the search form display part, it is done using raw HTML-PHP mix with calls to functions from some library files, so first main concern should be to handle the HTML-PHP mix and convert the code into functions. About that I saw the wiki page for Roadmap to 4.0 [0] :- "The current <html> and <?php> mix will be cleaned up in the process. The <html> output will be moved to lib/include files which can be called by either the index page or by the specific files (which can still be referenced separately)." So, to move HTML to lib/include files, slicing proper reusable HTML blocks from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the way, I should proceed ? [0] http://wiki.phpmyadmin.net/pma/FOSDEM_2012_Meeting Regards -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.

2 11

[Phpmyadmin-devel] Refactoring insert-edit
by Thilina Buddika Abeyrathna 23 May '12

23 May '12

Hi Marc, when I'm writing functions for columns of insertForm I need to pass all the following parameters to the functions. $field, $backup_field, $field_name_appendix, $unnullify_trigger, $tabindex, $tabindex_for_value, $idindex, $data So function signature is very long which is somewhat ugly, Is it ok to have a global parameter array for insert_edit.lib.php file. Does this break the refactoring? -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.

4 31

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1493
by michal＠cihar.com 23 May '12

23 May '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1493/changes> Changes: [weblate] Translated using Weblate. [mcihar] Wrap some long lines [mcihar] Calcualte include path only once [mcihar] Calculate function name only once ------------------------------------------ Started by an SCM change Started by an SCM change Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@1494a05c Using strategy: Default Last Built Revision: Revision def75ac09f904b1f796dbdb1569b5825be8d0fd7 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision d54c77b613888f101cc680bb1f03cb8434194937 (origin/master) Checking out Revision d54c77b613888f101cc680bb1f03cb8434194937 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson3321461921807073330.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit: [exec] PHPUnit 3.6.10 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.dist> [exec] [exec] .......... [exec] Result: 139 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 13 exact clones with 549 duplicated lines in 8 files: [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-479 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:628-653 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Svg_Relation_Schema.class.php:391-407 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Svg_Relation_Schema.class.php:441-449 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-657 [exec] /libraries/schema/Svg_Relation_Schema.class.php:588-638 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-663 [exec] /libraries/schema/Visio_Relation_Schema.class.php:375-431 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:577-598 [exec] [exec] - /themes/original/css/common.css.php:1265-1286 [exec] /themes/original/css/common.css.php:1269-1290 [exec] [exec] - /themes/original/css/common.css.php:1209-1317 [exec] /themes/pmahomme/css/common.css.php:1583-1691 [exec] [exec] - /themes/original/css/common.css.php:1265-1460 [exec] /themes/pmahomme/css/pmd.css.php:47-242 [exec] [exec] 0.45% duplicated lines out of 122051 total lines of code. [exec] [exec] Time: 8 seconds, Memory: 101.25Mb [exec] Result: 1 phpcs: [exec] Time: 01:52, Memory: 57.00Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 323 [exec] [exec] Lines of Code (LOC): 122051 [exec] Cyclomatic Complexity / Lines of Code: 0.15 [exec] Comment Lines of Code (CLOC): 36398 [exec] Non-Comment Lines of Code (NCLOC): 85653 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 82 [exec] Abstract: 2 (2.44%) [exec] Concrete: 80 (97.56%) [exec] Average Class Length (NCLOC): 219 [exec] Methods: 778 [exec] Scope: [exec] Non-Static: 683 (87.79%) [exec] Static: 95 (12.21%) [exec] Visibility: [exec] Public: 634 (81.49%) [exec] Non-Public: 144 (18.51%) [exec] Average Method Length (NCLOC): 23 [exec] Cyclomatic Complexity / Number of Methods: 3.75 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 797 [exec] [exec] Constants: 121 [exec] Global constants: 105 [exec] Class constants: 16 BUILD SUCCESSFUL Total time: 2 minutes 9 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 7961 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1492 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 24 warnings. [DRY] Computing warning deltas based on reference build #1492 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 432 files to scan for tasks [TASKS] Found 188 open tasks. [TASKS] Computing warning deltas based on reference build #1492 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1492 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-05-23_14-33-22/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml'> for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 1

[Phpmyadmin-devel] Replacing Highcharts
by Marc Delisle 22 May '12

22 May '12

Hi, due to a licensing issue with Highcharts (which we started to use in 3.5.x), we have to think about replacing it with another library. Otherwise, distros like Debian won't accept 3.5. We'll need: 1. ideas for a replacement library (GPL) 2. volunteers to do the switch (I am volunteer) The goal is to do the replacement in 3.5.x, not 4.0. -- Marc Delisle http://infomarc.info

4 10

[Phpmyadmin-devel] GSoC Git repos
by Michal Čihař 21 May '12

21 May '12

Hi all (especially students) I've made some clarifications to GSoC student guide about git repositories [1]. To make it short: We want to merge your code as soon as possible. So try to keep your repository in good shape all the time and whenever you've completed some bigger part, just file a pull request on Github or tell your mentor to merge your changes. [1]:http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide#Publish_a_Git_rep… -- Michal Čihař | http://cihar.com | http://blog.cihar.com

1 0