Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Merging Drizzle support
by Piotr Przybylski 24 Aug '11

24 Aug '11

Hi, In a day or two I will be merging my Drizzle code into master, I just need some time to look through all my changes and check whether they need any refactoring. Is that ok? -- Regards, Piotr Przybylski

3 3

[Phpmyadmin-devel] datepicker and DATE columns
by Marc Delisle 23 Aug '11

23 Aug '11

Piotr, in current master, clicking Insert for a table with a DATE or DATETIME column does not show the picker icon. git bisect tells me that your commit 84cc7837f5da69c588f7503da0acc9512ff29619 caused this. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] Grid editing and null checkbox
by Madhura Jayaratne 23 Aug '11

23 Aug '11

Hi Aris, Out of the columns that can be made null, only some of the columns facilitate nullifying a value with grid editing. For example, while columns rating and special_features of sakila.film can be made null with grid editing, release_year and length of the same table cannot be made null. I feel it would be better if the behavior is consistent among all the columns that can be made null. -- Thanks and Regards, Madhura Jayaratne

3 2

Re: [Phpmyadmin-devel] Bug in Ajax table Structure column Change
by Aris Feryanto 23 Aug '11

23 Aug '11

Hi, On 19 Agu 2011, at 13:57, Thilanka Kaushalya <lgtkaushalya(a)gmail.com> wrote: Hi Marc, > > >I found the place where this issue generates. When we try click on Table->Structure->Column->Change link it goes to the tbl_alter.php file and within that the "append_fields_form" is process by using tbl_properties.inc.php file. At line number 325 in tbl_properties.inc.php "PMA_getSupportedDatatypes(true, $type_upper);" function is call to get the table type select options. > > >You can find at line 3118 in "PMA_getSupportedDatatypes(true, $type_upper);" the option selection is set as >if ($selected == $value) { > $retval .= "<option selected='selected'>$value</option>"; > } else { > $retval .= "<option>$value</option>"; > } > But if you use an echo you can see that $selected contains VARCHAR(45)as the value and $value contains VARCHAR as the value. So when we try to edit the tables which are having VARCHAR type columns it does not select the value at the options. > > >I can modify the logic by splitting the $selected by "(" and solve the issue. Is there any better solution you can suggest. If there any please let me know. Thank you. > I did a bisecting in the official branch (using "git bisect" command) and found that 48149c261c633baf517455079a2524a9a9aac6a0 (message: "Use already calculated values", by Michal) is the first bad commit. Hope this helps. -- Aris Feryanto

4 4

Re: [Phpmyadmin-devel] Date-time picker
by Aris Feryanto 23 Aug '11

23 Aug '11

On 23 Agu 2011, at 02:57, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: > > On 23 Agu 2011, at 02:29, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: > >> 2011/8/22 Tyron Madlener <tyronx(a)gmail.com>: >>> On Mon, Aug 22, 2011 at 8:23 PM, Madhura Jayaratne <madhura.cj(a)gmail.com> wrote: >>>> Hi Aris, >>>> The icon to open the date-time picker in table-insert and table-search pages >>>> has gone missing. >>>> It seems like condition if ($.datetimepicker != undefined) in function.js >>>> (line 688) is causing this. Was this condition added to prevent some JS >>>> errors or can we remove it? >>>> Also, the date-time picker does not seem to display the month anywhere or >>>> change the year at the top when the arrows on either side of it are clicked. >>>> >>> >>> Piotr added this line with commit >>> 84cc7837f5da69c588f7503da0acc9512ff29619, though I don't quite know >>> why. >>> >> >> I was seeing a JS error on server Status page, because the script was >> trying to use $.datepicker which is there loaded on demand: .datefield >> and .datetimefield elements exist there but they should be initialized >> only when Monitor tab is used (timepicker's .js file is then >> dynamically loaded). >> > > I think the checking should be done with "$.fn.datetimepicker" instead of "$.datetimepicker". > > And about the month and year navigator, I found that it is firstly not working after addition of PMA_formatJsVal() function by Michal. But, I'm still not sure what's wrong with this. > After investigating a bit, I found that line 99 in js_escape.lib.php should be: 97: $result .= '['; 98: foreach ($value as $id => $val) { 99: $result .= PMA_formatJsVal($val) . ","; 100: } the PMA_formatJsVal should take $val instead of $value as the parameter. -- Aris Feryanto

2 1

Re: [Phpmyadmin-devel] Date-time picker
by Aris Feryanto 22 Aug '11

22 Aug '11

On 23 Agu 2011, at 02:29, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: > 2011/8/22 Tyron Madlener <tyronx(a)gmail.com>: >> On Mon, Aug 22, 2011 at 8:23 PM, Madhura Jayaratne <madhura.cj(a)gmail.com> wrote: >>> Hi Aris, >>> The icon to open the date-time picker in table-insert and table-search pages >>> has gone missing. >>> It seems like condition if ($.datetimepicker != undefined) in function.js >>> (line 688) is causing this. Was this condition added to prevent some JS >>> errors or can we remove it? >>> Also, the date-time picker does not seem to display the month anywhere or >>> change the year at the top when the arrows on either side of it are clicked. >>> >> >> Piotr added this line with commit >> 84cc7837f5da69c588f7503da0acc9512ff29619, though I don't quite know >> why. >> > > I was seeing a JS error on server Status page, because the script was > trying to use $.datepicker which is there loaded on demand: .datefield > and .datetimefield elements exist there but they should be initialized > only when Monitor tab is used (timepicker's .js file is then > dynamically loaded). > I think the checking should be done with "$.fn.datetimepicker" instead of "$.datetimepicker". And about the month and year navigator, I found that it is firstly not working after addition of PMA_formatJsVal() function by Michal. But, I'm still not sure what's wrong with this. -- Aris Feryanto

1 0

[Phpmyadmin-devel] Date-time picker
by Madhura Jayaratne 22 Aug '11

22 Aug '11

Hi Aris, The icon to open the date-time picker in table-insert and table-search pages has gone missing. It seems like condition if ($.datetimepicker != undefined) in function.js (line 688) is causing this. Was this condition added to prevent some JS errors or can we remove it? Also, the date-time picker does not seem to display the month anywhere or change the year at the top when the arrows on either side of it are clicked. -- Thanks and Regards, Madhura Jayaratne

3 2

[Phpmyadmin-devel] Prototype of new navigation
by Rouslan Placella 22 Aug '11

22 Aug '11

Hi there, I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea. I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks. Rouslan [1]: http://demo.phpmyadmin.net/gsoc-rouslan/

7 18

[Phpmyadmin-devel] Zoom-search and dates
by Marc Delisle 22 Aug '11

22 Aug '11

Ammar, Zoom-search of date values needs improvement. Here is an example table: CREATE TABLE IF NOT EXISTS `birthday` ( `id` int(11) NOT NULL AUTO_INCREMENT, `name` varchar(50) NOT NULL, `birthday` date NOT NULL, PRIMARY KEY (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=latin1 AUTO_INCREMENT=5 ; INSERT INTO `birthday` (`id`, `name`, `birthday`) VALUES (1, 'A', '1950-01-01'), (2, 'B', '1950-02-02'), (3, 'C', '1960-03-03'), (4, 'D', '2000-04-04'); Generating a plot via zoom-search show that the same time elapsed between two days (in 1950) than in ten or forty years. If you could convert these dates to a number of days (probably at the Javascript layer), the same way than in MySQL [0], you would get meaningful results. Of course you still need to display the unconverted date value. [0] http://dev.mysql.com/doc/refman/5.5/en/date-and-time-functions.html#functio… -- Marc Delisle http://infomarc.info

5 20

[Phpmyadmin-devel] Zoom-search and missing data label
by Marc Delisle 22 Aug '11

22 Aug '11

Ammar, when data label is set to none: Notice in ./tbl_zoom_select.php#373 Undefined offset: 0 -- Marc Delisle http://infomarc.info

2 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers