- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Zoom-search and missing data label
by Marc Delisle 22 Aug '11

22 Aug '11

Ammar, when data label is set to none: Notice in ./tbl_zoom_select.php#373 Undefined offset: 0 -- Marc Delisle http://infomarc.info

2 2

Re: [Phpmyadmin-devel] Grid editing and Browse foreign values
by Aris Feryanto 22 Aug '11

22 Aug '11

On 20 Agu 2011, at 22:54, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: > > On 19 Agu 2011, at 19:46, Marc Delisle <marc(a)infomarc.info> wrote: > >> Aris, >> >> in sakila.film_actor, grid editing a value of film_id and clicking >> "Browse foreign values" shows the values in another window but I can't >> pick a value and update the first window. >> >> With Edit it works fine. >> > > Hmm. Weird. It was working before. I'll look into this soon. > Fixed in my git. And I forgot to update something about grid editing: The grid editing now display a date(time) picker for datetime, date, or timestamp data type. In order to make the datetime picker work for grid editing, I replaced the js/jquery/timepicker.js by Martin Milesich [0] with a new timepicker by Trent Richardson [1]. Why? At first, I tried to display datetime picker with existing PMA_addDatePicker() function, which call a jQuery plugin function defined in js/jquery/timepicker.js. But, it didn't work. I need to append the datetime picker inside the "edit area", while it must update the selected date & time in the input box outside the edit area. It seems that the previous datetime picker cannot handle this case. Then, I opened link [0] and found the statement written by the author: "I would not recommend you to use this plugin because you may end up hitting your head against the wall. Instead, use the timepicker plugin from Trent Richardson." Then, I tried to use the new timepicker and it works! :) The new plugin also quite similar with the previous, so I only need to change a little amount of code in PMA_addDatePicker() function. -- Aris Feryanto

2 1

[Phpmyadmin-devel] top_panel.png
by Dieter Adriaenssens 22 Aug '11

22 Aug '11

Hi, Yesterday I was testing Piotr's branch and when visiting the Plugins page with Chrome, pma_homme theme, some image was not loaded : images/top_panel.png With Firefox or with the previous default theme, there was no problem. -- Groetjes, Dieter Adriaenssens

3 2

[Phpmyadmin-devel] "Monitor" broken in master
by Rouslan Placella 22 Aug '11

22 Aug '11

Tyron, The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure. Rouslan

3 7

[Phpmyadmin-devel] Grid editing and Browse foreign values
by Marc Delisle 20 Aug '11

20 Aug '11

Aris, in sakila.film_actor, grid editing a value of film_id and clicking "Browse foreign values" shows the values in another window but I can't pick a value and update the first window. With Edit it works fine. -- Marc Delisle http://infomarc.info

2 1

Re: [Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Operations -> table options
by Thilanka Kaushalya 20 Aug '11

20 Aug '11

Hi Marc, > 2. For "*Table options*" if I add the ajax behavior to submit the > > form without reloading the page I may need to replace all the > > table parameters which are currently embedded with the "*href*" > > attributes in the whole page. As an example it I change the table > > name from "actor" to "actor1" using "*Table options*" I may need > > to change the "*href*" of all four links in "*Table maintenance*" > > and "*Delete data or table*" to actor1 by using ajax. Is it okay > > to do that. > > Yes. > I tried to work with this feature. I faces following problems with that. 1. Currently the logic is handled under the "*if (isset($_REQUEST['submitoptions']))*" section in tbl_operations.php file. If I apply the ajax submission which submits the form without reloading the page, to this form I need to get the whole form as the response for the submission and replace it with the current form, because we don't know what values get changed. For getting the form as a response I need to get the html content of the updated "*Table operations*", so it will not be a small json response like in other cases (ex: in "Alter table oder by" ajax submission it retrieves a small json response with the message). So it will be costly for the operation. 2. Then if we used this form to rename the table (ex: "actor" to "actor1") we need to change each an every place where we use the actor name such as links in Top menu container, hidden fields in all the form within this page which carries the table name (ex: <input type="hidden" name="table" value="actor">. If not we have to replace whole page with the update page using ajax, but this is costly. So I think it is better to leave this option with the normal form submission without converting it to ajax submission. What is your idea on that. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

2 7

Re: [Phpmyadmin-devel] Grid editing and escaping
by Aris Feryanto 19 Aug '11

19 Aug '11

On 19 Agu 2011, at 20:37, Marc Delisle <marc(a)infomarc.info> wrote: > Michal Čihař a écrit : >> Hi >> >> Dne Fri, 19 Aug 2011 08:20:45 -0400 >> Marc Delisle <marc(a)infomarc.info> napsal(a): >> >>> Michal Čihař a écrit : >>>> Hi >>>> >>>> Dne Fri, 19 Aug 2011 08:00:31 -0400 >>>> Marc Delisle <marc(a)infomarc.info> napsal(a): >>>> >>>>> Aris Feryanto a écrit : >>>>>> On 19 Agu 2011, at 15:36, Aris Feryanto <aris_feryanto(a)yahoo.com> >>>>>> wrote: >>>>>> >>>>>>> Hi Michal, >>>>>>> >>>>>>>> From: Michal Čihař <michal(a)cihar.com> >>>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> it looks like grid editing does not properly handle escaping HTML >>>>>>>> entities. Just try importing test/test_data/exploit_test.sql and >>>>>>>> edit any row in exploit_test.evil_content. >>>>>>>> >>>>>>> Thank you for pointing this out. I fixed this in my git. >>>>> Ok but I believe I've seen a recent commit by Michal that fixed this >>>>> kind of problem in a quicker way; it was about using .html(x) instead of >>>>> .text(x) or the reverse :) >>>>> >>>>> Michal, can you enlighten us? >>>> It was on security list for inline editing :-). >>> It was not a commit? >> >> No, because I was totally unsure about it. Herman has reviewed itand >> pushed it to MAINT_3_4_4-security about hour ago. > > Right, I should buy more RAM for my brain. > > Aris, could you make some tests to see if this technique could replace > your new escaping function PMA_htmlEncode()? > > Instead of > $somejQueryObject.html(new_html); > > use > $somejQueryObject.text(new_html); > Right, Marc. When I was fixing this bug, I decided to use above technique to handle the HTML escaping. I just forgot to push my commits that removed the PMA_htmlEncode function. But, since .text() cannot handle new line reliably [0], the new lines in grid edited cells may disappear for some browsers. I googled to find a solution for this, but cannot find the best cross-browser solution. [0] http://api.jquery.com/text/ : (Due to variations in the HTML parsers in different browsers, the text returned may vary in newlines and other white space.) -- Aris Feryanto

2 1

Re: [Phpmyadmin-devel] Grid editing and escaping
by Aris Feryanto 19 Aug '11

19 Aug '11

On 19 Agu 2011, at 15:36, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: > Hi Michal, > >> From: Michal Čihař <michal(a)cihar.com> >> >> Hi >> >> it looks like grid editing does not properly handle escaping HTML >> entities. Just try importing test/test_data/exploit_test.sql and edit >> any row in exploit_test.evil_content. >> > > Thank you for pointing this out. I fixed this in my git. > I also change the way of grid editing a bit. For normal text, the grid editing is shown without 'edit area' (bigger editing area under the edited cell) anymore. I think this is better than having two input field for one edited cell. -- Aris Feryanto

3 5

[Phpmyadmin-devel] Zoom-search and panning feature
by Ammar Yasir 19 Aug '11

19 Aug '11

Hi, I guess there is no inbuilt panning feature available for Highcharts yet. I also looked around in the Highstock demos (which has pan feature) on whether we can use the feature from there. The problem is that the zoom feature in Highcharts uses the click and drag mouse wheel event, so we cant use those events for pan as Highstock does. If we want to have a pan feature with inbuilt zoom of Highcharts, we would have to use a button panel or similar. Otherwise write our own zoom and pan feature?

4 9

[Phpmyadmin-devel] Browse foreign values in table search
by Madhura Jayaratne 19 Aug '11

19 Aug '11

Hi Ammar, 'Browse foreign values' in table search does not seem to work correctly. Although you can browser foreign values in the newly opened window, it does not enter the value being selected. Id of the field seems to cause this and I'm not sure why there are two id s (line 182/183 and 187/188 of table_select.lib.php). Could you please have a look at it. -- Thanks and Regards, Madhura Jayaratne

1 0