[Phpmyadmin-devel] ideas / concerns / problems [about|with] user settings feature
Hi, I have few things that I want to discuss. I see some of the settings do not have their own user interface to edit them such as “PropertiesIconic”. I might have to change plans about implementing separate user interfaces for each settings, as they virtually do not exist for some of them. I am beginning to feel like this project is not just about having a feature to store settings permanently, but also providing users an interface to change those settings that they were not able to do so before because of not having access to config files on the server. I see all of the settings (currently under consideration) also have configuration options in ./libraries/config.default.php. Are these configs only there for initial installation purpose? What would happen if sysadmins change value for these options? Will these new settings override those stored in DB? Would it not be a decent idea to simply apply user settings to relative vars in ./libraries/config.default.php by extracting them from db? May be also have a mechanism to allow sysadmins to override DB stored settings? I see there are several settings in ./libraries/config.default.php that can easily be imported to permanent settings user interface. Is there a limit on the number of settings that can have a place in the central admin interface due to performance, or some other issues? *Now, some coding questions:* Following UPDATE query does not happen to perform any change to the table: PMA_DBI_try_query("UPDATE pma_perm_usr_pref SET maxRows = 20 WHERE username = root") And following SELECT query actually gives me a rather weird result: PMA_DBI_try_query("SELECT maxRows FROM pma_perm_usr_pref WHERE username = root") results in: *Resource Id #61 *Of course, changeable values are not hard-coded in the actual script. :) Is there something wrong with the sql query? For the later, I tried adding $link ( = PMA_DBI_select_db($cfg['Servers'][1]['pmadb']) ) parameter just to test if not having it was the problem. But, no luck. Well, this brings me to my last question. For now, I am manually setting $i equal to 1. Is there a way to extract this server parameter from some automatically generated script? Thank so much! Your help is much appreciated! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info
Zeeshan Mughal a écrit :
Hi,
I have few things that I want to discuss.
I see some of the settings do not have their own user interface to edit them such as “PropertiesIconic”. I might have to change plans about implementing separate user interfaces for each settings, as they virtually do not exist for some of them. I am beginning to feel like this project is not just about having a feature to store settings permanently, but also providing users an interface to change those settings that they were not able to do so before because of not having access to config files on the server.
If you have a look at http://wiki.phpmyadmin.net/pma/SummerOfCode2009IdeasList#User_Preferences you'll see that this was exactly what was asked for this project: "Some configuration parameters do not have an impact on security or performance; it would be interesting if each end-user of a shared PMA installation could change them on-the-fly and store these in pmadb."
I see all of the settings (currently under consideration) also have configuration options in ./libraries/config.default.php. Are these configs only there for initial installation purpose? What would happen if sysadmins change value for these options? Will these new settings override those stored in DB?
These configs will have to stay there )in the config.default.php + config.inc.php) because the userprefs feature might be not available. IMO, as the parameters chosen to be part of userprefs should not have an impact on security or performance, the value set by each user will override the one set in the general config file.
Would it not be a decent idea to simply apply user settings to relative vars in ./libraries/config.default.php by extracting them from db? May be also have a mechanism to allow sysadmins to override DB stored settings?
Please give an example where this override would be needed.
I see there are several settings in ./libraries/config.default.php that can easily be imported to permanent settings user interface. Is there a limit on the number of settings that can have a place in the central admin interface due to performance, or some other issues?
This will have to be tested when we have an implementation prototype to test.
/Now, some coding questions:/
Following UPDATE query does not happen to perform any change to the table:
PMA_DBI_try_query("UPDATE pma_perm_usr_pref SET maxRows = 20 WHERE username = root")
Here, username is a column name and root is ... a column name?
And following SELECT query actually gives me a rather weird result:
PMA_DBI_try_query("SELECT maxRows FROM pma_perm_usr_pref WHERE username = root")
Same question. I think you forgot to quote the constant you are using.
results in: /Resource Id #61
/Of course, changeable values are not hard-coded in the actual script. :) Is there something wrong with the sql query?
For the later, I tried adding $link ( = PMA_DBI_select_db($cfg['Servers'][1]['pmadb']) ) parameter just to test if not having it was the problem. But, no luck.
Use $GLOBALS['cfg']['Server']['pmadb'].
Well, this brings me to my last question. For now, I am manually setting $i equal to 1. Is there a way to extract this server parameter from some automatically generated script?
Thank so much! Your help is much appreciated!
-- Marc Delisle http://infomarc.info
*If you have a look at http://wiki.phpmyadmin.net/pma/SummerOfCode2009IdeasList#User_Preferences you'll see that this was exactly what was asked for this project: "Some configuration parameters do not have an impact on security or performance; it would be interesting if each end-user of a shared PMA installation could change them on-the-fly and store these in pmadb." * haha. I just can't help making more trouble for myself with nifty ideas. I think there were crazier ideas in my initial pitch back in April, here's my abstract: Keeping track of past experiences to assist the user effectively manage the MySQL database server using phpMyAdmin web interface. If a user selects a certain database as he first logs in to the system, this user preference will be performed automatically after the script intelligently decides that this is user's preferred destination. Users will have options to change the automated settings if they wish to. A set number of these automated configurations will be designed to assist the user. Sounds really interesting. ;) *
Would it not be a decent idea to simply apply user settings to relative vars in ./libraries/config.default.php by extracting them from db? May be also have a mechanism to allow sysadmins to override DB stored settings?
Please give an example where this override would be needed. * I think I was confusing it with something else. *Here are my notes on the code that I have written so far:* - I have commented out user settings interface for "Default Language" as only one of the languages show up in the drop down menu. And when I hit submit that language is set to default for some weird reasons. - The current value of a setting will be selected on page load in drop down menu element, and it will be printed in text box input. The mechanism is a bit confusing, and I will work on it first thing tomorrow morning. Any suggestions to deal with this problem differently? - need to define an additional method in sql driver class to select all of the settings' values at once - need to implement a sophisticated interface to handle errors - SQL query still does not produce expected result. I am wondering I need to link queries with server, but I was not able to figure out how to extract link to connection server. - I see that some of the configuration settings can simple be changed through ./libraries/config.default.php such as PropertiesIconic. I am wondering that these settings are directly extracted from config file. So, in this case, may be create a new config file to set these settings. Thanks! P.S. Please bear with me if there is a confusion. I don't drink coffee, or coke to keep myself awake. I am an all-time water drinker. -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Sat, Jul 18, 2009 at 6:07 AM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan Mughal a écrit :
Hi,
I have few things that I want to discuss.
I see some of the settings do not have their own user interface to edit them such as “PropertiesIconic”. I might have to change plans about implementing separate user interfaces for each settings, as they virtually do not exist for some of them. I am beginning to feel like this project is not just about having a feature to store settings permanently, but also providing users an interface to change those settings that they were not able to do so before because of not having access to config files on the server.
If you have a look at http://wiki.phpmyadmin.net/pma/SummerOfCode2009IdeasList#User_Preferences you'll see that this was exactly what was asked for this project:
"Some configuration parameters do not have an impact on security or performance; it would be interesting if each end-user of a shared PMA installation could change them on-the-fly and store these in pmadb."
I see all of the settings (currently under consideration) also have configuration options in ./libraries/config.default.php. Are these configs only there for initial installation purpose? What would happen if sysadmins change value for these options? Will these new settings override those stored in DB?
These configs will have to stay there )in the config.default.php + config.inc.php) because the userprefs feature might be not available.
IMO, as the parameters chosen to be part of userprefs should not have an impact on security or performance, the value set by each user will override the one set in the general config file.
Would it not be a decent idea to simply apply user settings to relative vars in ./libraries/config.default.php by extracting them from db? May be also have a mechanism to allow sysadmins to override DB stored
settings?
Please give an example where this override would be needed.
I see there are several settings in ./libraries/config.default.php that can easily be imported to permanent settings user interface. Is there a limit on the number of settings that can have a place in the central admin interface due to performance, or some other issues?
This will have to be tested when we have an implementation prototype to test.
/Now, some coding questions:/
Following UPDATE query does not happen to perform any change to the
table:
PMA_DBI_try_query("UPDATE pma_perm_usr_pref SET maxRows = 20 WHERE username = root")
Here, username is a column name and root is ... a column name?
And following SELECT query actually gives me a rather weird result:
PMA_DBI_try_query("SELECT maxRows FROM pma_perm_usr_pref WHERE username = root")
Same question. I think you forgot to quote the constant you are using.
results in: /Resource Id #61
/Of course, changeable values are not hard-coded in the actual script. :) Is there something wrong with the sql query?
For the later, I tried adding $link ( = PMA_DBI_select_db($cfg['Servers'][1]['pmadb']) ) parameter just to test if not having it was the problem. But, no luck.
Use $GLOBALS['cfg']['Server']['pmadb'].
Well, this brings me to my last question. For now, I am manually setting $i equal to 1. Is there a way to extract this server parameter from some automatically generated script?
Thank so much! Your help is much appreciated!
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. a écrit :
_Here are my notes on the code that I have written so far:_
- I have commented out user settings interface for "Default Language" as only one of the languages show up in the drop down menu. And when I hit submit that language is set to default for some weird reasons.
- The current value of a setting will be selected on page load in drop down menu element, and it will be printed in text box input. The mechanism is a bit confusing, and I will work on it first thing tomorrow morning. Any suggestions to deal with this problem differently?
- need to define an additional method in sql driver class to select all of the settings' values at once
- need to implement a sophisticated interface to handle errors We already have error handling code, look at the existing phpMyAdmin code for $cfg['Error_Handler'].
- SQL query still does not produce expected result. I am wondering I need to link queries with server, but I was not able to figure out how to extract link to connection server.
The standard way of accessing the pmadb is via PMA_query_as_controluser().
- I see that some of the configuration settings can simple be changed through ./libraries/config.default.php such as PropertiesIconic. I am wondering that these settings are directly extracted from config file. So, in this case, may be create a new config file to set these settings.
What is you plan with the font size setting? It's already taken care of, on the main page. For the default language, I don't think that this is much needed, as the current language selectors work well and are able to detect the browser's defined language. The CSS should go into the themes and not directly in scripts. -- Marc Delisle http://infomarc.info
*What is you plan with the font size setting? It's already taken care of, on the main page. For the default language, I don't think that this is much needed, as the current language selectors work well and are able to detect the browser's defined language.* Yes, this is what I have was recently thinking. Since, the original goals of the project are very clear to me know I don't think there is need to have interfaces for default language, font size, and max rows etc. I think I was confusing what I was originally supposed to do (which also happens to be much simpler) with something I read in your book about "permanent storage" feature. Can you please elaborate on this if it is related to my project, and in what way? Thank you! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Mon, Jul 20, 2009 at 5:04 AM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
_Here are my notes on the code that I have written so far:_
- I have commented out user settings interface for "Default Language" as only one of the languages show up in the drop down menu. And when I hit submit that language is set to default for some weird reasons.
- The current value of a setting will be selected on page load in drop down menu element, and it will be printed in text box input. The mechanism is a bit confusing, and I will work on it first thing tomorrow morning. Any suggestions to deal with this problem differently?
- need to define an additional method in sql driver class to select all of the settings' values at once
- need to implement a sophisticated interface to handle errors We already have error handling code, look at the existing phpMyAdmin code for $cfg['Error_Handler'].
- SQL query still does not produce expected result. I am wondering I need to link queries with server, but I was not able to figure out how to extract link to connection server.
The standard way of accessing the pmadb is via PMA_query_as_controluser().
- I see that some of the configuration settings can simple be changed through ./libraries/config.default.php such as PropertiesIconic. I am wondering that these settings are directly extracted from config file. So, in this case, may be create a new config file to set these settings.
What is you plan with the font size setting? It's already taken care of, on the main page.
For the default language, I don't think that this is much needed, as the current language selectors work well and are able to detect the browser's defined language.
The CSS should go into the themes and not directly in scripts.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. a écrit :
/What is you plan with the font size setting? It's already taken care of, on the main page.
For the default language, I don't think that this is much needed, as the current language selectors work well and are able to detect the browser's defined language./
Yes, this is what I have was recently thinking. Since, the original goals of the project are very clear to me know I don't think there is need to have interfaces for default language, font size, and max rows etc.
Huh? I was only writing about font size and default language selector. Max rows and (probably) the other settings you were addressing in your sample code, should go to user preferences.
I think I was confusing what I was originally supposed to do (which also happens to be much simpler) with something I read in your book about "permanent storage" feature. Can you please elaborate on this if it is related to my project, and in what way?
"User preferences in permanent storage" means that they are stored in a place more permanent than in session. As we don't want to bloat the cookies, the chosen place is a user preferences in pmadb, which is the project on which you are working. -- Marc Delisle http://infomarc.info
*Huh? I was only writing about font size and default language selector. Max rows and (probably) the other settings you were addressing in your sample code, should go to user preference * Since, max_rows also has its own interface I thought it is unrelated to the project. But I will include it, though. -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Mon, Jul 20, 2009 at 1:53 PM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
/What is you plan with the font size setting? It's already taken care of, on the main page.
For the default language, I don't think that this is much needed, as the current language selectors work well and are able to detect the browser's defined language./
Yes, this is what I have was recently thinking. Since, the original goals of the project are very clear to me know I don't think there is need to have interfaces for default language, font size, and max rows etc.
Huh? I was only writing about font size and default language selector. Max rows and (probably) the other settings you were addressing in your sample code, should go to user preferences.
I think I was confusing what I was originally supposed to do (which also happens to be much simpler) with something I read in your book about "permanent storage" feature. Can you please elaborate on this if it is related to my project, and in what way?
"User preferences in permanent storage" means that they are stored in a place more permanent than in session. As we don't want to bloat the cookies, the chosen place is a user preferences in pmadb, which is the project on which you are working.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. a écrit :
/Huh? I was only writing about font size and default language selector. Max rows and (probably) the other settings you were addressing in your sample code, should go to user preference / Since, max_rows also has its own interface I thought it is unrelated to the project. But I will include it, though.
Having an interface is not the same thing as a persistent preference. Font size is persistent (in cookie), language is first auto-detected then stored in cookie. Maximum rows is persistent per table, only for the working session (logout and you lose your choice). And as you know, other parameters in config file are not on the interface but should be. -- Marc Delisle http://infomarc.info
I have a concern about where to place the link to usr pref interface. It is currently placed on the homepage, but my understanding is that it is actually a place for links to server configuration pages. The interface I am working on is for all users on the server, so I was wondering may be it would be a good idea to have it somewhere else. May be in the left navigation bar along with links to docs, home page, sql query interface etc. If this is the case, can you please tell me which file I specially have to edit to place an icon being linked to user prefs interface. I think it should open as a pop-up just link sql query interface. Later on, I can also use a JS library to enhance user experience. But for now, I will focus on main goal of the project. Thanks! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Mon, Jul 20, 2009 at 2:29 PM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
/Huh? I was only writing about font size and default language selector. Max rows and (probably) the other settings you were addressing in your sample code, should go to user preference / Since, max_rows also has its own interface I thought it is unrelated to the project. But I will include it, though.
Having an interface is not the same thing as a persistent preference.
Font size is persistent (in cookie), language is first auto-detected then stored in cookie. Maximum rows is persistent per table, only for the working session (logout and you lose your choice).
And as you know, other parameters in config file are not on the interface but should be.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. a écrit :
I have a concern about where to place the link to usr pref interface.
It is currently placed on the homepage, but my understanding is that it is actually a place for links to server configuration pages.
The interface I am working on is for all users on the server, so I was wondering may be it would be a good idea to have it somewhere else. May be in the left navigation bar along with links to docs, home page, sql query interface etc.
If this is the case, can you please tell me which file I specially have to edit to place an icon being linked to user prefs interface. I think it should open as a pop-up just link sql query interface. Later on, I can also use a JS library to enhance user experience. But for now, I will focus on main goal of the project.
Thanks!
The HTML source code of the page tells you that the source for this frame is navigation.php. -- Marc Delisle http://infomarc.info
Hi, Thanks so much for all the help. :-) - Using PMA_query_as_controluser() gives me "undefined method" error. I am using PMA_DBI_fetch_result() instead which seems to work OK. - I have created a readme file, which, for now contains dummy data for pma_perm_usr_pref table. - I will include the link to usr setting interface in navigation.php, and remove it from main homepage later on. For now, I want to focus on implementing back-end logic for the form. - I put the custom CSS code I wrote in all three CSS files in /themes/original/css/ directory but it did not seem to be working. So, I have included back the CSS code into the original file, too. - All current values of settings are stored in vars in the following format: $current_[setting_name] after being extracted from the database. I was initially thinking about using JS to select the current value by default. My implementation required looking up index of the "current value" (extracted from db) in select menu. I hope it it possible, but I could not find a away to accomplish it. In an ideal case, if I know the index, I can apply 'selected="selected"' attribute to that specific option. Any other suggestions, please? - My most recent plan for this project included having a submit for each setting along with the submit to update all the settings. I originally thought about it as I was thinking it would be a better user interaction practice. But now I am thinking it might complicate things for the user if he sees multiple submit button. May be having some nifty little image next to each setting, and using AJAX to update the setting will do justice to users. Well, for now, there is only one submit button that would update all settings. I am projecting that I may be able to complete the front-end user interface, and back-end logic to fetch and update settings by the end of this week. Hopefully, if goals are accomplished, I will move on to implementing AJAX for an enhanced user interaction and experience, which may take about half of a week. If things go according to plans, hopefully, I may work on the auto table update feature for tables in phpmyadmin database you expected me to do. I really find this project very interesting, and I think it will be a worthwhile learning experience. I am also attaching the most recent version of patch. There is not much development in terms of processing user input. But it might be of some use. Thanks! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Mon, Jul 20, 2009 at 3:49 PM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
I have a concern about where to place the link to usr pref interface.
It is currently placed on the homepage, but my understanding is that it is actually a place for links to server configuration pages.
The interface I am working on is for all users on the server, so I was wondering may be it would be a good idea to have it somewhere else. May be in the left navigation bar along with links to docs, home page, sql query interface etc.
If this is the case, can you please tell me which file I specially have to edit to place an icon being linked to user prefs interface. I think it should open as a pop-up just link sql query interface. Later on, I can also use a JS library to enhance user experience. But for now, I will focus on main goal of the project.
Thanks!
The HTML source code of the page tells you that the source for this frame is navigation.php.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. a écrit :
Hi,
Thanks so much for all the help. :-)
- Using PMA_query_as_controluser() gives me "undefined method" error. I am using PMA_DBI_fetch_result() instead which seems to work OK.
Not acceptable, as it won't work when the logged-in user has no access to the pmadb. There is a reason why it's undefined: you did not include the library file where this is defined.
- I have created a readme file, which, for now contains dummy data for pma_perm_usr_pref table.
- I will include the link to usr setting interface in navigation.php, and remove it from main homepage later on. For now, I want to focus on implementing back-end logic for the form.
- I put the custom CSS code I wrote in all three CSS files in /themes/original/css/ directory but it did not seem to be working. So, I have included back the CSS code into the original file, too.
Maybe it did not work because you did not clear your browser cache.
- All current values of settings are stored in vars in the following format: $current_[setting_name] after being extracted from the database. I was initially thinking about using JS to select the current value by default. My implementation required looking up index of the "current value" (extracted from db) in select menu. I hope it it possible, but I could not find a away to accomplish it. In an ideal case, if I know the index, I can apply 'selected="selected"' attribute to that specific option. Any other suggestions, please?
- My most recent plan for this project included having a submit for each setting along with the submit to update all the settings. I originally thought about it as I was thinking it would be a better user interaction practice. But now I am thinking it might complicate things for the user if he sees multiple submit button. May be having some nifty little image next to each setting, and using AJAX to update the setting will do justice to users. Well, for now, there is only one submit button that would update all settings.
When you edit a row in phpMyAdmin and you submit, there is logic that checks which column has been changed and updates only what is needed.
I am projecting that I may be able to complete the front-end user interface, and back-end logic to fetch and update settings by the end of this week. Hopefully, if goals are accomplished, I will move on to implementing AJAX for an enhanced user interaction and experience, which may take about half of a week.
How many settings do you plan to cover?
If things go according to plans, hopefully, I may work on the auto table update feature for tables in phpmyadmin database you expected me to do. I really find this project very interesting, and I think it will be a worthwhile learning experience.
I am also attaching the most recent version of patch. There is not much development in terms of processing user input. But it might be of some use.
Please put your patches on phpMyAdmin's patch tracker instead of sending them on this list.
Thanks!
-
-- Marc Delisle http://infomarc.info
*When you edit a row in phpMyAdmin and you submit, there is logic that checks which column has been changed and updates only what is needed. * Is there any example in pma codebase I can use it for reference? *How many settings do you plan to cover? * I plan the cover all the settings that are currently under consideration. As you said, we can include more settings after we have a test prototype. I was wondering how settings such as PropertiesIconic are applied. I was able to change it manually, so is it directly read from config file each time? Also, I was wondering what are your thoughts above moving the link to user prefs interface in navigation.php? Thanks! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Tue, Jul 21, 2009 at 4:19 AM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
Hi,
Thanks so much for all the help. :-)
- Using PMA_query_as_controluser() gives me "undefined method" error. I am using PMA_DBI_fetch_result() instead which seems to work OK.
Not acceptable, as it won't work when the logged-in user has no access to the pmadb. There is a reason why it's undefined: you did not include the library file where this is defined.
- I have created a readme file, which, for now contains dummy data for pma_perm_usr_pref table.
- I will include the link to usr setting interface in navigation.php, and remove it from main homepage later on. For now, I want to focus on implementing back-end logic for the form.
- I put the custom CSS code I wrote in all three CSS files in /themes/original/css/ directory but it did not seem to be working. So, I have included back the CSS code into the original file, too.
Maybe it did not work because you did not clear your browser cache.
- All current values of settings are stored in vars in the following format: $current_[setting_name] after being extracted from the database. I was initially thinking about using JS to select the current value by default. My implementation required looking up index of the "current value" (extracted from db) in select menu. I hope it it possible, but I could not find a away to accomplish it. In an ideal case, if I know the index, I can apply 'selected="selected"' attribute to that specific option. Any other suggestions, please?
- My most recent plan for this project included having a submit for each setting along with the submit to update all the settings. I originally thought about it as I was thinking it would be a better user interaction practice. But now I am thinking it might complicate things for the user if he sees multiple submit button. May be having some nifty little image next to each setting, and using AJAX to update the setting will do justice to users. Well, for now, there is only one submit button that would update all settings.
When you edit a row in phpMyAdmin and you submit, there is logic that checks which column has been changed and updates only what is needed.
I am projecting that I may be able to complete the front-end user interface, and back-end logic to fetch and update settings by the end of this week. Hopefully, if goals are accomplished, I will move on to implementing AJAX for an enhanced user interaction and experience, which may take about half of a week.
How many settings do you plan to cover?
If things go according to plans, hopefully, I may work on the auto table update feature for tables in phpmyadmin database you expected me to do. I really find this project very interesting, and I think it will be a worthwhile learning experience.
I am also attaching the most recent version of patch. There is not much development in terms of processing user input. But it might be of some
use.
Please put your patches on phpMyAdmin's patch tracker instead of sending them on this list.
Thanks!
-
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. a écrit :
/When you edit a row in phpMyAdmin and you submit, there is logic that checks which column has been changed and updates only what is needed. / Is there any example in pma codebase I can use it for reference?
I suggest you become more familiar with the code base, either by studying the links in the interface, or by following the code flow thru a debugger.
/How many settings do you plan to cover? / I plan the cover all the settings that are currently under consideration. As you said, we can include more settings after we have a test prototype.
I was wondering how settings such as PropertiesIconic are applied. I was able to change it manually, so is it directly read from config file each time?
Have a look at the code base to see which script reads config.default.php.
Also, I was wondering what are your thoughts above moving the link to user prefs interface in navigation.php?
I don't believe that this decision is important at this early stage of the implementation.
Thanks!
-- Marc Delisle http://infomarc.info
Hi, *I suggest you become more familiar with the code base, either by studying the links in the interface, or by following the code flow thru a debugger.* I am using Notepad++ for development, which I believe does not have a plugin for debugging PHP code. I know Eclipse PDT has a debugging tool for PHP, but I am not really fond of using Eclipse. I was wondering if you have any personal recommendations about it that would be awesome. * *Here are my notes: - inputs for all the settings are available on the admin interface, and all the current values (extracted from db) are selected on page load - things left out to be done in coming days: - processing form inputs - handling errors using phpmyadmin default error handler - updating settings' values in db upon form submission - changing session values for each setting; this is going to be the major part as I would have to dig into pma code base to get it done - using PMA_query_as_controluser() for querying database - when all of the above is done, it would be time to do some JSing to show off my creativity patch: http://sourceforge.net/tracker/index.php?func=detail&aid=2825187&group_id=23... Thanks! P.S. I was just wondering what does "lem9" mean? -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Tue, Jul 21, 2009 at 4:08 PM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
/When you edit a row in phpMyAdmin and you submit, there is logic that checks which column has been changed and updates only what is needed. / Is there any example in pma codebase I can use it for reference?
I suggest you become more familiar with the code base, either by studying the links in the interface, or by following the code flow thru a debugger.
/How many settings do you plan to cover? / I plan the cover all the settings that are currently under consideration. As you said, we can include more settings after we have a test prototype.
I was wondering how settings such as PropertiesIconic are applied. I was able to change it manually, so is it directly read from config file each time?
Have a look at the code base to see which script reads config.default.php.
Also, I was wondering what are your thoughts above moving the link to user prefs interface in navigation.php?
I don't believe that this decision is important at this early stage of the implementation.
Thanks!
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Zeeshan M. a écrit :
Hi,
/I suggest you become more familiar with the code base, either by studying the links in the interface, or by following the code flow thru a debugger./
I am using Notepad++ for development, which I believe does not have a plugin for debugging PHP code. I know Eclipse PDT has a debugging tool for PHP, but I am not really fond of using Eclipse. I was wondering if you have any personal recommendations about it that would be awesome.
There were many suggestions on this list a few days ago; I don't have a personal recommendation.
P.S. I was just wondering what does "lem9" mean?
The Lunar Excursion Module first landed on Moon on my 9th birthday. http://en.wikipedia.org/wiki/Apollo_Lunar_Module -- Marc Delisle http://infomarc.info
Hi, I uploaded a revision for patch # <goog_1248753684487>2825187<https://sourceforge.net/tracker/download.php?group_id=23067&atid=377410&file_id=336915&aid=2825187>at sourceforge.net. This revision can update, and read the value of PropertiesIconic setting. I see there is a minor bug when it is set to disabled, as icons also appear along with the text. I will look into it tomorrow, but I don't think it should be hard to debug. I believe since I have a model set up to follow for other settings things are going to be much better from now on. There are a few drawbacks in the form procession script that I need to consider in the future release. - I need to implement pma native error handler. - Use PMA_query_as_controluser() for querying database. I read your e-mail Marc, I will check up with the documents. (Thanks!) Also, I was wondering what are your thoughts about test cases for the following settings: - Maximum Table List has to be > 0 - Login Cookie Validity has to be > 0 - Maximum Database List has to be > 0 - Properties Number Columns has to be > 0 - Foreign Key Maximum Limit has to be > 0 - Navigation Width has to be > 0 Of course, all of them also have to be numeric. Please provide your generous feedback! Thank you! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Wed, Jul 22, 2009 at 3:51 AM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
Hi,
/I suggest you become more familiar with the code base, either by studying the links in the interface, or by following the code flow thru a debugger./
I am using Notepad++ for development, which I believe does not have a plugin for debugging PHP code. I know Eclipse PDT has a debugging tool for PHP, but I am not really fond of using Eclipse. I was wondering if you have any personal recommendations about it that would be awesome.
There were many suggestions on this list a few days ago; I don't have a personal recommendation.
P.S. I was just wondering what does "lem9" mean?
The Lunar Excursion Module first landed on Moon on my 9th birthday. http://en.wikipedia.org/wiki/Apollo_Lunar_Module
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Can anyone please provide their feedback? Thanks! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Tue, Jul 28, 2009 at 3:24 AM, Zeeshan M. <zeeshan.jp@gmail.com> wrote:
Hi,
I uploaded a revision for patch # <http://goog_1248753684487>2825187<https://sourceforge.net/tracker/download.php?group_id=23067&atid=377410&file_id=336915&aid=2825187>at sourceforge.net.
This revision can update, and read the value of PropertiesIconic setting. I see there is a minor bug when it is set to disabled, as icons also appear along with the text. I will look into it tomorrow, but I don't think it should be hard to debug. I believe since I have a model set up to follow for other settings things are going to be much better from now on.
There are a few drawbacks in the form procession script that I need to consider in the future release.
- I need to implement pma native error handler. - Use PMA_query_as_controluser() for querying database. I read your e-mail Marc, I will check up with the documents. (Thanks!)
Also, I was wondering what are your thoughts about test cases for the following settings:
- Maximum Table List has to be > 0 - Login Cookie Validity has to be > 0 - Maximum Database List has to be > 0 - Properties Number Columns has to be > 0 - Foreign Key Maximum Limit has to be > 0 - Navigation Width has to be > 0
Of course, all of them also have to be numeric.
Please provide your generous feedback!
Thank you!
-------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info
On Wed, Jul 22, 2009 at 3:51 AM, Marc Delisle <marc@infomarc.info> wrote:
Zeeshan M. a écrit :
Hi,
/I suggest you become more familiar with the code base, either by studying the links in the interface, or by following the code flow thru a debugger./
I am using Notepad++ for development, which I believe does not have a plugin for debugging PHP code. I know Eclipse PDT has a debugging tool for PHP, but I am not really fond of using Eclipse. I was wondering if you have any personal recommendations about it that would be awesome.
There were many suggestions on this list a few days ago; I don't have a personal recommendation.
P.S. I was just wondering what does "lem9" mean?
The Lunar Excursion Module first landed on Moon on my 9th birthday. http://en.wikipedia.org/wiki/Apollo_Lunar_Module
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Dne Tue, 28 Jul 2009 03:24:25 -0400 "Zeeshan M." <zeeshan.jp@gmail.com> napsal(a):
I uploaded a revision for patch # <goog_1248753684487>2825187<https://sourceforge.net/tracker/download.php?group_id=23067&atid=377410&file_id=336915&aid=2825187>at sourceforge.net.
Why do you introduce syntax errors (calendar.php)? Why do you change config defaults (libraries/config.default.php)? Why do you duplicate lot of information in permUsrPref class (user name, table name, database link,...)? In server_perm_storage.php there is a huge code duplication, please have just one piece code to handle setting the value and do not copy it for every available option. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
Hi, * Why do you introduce syntax errors (calendar.php)? * I think I edited it by mistake, I'll fix it. * Why do you change config defaults (libraries/config.default.php)? * I had to set pma db var equal to "phpmyadmin" as for some reasons it was not set to "phpmyadmin" by default. * Why do you duplicate lot of information in permUsrPref class (user name, table name, database link,...)?* Such parameters are set only once in the constructor. Can you please elaborate with a minimal example what do you mean by duplication? *In server_perm_storage.php there is a huge code duplication, please have just one piece code to handle setting the value and do not copy it for every available optiofn.* I thought each setting would have different test cases, that's why I set up conditional statements separately. May be I can reduce code by generalizing test cases, but I am not sure if it would be a probable solution. What are your thoughts? Thanks! -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Wed, Jul 29, 2009 at 4:59 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Tue, 28 Jul 2009 03:24:25 -0400 "Zeeshan M." <zeeshan.jp@gmail.com> napsal(a):
I uploaded a revision for patch # <goog_1248753684487>2825187< https://sourceforge.net/tracker/download.php?group_id=23067&atid=377410&file... at sourceforge.net.
Why do you introduce syntax errors (calendar.php)?
Why do you change config defaults (libraries/config.default.php)?
Why do you duplicate lot of information in permUsrPref class (user name, table name, database link,...)?
In server_perm_storage.php there is a huge code duplication, please have just one piece code to handle setting the value and do not copy it for every available option.
-- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi please configure your mailer to quote properly (and do not use html mails), this way it is quite hard to track your replies. Dne Wed, 29 Jul 2009 13:55:52 -0400 "Zeeshan M." <zeeshan.jp@gmail.com> napsal(a):
* Why do you change config defaults (libraries/config.default.php)? * I had to set pma db var equal to "phpmyadmin" as for some reasons it was not set to "phpmyadmin" by default.
Configuration changes should go to config.inc.php, these are *defaults*.
* Why do you duplicate lot of information in permUsrPref class (user name, table name, database link,...)?*
Such parameters are set only once in the constructor. Can you please elaborate with a minimal example what do you mean by duplication?
You copy them from configuration, you should rather use directly configuration data in your code.
*In server_perm_storage.php there is a huge code duplication, please have just one piece code to handle setting the value and do not copy it for every available optiofn.*
I thought each setting would have different test cases, that's why I set up conditional statements separately. May be I can reduce code by generalizing test cases, but I am not sure if it would be a probable solution. What are your thoughts?
Having defined list of variables with descriptions and functions to call to verify input is correct. It would make code more readable even when there will be more options. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
Hi,
Configuration changes should go to config.inc.php, these are *defaults*. You copy them from configuration, you should rather use directly configuration data in your code.
Sure, I'll make these changed. :)
Having defined list of variables with descriptions and functions to call to verify input is correct. It would make code more readable even when there will be more options.
Can you also please look over the test cases to see if more restrictions can be applied -------------------------------------------------- Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org Web: http://www.zixan.info On Thu, Jul 30, 2009 at 5:20 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
please configure your mailer to quote properly (and do not use html mails), this way it is quite hard to track your replies.
Dne Wed, 29 Jul 2009 13:55:52 -0400 "Zeeshan M." <zeeshan.jp@gmail.com> napsal(a):
* Why do you change config defaults (libraries/config.default.php)? * I had to set pma db var equal to "phpmyadmin" as for some reasons it was
not
set to "phpmyadmin" by default.
Configuration changes should go to config.inc.php, these are *defaults*.
* Why do you duplicate lot of information in permUsrPref class (user name, table name, database link,...)?*
Such parameters are set only once in the constructor. Can you please elaborate with a minimal example what do you mean by duplication?
You copy them from configuration, you should rather use directly configuration data in your code.
*In server_perm_storage.php there is a huge code duplication, please have just one piece code to handle setting the value and do not copy it for every available optiofn.*
I thought each setting would have different test cases, that's why I set up conditional statements separately. May be I can reduce code by generalizing test cases, but I am not sure if it would be a probable solution. What are your thoughts?
Having defined list of variables with descriptions and functions to call to verify input is correct. It would make code more readable even when there will be more options.
-- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
participants (4)
-
Marc Delisle -
Michal Čihař -
Zeeshan M. -
Zeeshan Mughal