table export and aliases removal/replacement
Hi Dan, in tbl_export.php you wrote some logic (lines 116 to 172) that deals with aliases. Could you give a use case where this logic is important? I am asking because of https://github.com/phpmyadmin/phpmyadmin/issues/11679 and https://github.com/phpmyadmin/phpmyadmin/pull/11738 -- Marc Delisle | phpMyAdmin
Hi everyone, I am Salawu Abiodun Olagoke (Nigeria), I'm participating in the Ericsson challenge - #EIA2016. Kindly vote for my team. Steps: 1. Click the link below 2. Click 'Vote for this project' 3. Enter your email and submit (press enter on you keypad to submit) until you see voted 4. Check your email and click the link sent to you for confirmation. 5. Wait for the link to load and display success. With that, you've given us a plus one to help the city life with our innovation. If you have many email account, you can vote with them all using different browsers. (opera mini is not compatible) Thanks, God bless you. http://www.ericsson.com/thecompany/events/ericsson-innovation-awards/competi... Please rebroadcast, let this info reach all, make our dreams a reality.
I think that part of code need not be removed. An empty array is passed for replaces where actually an array of tokens is expected (I am talking about call to replaceTokens function on https://github.com/phpmyadmin/phpmyadmin/blob/master/tbl_export.php#L109). That is the reason aliases are not replaced. On Sun, Dec 13, 2015 at 11:37 PM, Marc Delisle <marc@infomarc.info> wrote:
Hi Dan,
in tbl_export.php you wrote some logic (lines 116 to 172) that deals with aliases. Could you give a use case where this logic is important? I am asking because of
https://github.com/phpmyadmin/phpmyadmin/issues/11679 and https://github.com/phpmyadmin/phpmyadmin/pull/11738
-- Marc Delisle | phpMyAdmin
_______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Hello, Basically, that code is responsible for finding and removing aliases. The old code (that I replaced) is this [1]. As far as I understand (now), aliases should only be removed from the `FROM` clause and wherever they are found in other clauses. I had a fix prepared, but exams and homework came and I did not get to work on it anymore. My last exam is on 16. If no other fix is proposed by then, I will push mine. [1] https://github.com/phpmyadmin/phpmyadmin/blob/RELEASE_4_4_15/tbl_export.php#... On Sun, Dec 13, 2015 at 8:41 PM, Raghu Ram < raghuram.vadapalli@research.iiit.ac.in> wrote:
I think that part of code need not be removed. An empty array is passed for replaces where actually an array of tokens is expected (I am talking about call to replaceTokens function on https://github.com/phpmyadmin/phpmyadmin/blob/master/tbl_export.php#L109). That is the reason aliases are not replaced.
On Sun, Dec 13, 2015 at 11:37 PM, Marc Delisle <marc@infomarc.info> wrote:
Hi Dan,
in tbl_export.php you wrote some logic (lines 116 to 172) that deals with aliases. Could you give a use case where this logic is important? I am asking because of
https://github.com/phpmyadmin/phpmyadmin/issues/11679 and https://github.com/phpmyadmin/phpmyadmin/pull/11738
-- Marc Delisle | phpMyAdmin
_______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
_______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Have you ever imagined a future city with no traffic Congestion.... Have you ever imagined a pollution-free city.... Have you ever imagined a city with little or no road accident....... Those and more are the objectives of our innovation, Kindly Support my Great Team and our Great Innovation... Good morning, I am Salawu Abiodun Olagoke (Hardware), I'm participating in the Ericsson challenge - #EIA2016. Kindly vote for my team. Steps: 1. Click the link below 2. Click 'Vote for this project' 3. Enter your email and submit (press enter on you keypad to submit) until you see voted 4. Check your email and click the link sent to you for confirmation. 5. Wait for the link to load and display success. With that, you've given us a plus one to help the city life with our innovation. If you have many email accounts, you can vote with them all using different browsers. (opera mini is not compatible) Thanks, God bless you. http://www.ericsson.com/thecompany/events/ericsson-innovation-awards/competi... Please rebroadcast, let this info reaches all, make our dreams a reality. Enjoy your day
participants (4)
-
Dan Ungureanu -
Marc Delisle -
Raghu Ram -
Salawu Abiodun