Hi Marc,
Please checkout "master" instead.
I have then re checkout the "master" and checked for the functionality of the search option.
One area that needs improvement is Database search:
- collapse/expand the "Search in database" fieldset
- separate popup when clicking on Browse in the search results, to avoid
losing the search results; the same for Delete (especially when a Delete attempt fails)
When I tried to search using PMA it gives unexpected UI panel repeating within the result window. I check it with the version 3.3.7 and in that it works fine. Here is the link which I have showed the screen shots of the results which I get. Here the "Tab navigation bar [1]" and the "Search in database[2]" panels showed twice.
https://docs.google.com/document/d/1eEEgOemO8uhkzAw_aFYOSwHDKYZeiLRPuVDjAHxx...
I'm Using Ubuntu 10.10 as the os, apache-2.2.16 as the server and using a symlink to the phpmyadmin folder and Google chrome as the browser for testing this.
Can you clarify whether this is a bug.
Are you familiar with jQuery?
Last few days I went through some jQuery tutorial and now having some basic knowledge on it. So I'm willing to start working on the improvements you have mentioned. Are there any standards which should I follow in PMA UI designing. I will start working on the task of -collapse/expand the "Search in database" fieldset. But in the -separate popup when clicking on Browse in the search results, task needs a better structure. So may I draw a wire-frame for that UI, so you can correct me if it needs any modification.
Regards, Thilanka.
lgtkaushalya@gmail.com a écrit :
Hi Marc,
Please checkout "master" instead.I have then re checkout the "master" and checked for the functionality of the search option.
One area that needs improvement is Database search: - collapse/expand the "Search in database" fieldset - separate popup when clicking on Browse in the search results, to avoid losing the search results; the same for Delete (especially when a Delete attempt fails)When I tried to search using PMA it gives unexpected UI panel repeating within the result window. I check it with the version 3.3.7 and in that it works fine. Here is the link which I have showed the screen shots of the results which I get. Here the "Tab navigation bar [1]" and the "Search in database[2]" panels showed twice.
https://docs.google.com/document/d/1eEEgOemO8uhkzAw_aFYOSwHDKYZeiLRPuVDjAHxx... https://docs.google.com/document/d/1eEEgOemO8uhkzAw_aFYOSwHDKYZeiLRPuVDjAHxx8tc/edit?hl=en&authkey=CO738scF#
I'm Using Ubuntu 10.10 as the os, apache-2.2.16 as the server and using a symlink to the phpmyadmin folder and Google chrome as the browser for testing this.
Can you clarify whether this is a bug.
I don't have this testing environment so I suggest you open a bug report at http://sourceforge.net/tracker/?atid=377408&group_id=23067 and give your screenshot reference. There have been and are other bug reports specific to Chrome.
Are you familiar with jQuery?Last few days I went through some jQuery tutorial and now having some basic knowledge on it. So I'm willing to start working on the improvements you have mentioned. Are there any standards which should I follow in PMA UI designing. I will start working on the task of -collapse/expand the "Search in database" fieldset.
Have a look at how the expand/collapse happens in table search. There are no formal written standard.
But in the -separate popup when clicking on Browse in the search results, task needs a better structure. So may I draw a wire-frame for that UI, so you can correct me if it needs any modification.
OK.
Regards, Thilanka.
Hi Marc,
I don't have this testing environment so I suggest you open a bug report
at http://sourceforge.net/tracker/?atid=377408&group_id=23067 and give your screenshot reference. There have been and are other bug reports specific to Chrome.
I have checked whether the bug has previously reported and I found not. So
I reported a bug at sourceforge.
Have a look at how the expand/collapse happens in table search. There
are no formal written standard.
I referred the table search and I have drown a wire frame for that also to make sure whether I got your idea correctly. Here is the google doc which contains the design.
https://docs.google.com/document/d/19su2WBJEm8QpOZQ-RHmrfzysfFlrBQ8XoS9EadJQ...
The intended columns were described at the doc. So please comment on the design and clarify me whether I got your idea correct.
Regards, Thilanka.
--
Marc Delisle http://infomarc.info
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-01-28 05:11, lgtkaushalya@gmail.com a écrit :
Hi Marc,
I don't have this testing environment so I suggest you open a bug report
at http://sourceforge.net/tracker/?atid=377408&group_id=23067 and give your screenshot reference. There have been and are other bug reports specific to Chrome.
I have checked whether the bug has previously reported and I found not. So
I reported a bug at sourceforge.
Have a look at how the expand/collapse happens in table search. There
are no formal written standard.
I referred the table search and I have drown a wire frame for that also to make sure whether I got your idea correctly. Here is the google doc which contains the design.
https://docs.google.com/document/d/19su2WBJEm8QpOZQ-RHmrfzysfFlrBQ8XoS9EadJQ...
The intended columns were described at the doc. So please comment on the design and clarify me whether I got your idea correct.
Regards, Thilanka.
Hi, looking at your wire frame, I fail to see how one would expand/collapse the search criteria when there are search results on-screen, which is the feature that is present in table search in current master.
Also I don't understand how the Column section would be used.
Hi Marc,
Hi, looking at your wire frame, I fail to see how one would expand/collapse the search criteria when there are search results on-screen, which is the feature that is present in table search in current master.
Also I don't understand how the Column section would be used.
I realize that I interpreted your idea in a wrong way. I saw the "Show search criteria" option just now. I got the idea well. Sorry for the inconvenience you faced. Thank you.
Regards, Thilanka.
Hi Marc,
I was successfully able to a add a "Show search criteria" link to the database search window. It works similar as the table search criteria show links. Currently I have used the link below the browse and delete options appear. This doc contains the screen shots of how it works [1].
The reason I didn't add it to the result shown window is, because I planned to combine it with my second task. That is modify the search result show window as it appear in the same page on a new panel(pop up), without directing it to a new window, as you said earlier.
- separate popup when clicking on Browse in the search results, to avoid
losing the search results; the same for Delete (especially when a Delete attempt fails)
In the creme browser there is a small toggling problem with both table search criteria and db search criteria which I have reported as [2] ID: 3168569. But this works fine with fire fox.
So please let me know if you see any issue on the above improvement. What do you prefer for applying these changes. May i send it as a whole when I finish both of them or may I send my first one right now. Thank you.
[1] - https://docs0.google.com/document/d/1wJqxndD4Ae2nW4zyR_kpPyepaX1PWqbyAlWifHn... [2] - https://sourceforge.net/tracker/?func=detail&aid=3168569&group_id=23...
Regards, Thilanka.
lgtkaushalya@gmail.com a écrit :
Hi Marc,
I was successfully able to a add a "Show search criteria" link to the database search window. It works similar as the table search criteria show links. Currently I have used the link below the browse and delete options appear. This doc contains the screen shots of how it works [1].
This is exactly what I meant.
The reason I didn't add it to the result shown window is, because I planned to combine it with my second task. That is modify the search result show window as it appear in the same page on a new panel(pop up), without directing it to a new window, as you said earlier.
- separate popup when clicking on Browse in the search results, to avoid losing the search results; the same for Delete (especially when a Delete attempt fails)
Good idea.
In the creme browser there is a small toggling problem with both table search criteria and db search criteria which I have reported as [2] ID: 3168569. But this works fine with fire fox.
Thanks.
So please let me know if you see any issue on the above improvement. What do you prefer for applying these changes. May i send it as a whole when I finish both of them or may I send my first one right now. Thank you.
Smaller commits are preferable. As mentionned on [0] "The best way to show us you are prepared is to publish your git tree (see Devel:Git) with some changes fixing bugs or implementing some improvements."
[0] http://wiki.phpmyadmin.net/pma/GSoC_2011_Applicant_Guide
Hi Marc,
I have submitted the patch to the tracker with the id 3169798 [1]. This patch only contains the modification done to adding the "Show/Hide search criteria" link to the DB_search results. Please let me know if there any issues with that
Since I'm going away from the home this week I'll not be able to work on the rest of the task until next Monday. So I'll continue with the rest in next week. Thank you.
[1] - https://sourceforge.net/tracker/?func=detail&aid=3169798&group_id=23...
Regards, Thilanka.
lgtkaushalya@gmail.com a écrit :
Hi Marc,
I have submitted the patch to the tracker with the id 3169798 [1]. This patch only contains the modification done to adding the "Show/Hide search criteria" link to the DB_search results. Please let me know if there any issues with that
Since I'm going away from the home this week I'll not be able to work on the rest of the task until next Monday. So I'll continue with the rest in next week. Thank you.
[1]
https://sourceforge.net/tracker/?func=detail&aid=3169798&group_id=23067&atid=377410
Regards, Thilanka.
Hi Thilanka, your patch has been merged to master, thanks.
Hi Marc,
I have checked for the improvement on Ajaxify the database search result browsing and and deletion operations. I have modified the browse option and loaded the search results in the same window with the search criteria done. Here is the doc which contains the screen shots of the modification [1].
But there is a little issue with that. I just used to load the same result window which gave previously by the sql.php file. So the tab navigation bar is appeared again according to the browsing table(I have showed it by [3] in the image). Without that navigation bar we cannot give the table options such as structure and import, and also if we remove the database tab navigation bar(which I showed by the [1] in the image) and replaced it with the table tab navigation bar (I have showed it by [3] in the image) we will not be able to do the database navigation options at that stage.
So I'm confusing with taking decision of removing or keeping the table tab navigation bar(I have showed it by [3] in the image) on the Ajaxified DB result panel. So can you suggest your opinions on this issue. Thank you.
[1] - https://docs.google.com/document/d/1E1Hh9BjAt741o4anw7jpIhUBh7JqrUnYfrppUE9n...
Regards, Thilanka.
Le 2011-02-05 10:42, lgtkaushalya@gmail.com a écrit :
Hi Marc,
I have checked for the improvement on Ajaxify the database search result browsing and and deletion operations. I have modified the browse option and loaded the search results in the same window with the search criteria done. Here is the doc which contains the screen shots of the modification [1].
But there is a little issue with that. I just used to load the same result window which gave previously by the sql.php file. So the tab navigation bar is appeared again according to the browsing table(I have showed it by [3] in the image). Without that navigation bar we cannot give the table options such as structure and import, and also if we remove the database tab navigation bar(which I showed by the [1] in the image) and replaced it with the table tab navigation bar (I have showed it by [3] in the image) we will not be able to do the database navigation options at that stage.
So I'm confusing with taking decision of removing or keeping the table tab navigation bar(I have showed it by [3] in the image) on the Ajaxified DB result panel. So can you suggest your opinions on this issue. Thank you.
[1] - https://docs.google.com/document/d/1E1Hh9BjAt741o4anw7jpIhUBh7JqrUnYfrppUE9n...
Regards, Thilanka.
Thilanka, this is a very good question. If we stay in the same pane, I would prefer to remove #3 (table menu tabs) because at this point, what I usually want to do is look at the data and edit it, not really start operations on this table. Probably also replace the line
localhost super_store advertisement with advertisement
However, maybe you could show a superimposed pane with the table results, keeping its menu tabs. This could be done similar to when we create a table.
Hi Marc,
Thilanka,
this is a very good question. If we stay in the same pane, I would prefer to remove #3 (table menu tabs) because at this point, what I usually want to do is look at the data and edit it, not really start operations on this table. Probably also replace the line
localhost super_store advertisement with advertisement
OK. I got the idea. I'll be update you soon. Thanks for the tip. :)
However, maybe you could show a superimposed pane with the table results, keeping its menu tabs. This could be done similar to when we create a table.
Regards, Thilanka.
Le 2011-02-05 11:37, lgtkaushalya@gmail.com a écrit :
Hi Marc,
Thilanka,
this is a very good question. If we stay in the same pane, I would prefer to remove #3 (table menu tabs) because at this point, what I usually want to do is look at the data and edit it, not really start operations on this table. Probably also replace the line
localhost super_store advertisement with advertisement
OK. I got the idea. I'll be update you soon. Thanks for the tip. :)
Others may have different opinions to submit, however...
However, maybe you could show a superimposed pane with the table results, keeping its menu tabs. This could be done similar to when we create a table.
Regards, Thilanka.
The modern datacenter depends on network connectivity to access resources and provide services. The best practices for maximizing a physical server's connectivity to a physical network are well understood - see how these rules translate into the virtual world? http://p.sf.net/sfu/oracle-sfdevnlfb
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Marc,
I worked with Ajaxify the Browse and Delete options in the database search. I have successfully finished it and tested it with the Chrome and Firefox browsers. I have submitted the patch with the ID: 3176420 [1].
This doc contains screen shots of the modifications [2] for quick reference.
Please let me know if there should be more changes on that. Thanks.
[1] - https://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=23... [2] - https://docs.google.com/document/d/1WupXl9vF-k9xcaVGzRUGbVQIag8URh82WaQlws6r...
Regards, Thilanka.
Thilanka Kaushalya a écrit :
Hi Marc,
I worked with Ajaxify the Browse and Delete options in the databasesearch. I have successfully finished it and tested it with the Chrome and Firefox browsers. I have submitted the patch with the ID: 3176420 [1].
This doc contains screen shots of the modifications [2] for quickreference.
Please let me know if there should be more changes on that. Thanks.[1] - https://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=23... https://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=23067&atid=377410 [2] - https://docs.google.com/document/d/1WupXl9vF-k9xcaVGzRUGbVQIag8URh82WaQlws6r... https://docs.google.com/document/d/1WupXl9vF-k9xcaVGzRUGbVQIag8URh82WaQlws6rgu0/edit?hl=en&authkey=CNKJ1OQL#
Regards, Thilanka.
Interesting patch, I have put my comments in the patch tracker itself.
Hi Marc,
I have miss the fact of jquery disabled user configuration when I designed the modification. So I have modified the whole db search criteria using only jquery. Thats why it is not function well under the jquery disabled configurations.
Sorry for the inconvenience you faced. I will fix those issues as soon as possible. Thank you.
Regards, Thilanka.
Thilanka Kaushalya a écrit :
Hi Marc,
I have miss the fact of jquery disabled user configuration when Idesigned the modification. So I have modified the whole db search criteria using only jquery. Thats why it is not function well under the jquery disabled configurations.
It's not jQuery-disabled configurations, it's Ajax-disabled only. Since you are using Ajax, the Browse and Delete links should not call the new code if the user runs an Ajax-disabled phpMyAdmin configuration.
Sorry for the inconvenience you faced. I will fix those issues assoon as possible. Thank you.
Regards, Thilanka.
--
http://coders-view.blogspot.com/ http://thilankagekawuluwa.blogspot.com/ http://twitter.com/thilanka_k
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Marc,
Since I was little bit busy during the last week I could not continue the AJAXify Interface modification. I will continue my works in this week.
I have contacted the Ninad Pundalik who did this project last year, for more information on the project.
Regards, Thilanka.
Hi Marc,
I have started working on your suggestions on the patch I have previously submitted[1]. In the 3rd point you have mentioned that the Browse option does not work when the ajax is disabled. 3. even when fixing #2, clicking on Browse in the search results does nothing About #3, it happens when Ajax is disabled by the user (this was my case), see $cfg['AjaxEnable']. I have set the settings to $cfg['AjaxEnable'] = false, and tested my modifications. In that case even though the Show/Hide criteria link is not shown (since ajax is disabled), *the browse results are shown correctly below the search criteria panel. *I cannot understand why it is not working on your settings. Please let me know if I should change another parameter in settings and check for the issue. There are some issues with the delete option when we disabled the Ajax on settings. I'll fix them as soon as possible. Thank you.
[1] - http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=230...
Regards, Thilanka.
Thilanka Kaushalya a écrit :
Hi Marc,
I have started working on your suggestions on the patch I have previously submitted[1]. In the 3rd point you have mentioned that the Browse option does not work when the ajax is disabled. 3. even when fixing #2, clicking on Browse in the search results does nothing About #3, it happens when Ajax is disabled by the user (this was my case), see $cfg['AjaxEnable']. I have set the settings to $cfg['AjaxEnable'] = false, and tested my modifications. In that case even though the Show/Hide criteria link is not shown (since ajax is disabled), *the browse results are shown correctly below the search criteria panel. *I cannot understand why it is not working on your settings. Please let me know if I should change another parameter in settings and check for the issue.
Thilanka, you're right. I tried again with current master + your patch (adjusted by changing "<?" with "<?php") and browse works even if AjaxEnable is false. Maybe last time I had forgotten to change one of the "<?" or had not cleared my browser cache.
However IMO it should not be working as this is an Ajax behavior and the config says that it's disabled.
Hi Marc,
I worked with fixing the issues you raised with my previous patch *ID: 3176420* [1]. I have fixed the following issues with that patch.
1. Replaced the <? tags by <? php tags, 2. Fixed the "space before tab in indent" issues and check by apply the patch. Now no such issues are shown. 3. Added the default link option to the links, so now they works for javascript disabled browsers. 4. Also works under ajax disabled settings.
I upload the parch file in to the same pace with the id *ID: 3176420* [1]. Please can you check that and comment on it. I will add the "Hide search results" and "Show search results features you suggested as soon as possible.Thank you.
[1] - https://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=23...
Regards, Thilanka.
Le 2011-02-26 00:11, Thilanka Kaushalya a écrit :
Hi Marc,
I worked with fixing the issues you raised with my previous patch *ID:3176420* [1]. I have fixed the following issues with that patch.
- Replaced the <? tags by <? php tags,
- Fixed the "space before tab in indent" issues and check by apply the
patch. Now no such issues are shown. 3. Added the default link option to the links, so now they works for javascript disabled browsers. 4. Also works under ajax disabled settings.
Thilanka, about your point 4, well the Ajax behavior should _not_ work if the user sets AjaxEnable to false.
Hi Marc,
Thilanka, about your point 4, well the Ajax behavior should _not_ work if the user sets AjaxEnable to false.
I just got the point. Thanks for the clarification and sorry for the inconvenience. I fixed it by handling it with Ajax Enabled and disabled settings with the third patch I have added to the patch ID: 3176420 [1]. I have changed the tab indentations to spaces. Please can you check the patch with these modification. Thank you.
[1] - https://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=23...
Regards, Thilanka.
Hi Marc,
Thank you applying my patch. Since I'm on my exams this week I was little bit busy with studies. So I'll develop the hide/show criteria for the search results in the next week. Since currently we have only few actions to ajaxify listed in the wiki page [1], I thought to start a google spread sheet to list the functionalities I identify which are should ajaxify. It will help me to get review those ideas from the community. Finally we can add those points to the wiki. Thank you.
[1] - http://wiki.phpmyadmin.net/pma/AJAXify_Interface
http://wiki.phpmyadmin.net/pma/AJAXify_InterfaceRegards, Thilanka.
Le 2011-03-07 09:23, Thilanka Kaushalya a écrit :
Hi Marc,
Thank you applying my patch. Since I'm on my exams this week I waslittle bit busy with studies. So I'll develop the hide/show criteria for the search results in the next week. Since currently we have only few actions to ajaxify listed in the wiki page [1], I thought to start a google spread sheet to list the functionalities I identify which are should ajaxify. It will help me to get review those ideas from the community. Finally we can add those points to the wiki. Thank you.
[1] - http://wiki.phpmyadmin.net/pma/AJAXify_Interface
http://wiki.phpmyadmin.net/pma/AJAXify_InterfaceRegards, Thilanka.
I suggest you just use this wiki page and its discussion feature, plus announcement on this list to encourage participation. Then everything will be at the same place.
Hi Marc,
I suggest you just use this wiki page and its discussion feature, plus announcement on this list to encourage participation. Then everything will be at the same place.
Thank you for the quick response. Then I'll use the same wiki page as you said.
Regards, Thilanka.
Hi Marc,
I went through some major functionalities on PMA and tried to find some actions which should really need the ajax effect. But, since some of the major functionalities are already ajaxified still I could not find such actions which should improve. So what are the areas that I should go through for finding appropriate actions. Are there any area which is previously select under Ajaxifying topic. I'll will be very helpful for me if you could direct me for a such area. Thank you.
Regards, Thilanka.
Thilanka Kaushalya a écrit :
Hi Marc,
I went through some major functionalities on PMA and tried to find some actions which should really need the ajax effect. But, since some of the major functionalities are already ajaxified still I could not find such actions which should improve. So what are the areas that I should go through for finding appropriate actions. Are there any area which is previously select under Ajaxifying topic. I'll will be very helpful for me if you could direct me for a such area. Thank you.
Regards, Thilanka.
Thilanka, After a quick look, here are some examples:
- on table Structure, adding a column could display a panel similar to when we create a table (jQuery dialog)
- clicking on Edit for a row could bring a similar panel
- in Browse, deleting a row does not not Ajax to me
- clicking a table name in navigation panel could load the main panel in a way that does not look like a panel refresh
Work needs to be done to find appropriate actions, then update http://wiki.phpmyadmin.net/pma/AJAXify_Interface.
Hi Marc,
Thanks for the quick response.
- on table Structure, adding a column could display a panel similar to
when we create a table (jQuery dialog)
clicking on Edit for a row could bring a similar panel
in Browse, deleting a row does not not Ajax to me
clicking a table name in navigation panel could load the main panel in
a way that does not look like a panel refresh
Work needs to be done to find appropriate actions, then update http://wiki.phpmyadmin.net/pma/AJAXify_Interface.
I got the idea and will continue on that.
Regards, Thilanka.
Hi Marc,
I went through some of the sections of the PMA and found some actions which could be more useful with Ajax support.
1. In table Browse and Structure options, Change multiple rows should add a ajax window. Currently when no row is selected it does not give an error dialog have to handle that. 2. In table Structure->Change should add ajax window support. 3. In table Structure, Add column(s) At End of/ At beginning of tables should apply the ajax window support. 4. In database Structure we can add a ajax window to the insert option because it will help the user to insert for multiple tables from a one place.
These are my suggestions and can you please check and confirm me on that. I'll go through the other sections deeply to find more actions.
Regards, Thilanka.
Le 2011-03-17 14:02, Thilanka Kaushalya a écrit :
Hi Marc,
I went through some of the sections of the PMA and found some actions which could be more useful with Ajax support.
- In table Browse and Structure options, Change multiple rows should add
a ajax window. Currently when no row is selected it does not give an error dialog have to handle that. 2. In table Structure->Change should add ajax window support. 3. In table Structure, Add column(s) At End of/ At beginning of tables should apply the ajax window support. 4. In database Structure we can add a ajax window to the insert option because it will help the user to insert for multiple tables from a one place.
These are my suggestions and can you please check and confirm me on that. I'll go through the other sections deeply to find more actions.
Indeed these are good ideas; I'll update the http://wiki.phpmyadmin.net/pma/AJAXify_Interface page with them.
Hi Marc,
Thanks for adding the Ajaxify ideas to the wiki page.
Indeed these are good ideas; I'll update the http://wiki.phpmyadmin.net/pma/AJAXify_Interface page with them.
Since my exam is over I started working on adding the Show/Hide search results option to the db search. I have almost done that, but have to clarify small issue on that. Currently when a user deletes the searched results it shows the delete results as well as the sql query box on the same page. I have add the option of hide/show query box link with my previous patch *ID: 3176420 [1]* . Currently when I add the show/hide search results link it handle hide/show of both results and the sql query box. I'm not sure whether we need both these links and it seems better to have only one link (Show/Hide search results). I have shared some screen shots of the problem with this google doc [2]. Please can you help me on this issue. Thank you.
[1] - http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=230... [2] - https://docs.google.com/document/d/1Rg96E1m_PCgdY00QIIyE_imwDMslefO2MzNC0Q2k...
Regards, Thilanka.
Thilanka Kaushalya a écrit :
Hi Marc,
Thanks for adding the Ajaxify ideas to the wiki page. Indeed these are good ideas; I'll update the http://wiki.phpmyadmin.net/pma/AJAXify_Interface page with them. Since my exam is over I started working on adding the Show/Hidesearch results option to the db search. I have almost done that, but have to clarify small issue on that. Currently when a user deletes the searched results it shows the delete results as well as the sql query box on the same page. I have add the option of hide/show query box link with my previous patch *ID: 3176420 [1]* . Currently when I add the show/hide search results link it handle hide/show of both results and the sql query box. I'm not sure whether we need both these links and it seems better to have only one link (Show/Hide search results). I have shared some screen shots of the problem with this google doc [2]. Please can you help me on this issue. Thank you.
[1]
http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=23067&atid=377410 [2]
Thilanka,
1. Do we need the query box on this page? 1.2 If we need it, maybe hide it by default?
2. When I delete using the Delete link in "Search results", the number of matches is not updated.
3. Your proposed "Hide search results" would be better shown just under the Search results.
Hi Marc,
On Thu, Mar 24, 2011 at 5:10 PM, Marc Delisle marc@infomarc.info wrote:
Thilanka Kaushalya a écrit :
Hi Marc,
Thanks for adding the Ajaxify ideas to the wiki page. Indeed these are good ideas; I'll update the http://wiki.phpmyadmin.net/pma/AJAXify_Interface page with them. Since my exam is over I started working on adding the Show/Hidesearch results option to the db search. I have almost done that, but have to clarify small issue on that. Currently when a user deletes the searched results it shows the delete results as well as the sql query box on the same page. I have add the option of hide/show query box link with my previous patch *ID: 3176420 [1]* . Currently when I add the show/hide search results link it handle hide/show of both results and the sql query box. I'm not sure whether we need both these links and it seems better to have only one link (Show/Hide search results). I have shared some screen shots of the problem with this google doc [2]. Please can you help me on this issue. Thank you.
[1]
http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=230...
<
http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=230...
[2]
https://docs.google.com/document/d/1Rg96E1m_PCgdY00QIIyE_imwDMslefO2MzNC0Q2k...
<
https://docs.google.com/document/d/1Rg96E1m_PCgdY00QIIyE_imwDMslefO2MzNC0Q2k...
Thilanka,
- Do we need the query box on this page?
1.2 If we need it, maybe hide it by default?
- When I delete using the Delete link in "Search results", the number
of matches is not updated.
It is working correctly with me. Please can you check it again by cache clearing.
- Your proposed "Hide search results" would be better shown just under
the Search results.
Ok. I'll continue with that.
Regards, Thilanka.
Thilanka Kaushalya a écrit :
Hi Marc,
1. Do we need the query box on this page? 1.2 If we need it, maybe hide it by default? 2. When I delete using the Delete link in "Search results", the number of matches is not updated.It is working correctly with me. Please can you check it again by cache clearing.
Tested again with cache clearing, still have the problem. Here is my scenario:
- I do a db-search for some string, let's say I get one match inside table "person".
- I click Delete _on the same line_ as the "1 match inside table person" message.
- I get a "Delete the matches" popup and click OK.
- The interface shows the generated "DELETE" statement but the upper part still shows "1 match inside table person" and the Total still shows "1 match".
Hi Marc,
On Thu, Mar 24, 2011 at 5:10 PM, Marc Delisle marc@infomarc.info wrote:
Thilanka Kaushalya a écrit :
Hi Marc,
Thanks for adding the Ajaxify ideas to the wiki page. Indeed these are good ideas; I'll update the http://wiki.phpmyadmin.net/pma/AJAXify_Interface page with them. Since my exam is over I started working on adding the Show/Hidesearch results option to the db search. I have almost done that, but have to clarify small issue on that. Currently when a user deletes the searched results it shows the delete results as well as the sql query box on the same page. I have add the option of hide/show query box link with my previous patch *ID: 3176420 [1]* . Currently when I add the show/hide search results link it handle hide/show of both results and the sql query box. I'm not sure whether we need both these links and it seems better to have only one link (Show/Hide search results). I have shared some screen shots of the problem with this google doc [2]. Please can you help me on this issue. Thank you.
[1]
http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=230...
<
http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=230...
[2]
https://docs.google.com/document/d/1Rg96E1m_PCgdY00QIIyE_imwDMslefO2MzNC0Q2k...
<
https://docs.google.com/document/d/1Rg96E1m_PCgdY00QIIyE_imwDMslefO2MzNC0Q2k...
Thilanka,
- Do we need the query box on this page?
1.2 If we need it, maybe hide it by default?
- When I delete using the Delete link in "Search results", the number
of matches is not updated.
I have little bit confused on this comment.
- Your proposed "Hide search results" would be better shown just under
the Search results.
What section do you point out by "Search results". I thought it is the area that shows the Browse results and delete results (No 1 in the screen shot). In that case the show/hide search results link will appear under that and toggle the browse and delete results.
But I'm confused whether you referred the top table which list the search results (No 2 in the screen shot). If so I don't see a high importancy on that when we are using databases with few tables. It may useful when searching on a DB with large number of tables.
I have attached the screen shot with this doc to point out the areas [1]. Please clarify me on this. Thank you
[1] - https://docs.google.com/document/d/1cQjKyNZOpoIGxBMiZFyLIyvLAdtmAM4ccbXx1ASr...
Regards, Thilanka.
Le 2011-03-25 13:46, Thilanka Kaushalya a écrit :
Hi Marc,
On Thu, Mar 24, 2011 at 5:10 PM, Marc Delisle marc@infomarc.info wrote:
Thilanka Kaushalya a écrit :
Hi Marc,
Thanks for adding the Ajaxify ideas to the wiki page. Indeed these are good ideas; I'll update the http://wiki.phpmyadmin.net/pma/AJAXify_Interface page with them. Since my exam is over I started working on adding the Show/Hidesearch results option to the db search. I have almost done that, but have to clarify small issue on that. Currently when a user deletes the searched results it shows the delete results as well as the sql query box on the same page. I have add the option of hide/show query box link with my previous patch *ID: 3176420 [1]* . Currently when I add the show/hide search results link it handle hide/show of both results and the sql query box. I'm not sure whether we need both these links and it seems better to have only one link (Show/Hide search results). I have shared some screen shots of the problem with this google doc [2]. Please can you help me on this issue. Thank you.
[1]
http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=230...
<
http://sourceforge.net/tracker/?func=detail&aid=3176420&group_id=230...
[2]
https://docs.google.com/document/d/1Rg96E1m_PCgdY00QIIyE_imwDMslefO2MzNC0Q2k...
<
https://docs.google.com/document/d/1Rg96E1m_PCgdY00QIIyE_imwDMslefO2MzNC0Q2k...
Thilanka,
- Do we need the query box on this page?
1.2 If we need it, maybe hide it by default?
- When I delete using the Delete link in "Search results", the number
of matches is not updated.
I have little bit confused on this comment.
- Your proposed "Hide search results" would be better shown just under
the Search results.
What section do you point out by "Search results". I thought it is the area that shows the Browse results and delete results (No 1 in the screen shot). In that case the show/hide search results link will appear under that and toggle the browse and delete results.
I mean the area No 1 in your screenshot. In this area, when I click Delete, the deletion occurs but the number of matches is not updated.
But I'm confused whether you referred the top table which list the search results (No 2 in the screen shot). If so I don't see a high importancy on that when we are using databases with few tables. It may useful when searching on a DB with large number of tables.
I have attached the screen shot with this doc to point out the areas [1]. Please clarify me on this. Thank you
[1] -https://docs.google.com/document/d/1cQjKyNZOpoIGxBMiZFyLIyvLAdtmAM4ccbXx1ASr...
Regards, Thilanka.
Hi Marc,
I got your point and I have checked the issue with the latest update from the master. But in my machine it does not give any issue and updates correctly to the 0 matches after deletion. I have shared the screenshots of the scenario with this doc [1]. In the previous patch I have handled it by triggering the go button the search criteria after the deletion by jquery trigger function. So it should work fine.
What section do you point out by "Search results". I thought it is the area that shows the Browse results and delete results (No 1 in the screen shot). In that case the show/hide search results link will appear under
that
and toggle the browse and delete results.
Now I have a another problem which I have raised with the my last mail and I think my explanation with that mail was unable to convince you the problem. I have added the new "Show/Hide search results" option to toggle the browsed and deleted results which are appear below the "Show/Hide search criteria" link. I have share a doc containing the above scenario [2](This doc contains the scenario of the Hide/Show search results as understood by me). But I'm not sure whether I have provided the right feature for your request. Is this correct or should I change "Show/Hide search results" option to toggle the results appearing under "Search results for *a* at least one of the words" heading( Which I have highlighted by the number 4). If so please correct me.
[1] - https://docs.google.com/document/d/18pxKFkjDlPg2eOQXKDCWSt3HE9sstBoFZKIwDPIk...
https://docs.google.com/document/d/18pxKFkjDlPg2eOQXKDCWSt3HE9sstBoFZKIwDPIk2JU/edit?hl=en&authkey=CJfW4eoD#[2] - https://docs.google.com/document/d/1Mf55LtS0nhj7glIo72V02HTb8eVjP0RC2cQYlD47...
Regards, Thilanka.
Le 2011-03-26 05:48, Thilanka Kaushalya a écrit :
Hi Marc,
I got your point and I have checked the issue with the latest update from the master. But in my machine it does not give any issue and updates correctly to the 0 matches after deletion. I have shared the screenshots of the scenario with this doc [1]. In the previous patch I have handled it by triggering the go button the search criteria after the deletion by jquery trigger function. So it should work fine.
It seems I found the one case where it fails: if the table is listed as the last one in the search results. Can be reproduced in the sakila database if you add the "zzz" table to it, insert some data and search for it in the db search.
Now I have a another problem which I have raised with the my last mail and I think my explanation with that mail was unable to convince you the problem. I have added the new "Show/Hide search results" option to toggle the browsed and deleted results which are appear below the "Show/Hide search criteria" link. I have share a doc containing the above scenario [2](This doc contains the scenario of the Hide/Show search results as understood by me). But I'm not sure whether I have provided the right feature for your request. Is this correct or should I change "Show/Hide search results" option to toggle the results appearing under "Search results for *a* at least one of the words" heading( Which I have highlighted by the number 4). If so please correct me.
For me, "Search results" only means your area 4, not what you get at the bottom when you click on Browse in the search results and see rows from a table (let's call this the "Showing rows" area).
So I would like a "Show/Hide search results" link to toggle this "Search results" area.
It is clearer this way?
[1] - https://docs.google.com/document/d/18pxKFkjDlPg2eOQXKDCWSt3HE9sstBoFZKIwDPIk...
https://docs.google.com/document/d/1Mf55LtS0nhj7glIo72V02HTb8eVjP0RC2cQYlD47...
Regards, Thilanka.
Hi Marc,
I have submitted a patch on adding "Show/Hide search results criteria for db search" [1]. Please check that.
It seems I found the one case where it fails: if the table is listed as the last one in the search results. Can be reproduced in the sakila database if you add the "zzz" table to it, insert some data and search for it in the db search.
Now I'm looking at this issue and will be able to update you soon. Thank you.
[1] - https://sourceforge.net/tracker/?func=detail&aid=3256122&group_id=23...
Regards, Thilanka.
Hi Marc,
I submitted my project proposal on Ajaxify PMA interface idea for the Melanga site. I'm waiting for the comments on my proposal from you and the community members. Thank you.
Regards, Thilanka.
-
lgtkaushalya＠gmail.com -
Marc Delisle -
Thilanka Kaushalya