Hi, all.
I'm a third year phd-student of the Kursk State University, Russia. I'm interesting in some pre-ideas of GSoC 2010 for phpMyAdmin project. Particulary in "User interface cleanup" and "phpMyAdmin OOP".
As recomended Michal Čihař, i've tryed to solve one of the tasks for new developers. Task "Show filename of imported file", rfe:2958013, https://sourceforge.net/tracker/index.php?func=detail&aid=2958013&gr...
But i can't attach my patch to this issue. And i'm sending my path to this list.
Best regards. Pavel Konnikov
Pavel Konnikov wrote:
Hi, all.
I'm a third year phd-student of the Kursk State University, Russia. I'm interesting in some pre-ideas of GSoC 2010 for phpMyAdmin project. Particulary in "User interface cleanup" and "phpMyAdmin OOP".
As recomended Michal Čihař, i've tryed to solve one of the tasks for new developers.
Welcome
Task "Show filename of imported file", rfe:2958013, https://sourceforge.net/tracker/index.php?func=detail&aid=2958013&gr...
But i can't attach my patch to this issue. And i'm sending my path to this list.
Only the original submitter and project members van attach files to already open tracker artifacts. Adding an artifact to the patches tracker would probably be the best course of action.
Here are a few quick first remarks about the patch
* you put the filename in a separate formfield, couldn't we use $import_file for this? * you indented some of the lines with a tab-character, please use 4 spaces as is recommended by the PEAR coding standards http://pear.php.net/manual/en/standards.php (referenced from http://wiki.phpmyadmin.net/pma/Devel:Coding_guidelines)
Only the original submitter and project members van attach files to already open tracker artifacts. Adding an artifact to the patches tracker would probably be the best course of action.
I've add new patch in patch tracker "After import also display uploaded filename" ID: 2962655 https://sourceforge.net/tracker/?func=detail&aid=2962655&group_id=23...
Here are a few quick first remarks about the patch
- you put the filename in a separate formfield, couldn't we use
$import_file for this?
$import_file variable store the file name on the server instead of on the client.
- you indented some of the lines with a tab-character, please use 4
spaces as is recommended by the PEAR coding standards
I've fixed it
-- Met vriendelijke groet / Regards,
Herman van Rink Initfour websolutions
Best regards. Pavel Konnikov