Hi,
I'm working on bug ticket http://sourceforge.net/p/phpmyadmin/bugs/3733/ I already replaced all & in PHP files by the separator defined in php.ini. I also replaced a part of & in JS files (almost all). But I still have an issue... with Jquery method $.get...
This method have many parameters, and one could be a JSON object of URL parameters. Something like this: var params = { aPath: $expandElem.find('span.aPath').text(), vPath: $expandElem.find('span.vPath').text() }; And this: $.get(url, params, function (data) { ... });
Imagine that you set the arg_separator to "|" in your php.ini, the result will be: - initial URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2 - params: var params = { p3: "v3", p4: "v4" }; - generated URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2&p3=v3%7Cp4=v4
As you can see, there is a & between the initial URL and the added parameters...
Do you know a way to manage the arg_separator used by Jquery please?
Thanks a lot ! Hugues.
Le 2014-04-13 09:30, Hugues Peccatte a écrit :
Hi,
I'm working on bug ticket http://sourceforge.net/p/phpmyadmin/bugs/3733/ I already replaced all & in PHP files by the separator defined in php.ini.
Hugues, are you using PMA_URL_getArgSeparator() ?
I also replaced a part of & in JS files (almost all). But I still have an issue… with Jquery method $.get…
This method have many parameters, and one could be a JSON object of URL parameters. Something like this: var params = { aPath: $expandElem.find('span.aPath').text(), vPath: $expandElem.find('span.vPath').text() }; And this: $.get(url, params, function (data) { … });
Imagine that you set the arg_separator to "|" in your php.ini, the result will be:
- initial URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2
- params: var params = { p3: "v3", p4: "v4" };
- generated URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2&p3=v3%7Cp4=v4
As you can see, there is a & between the initial URL and the added parameters…
Do you know a way to manage the arg_separator used by Jquery please?
Thanks a lot ! Hugues.
Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2014-04-13 15:41 GMT+02:00 Marc Delisle marc@infomarc.info:
Le 2014-04-13 09:30, Hugues Peccatte a écrit :
Hi,
I'm working on bug ticket http://sourceforge.net/p/phpmyadmin/bugs/3733/ I already replaced all & in PHP files by the separator defined in
php.ini.
Hugues, are you using PMA_URL_getArgSeparator() ?
Yes, I used it everywhere. Even to give the value to Javascript. (I've another question about this, but I would like to solve this problem first.)
I also replaced a part of & in JS files (almost all). But I still have an issue... with Jquery method $.get...
This method have many parameters, and one could be a JSON object of URL parameters. Something like this: var params = { aPath: $expandElem.find('span.aPath').text(), vPath: $expandElem.find('span.vPath').text() }; And this: $.get(url, params, function (data) { ... });
Imagine that you set the arg_separator to "|" in your php.ini, the result will be:
- initial URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2
- params: var params = { p3: "v3", p4: "v4" };
- generated URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2&p3=v3%7Cp4=v4
As you can see, there is a & between the initial URL and the added parameters...
Do you know a way to manage the arg_separator used by Jquery please?
Thanks a lot ! Hugues.
-- Marc Delisle
Hugues.
Le 2014-04-13 09:30, Hugues Peccatte a écrit :
Hi,
I'm working on bug ticket http://sourceforge.net/p/phpmyadmin/bugs/3733/ I already replaced all & in PHP files by the separator defined in php.ini. I also replaced a part of & in JS files (almost all). But I still have an issue… with Jquery method $.get…
This method have many parameters, and one could be a JSON object of URL parameters. Something like this: var params = { aPath: $expandElem.find('span.aPath').text(), vPath: $expandElem.find('span.vPath').text() }; And this: $.get(url, params, function (data) { … });
Imagine that you set the arg_separator to "|" in your php.ini, the
But this would not follow the recommendation in http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2.
result will be:
- initial URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2
- params: var params = { p3: "v3", p4: "v4" };
- generated URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2&p3=v3%7Cp4=v4
As you can see, there is a & between the initial URL and the added parameters…
Do you know a way to manage the arg_separator used by Jquery please?
Thanks a lot ! Hugues.
Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2014-04-13 15:47 GMT+02:00 Marc Delisle marc@infomarc.info:
Le 2014-04-13 09:30, Hugues Peccatte a écrit :
Hi,
I'm working on bug ticket http://sourceforge.net/p/phpmyadmin/bugs/3733/ I already replaced all & in PHP files by the separator defined in
php.ini.
I also replaced a part of & in JS files (almost all). But I still have an issue... with Jquery method $.get...
This method have many parameters, and one could be a JSON object of URL parameters. Something like this: var params = { aPath: $expandElem.find('span.aPath').text(), vPath: $expandElem.find('span.vPath').text() }; And this: $.get(url, params, function (data) { ... });
Imagine that you set the arg_separator to "|" in your php.ini, the
But this would not follow the recommendation in http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 .
Yes, I agree, but should we so remove the use of ini_get('arg_separator.input') in PMA_URL_getArgSeparator as there is W3C recommandations? And so define that & char is mandatory? (It would be easier and the ticket could be closed, I believe.)
Or should we deal with the fact that we could have & or ";" as a separator? And so find a way to manage it with Jquery?
Thanks for you answers.
Hugues.
result will be:
- initial URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2
- params: var params = { p3: "v3", p4: "v4" };
- generated URL: http://myurl.com/mypage.php?p1=v1%7Cp2=V2&p3=v3%7Cp4=v4
As you can see, there is a & between the initial URL and the added parameters...
Do you know a way to manage the arg_separator used by Jquery please?
Thanks a lot ! Hugues.
-- Marc Delisle
Le 2014-04-13 09:59, Hugues Peccatte a écrit :
2014-04-13 15:47 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Le 2014-04-13 09:30, Hugues Peccatte a écrit : > Hi, > > I'm working on bug ticket http://sourceforge.net/p/phpmyadmin/bugs/3733/ > I already replaced all & in PHP files by the separator defined in php.ini. > I also replaced a part of & in JS files (almost all). But I still have > an issue… with Jquery method $.get… > > This method have many parameters, and one could be a JSON object of URL > parameters. > Something like this: > var params = { > aPath: $expandElem.find('span.aPath').text(), > vPath: $expandElem.find('span.vPath').text() > }; > And this: > $.get(url, params, function (data) { > … > }); > > Imagine that you set the arg_separator to "|" in your php.ini, the But this would not follow the recommendation in http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2.Yes, I agree, but should we so remove the use of ini_get('arg_separator.input') in PMA_URL_getArgSeparator as there is W3C recommandations? And so define that & char is mandatory? (It would be easier and the ticket could be closed, I believe.)
I think you mean "define that the semicolon (;) is mandatory". But at the same time, the directive exists in php.ini so we should try to respect it, so support whatever is there as a separator (hoping that it's the ampersand or the semicolon).
Or should we deal with the fact that we could have & or ";" as a separator? And so find a way to manage it with Jquery?
This would be the best way to go.
Thanks for you answers.
Hugues.
> result will be: > - initial URL: http://myurl.com/mypage.php?p1=v1|p2=V2 > - params: var params = { > p3: "v3", > p4: "v4" > }; > - generated URL: http://myurl.com/mypage.php?p1=v1|p2=V2&p3=v3|p4=v4 > > As you can see, there is a & between the initial URL and the added > parameters… > > Do you know a way to manage the arg_separator used by Jquery please? > > Thanks a lot ! > Hugues. -- Marc Delisle
Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi
Dne Sun, 13 Apr 2014 15:30:57 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I'm working on bug ticket http://sourceforge.net/p/phpmyadmin/bugs/3733/ I already replaced all & in PHP files by the separator defined in php.ini. I also replaced a part of & in JS files (almost all). But I still have an issue... with Jquery method $.get...
This method have many parameters, and one could be a JSON object of URL parameters. Something like this: var params = { aPath: $expandElem.find('span.aPath').text(), vPath: $expandElem.find('span.vPath').text() }; And this: $.get(url, params, function (data) { ... });
It seems to be hardcoded within jQuery.param(). On the other side, if you give jQuery.get() a string as a params, it will use it as it is. So we can introduce our own function to do the array to string conversion, which will use correct separator, something like (completely not tested):
function PMA_URL_params(params) { var s = []; $.each(params, function() { s[s.length] = encodeURIComponent( key ) + "=" + encodeURIComponent( value ); }); return s.join(SEPARATOR); }
$.get(url, PMA_URL_params(params), function (data) { ... });
2014-04-14 9:05 GMT+02:00 Michal Čihař michal@cihar.com:
Hi
Dne Sun, 13 Apr 2014 15:30:57 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I'm working on bug ticket http://sourceforge.net/p/phpmyadmin/bugs/3733/ I already replaced all & in PHP files by the separator defined in
php.ini.
I also replaced a part of & in JS files (almost all). But I still have an issue... with Jquery method $.get...
This method have many parameters, and one could be a JSON object of URL parameters. Something like this: var params = { aPath: $expandElem.find('span.aPath').text(), vPath: $expandElem.find('span.vPath').text() }; And this: $.get(url, params, function (data) { ... });
It seems to be hardcoded within jQuery.param(). On the other side, if you give jQuery.get() a string as a params, it will use it as it is. So we can introduce our own function to do the array to string conversion, which will use correct separator, something like (completely not tested):
function PMA_URL_params(params) { var s = []; $.each(params, function() { s[s.length] = encodeURIComponent( key ) + "=" + encodeURIComponent( value ); });
return s.join(SEPARATOR);
}
$.get(url, PMA_URL_params(params), function (data) { ... });
-- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Hi,
I was looking for something more implicit, so we wouldn't have to change the calls to $.get. But that seems to be difficult, so your solution might be the best. I just suggest this: function PMA_URL_params(params) { var s = ['']; //Set with an empty element, so the join will start with a SEPARATOR char. If params is empty, the return would be an empty string. $.each(params, function() { s[s.length] = encodeURIComponent( key ) + "=" + encodeURIComponent( value ); }); return s.join(SEPARATOR); }
//Give a URL with all parameters, not the URL and another parameter with the GET parameters. Why? Because of the Jquery concatenation that would concat URL and params with a &. $.get(url + PMA_URL_params(params), function (data) { ... });
Is it ok for you ?
Hugues.
Hi
Dne Mon, 14 Apr 2014 09:53:52 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I was looking for something more implicit, so we wouldn't have to change the calls to $.get. But that seems to be difficult, so your solution might be the best.
Well we can also override jQuery.get to do what we want (basically just wrapper around original code to do compose the URL correctly. That might be cleaner approach.
2014-04-14 13:20 GMT+02:00 Michal Čihař michal@cihar.com:
Hi
Dne Mon, 14 Apr 2014 09:53:52 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I was looking for something more implicit, so we wouldn't have to change the calls to $.get. But that seems to be difficult, so your solution
might
be the best.
Well we can also override jQuery.get to do what we want (basically just wrapper around original code to do compose the URL correctly. That might be cleaner approach.
Thanks for this very interesting feedback ! I found this : http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
I'll try to override the $.get method by this way.
Hugues.
2014-04-16 22:16 GMT+02:00 Hugues Peccatte hugues.peccatte@gmail.com:
2014-04-14 13:20 GMT+02:00 Michal Čihař michal@cihar.com:
Hi
Dne Mon, 14 Apr 2014 09:53:52 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I was looking for something more implicit, so we wouldn't have to change the calls to $.get. But that seems to be difficult, so your solution
might
be the best.
Well we can also override jQuery.get to do what we want (basically just wrapper around original code to do compose the URL correctly. That might be cleaner approach.
Thanks for this very interesting feedback ! I found this : http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
I'll try to override the $.get method by this way.
It's done… I overwrote $.get… But there is many Jquery methods which use the "&" as an URL parameter separator… I would have love that they have a $.getArgSeparator, like pMA, so we could overwrite this method only! :) We can overwrite all methods which use "&". But when we'll want to change the Jquery version, it will be a mess.
Shall we continue to search a way to use another separator than "&"? Do you want we to push my work on my repository, so you can see what I've done?
Hugues.
2014-04-17 11:59 GMT+02:00 Hugues Peccatte hugues.peccatte@gmail.com:
2014-04-16 22:16 GMT+02:00 Hugues Peccatte hugues.peccatte@gmail.com:
2014-04-14 13:20 GMT+02:00 Michal Čihař michal@cihar.com:
Hi
Dne Mon, 14 Apr 2014 09:53:52 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I was looking for something more implicit, so we wouldn't have to
change
the calls to $.get. But that seems to be difficult, so your solution
might
be the best.
Well we can also override jQuery.get to do what we want (basically just wrapper around original code to do compose the URL correctly. That might be cleaner approach.
Thanks for this very interesting feedback ! I found this : http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
I'll try to override the $.get method by this way.
It's done… I overwrote $.get… But there is many Jquery methods which use the "&" as an URL parameter separator… I would have love that they have a $.getArgSeparator, like pMA, so we could overwrite this method only! :) We can overwrite all methods which use "&". But when we'll want to change the Jquery version, it will be a mess.
Shall we continue to search a way to use another separator than "&"? Do you want we to push my work on my repository, so you can see what I've done?
I didn't wait for an answer. If you want to check: https://github.com/Tithugues/phpmyadmin/tree/b3733
Hugues.
Hugues Peccatte a écrit :
2014-04-17 11:59 GMT+02:00 Hugues Peccatte hugues.peccatte@gmail.com:
2014-04-16 22:16 GMT+02:00 Hugues Peccatte hugues.peccatte@gmail.com:
2014-04-14 13:20 GMT+02:00 Michal Čihař michal@cihar.com:
Hi
Dne Mon, 14 Apr 2014 09:53:52 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I was looking for something more implicit, so we wouldn't have to
change
the calls to $.get. But that seems to be difficult, so your solution
might
be the best.
Well we can also override jQuery.get to do what we want (basically just wrapper around original code to do compose the URL correctly. That might be cleaner approach.
Thanks for this very interesting feedback ! I found this : http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
I'll try to override the $.get method by this way.
It's done… I overwrote $.get… But there is many Jquery methods which use the "&" as an URL parameter separator… I would have love that they have a $.getArgSeparator, like pMA, so we could overwrite this method only! :) We can overwrite all methods which use "&". But when we'll want to change the Jquery version, it will be a mess.
Shall we continue to search a way to use another separator than "&"? Do you want we to push my work on my repository, so you can see what I've done?
I didn't wait for an answer. If you want to check: https://github.com/Tithugues/phpmyadmin/tree/b3733
Hugues.
Hi Hugues, I have started to review the code; so far it looks fine.
In js/messages.php, maybe it would be more consistent to call PMA_URL_getArgSeparator() ?
2014-04-17 14:07 GMT+02:00 Marc Delisle marc@infomarc.info:
Hugues Peccatte a écrit :
2014-04-17 11:59 GMT+02:00 Hugues Peccatte hugues.peccatte@gmail.com:
2014-04-16 22:16 GMT+02:00 Hugues Peccatte hugues.peccatte@gmail.com:
2014-04-14 13:20 GMT+02:00 Michal Čihař michal@cihar.com:
Hi
Dne Mon, 14 Apr 2014 09:53:52 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I was looking for something more implicit, so we wouldn't have to
change
the calls to $.get. But that seems to be difficult, so your solution
might
be the best.
Well we can also override jQuery.get to do what we want (basically just wrapper around original code to do compose the URL correctly.
That
might be cleaner approach.
Thanks for this very interesting feedback ! I found this :
http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
I'll try to override the $.get method by this way.
It's done… I overwrote $.get… But there is many Jquery methods which use the "&" as an URL parameter separator… I would have love that they have
a
$.getArgSeparator, like pMA, so we could overwrite this method only! :) We can overwrite all methods which use "&". But when we'll want to
change
the Jquery version, it will be a mess.
Shall we continue to search a way to use another separator than "&"? Do you want we to push my work on my repository, so you can see what
I've
done?
I didn't wait for an answer. If you want to check: https://github.com/Tithugues/phpmyadmin/tree/b3733
Hugues.
Hi Hugues, I have started to review the code; so far it looks fine.
In js/messages.php, maybe it would be more consistent to call PMA_URL_getArgSeparator() ?
You're right. It's done.
Hugues.
Le 2014-04-17 13:43, Hugues Peccatte a écrit :
2014-04-17 14:07 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Hugues Peccatte a écrit : > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>: > >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>: >> >> 2014-04-14 13:20 GMT+02:00 Michal Čihař <michal@cihar.com <mailto:michal@cihar.com>>: >>> Hi >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200 >>>> Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> napsal(a): >>>> >>>>> I was looking for something more implicit, so we wouldn't have to >>>> change >>>>> the calls to $.get. But that seems to be difficult, so your solution >>>> might >>>>> be the best. >>>> Well we can also override jQuery.get to do what we want (basically >>>> just wrapper around original code to do compose the URL correctly. That >>>> might be cleaner approach. >>>> >>> Thanks for this very interesting feedback ! >>> I found this : >>> http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm >>> >>> I'll try to override the $.get method by this way. >>> >> It's done… I overwrote $.get… But there is many Jquery methods which use >> the "&" as an URL parameter separator… I would have love that they have a >> $.getArgSeparator, like pMA, so we could overwrite this method only! :) >> We can overwrite all methods which use "&". But when we'll want to change >> the Jquery version, it will be a mess. >> >> Shall we continue to search a way to use another separator than "&"? >> Do you want we to push my work on my repository, so you can see what I've >> done? >> >> > I didn't wait for an answer. If you want to check: > https://github.com/Tithugues/phpmyadmin/tree/b3733 > > Hugues. Hi Hugues, I have started to review the code; so far it looks fine. In js/messages.php, maybe it would be more consistent to call PMA_URL_getArgSeparator() ?You're right. It's done.
Hugues.
Ok. Feel free to merge to master; I'll release -beta1 afterwards.
2014-04-17 23:38 GMT+02:00 Marc Delisle marc@infomarc.info:
Le 2014-04-17 13:43, Hugues Peccatte a écrit :
2014-04-17 14:07 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Hugues Peccatte a écrit : > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>: > >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>: >> >> 2014-04-14 13:20 GMT+02:00 Michal Čihař <michal@cihar.com <mailto:michal@cihar.com>>: >>> Hi >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200 >>>> Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> napsal(a): >>>> >>>>> I was looking for something more implicit, so we wouldn't haveto
>>>> change >>>>> the calls to $.get. But that seems to be difficult, so your solution >>>> might >>>>> be the best. >>>> Well we can also override jQuery.get to do what we want(basically
>>>> just wrapper around original code to do compose the URL correctly. That >>>> might be cleaner approach. >>>> >>> Thanks for this very interesting feedback ! >>> I found this : >>>http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
>>> >>> I'll try to override the $.get method by this way. >>> >> It's done… I overwrote $.get… But there is many Jquery methods which use >> the "&" as an URL parameter separator… I would have love that they have a >> $.getArgSeparator, like pMA, so we could overwrite this method only! :) >> We can overwrite all methods which use "&". But when we'll want to change >> the Jquery version, it will be a mess. >> >> Shall we continue to search a way to use another separator than"&"?
>> Do you want we to push my work on my repository, so you can see what I've >> done? >> >> > I didn't wait for an answer. If you want to check: > https://github.com/Tithugues/phpmyadmin/tree/b3733 > > Hugues. Hi Hugues, I have started to review the code; so far it looks fine. In js/messages.php, maybe it would be more consistent to call PMA_URL_getArgSeparator() ?You're right. It's done.
Hugues.
Ok. Feel free to merge to master; I'll release -beta1 afterwards.
I really can't… There is still issues with Jquery methods which use the "&". That why I asked: Shall we continue to search a way to use another separator than "&"? Override all methods? I don't think this is a good thing…
Thanks for your feedback and code review.
Hugues.
Le 2014-04-18 05:34, Hugues Peccatte a écrit :
2014-04-17 23:38 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Le 2014-04-17 13:43, Hugues Peccatte a écrit : > 2014-04-17 14:07 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>: > > Hugues Peccatte a écrit : > > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>: > > > >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>: > >> > >> 2014-04-14 13:20 GMT+02:00 Michal Čihař <michal@cihar.com <mailto:michal@cihar.com> > <mailto:michal@cihar.com <mailto:michal@cihar.com>>>: > >>> Hi > >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200 > >>>> Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>> napsal(a): > >>>> > >>>>> I was looking for something more implicit, so we wouldn't have to > >>>> change > >>>>> the calls to $.get. But that seems to be difficult, so your > solution > >>>> might > >>>>> be the best. > >>>> Well we can also override jQuery.get to do what we want (basically > >>>> just wrapper around original code to do compose the URL > correctly. That > >>>> might be cleaner approach. > >>>> > >>> Thanks for this very interesting feedback ! > >>> I found this : > >>> > http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm > >>> > >>> I'll try to override the $.get method by this way. > >>> > >> It's done… I overwrote $.get… But there is many Jquery methods > which use > >> the "&" as an URL parameter separator… I would have love that > they have a > >> $.getArgSeparator, like pMA, so we could overwrite this method > only! :) > >> We can overwrite all methods which use "&". But when we'll want > to change > >> the Jquery version, it will be a mess. > >> > >> Shall we continue to search a way to use another separator than "&"? > >> Do you want we to push my work on my repository, so you can see > what I've > >> done? > >> > >> > > I didn't wait for an answer. If you want to check: > > https://github.com/Tithugues/phpmyadmin/tree/b3733 > > > > Hugues. > > Hi Hugues, > I have started to review the code; so far it looks fine. > > In js/messages.php, maybe it would be more consistent to call > PMA_URL_getArgSeparator() ? > > > You're right. It's done. > > Hugues. Ok. Feel free to merge to master; I'll release -beta1 afterwards.I really can't… There is still issues with Jquery methods which use the "&". That why I asked: Shall we continue to search a way to use another separator than "&"? Override all methods? I don't think this is a good thing…
Thanks for your feedback and code review.
Hugues.
Well, it depends: have you tested the behavior of the other jQuery methods that use the "&", when PHP is configured to use ";" as the argument separator?
2014-04-18 12:41 GMT+02:00 Marc Delisle marc@infomarc.info:
Le 2014-04-18 05:34, Hugues Peccatte a écrit :
2014-04-17 23:38 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Le 2014-04-17 13:43, Hugues Peccatte a écrit : > 2014-04-17 14:07 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>: > > Hugues Peccatte a écrit : > > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com:
> > > >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com:
> >> > >> 2014-04-14 13:20 GMT+02:00 Michal Čihař <michal@cihar.com <mailto:michal@cihar.com> > <mailto:michal@cihar.com <mailto:michal@cihar.com>>>: > >>> Hi > >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200 > >>>> Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>> napsal(a): > >>>> > >>>>> I was looking for something more implicit, so we wouldn't have to > >>>> change > >>>>> the calls to $.get. But that seems to be difficult, soyour
> solution > >>>> might > >>>>> be the best. > >>>> Well we can also override jQuery.get to do what we want (basically > >>>> just wrapper around original code to do compose the URL > correctly. That > >>>> might be cleaner approach. > >>>> > >>> Thanks for this very interesting feedback ! > >>> I found this : > >>> >http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
> >>> > >>> I'll try to override the $.get method by this way. > >>> > >> It's done… I overwrote $.get… But there is many Jquerymethods
> which use > >> the "&" as an URL parameter separator… I would have lovethat
> they have a > >> $.getArgSeparator, like pMA, so we could overwrite thismethod
> only! :) > >> We can overwrite all methods which use "&". But when we'llwant
> to change > >> the Jquery version, it will be a mess. > >> > >> Shall we continue to search a way to use another separator than "&"? > >> Do you want we to push my work on my repository, so you cansee
> what I've > >> done? > >> > >> > > I didn't wait for an answer. If you want to check: > > https://github.com/Tithugues/phpmyadmin/tree/b3733 > > > > Hugues. > > Hi Hugues, > I have started to review the code; so far it looks fine. > > In js/messages.php, maybe it would be more consistent to call > PMA_URL_getArgSeparator() ? > > > You're right. It's done. > > Hugues. Ok. Feel free to merge to master; I'll release -beta1 afterwards.I really can't… There is still issues with Jquery methods which use the "&". That why I asked: Shall we continue to search a way to use another separator than "&"? Override all methods? I don't think this is a good thing…
Thanks for your feedback and code review.
Hugues.
Well, it depends: have you tested the behavior of the other jQuery methods that use the "&", when PHP is configured to use ";" as the argument separator?
Yes, I still have issues with "&" which is used to concat the URL GET parameters. The "&" is used in 4 Jquery methods. All methods could be overwriten… But what about changing Jquery version ? We'll have to update the code. That's not infeasable, but we have to think remember it. And also to check the other methods of Jquery, to check than another one is not using "&".
Hugues.
Le 2014-04-18 08:00, Hugues Peccatte a écrit :
2014-04-18 12:41 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Le 2014-04-18 05:34, Hugues Peccatte a écrit : > 2014-04-17 23:38 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>: > > Le 2014-04-17 13:43, Hugues Peccatte a écrit : > > 2014-04-17 14:07 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>> > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>>: > > > > Hugues Peccatte a écrit : > > > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte > > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>: > > > > > >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte > > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>: > > >> > > >> 2014-04-14 13:20 GMT+02:00 Michal Čihař <michal@cihar.com <mailto:michal@cihar.com> > <mailto:michal@cihar.com <mailto:michal@cihar.com>> > > <mailto:michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>>>>: > > >>> Hi > > >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200 > > >>>> Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>> napsal(a): > > >>>> > > >>>>> I was looking for something more implicit, so we > wouldn't have to > > >>>> change > > >>>>> the calls to $.get. But that seems to be difficult, so your > > solution > > >>>> might > > >>>>> be the best. > > >>>> Well we can also override jQuery.get to do what we want > (basically > > >>>> just wrapper around original code to do compose the URL > > correctly. That > > >>>> might be cleaner approach. > > >>>> > > >>> Thanks for this very interesting feedback ! > > >>> I found this : > > >>> > > > http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm > > >>> > > >>> I'll try to override the $.get method by this way. > > >>> > > >> It's done… I overwrote $.get… But there is many Jquery methods > > which use > > >> the "&" as an URL parameter separator… I would have love that > > they have a > > >> $.getArgSeparator, like pMA, so we could overwrite this method > > only! :) > > >> We can overwrite all methods which use "&". But when we'll want > > to change > > >> the Jquery version, it will be a mess. > > >> > > >> Shall we continue to search a way to use another separator > than "&"? > > >> Do you want we to push my work on my repository, so you can see > > what I've > > >> done? > > >> > > >> > > > I didn't wait for an answer. If you want to check: > > > https://github.com/Tithugues/phpmyadmin/tree/b3733 > > > > > > Hugues. > > > > Hi Hugues, > > I have started to review the code; so far it looks fine. > > > > In js/messages.php, maybe it would be more consistent to call > > PMA_URL_getArgSeparator() ? > > > > > > You're right. It's done. > > > > Hugues. > > Ok. Feel free to merge to master; I'll release -beta1 afterwards. > > > I really can't… There is still issues with Jquery methods which use the > "&". > That why I asked: > Shall we continue to search a way to use another separator than "&"? > Override all methods? I don't think this is a good thing… > > Thanks for your feedback and code review. > > Hugues. Well, it depends: have you tested the behavior of the other jQuery methods that use the "&", when PHP is configured to use ";" as the argument separator?Yes, I still have issues with "&" which is used to concat the URL GET parameters. The "&" is used in 4 Jquery methods. All methods could be overwriten… But what about changing Jquery version ? We'll have to update the code. That's not infeasable, but we have to think remember it. And also to check the other methods of Jquery, to check than another one is not using "&".
Hugues.
It's not a good idea to change jQuery itself. I'll release -beta1 without this patch, let's continue the discussion afterwards.
2014-04-18 14:18 GMT+02:00 Marc Delisle marc@infomarc.info:
Le 2014-04-18 08:00, Hugues Peccatte a écrit :
2014-04-18 12:41 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Le 2014-04-18 05:34, Hugues Peccatte a écrit : > 2014-04-17 23:38 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>: > > Le 2014-04-17 13:43, Hugues Peccatte a écrit : > > 2014-04-17 14:07 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>> > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>>: > > > > Hugues Peccatte a écrit : > > > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte > > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>: > > > > > >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte > > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>: > > >> > > >> 2014-04-14 13:20 GMT+02:00 Michal Čihař <michal@cihar.com <mailto:michal@cihar.com> > <mailto:michal@cihar.com <mailto:michal@cihar.com>> > > <mailto:michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>>>>: > > >>> Hi > > >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200 > > >>>> Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>> napsal(a): > > >>>> > > >>>>> I was looking for something more implicit, so we > wouldn't have to > > >>>> change > > >>>>> the calls to $.get. But that seems to be difficult, so your > > solution > > >>>> might > > >>>>> be the best. > > >>>> Well we can also override jQuery.get to do what wewant
> (basically > > >>>> just wrapper around original code to do compose theURL
> > correctly. That > > >>>> might be cleaner approach. > > >>>> > > >>> Thanks for this very interesting feedback ! > > >>> I found this : > > >>> > > >http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
> > >>> > > >>> I'll try to override the $.get method by this way. > > >>> > > >> It's done… I overwrote $.get… But there is many Jquery methods > > which use > > >> the "&" as an URL parameter separator… I would have love that > > they have a > > >> $.getArgSeparator, like pMA, so we could overwrite this method > > only! :) > > >> We can overwrite all methods which use "&". But when we'll want > > to change > > >> the Jquery version, it will be a mess. > > >> > > >> Shall we continue to search a way to use another separator > than "&"? > > >> Do you want we to push my work on my repository, so you can see > > what I've > > >> done? > > >> > > >> > > > I didn't wait for an answer. If you want to check: > > > https://github.com/Tithugues/phpmyadmin/tree/b3733 > > > > > > Hugues. > > > > Hi Hugues, > > I have started to review the code; so far it looks fine. > > > > In js/messages.php, maybe it would be more consistent to call > > PMA_URL_getArgSeparator() ? > > > > > > You're right. It's done. > > > > Hugues. > > Ok. Feel free to merge to master; I'll release -beta1afterwards.
> > > I really can't… There is still issues with Jquery methods which use the > "&". > That why I asked: > Shall we continue to search a way to use another separator than"&"?
> Override all methods? I don't think this is a good thing… > > Thanks for your feedback and code review. > > Hugues. Well, it depends: have you tested the behavior of the other jQuery methods that use the "&", when PHP is configured to use ";" as the argument separator?Yes, I still have issues with "&" which is used to concat the URL GET parameters. The "&" is used in 4 Jquery methods. All methods could be overwriten… But what about changing Jquery version ? We'll have to update the code. That's not infeasable, but we have to think remember it. And also to check the other methods of Jquery, to check than another one is not using "&".
Hugues.
It's not a good idea to change jQuery itself. I'll release -beta1 without this patch, let's continue the discussion afterwards.
Maybe, the best thing is to… send a pull request to Jquery to manage a different arg separator. :) If nobody has any idea, I'll may try this…
Hugues.
Le 2014-04-19 05:17, Hugues Peccatte a écrit :
2014-04-18 14:18 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Le 2014-04-18 08:00, Hugues Peccatte a écrit : > 2014-04-18 12:41 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>: > > Le 2014-04-18 05:34, Hugues Peccatte a écrit : > > 2014-04-17 23:38 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>> > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>>: > > > > Le 2014-04-17 13:43, Hugues Peccatte a écrit : > > > 2014-04-17 14:07 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>> > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>> > > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>>>: > > > > > > Hugues Peccatte a écrit : > > > > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte > > > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>>: > > > > > > > >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte > > > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>>: > > > >> > > > >> 2014-04-14 13:20 GMT+02:00 Michal Čihař > <michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>> > > <mailto:michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>>> > > > <mailto:michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>> > <mailto:michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>>>>>: > > > >>> Hi > > > >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200 > > > >>>> Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>> > > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>> napsal(a): > > > >>>> > > > >>>>> I was looking for something more implicit, so we > > wouldn't have to > > > >>>> change > > > >>>>> the calls to $.get. But that seems to be > difficult, so your > > > solution > > > >>>> might > > > >>>>> be the best. > > > >>>> Well we can also override jQuery.get to do what we want > > (basically > > > >>>> just wrapper around original code to do compose the URL > > > correctly. That > > > >>>> might be cleaner approach. > > > >>>> > > > >>> Thanks for this very interesting feedback ! > > > >>> I found this : > > > >>> > > > > > > http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm > > > >>> > > > >>> I'll try to override the $.get method by this way. > > > >>> > > > >> It's done… I overwrote $.get… But there is many > Jquery methods > > > which use > > > >> the "&" as an URL parameter separator… I would have > love that > > > they have a > > > >> $.getArgSeparator, like pMA, so we could overwrite > this method > > > only! :) > > > >> We can overwrite all methods which use "&". But when > we'll want > > > to change > > > >> the Jquery version, it will be a mess. > > > >> > > > >> Shall we continue to search a way to use another > separator > > than "&"? > > > >> Do you want we to push my work on my repository, so > you can see > > > what I've > > > >> done? > > > >> > > > >> > > > > I didn't wait for an answer. If you want to check: > > > > https://github.com/Tithugues/phpmyadmin/tree/b3733 > > > > > > > > Hugues. > > > > > > Hi Hugues, > > > I have started to review the code; so far it looks fine. > > > > > > In js/messages.php, maybe it would be more consistent to > call > > > PMA_URL_getArgSeparator() ? > > > > > > > > > You're right. It's done. > > > > > > Hugues. > > > > Ok. Feel free to merge to master; I'll release -beta1 afterwards. > > > > > > I really can't… There is still issues with Jquery methods which > use the > > "&". > > That why I asked: > > Shall we continue to search a way to use another separator than "&"? > > Override all methods? I don't think this is a good thing… > > > > Thanks for your feedback and code review. > > > > Hugues. > > Well, it depends: have you tested the behavior of the other jQuery > methods that use the "&", when PHP is configured to use ";" as the > argument separator? > > > Yes, I still have issues with "&" which is used to concat the URL GET > parameters. > The "&" is used in 4 Jquery methods. All methods could be overwriten… > But what about changing Jquery version ? > We'll have to update the code. That's not infeasable, but we have to > think remember it. And also to check the other methods of Jquery, to > check than another one is not using "&". > > Hugues. It's not a good idea to change jQuery itself. I'll release -beta1 without this patch, let's continue the discussion afterwards.Maybe, the best thing is to… send a pull request to Jquery to manage a different arg separator. :) If nobody has any idea, I'll may try this…
Yes, but first ask on stackoverflow: there are already 470 000 questions tagged "jQuery". Or http://forum.jquery.com.
2014-04-19 13:13 GMT+02:00 Marc Delisle marc@infomarc.info:
Le 2014-04-19 05:17, Hugues Peccatte a écrit :
2014-04-18 14:18 GMT+02:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:
Le 2014-04-18 08:00, Hugues Peccatte a écrit : > 2014-04-18 12:41 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>: > > Le 2014-04-18 05:34, Hugues Peccatte a écrit : > > 2014-04-17 23:38 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>> > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>>: > > > > Le 2014-04-17 13:43, Hugues Peccatte a écrit : > > > 2014-04-17 14:07 GMT+02:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>> > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>> > > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info> <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>>>>: > > > > > > Hugues Peccatte a écrit : > > > > 2014-04-17 11:59 GMT+02:00 Hugues Peccatte > > > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>>: > > > > > > > >> 2014-04-16 22:16 GMT+02:00 Hugues Peccatte > > > <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>>: > > > >> > > > >> 2014-04-14 13:20 GMT+02:00 Michal Čihař > <michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>> > > <mailto:michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>>> > > > <mailto:michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>> > <mailto:michal@cihar.com <mailto:michal@cihar.com> <mailto:michal@cihar.com <mailto:michal@cihar.com>>>>>: > > > >>> Hi > > > >>>> Dne Mon, 14 Apr 2014 09:53:52 +0200 > > > >>>> Hugues Peccatte <hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>> > > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>> > > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com> > <mailto:hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>>>> napsal(a): > > > >>>> > > > >>>>> I was looking for something more implicit,so we
> > wouldn't have to > > > >>>> change > > > >>>>> the calls to $.get. But that seems to be > difficult, so your > > > solution > > > >>>> might > > > >>>>> be the best. > > > >>>> Well we can also override jQuery.get to do what we want > > (basically > > > >>>> just wrapper around original code to do compose the URL > > > correctly. That > > > >>>> might be cleaner approach. > > > >>>> > > > >>> Thanks for this very interesting feedback ! > > > >>> I found this : > > > >>> > > > > > >http://www.bennadel.com/blog/1624-ask-ben-overriding-core-jquery-methods.htm
> > > >>> > > > >>> I'll try to override the $.get method by thisway.
> > > >>> > > > >> It's done… I overwrote $.get… But there is many > Jquery methods > > > which use > > > >> the "&" as an URL parameter separator… I wouldhave
> love that > > > they have a > > > >> $.getArgSeparator, like pMA, so we couldoverwrite
> this method > > > only! :) > > > >> We can overwrite all methods which use "&". But when > we'll want > > > to change > > > >> the Jquery version, it will be a mess. > > > >> > > > >> Shall we continue to search a way to use another > separator > > than "&"? > > > >> Do you want we to push my work on myrepository, so
> you can see > > > what I've > > > >> done? > > > >> > > > >> > > > > I didn't wait for an answer. If you want tocheck:
> > > >https://github.com/Tithugues/phpmyadmin/tree/b3733
> > > > > > > > Hugues. > > > > > > Hi Hugues, > > > I have started to review the code; so far it looks fine. > > > > > > In js/messages.php, maybe it would be more consistent to > call > > > PMA_URL_getArgSeparator() ? > > > > > > > > > You're right. It's done. > > > > > > Hugues. > > > > Ok. Feel free to merge to master; I'll release -beta1 afterwards. > > > > > > I really can't… There is still issues with Jquery methodswhich
> use the > > "&". > > That why I asked: > > Shall we continue to search a way to use another separator than "&"? > > Override all methods? I don't think this is a good thing… > > > > Thanks for your feedback and code review. > > > > Hugues. > > Well, it depends: have you tested the behavior of the otherjQuery
> methods that use the "&", when PHP is configured to use ";" asthe
> argument separator? > > > Yes, I still have issues with "&" which is used to concat the URLGET
> parameters. > The "&" is used in 4 Jquery methods. All methods could beoverwriten…
> But what about changing Jquery version ? > We'll have to update the code. That's not infeasable, but we haveto
> think remember it. And also to check the other methods of Jquery,to
> check than another one is not using "&". > > Hugues. It's not a good idea to change jQuery itself. I'll release -beta1 without this patch, let's continue the discussion afterwards.Maybe, the best thing is to… send a pull request to Jquery to manage a different arg separator. :) If nobody has any idea, I'll may try this…
Yes, but first ask on stackoverflow: there are already 470 000 questions tagged "jQuery". Or http://forum.jquery.com.
You were right, there is a ticket for this feature (that I didn't find before…) : http://bugs.jquery.com/ticket/6924 It won't be fix…
I opened a topic on the forum: https://forum.jquery.com/topic/manage-url-argument-separator Their solution is to override the methods… We can choose this solution, but so, we'll have to remember to update the methods when we'll want to change the Jquery version.
Hugues.
-
Hugues Peccatte -
Marc Delisle -
Michal Čihař