[Phpmyadmin-devel] Navigation tree problems
Hi all I've looked a bit about problems people see with navigation frame and here is a little summary. - Speed The navigation panel is quite slow. By quickly looking at SQL queries it does, the database/table comments are quite big culprit here. Simply setting $cfg['ShowTooltip'] = false reduces load time a lot. For not so big database (~25 tables), I get from 1.25s to 0.128s. Are tooltips really worth of this? I suggest to drop this feature completely. In case there will be demand for something like that, lets load it on demand when user is hovering the table. https://github.com/phpmyadmin/phpmyadmin/pull/646 - Pagination Pagination together with tree can be quite annoying. I think we should increase limit for pagination to something like 250. It is still not too much to load (with disabled table comments, see above) and you can scroll in the navigation bar, what is much more convenient that clicking browse arrows. https://github.com/phpmyadmin/phpmyadmin/pull/647 - Quick search and pagination "%s other result found" is another usability nightmare, but this can be hidden by increasing limits (see above). But IMHO quick search (as it is anyway server side) should directly return all results. - Database jumping Maybe we should consider some option for database jumping - providing select box with all databases which will bring user directly to this database. This seems to be quite frequent use case for people maintaining lot of databases and tree navigation makes this quite hard... - Preserving state on reload This has been already discussed before. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Tue, Aug 27, 2013 at 2:45 PM, Michal Čihař <michal@cihar.com> wrote: > Hi all > > I've looked a bit about problems people see with navigation frame and > here is a little summary. > > - Speed > > The navigation panel is quite slow. By quickly looking at SQL queries > it does, the database/table comments are quite big culprit here. Simply > setting $cfg['ShowTooltip'] = false reduces load time a lot. > > For not so big database (~25 tables), I get from 1.25s to 0.128s. > > Are tooltips really worth of this? I suggest to drop this feature > completely. In case there will be demand for something like that, lets > load it on demand when user is hovering the table. > > https://github.com/phpmyadmin/phpmyadmin/pull/646 > > - Pagination > > Pagination together with tree can be quite annoying. I think we should > increase limit for pagination to something like 250. It is still not > too much to load (with disabled table comments, see above) and you can > scroll in the navigation bar, what is much more convenient that > clicking browse arrows. > > https://github.com/phpmyadmin/phpmyadmin/pull/647 > > +1 to the speed and pagination improvements... > - Quick search and pagination > > "%s other result found" is another usability nightmare, but this can be > hidden by increasing limits (see above). But IMHO quick search (as it > is anyway server side) should directly return all results. > > - Database jumping > > Maybe we should consider some option for database jumping - providing > select box with all databases which will bring user directly to this > database. This seems to be quite frequent use case for people > maintaining lot of databases and tree navigation makes this quite > hard... > > I think fast-filter feature may also be more handy for quickly jumping databases:- - If we set the cursor focus by default on fast-filter feature when the user is in navi panel, (after removing "%s other result found" thing). This way user can just start typing a few characters in the name of the database.. Also, we could dynamically adjust the current "minimum 30 databases" limit on fast-filter feature, to enable fast-filter whenever the databases list is long enough that it goes down below the visible page height.. -- Atul Pratap Singh http://blog.atulsisodia.in/
Michal Čihař a écrit :
Hi all
I've looked a bit about problems people see with navigation frame and here is a little summary.
- Speed
The navigation panel is quite slow. By quickly looking at SQL queries it does, the database/table comments are quite big culprit here. Simply setting $cfg['ShowTooltip'] = false reduces load time a lot.
For not so big database (~25 tables), I get from 1.25s to 0.128s.
Are tooltips really worth of this? I suggest to drop this feature completely. In case there will be demand for something like that, lets load it on demand when user is hovering the table.
As I wrote in the pull request, I suggest instead to set the directive to false by default, keeping the feature for those who need it. At least for 4.0.x.
- Pagination
Pagination together with tree can be quite annoying. I think we should increase limit for pagination to something like 250. It is still not too much to load (with disabled table comments, see above) and you can scroll in the navigation bar, what is much more convenient that clicking browse arrows.
Merged.
- Quick search and pagination
"%s other result found" is another usability nightmare, but this can be hidden by increasing limits (see above). But IMHO quick search (as it is anyway server side) should directly return all results.
- Database jumping
Maybe we should consider some option for database jumping - providing select box with all databases which will bring user directly to this database. This seems to be quite frequent use case for people maintaining lot of databases and tree navigation makes this quite hard...
- Preserving state on reload
This has been already discussed before.
Kasun is working on that this week and maybe he should target QA_4_0 for this "feature" (if it's not too much new code)? As he said in his proposal, "This is more of a bug". -- Marc Delisle http://infomarc.info
Hi Dne Tue, 27 Aug 2013 08:29:04 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Michal Čihař a écrit :
Hi all
I've looked a bit about problems people see with navigation frame and here is a little summary.
- Speed
The navigation panel is quite slow. By quickly looking at SQL queries it does, the database/table comments are quite big culprit here. Simply setting $cfg['ShowTooltip'] = false reduces load time a lot.
For not so big database (~25 tables), I get from 1.25s to 0.128s.
Are tooltips really worth of this? I suggest to drop this feature completely. In case there will be demand for something like that, lets load it on demand when user is hovering the table.
As I wrote in the pull request, I suggest instead to set the directive to false by default, keeping the feature for those who need it. At least for 4.0.x.
IMHO it makes navigation simply too slow to even provide option to enable it. The problem is that there is probably no way to get table comment fast - either you use information_schema, which is usually slow for large databases (and therefore we do not use it by default) or SHOW TABLE STATUS which is on normal installations even slower than information_schema.
- Preserving state on reload
This has been already discussed before.
Kasun is working on that this week and maybe he should target QA_4_0 for this "feature" (if it's not too much new code)?
I agree this should go into 4.0.x. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Hi
Dne Tue, 27 Aug 2013 08:29:04 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Michal Čihař a écrit :
Hi all
I've looked a bit about problems people see with navigation frame and here is a little summary.
- Speed
The navigation panel is quite slow. By quickly looking at SQL queries it does, the database/table comments are quite big culprit here. Simply setting $cfg['ShowTooltip'] = false reduces load time a lot.
For not so big database (~25 tables), I get from 1.25s to 0.128s.
Are tooltips really worth of this? I suggest to drop this feature completely. In case there will be demand for something like that, lets load it on demand when user is hovering the table.
https://github.com/phpmyadmin/phpmyadmin/pull/646 As I wrote in the pull request, I suggest instead to set the directive to false by default, keeping the feature for those who need it. At least for 4.0.x.
IMHO it makes navigation simply too slow to even provide option to enable it. The problem is that there is probably no way to get table comment fast - either you use information_schema, which is usually slow for large databases (and therefore we do not use it by default) or SHOW TABLE STATUS which is on normal installations even slower than information_schema.
OK then. Merged to QA_4_0 and I'm working to merge it to master.
- Preserving state on reload
This has been already discussed before. Kasun is working on that this week and maybe he should target QA_4_0 for this "feature" (if it's not too much new code)?
I agree this should go into 4.0.x.
------------------------------------------------------------------------
------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
------------------------------------------------------------------------
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info
Marc Delisle a écrit :
Michal Čihař a écrit :
Hi
Dne Tue, 27 Aug 2013 08:29:04 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Michal Čihař a écrit :
Hi all
I've looked a bit about problems people see with navigation frame and here is a little summary.
- Speed
The navigation panel is quite slow. By quickly looking at SQL queries it does, the database/table comments are quite big culprit here. Simply setting $cfg['ShowTooltip'] = false reduces load time a lot.
For not so big database (~25 tables), I get from 1.25s to 0.128s.
Are tooltips really worth of this? I suggest to drop this feature completely. In case there will be demand for something like that, lets load it on demand when user is hovering the table.
https://github.com/phpmyadmin/phpmyadmin/pull/646 As I wrote in the pull request, I suggest instead to set the directive to false by default, keeping the feature for those who need it. At least for 4.0.x. IMHO it makes navigation simply too slow to even provide option to enable it. The problem is that there is probably no way to get table comment fast - either you use information_schema, which is usually slow for large databases (and therefore we do not use it by default) or SHOW TABLE STATUS which is on normal installations even slower than information_schema.
OK then. Merged to QA_4_0 and I'm working to merge it to master.
Done.
- Preserving state on reload
This has been already discussed before. Kasun is working on that this week and maybe he should target QA_4_0 for this "feature" (if it's not too much new code)? I agree this should go into 4.0.x.
Maybe 4.0.7 for Kasun's changes? Meanwhile I plan to release 4.0.6-rc1 in one hour unless someone objects. -- Marc Delisle http://infomarc.info
On Aug 27, 2013, at 11:10 AM, Marc Delisle <marc@infomarc.info> wrote:
Marc Delisle a écrit :
Michal Čihař a écrit :
Hi
Dne Tue, 27 Aug 2013 08:29:04 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Michal Čihař a écrit :
Hi all
I've looked a bit about problems people see with navigation frame and here is a little summary.
- Speed
The navigation panel is quite slow. By quickly looking at SQL queries it does, the database/table comments are quite big culprit here. Simply setting $cfg['ShowTooltip'] = false reduces load time a lot.
For not so big database (~25 tables), I get from 1.25s to 0.128s.
Are tooltips really worth of this? I suggest to drop this feature completely. In case there will be demand for something like that, lets load it on demand when user is hovering the table.
https://github.com/phpmyadmin/phpmyadmin/pull/646 As I wrote in the pull request, I suggest instead to set the directive to false by default, keeping the feature for those who need it. At least for 4.0.x. IMHO it makes navigation simply too slow to even provide option to enable it. The problem is that there is probably no way to get table comment fast - either you use information_schema, which is usually slow for large databases (and therefore we do not use it by default) or SHOW TABLE STATUS which is on normal installations even slower than information_schema.
OK then. Merged to QA_4_0 and I'm working to merge it to master.
Done.
- Preserving state on reload
This has been already discussed before. Kasun is working on that this week and maybe he should target QA_4_0 for this "feature" (if it's not too much new code)? I agree this should go into 4.0.x.
Maybe 4.0.7 for Kasun's changes?
Meanwhile I plan to release 4.0.6-rc1 in one hour unless someone objects.
Fine by me
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Dne Tue, 27 Aug 2013 11:10:41 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Marc Delisle a écrit :
Michal Čihař a écrit :
Hi
Dne Tue, 27 Aug 2013 08:29:04 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Michal Čihař a écrit :
Hi all
I've looked a bit about problems people see with navigation frame and here is a little summary.
- Speed
The navigation panel is quite slow. By quickly looking at SQL queries it does, the database/table comments are quite big culprit here. Simply setting $cfg['ShowTooltip'] = false reduces load time a lot.
For not so big database (~25 tables), I get from 1.25s to 0.128s.
Are tooltips really worth of this? I suggest to drop this feature completely. In case there will be demand for something like that, lets load it on demand when user is hovering the table.
https://github.com/phpmyadmin/phpmyadmin/pull/646 As I wrote in the pull request, I suggest instead to set the directive to false by default, keeping the feature for those who need it. At least for 4.0.x. IMHO it makes navigation simply too slow to even provide option to enable it. The problem is that there is probably no way to get table comment fast - either you use information_schema, which is usually slow for large databases (and therefore we do not use it by default) or SHOW TABLE STATUS which is on normal installations even slower than information_schema.
OK then. Merged to QA_4_0 and I'm working to merge it to master.
Done.
Thanks!
- Preserving state on reload
This has been already discussed before. Kasun is working on that this week and maybe he should target QA_4_0 for this "feature" (if it's not too much new code)? I agree this should go into 4.0.x.
Maybe 4.0.7 for Kasun's changes?
Meanwhile I plan to release 4.0.6-rc1 in one hour unless someone objects.
Okay for me. -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
On Tue, Aug 27, 2013 at 5:59 PM, Marc Delisle <marc@infomarc.info> wrote:
Michal Čihař a écrit :
Hi all
I've looked a bit about problems people see with navigation frame and here is a little summary.
- Speed
The navigation panel is quite slow. By quickly looking at SQL queries it does, the database/table comments are quite big culprit here. Simply setting $cfg['ShowTooltip'] = false reduces load time a lot.
For not so big database (~25 tables), I get from 1.25s to 0.128s.
Are tooltips really worth of this? I suggest to drop this feature completely. In case there will be demand for something like that, lets load it on demand when user is hovering the table.
As I wrote in the pull request, I suggest instead to set the directive to false by default, keeping the feature for those who need it. At least for 4.0.x.
- Pagination
Pagination together with tree can be quite annoying. I think we should increase limit for pagination to something like 250. It is still not too much to load (with disabled table comments, see above) and you can scroll in the navigation bar, what is much more convenient that clicking browse arrows.
Merged.
- Quick search and pagination
"%s other result found" is another usability nightmare, but this can be hidden by increasing limits (see above). But IMHO quick search (as it is anyway server side) should directly return all results.
- Database jumping
Maybe we should consider some option for database jumping - providing select box with all databases which will bring user directly to this database. This seems to be quite frequent use case for people maintaining lot of databases and tree navigation makes this quite hard...
- Preserving state on reload
This has been already discussed before.
Kasun is working on that this week and maybe he should target QA_4_0 for this "feature" (if it's not too much new code)?
As he said in his proposal, "This is more of a bug".
Hi, Feature request 1398 [1], which I have gone on to implement [2] under GSoC is about indicating the current database/table/view rather than preserving the state of the navigation tree on reload. I am willing to have a look at the reload issue, but this will probably be after the GSoC period. [1] https://sourceforge.net/p/phpmyadmin/feature-requests/1398/ [2] https://github.com/phpmyadmin/phpmyadmin/pull/632 -- Regards Kasun Chathuranga
participants (5)
-
Atul Pratap Singh -
Isaac Bennetch -
Kasun Chathuranga -
Marc Delisle -
Michal Čihař