July 2011 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] phpMyAdmin 3.4.3.2 and 3.3.10.3 are released
by Marc Delisle 23 Jul '11

23 Jul '11

Welcome to phpMyAdmin 3.4.3.2 and to phpMyAdmin 3.3.10.3, which are security releases. Please refer to the upcoming PMASA-2011-9 to PMASA-2011-12 announcements on http://www.phpmyadmin.net/home_page/security/. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Structure ->Add columns
by Thilanka Kaushalya 22 Jul '11

22 Jul '11

Hi Marc, I worked with this feature. 1. I added the "*$("#addColumns.ajax input[value=Go]").live('click')*" action to the tbl_structure.js file which gives the add columns dialog for the user. 2. Then I reused the code in "*$("#append_fields_form input[name=do_save_data]").live('click')*" action in functions.js file which was initially written for handling the table->change option. I did small changes for the same action and used with this feature. I pushed my changes to the repo. Please check that. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

2 5

[Phpmyadmin-devel] Zoom search's latest changes
by Marc Delisle 22 Jul '11

22 Jul '11

Ammar, on the positive side, I very much like the new way of editing a data point in a separate window. I have a few problems: - when dragging the bottom-right corner to resize the plot, under Firefox 5.0 / Vista: uncaught exception. - when testing under IE 9 / Vista, choosing a column in the criteria does not show other column's information so I cannot ask for film_id < 100. Also, I believe that an issue was in discussion: what happens with huge tables? -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] Continuous integration
by Michal Čihař 22 Jul '11

22 Jul '11

Hi all I've setup continuous testing of phpMyAdmin's code base on http://ci.phpmyadmin.net/. It is configured to send mails to all people who have commited code while the tests broke. This email is sent to devel mailing list as well. You can find more details (well not that much right now) on wiki page: https://wiki.phpmyadmin.net/pma/Continuous_Integration -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 7

[Phpmyadmin-devel] PMA Icon Spritify
by Tyron Madlener 21 Jul '11

21 Jul '11

Hi, I've got a huge patch ready. In my branch 'sprites' I have replaced the majority of all pma icons with sprites. This gives us the following advantages - In a few tests I saw that the overall amount of GET requests now has been reduced by 20-33% depending on the loaded page - In the process I removed all width/height attributes, and instead moving this style related property into the stylesheet file. This will also allow for much greater flexibility for theme makers. - The code altogether is easier to read. No more theme path required anymore. Example: - . ($cfg['MainPageIconic'] ? '<img class="icon" src="' . $pmaThemeImage . 's_vars.png" width="16" height="16" alt="" />' : '') + . ($cfg['MainPageIconic'] ? '<img class="icon ic_s_vars" src="themes/dot.gif" alt="" />' : '') Notes about the change: - The stylesheets now contain for each icon "name.png" a class "ic_name" that needs to be applied. - Sprites and CSS were automatically generated using http://spritegen.website-performance.org/ - this can be used to update the sprite data at a later point - I have not replaced the following icons for now: - Icons bigger than 16x16 - Icons being used with PMA_buttonOrImage() or PMA_linkOrButton() - CSS: Icons used as list-style-image or background-image - PMA_getIcon() now translates 'sdf.png' into a 'ic_sdf' class - Many help icons were sized 11x11 although the icon itself is 16x16. I changed this to 16x16, but using an extra class 'ic_b_help_s', so they can be still sized 11x11, if necessary. - I tested all pma pages I could reach with my local configuration, but there might be still some typos around. - I have merged my tree with the master branch yesterday (though a bit too late), so if we merge my code to master soon it should result in little merge conflicts.

4 9

[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Structure ->Column->Change
by Thilanka Kaushalya 21 Jul '11

21 Jul '11

Hi Marc, I worked with my 7th week task which is to implementing the "Change one column in Table structure". 1. I tried to reuse the code, which I was developed for multi_column change earlier. So I moved the common logic to changeColumns(action,$url) function which is in the tbl_structure.js file. Should I move the code to functions.js file. 2. Also I reused "*$("#append_fields_form input[name=do_save_data].ajax").live('click')*" action which was built for the multi_colum change. 3. Then I developed the "*$("#fieldsForm.ajax #tablestructure tbody tr td.edit a").live('click')*" action which loads the change dialog for the user. I pushed my changes to the repo. Please check that. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

4 36

Re: [Phpmyadmin-devel] zoom-search and redirection
by Ammar Yasir 21 Jul '11

21 Jul '11

On Fri, Jul 15, 2011 at 7:26 PM, Ammar Yasir <ammaryasir.88(a)gmail.com>wrote: > > > On Fri, Jul 15, 2011 at 7:19 PM, Marc Delisle <marc(a)infomarc.info> wrote: > >> Le 2011-07-14 15:39, Ammar Yasir a écrit : >> > On Fri, Jul 15, 2011 at 1:01 AM, Ammar Yasir <ammaryasir.88(a)gmail.com >> >wrote: >> > >> >> >> >> >> >> On Fri, Jul 15, 2011 at 12:59 AM, Ammar Yasir <ammaryasir.88(a)gmail.com >> >wrote: >> >> >> >>> >> >>> >> >>> On Wed, Jul 13, 2011 at 3:24 AM, Ammar Yasir <ayax88(a)gmail.com> >> wrote: >> >>> >> >>>> >> >>>> >> >>>> On Tue, Jul 12, 2011 at 6:32 PM, Marc Delisle <marc(a)infomarc.info >> >wrote: >> >>>> >> >>>>> Le 2011-07-11 21:26, Ammar Yasir a écrit : >> >>>>>> >> >>>>>> >> >>>>>> On Mon, Jul 11, 2011 at 3:16 AM, Marc Delisle <marc(a)infomarc.info >> >>>>>> <mailto:marc@infomarc.info>> wrote: >> >>>>>> >> >>>>>> Le 2011-07-09 22:59, Ammar Yasir a écrit : >> >>>>>> > >> >>>>>> > >> >>>>>> > I've done a basic version of edit functionality. I added a >> >>>>> unique >> >>>>>> > identifier for each row in the query result data by using >> the >> >>>>>> > PMA_getUniqueCondition() from the common.lib.php file >> >>>>>> (where_clause). I >> >>>>>> > then generate the update query in the edit submit event >> using >> >>>>>> this where >> >>>>>> > clause and post it to sql.php. The return data is added to >> the >> >>>>>> > <sqlqueryresult> div to show the query executed and the >> >>>>> message. The >> >>>>>> > plot also updates on submit if one of the axes is updated. >> Is >> >>>>> my >> >>>>>> logic >> >>>>>> > is okay? >> >>>>>> > I've pushed my work and you can try scenarios on the >> film_actor >> >>>>>> table in >> >>>>>> > the sakila database. >> >>>>>> >> >>>>>> Ammar, >> >>>>>> I tried with the film table, changing the "title" column and >> got >> >>>>>> this error: >> >>>>>> value is undefined at line 177 in js/tbl_zoom_plot.js. >> >>>>>> >> >>>>>> Fixed some issues and pushed it to my repo. Had to add checkboxes >> for >> >>>>>> null condition on fields (in Data point content section). >> >>>>> >> >>>>> It works fine now. >> >>>>> Please don't forget the issue of generating the default data label >> based >> >>>>> on the "display field". >> >>>>> >> >>>> >> >>> Fixed this, default label is taken from table display field. >> >> It still does not work. When I initially enter Zoom search, $zoom_submit >> and $inputs are not defined so $dataLabel does not receive the results >> of PMA_getDisplayField($db,$table). >> >> I think I misunderstood. What I am doing is that, if a user does not > selects a datalabel, it defaults to the display field. That works fine. I > guess what you are saying is that the default selected value/index should be > the display field? > > >> >>> Also changed the type of xAxis to linear (t defaulted to timeline >> >>> earlier). >> >>> >> >>> There was a small thing I noticed on the row edit feature. >> >>> When the form is displayed for row edit and some field is null, the >> 'Null' >> >>> checkbox is checked. When we select some value it is unchecked. It >> should be >> >>> checked again if we select the value empty or null but it does not. If >> we >> >>> forget to check it back this will give an SQL error. >> >>> Screenshot attached for the sakila db film table where >> >>> original_language_id is null, and if I miss checking it back I'll get >> an SQL >> >>> error. >> >>> >> >> >> > Sorry, missed the screenshots in previous mail. They are on my blog: >> > http://ammaryasirr.blogspot.com/ >> >> Hi, I missed out on one more issue to be fixed, if we refresh the zoom-search page at any stage it just shows two panels with table names and blank page on the right frame. I wanted a refresh to take us back to the tbl_search page, like we have clicked the search tab on the maintabs. I have almost the same code as tbl_select page, $goto is taken from '$goto = $GLOBALS['cfg']['DefaultTabTable']' , why is it going wrong? > -- >> Marc Delisle >> http://infomarc.info >> >> >> ------------------------------------------------------------------------------ >> AppSumo Presents a FREE Video for the SourceForge Community by Eric >> Ries, the creator of the Lean Startup Methodology on "Lean Startup >> Secrets Revealed." This video shows you how to validate your ideas, >> optimize your ideas and identify your business strategy. >> http://p.sf.net/sfu/appsumosfdev2dev >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel(a)lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> > >

2 1

Re: [Phpmyadmin-devel] about CSS overrides
by Michal Čihař 21 Jul '11

21 Jul '11

Hi again, please keep the discussion on the list :-). Dne Thu, 21 Jul 2011 15:00:28 +0300 Tyron Madlener <tyronx(a)gmail.com> napsal(a): > Actually we have a bunch of changes but they are not in the overrides > file, they are in the original theme file: > http://repo.or.cz/w/phpmyadmin/tyronm.git/history/HEAD:/themes/pmahomme/jqu… I think bugs and fixes for them should be pushed upstream, so that we don't have to maintain much of such patches. > And the timepicker z-index thing in return is not required anymore. It > was an attempted fix for timepicker appearing behind dialogs by Aris, > but it doesn't work e.g. on multiple dialogs. I have fixed that with > commit 67ec8263dbfd9f39c25bec5350f4618f5c14e001 which should be merged > to master already. Aris and me have discussed it on this mailing list > just a few days ago. I've cherry picked this patch. When the CSS is obsoleted by your change, you should have removed the CSS as well. Doing it now. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

1 0

[Phpmyadmin-devel] about CSS overrides
by Marc Delisle 21 Jul '11

21 Jul '11

Michal, the idea of CSS overrides, as discussed on this list, was to avoid a problem with future upgrades of jQuery UI inside phpMyAdmin. -- Marc Delisle http://infomarc.info

3 4

[Phpmyadmin-devel] Timepicker dialog
by Tyron Madlener 21 Jul '11

21 Jul '11

Rouslan, about your patch "Fix for bug #3354356 - Timepicker does not work in AJAX dialogs", commit 9e34ccf57cfc97c3cac6d7f9ceecd6e1cc89e10d This fix is flawed. The z-index is calculated by the amount of opened widgets. So as soon as there is one more widget opened, the timepicker will appear in the background again. One way to get it working would be using following code in the beforeShow event in PMA_addDatepicker()/functions.js // Fix wrong timepicker z-index, doesn't work without timeout setTimeout(function() { $('#ui-timepicker-div').css('z-index',$('#ui-datepicker-div').css('z-index')) },0); If pushed this change to my repo, so if it will be merged to master, the bug will be fixed already.

3 3