August 2011 - Developers - lists.phpmyadmin.net

Re: [Phpmyadmin-devel] Grid editing and escaping
by Aris Feryanto 19 Aug '11

19 Aug '11

On 19 Agu 2011, at 20:37, Marc Delisle <marc(a)infomarc.info> wrote: > Michal Čihař a écrit : >> Hi >> >> Dne Fri, 19 Aug 2011 08:20:45 -0400 >> Marc Delisle <marc(a)infomarc.info> napsal(a): >> >>> Michal Čihař a écrit : >>>> Hi >>>> >>>> Dne Fri, 19 Aug 2011 08:00:31 -0400 >>>> Marc Delisle <marc(a)infomarc.info> napsal(a): >>>> >>>>> Aris Feryanto a écrit : >>>>>> On 19 Agu 2011, at 15:36, Aris Feryanto <aris_feryanto(a)yahoo.com> >>>>>> wrote: >>>>>> >>>>>>> Hi Michal, >>>>>>> >>>>>>>> From: Michal Čihař <michal(a)cihar.com> >>>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> it looks like grid editing does not properly handle escaping HTML >>>>>>>> entities. Just try importing test/test_data/exploit_test.sql and >>>>>>>> edit any row in exploit_test.evil_content. >>>>>>>> >>>>>>> Thank you for pointing this out. I fixed this in my git. >>>>> Ok but I believe I've seen a recent commit by Michal that fixed this >>>>> kind of problem in a quicker way; it was about using .html(x) instead of >>>>> .text(x) or the reverse :) >>>>> >>>>> Michal, can you enlighten us? >>>> It was on security list for inline editing :-). >>> It was not a commit? >> >> No, because I was totally unsure about it. Herman has reviewed itand >> pushed it to MAINT_3_4_4-security about hour ago. > > Right, I should buy more RAM for my brain. > > Aris, could you make some tests to see if this technique could replace > your new escaping function PMA_htmlEncode()? > > Instead of > $somejQueryObject.html(new_html); > > use > $somejQueryObject.text(new_html); > Right, Marc. When I was fixing this bug, I decided to use above technique to handle the HTML escaping. I just forgot to push my commits that removed the PMA_htmlEncode function. But, since .text() cannot handle new line reliably [0], the new lines in grid edited cells may disappear for some browsers. I googled to find a solution for this, but cannot find the best cross-browser solution. [0] http://api.jquery.com/text/ : (Due to variations in the HTML parsers in different browsers, the text returned may vary in newlines and other white space.) -- Aris Feryanto

2 1

Re: [Phpmyadmin-devel] Grid editing and escaping
by Aris Feryanto 19 Aug '11

19 Aug '11

On 19 Agu 2011, at 15:36, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: > Hi Michal, > >> From: Michal Čihař <michal(a)cihar.com> >> >> Hi >> >> it looks like grid editing does not properly handle escaping HTML >> entities. Just try importing test/test_data/exploit_test.sql and edit >> any row in exploit_test.evil_content. >> > > Thank you for pointing this out. I fixed this in my git. > I also change the way of grid editing a bit. For normal text, the grid editing is shown without 'edit area' (bigger editing area under the edited cell) anymore. I think this is better than having two input field for one edited cell. -- Aris Feryanto

3 5

[Phpmyadmin-devel] Zoom-search and panning feature
by Ammar Yasir 19 Aug '11

19 Aug '11

Hi, I guess there is no inbuilt panning feature available for Highcharts yet. I also looked around in the Highstock demos (which has pan feature) on whether we can use the feature from there. The problem is that the zoom feature in Highcharts uses the click and drag mouse wheel event, so we cant use those events for pan as Highstock does. If we want to have a pan feature with inbuilt zoom of Highcharts, we would have to use a button panel or similar. Otherwise write our own zoom and pan feature?

4 9

[Phpmyadmin-devel] Browse foreign values in table search
by Madhura Jayaratne 19 Aug '11

19 Aug '11

Hi Ammar, 'Browse foreign values' in table search does not seem to work correctly. Although you can browser foreign values in the newly opened window, it does not enter the value being selected. Id of the field seems to cause this and I'm not sure why there are two id s (line 182/183 and 187/188 of table_select.lib.php). Could you please have a look at it. -- Thanks and Regards, Madhura Jayaratne

1 0

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #305
by michal＠cihar.com 19 Aug '11

19 Aug '11

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/305/changes> Changes: [michal] Wrap some long lines [michal] Factor out code escaping from echo [michal] Function for setting variable [michal] Use PMA_AddJSVar [michal] Use PMA_AddJSVar [michal] Handle more types in js variable formatting [michal] Add test for js escaping ------------------------------------------ [...truncated 201 lines...] [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 258 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:38 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:542 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:484 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1132 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1252 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:471 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:192 [exec] Result: 1 phploc: [exec] phploc 1.6.1 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 321 [exec] [exec] Lines of Code (LOC): 107303 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 32848 [exec] Non-Comment Lines of Code (NCLOC): 74455 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 79 [exec] Abstract: 3 (3.80%) [exec] Concrete: 76 (96.20%) [exec] Average Class Length (NCLOC): 193 [exec] Methods: 741 [exec] Scope: [exec] Non-Static: 648 (87.45%) [exec] Static: 93 (12.55%) [exec] Visibility: [exec] Public: 608 (82.05%) [exec] Non-Public: 133 (17.95%) [exec] Average Method Length (NCLOC): 20 [exec] Cyclomatic Complexity / Number of Methods: 3.54 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 714 [exec] [exec] Constants: 119 [exec] Global constants: 109 [exec] Class constants: 10 BUILD SUCCESSFUL Total time: 2 minutes 20 seconds [CHECKSTYLE] Collecting checkstyle analysis files... CHECKSTYLESuccessfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 21023 warnings. [DRY] Collecting duplicate code analysis files... DRYSuccessfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 26 warnings. [TASKS] Scanning workspace files for tasks... Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2011-08-19_10-51-12/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at BUILD level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2011-08-19_10-51-12/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2011-08-19_10-51-12/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit-3.4 (default)' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Stopping recording.

1 1

[Phpmyadmin-devel] Grid editing and escaping
by Michal Čihař 19 Aug '11

19 Aug '11

Hi it looks like grid editing does not properly handle escaping HTML entities. Just try importing test/test_data/exploit_test.sql and edit any row in exploit_test.evil_content. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

2 1

[Phpmyadmin-devel] Bug in Ajax table Structure column Change
by Marc Delisle 19 Aug '11

19 Aug '11

Thilanka, could you have a look at this bug? I can reproduce it. https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3392824&group_… -- Marc Delisle http://infomarc.info

2 3

[Phpmyadmin-devel] SQL Pretty printer
by Tyron Madlener 19 Aug '11

19 Aug '11

On Thu, Aug 18, 2011 at 1:02 PM, Michal Čihař <michal(a)cihar.com> wrote: > Hi > > Dne Wed, 17 Aug 2011 20:45:44 +0300 > Tyron Madlener <tyronx(a)gmail.com> napsal(a): > >> Ok I just added this behavior myself. We just need a new css class for >> this now. Maybe it makes sense to give statements verbs a different >> color, let's say blue? Or better just the same keyword color? > > I think it should stay consistent with PHP parser/highlighter, so see > $GLOBALS['cfg']['SQP']['fmtColor'] for possible types. > I've just added a css rule for this with using the same as 'keyword' for now. I've also took the liberty to fix up the matching of multipart keywords such as "insert into", "group by". Those are now identified as one keyword instead of both being identified individually. And the reason for these 2 changes is because I've now implemented a sql pretty printer using the codemirror/mysql-mode tokenizer. This replaces the bunch of regex's that I used earlier to pretty print queries in the query analyzer dialog, since they fail in many cases. The new implementation should now pretty print any query correctly, including subqueries. I could need some more test data though. I've added this feature in the form of PMA_SQLPrettyPrint() in functions.js - maybe we use it for the sql query editor as well? Here's a screenshot of how it looks like: http://www.tyron.at/tmp/prettyprinter.png

2 1

[Phpmyadmin-devel] Codemirror highlighting glitch
by Tyron Madlener 18 Aug '11

18 Aug '11

Michal, The MySQL highlighter mistakenly highlights any word as function that are contained in the function list, even if they don't have the functions brackets appended. In my case with the substring "MAX(x)" the highlighter interprets 'MAX' as well as 'x' as function.

2 4

Re: [Phpmyadmin-devel] column reorder potential problem
by Aris Feryanto 17 Aug '11

17 Aug '11

On 12 Agu 2011, at 03:28, Marc Delisle <marc(a)infomarc.info> wrote: > Aris Feryanto a écrit : >> Hi Marc, >> >>> From: Marc Delisle <marc(a)infomarc.info> >> >>> Aris Feryanto a écrit : >>>> Hi, >>>> >>>>> From: Aris Feryanto <aris_feryanto(a)yahoo.com> >>>>> Hi Marc, >>>>> >>>>>> From: Marc Delisle <marc(a)infomarc.info> >>>>>> Aris, >>>>>> >>>>>> please have a look at [0]. It's interesting to see your code >>> being >>>>>> tested by many users at such an earlier stage. >>>>>> >>>>>> [0] >>>>>> >>> https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3386436&group_… >>>>> Thanks for noticing this. I just looked at the bug report: >>>>> >>>>> Details: The column reorder-patch breaks or complicates the selection >>> the text >>>>> of a column in FF5, especially for (smaller) id columns. >>>>> >>>>> >>>>> In my test, I cannot reproduce this after reordering some columns. The >>> bug only >>>>> happen after shift+click to select some rows in a table. This is a >>> known >>>>> disadvantage of enabling shift+click (I've stated this in when we >>> were >>>>> discussing to enable shift+click feature). Should we change it? >>>>> >>>>> Another way to keep the shift+click feature and text-selection work >>> together: >>>>> use javascript to clear selection after shift+click, but it makes the >>> screen >>>>> flickering for a while. You may try this in "clear_selection" >>> branch >>>>> in my git. >>>>> >>>> Any comment on the text selection problem? >>> Aris, >>> I cannot reproduce this problem. By the way, I believe that what Sven >>> Strickroth means is not that to reproduce the problem, you have to >>> reorder the columns. He means that since this patch has been merged, he >>> has this problem. >>> >>> You might want to clarify this with him, in the bug tracker. >> >> Yes, you are right. I just want to know exactly if he had the same issue like the one that I found. >> >> Here is my scenario to reproduce the text selection problem: >> - browse a table >> - make a selection in some text inside the table interface and notice that the text can be selected > > I tried with current master. > > Do you mean selecting some text which is part of the data rows? Yes, correct. Do you get the same problem? > >> - click on one of the checkboxes in the table rows >> - now, try to make a text selection again and notice that the text cannot be selected anymore >> >>> Also, ask him if he has FF extensions other than Firebug, and what is >>> his workstation platform. >>> >> -- Aris Feryanto

2 7