August 2011 - Developers - lists.phpmyadmin.net

Re: [Phpmyadmin-devel] Date-time picker
by Aris Feryanto 22 Aug '11

22 Aug '11

On 23 Agu 2011, at 02:29, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: > 2011/8/22 Tyron Madlener <tyronx(a)gmail.com>: >> On Mon, Aug 22, 2011 at 8:23 PM, Madhura Jayaratne <madhura.cj(a)gmail.com> wrote: >>> Hi Aris, >>> The icon to open the date-time picker in table-insert and table-search pages >>> has gone missing. >>> It seems like condition if ($.datetimepicker != undefined) in function.js >>> (line 688) is causing this. Was this condition added to prevent some JS >>> errors or can we remove it? >>> Also, the date-time picker does not seem to display the month anywhere or >>> change the year at the top when the arrows on either side of it are clicked. >>> >> >> Piotr added this line with commit >> 84cc7837f5da69c588f7503da0acc9512ff29619, though I don't quite know >> why. >> > > I was seeing a JS error on server Status page, because the script was > trying to use $.datepicker which is there loaded on demand: .datefield > and .datetimefield elements exist there but they should be initialized > only when Monitor tab is used (timepicker's .js file is then > dynamically loaded). > I think the checking should be done with "$.fn.datetimepicker" instead of "$.datetimepicker". And about the month and year navigator, I found that it is firstly not working after addition of PMA_formatJsVal() function by Michal. But, I'm still not sure what's wrong with this. -- Aris Feryanto

1 0

[Phpmyadmin-devel] Date-time picker
by Madhura Jayaratne 22 Aug '11

22 Aug '11

Hi Aris, The icon to open the date-time picker in table-insert and table-search pages has gone missing. It seems like condition if ($.datetimepicker != undefined) in function.js (line 688) is causing this. Was this condition added to prevent some JS errors or can we remove it? Also, the date-time picker does not seem to display the month anywhere or change the year at the top when the arrows on either side of it are clicked. -- Thanks and Regards, Madhura Jayaratne

3 2

[Phpmyadmin-devel] Prototype of new navigation
by Rouslan Placella 22 Aug '11

22 Aug '11

Hi there, I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea. I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks. Rouslan [1]: http://demo.phpmyadmin.net/gsoc-rouslan/

7 18

[Phpmyadmin-devel] Zoom-search and dates
by Marc Delisle 22 Aug '11

22 Aug '11

Ammar, Zoom-search of date values needs improvement. Here is an example table: CREATE TABLE IF NOT EXISTS `birthday` ( `id` int(11) NOT NULL AUTO_INCREMENT, `name` varchar(50) NOT NULL, `birthday` date NOT NULL, PRIMARY KEY (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=latin1 AUTO_INCREMENT=5 ; INSERT INTO `birthday` (`id`, `name`, `birthday`) VALUES (1, 'A', '1950-01-01'), (2, 'B', '1950-02-02'), (3, 'C', '1960-03-03'), (4, 'D', '2000-04-04'); Generating a plot via zoom-search show that the same time elapsed between two days (in 1950) than in ten or forty years. If you could convert these dates to a number of days (probably at the Javascript layer), the same way than in MySQL [0], you would get meaningful results. Of course you still need to display the unconverted date value. [0] http://dev.mysql.com/doc/refman/5.5/en/date-and-time-functions.html#functio… -- Marc Delisle http://infomarc.info

5 20

[Phpmyadmin-devel] Zoom-search and missing data label
by Marc Delisle 22 Aug '11

22 Aug '11

Ammar, when data label is set to none: Notice in ./tbl_zoom_select.php#373 Undefined offset: 0 -- Marc Delisle http://infomarc.info

2 2

Re: [Phpmyadmin-devel] Grid editing and Browse foreign values
by Aris Feryanto 22 Aug '11

22 Aug '11

On 20 Agu 2011, at 22:54, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: > > On 19 Agu 2011, at 19:46, Marc Delisle <marc(a)infomarc.info> wrote: > >> Aris, >> >> in sakila.film_actor, grid editing a value of film_id and clicking >> "Browse foreign values" shows the values in another window but I can't >> pick a value and update the first window. >> >> With Edit it works fine. >> > > Hmm. Weird. It was working before. I'll look into this soon. > Fixed in my git. And I forgot to update something about grid editing: The grid editing now display a date(time) picker for datetime, date, or timestamp data type. In order to make the datetime picker work for grid editing, I replaced the js/jquery/timepicker.js by Martin Milesich [0] with a new timepicker by Trent Richardson [1]. Why? At first, I tried to display datetime picker with existing PMA_addDatePicker() function, which call a jQuery plugin function defined in js/jquery/timepicker.js. But, it didn't work. I need to append the datetime picker inside the "edit area", while it must update the selected date & time in the input box outside the edit area. It seems that the previous datetime picker cannot handle this case. Then, I opened link [0] and found the statement written by the author: "I would not recommend you to use this plugin because you may end up hitting your head against the wall. Instead, use the timepicker plugin from Trent Richardson." Then, I tried to use the new timepicker and it works! :) The new plugin also quite similar with the previous, so I only need to change a little amount of code in PMA_addDatePicker() function. -- Aris Feryanto

2 1

[Phpmyadmin-devel] top_panel.png
by Dieter Adriaenssens 22 Aug '11

22 Aug '11

Hi, Yesterday I was testing Piotr's branch and when visiting the Plugins page with Chrome, pma_homme theme, some image was not loaded : images/top_panel.png With Firefox or with the previous default theme, there was no problem. -- Groetjes, Dieter Adriaenssens

3 2

[Phpmyadmin-devel] "Monitor" broken in master
by Rouslan Placella 22 Aug '11

22 Aug '11

Tyron, The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure. Rouslan

3 7

[Phpmyadmin-devel] Grid editing and Browse foreign values
by Marc Delisle 20 Aug '11

20 Aug '11

Aris, in sakila.film_actor, grid editing a value of film_id and clicking "Browse foreign values" shows the values in another window but I can't pick a value and update the first window. With Edit it works fine. -- Marc Delisle http://infomarc.info

2 1

Re: [Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Operations -> table options
by Thilanka Kaushalya 20 Aug '11

20 Aug '11

Hi Marc, > 2. For "*Table options*" if I add the ajax behavior to submit the > > form without reloading the page I may need to replace all the > > table parameters which are currently embedded with the "*href*" > > attributes in the whole page. As an example it I change the table > > name from "actor" to "actor1" using "*Table options*" I may need > > to change the "*href*" of all four links in "*Table maintenance*" > > and "*Delete data or table*" to actor1 by using ajax. Is it okay > > to do that. > > Yes. > I tried to work with this feature. I faces following problems with that. 1. Currently the logic is handled under the "*if (isset($_REQUEST['submitoptions']))*" section in tbl_operations.php file. If I apply the ajax submission which submits the form without reloading the page, to this form I need to get the whole form as the response for the submission and replace it with the current form, because we don't know what values get changed. For getting the form as a response I need to get the html content of the updated "*Table operations*", so it will not be a small json response like in other cases (ex: in "Alter table oder by" ajax submission it retrieves a small json response with the message). So it will be costly for the operation. 2. Then if we used this form to rename the table (ex: "actor" to "actor1") we need to change each an every place where we use the actor name such as links in Top menu container, hidden fields in all the form within this page which carries the table name (ex: <input type="hidden" name="table" value="actor">. If not we have to replace whole page with the update page using ajax, but this is costly. So I think it is better to leave this option with the normal form submission without converting it to ajax submission. What is your idea on that. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

2 7