Hi Marc,
> 3. In "*Delete data or table*" section currently there is a
> > "*("#truncate_tbl_anchor").live('click'')*" action in functions.js
> > file. In there after using the $.get() function, the two frames
> > are reloaded. We can modify this action to stay at the same page
> > after "*Truncate the table*". We cannot apply ajax to "*Delete the
> > table(Drop)*" option because anyhow we have to quit the "*Table
> > options*" after deleting the table.
>
> Agreed.
>
>
I changed the logic in "#truncate_tbl_anchor" as it handles the ajax
submission and pushed the changes to the repo. Can you please check that.
Thank you.
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
On 5 Agu 2011, at 10:04, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote:
>> From: Marc Delisle <marc(a)infomarc.info>
>
>> Aris Feryanto a écrit :
>>>> From: Marc Delisle <marc(a)infomarc.info>
>>>
>>>> Le 2011-07-31 13:15, Aris Feryanto a écrit :
>>>>
>>>>>>>> 3. I hope that we'll get the OK from other
>> developers to
>>>> remove
>>>>>>>> the row inline edit feature, because with the current
>> code,
>>>>>>>>
>>>>>>>> 3.1 we have two features to do almost the same thing
>> 3.2
>>>>>>>> currently, clicking on inline edit then on a cell
>> activates the
>>>>>>>> grid editing!
>>>>>>> I hope so. Any objections?
>>>> Still waiting for input from other developers...
>>>
>>> It seems there is no objection about this. Instead, positive feedback from
>> other phpMyAdmin developers.
>>
>> Yes. Can you remove the row inline edit feature from your tree?
>
> Sure. I will work on this.
Removed in my git.
>
>>
>>>
>>>>>>>> 4. With this feature, we have the same problems as
>> with inline
>>>>>>>> edit, such as:
>>>>>>>>
>>>>>>>> 4.2 (major) For tables with a unique key, if this key
>> is
>>>>>>>> edited, the Edit, Copy and Delete links no longer
>> contain a
>>>>>>>> valid where_clause parameter and the multi-rows
>> actions at the
>>>>>>>> bottom (with selected) no longer work.
>>>>>>>>
>>>>>>>> 4.3 (major) For tables without a unique key, if any
>> column is
>>>>>>>> edited, the Edit, Copy and Delete links no longer
>> contain a
>>>>>>>> valid where_clause parameter and the multi-rows
>> actions at the
>>>>>>>> bottom (with selected) no longer work.
>>>>>>>
>>>>>>> Two problems above were fixed.
>>>>>> It's a good progress but the fix is not complete.
>>>>>>
>>>>>> About remark 4.2, the Delete link still refers to the old
>> unique
>>>>>> key.
>>>>> It's weird, since this works in my test. Could you please
>> check this
>>>>> again?
>>>> The real problem is that the confirmation message shown before deletion
>>>> still contains the old key. Deletion itself works but I had stopped to
>>>> test after seeing the wrong confirmation message.
>>>
>>> Fixed
>>
>> Confirmed.
>>
>>>
>>>>>> About remark 4.3, the Edit link still points to the old data
>> and
>>>>>> fails, in the case of a table lacking a unique key.
>>>>>>
>>>>> Same as the response for 4.2, this works on my test. Could you
>> check
>>>>> this again?
>>>> I confirm the problem, on a copy of the sakila.actor table where I have
>>>> removed all indexes. I think it's because the last_update column (a
>>>> timestamp) was updated via grid-editing but the URL still contains the
>>>> previous value.
>>>
>>> Fixed.
>>
>> Problem 4.3 exists in your current tree. Tested with the Edit link on
>> the sakila.actor table by changing the actor_id.
>
After some searching, problem 4.3 seems cannot be fixed, since any fields in where_clause can be modified when we execute an UPDATE statement (e.g., by Triggers, field with option "ON UPDATE CURRENT_TIMESTAMP").
IMO, the choices to solve this are:
- to alert user when grid editing a nonunique row (telling that some features related to the edited table may not work after editing), or
- disable the grid editing feature at all for nonunique rows
What would be the best choice?
>
>>
>>>
>>>> 5. Just found out another problem, when the configuration AjaxEnable is
>>>> set to false.
>>>>
>>>> Trying your version with latest commit
>>>> 0d197603085c43cac543351795b3df6de4167b96 with Firefox 5 on
>> sakila.actor,
>>>> I cannot change the actor_id then click "Save edited data".
>> Look what
>>>> is
>>>> generated:
>>>>
>>>> UPDATE `sakila`.`actor` SET = '4002' WHERE `actor2`.`actor_id`
>> =2
>>>>
>>>
>>>
>>> Regarding the AjaxEnable setting, should the grid editing works when
>> AjaxEnable is set to off?
>>
>> No.
>
> I will work on this.
>
Fixed.
--
Aris Feryanto
My name : Washington
Website http://www.goosefinder.com/blog I updated from softaculous to
wordpress 3.2.1 since then my website do not want to upload now it's showing
Internal Server Error can some help me do a databasebackup
My name : Washington
Website http://www.goosefinder.com/blog I updated from softaculous to
wordpress 3.2.1 since then my website do not want to upload now it's showing
Internal Server Error can some help me do a databasebackup
I noticed that the JS code that handles the recent tables in the
navigation frame operates under the assumption that there will only ever
be one dot in the database+table string. This is not true. To reproduce
the problem:
* create database 'abc.def'
* in this database create table 'ghi'
* browse this table
* now select it from the recent table dropdown
* you are dropped to main.php because PMA is looking for database 'abc'
and table 'def' (the 'ghi' part is discarded)
I'm not saying that it's sane to put dots in the database name, but it's
certainly legal. So maybe the check should be for the last occurrence of
a dot...
Rouslan
Hi,
I just tried Aris's new feature: grid editing (or Edit mode). A few
things are not ready, for example ENUM, SET and TEXT editing; however I
feel that with this, we won't need inline edit (for rows) any more.
--
Marc Delisle
http://infomarc.info
Hi,
I run Advisor on my MySQL 5.5 and got two bogus warnings:
1. The MySQL server version less then 5.1.
It's not, but the rule does something else that description says:
substr(value,0,3) != "5.1"
2. Version less then 5.1.30 (the first GA release of 5.1).
I have 5.5.14, and it is triggered by the rule "substr(value,4,2) <
30" - "14 < 30"
--
Regards,
Piotr Przybylski
Hi all,
I've been using phpMyAdmin for a while now and recently started with a
group focused on open source. Personally, I'd like to contribute with
phpMyAdmin. So I joined the list and going through the buglist I run
into issue: 3306875 Can't rename a database that contains views.
I'm still getting familiar with the code, so I could use some pointers
or directions that could help me find a solution for this one.
Thanks any help in advance.
--
Marcos Mendonça