August 2011 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Dismissable ajax messages
by Rouslan Placella 14 Sep '11

14 Sep '11

Hi there, I think that there is a problem with the current implementation of the PMA_ajaxShowMessage() function. The issue is that it has a fixed 5sec timeout. For error messages I think that it's too little, but for info messages it's way too much. I remember someone already mentioning here on the list this exact problem (though can't remember who or when). I wrote a patch [1] that increases the ajax message timeout to 10s and offers the users the possibility to dismiss any ajax message. With this patch applied, the user is shown a tooltip when hovering a notification, which lets him/her know that by clicking on the notification, it will be removed. However this tooltip is hidden when the user hovers over a link or a button, since by clicking one of those the user will actually follow the link rather than dismissing the notification (which I think would be the expected behaviour). I'd like to merge this commit to master branch, so please let me know what you think. Rouslan [1]: http://repo.or.cz/w/phpmyadmin/roccivic.git/commitdiff/dd566ec76c0e182f6367…

2 2

[Phpmyadmin-devel] Codemirror upgrade broke my features
by Rouslan Placella 11 Sep '11

11 Sep '11

Yesterday Tyron brought to my attention that the editors for Routines, Triggers and Events look quite bad now. I've tracked the issue down to the upgrade of codemirror to version 2.12 (before/after screenshot attached). And in particular these lines of code that were introduced in codemirror.js (lines 775-777): --->%--- // Needed to prevent odd wrapping/hiding of widgets placed in here. code.style.width = ""; code.style.width = scroller.scrollWidth + "px"; --->%--- I'd like to comment these lines out, since I don't think that there is any other way of fixing the issue. Any objections? Rouslan

2 4

[Phpmyadmin-devel] No response from multiple queries
by Tyron Madlener 30 Aug '11

30 Aug '11

As mentioned in bug 3364150 (https://sourceforge.net/tracker/?func=detail&aid=3364150&group_id=23067&ati…) executing multiple queries currently doesn't give the user any feedback when ajax requests is enabled. This is due to the fact that: - On multiple queries, no success message is shown, but instead, the query text is altered to append a comment displaying success or failure on each query - Due to the recent addition of codemirror, this text is not correctly updated anymore. (which could be fixed fairly easily though) I find this bug quite severe because it leaves the user in the dark of what pma is doing, so I would propose to fix this soon and properly. A proper fix, imo, should look like this: Executing multiple queries should behave the same as executing a single query, UI wise. With that I mean it should show the same type of sucess/error message box below the navigation. It could contain the following information: - When all queries were ok: "Querie(s) executed sucessfully" in a green box - When some queries failed: "x out of y Queries failed. Details" in a yellow box and 'Details' being a link to javascript-show the single mysql errors of each failing query - When all queries failed: "All queries failed. Details" in a red box, with Details being again a js-show-box-link

2 1

[Phpmyadmin-devel] Not able to connect to database
by namitha＠vibrantinfosystems.com 29 Aug '11

29 Aug '11

2 1

[Phpmyadmin-devel] phpMyAdmin 3.4.4 and 3.3.10.4 are released
by Marc Delisle 24 Aug '11

24 Aug '11

Welcome to phpMyAdmin 3.4.4, a bugfix and security release, and to phpMyAdmin 3.3.10.4, a security release. Please refer to the upcoming PMASA-2011-13 announcements on http://www.phpmyadmin.net/home_page/security. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Merging Drizzle support
by Piotr Przybylski 24 Aug '11

24 Aug '11

Hi, In a day or two I will be merging my Drizzle code into master, I just need some time to look through all my changes and check whether they need any refactoring. Is that ok? -- Regards, Piotr Przybylski

3 3

[Phpmyadmin-devel] datepicker and DATE columns
by Marc Delisle 23 Aug '11

23 Aug '11

Piotr, in current master, clicking Insert for a table with a DATE or DATETIME column does not show the picker icon. git bisect tells me that your commit 84cc7837f5da69c588f7503da0acc9512ff29619 caused this. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] Grid editing and null checkbox
by Madhura Jayaratne 23 Aug '11

23 Aug '11

Hi Aris, Out of the columns that can be made null, only some of the columns facilitate nullifying a value with grid editing. For example, while columns rating and special_features of sakila.film can be made null with grid editing, release_year and length of the same table cannot be made null. I feel it would be better if the behavior is consistent among all the columns that can be made null. -- Thanks and Regards, Madhura Jayaratne

3 2

Re: [Phpmyadmin-devel] Bug in Ajax table Structure column Change
by Aris Feryanto 23 Aug '11

23 Aug '11

Hi, On 19 Agu 2011, at 13:57, Thilanka Kaushalya <lgtkaushalya(a)gmail.com> wrote: Hi Marc, > > >I found the place where this issue generates. When we try click on Table->Structure->Column->Change link it goes to the tbl_alter.php file and within that the "append_fields_form" is process by using tbl_properties.inc.php file. At line number 325 in tbl_properties.inc.php "PMA_getSupportedDatatypes(true, $type_upper);" function is call to get the table type select options. > > >You can find at line 3118 in "PMA_getSupportedDatatypes(true, $type_upper);" the option selection is set as >if ($selected == $value) { > $retval .= "<option selected='selected'>$value</option>"; > } else { > $retval .= "<option>$value</option>"; > } > But if you use an echo you can see that $selected contains VARCHAR(45)as the value and $value contains VARCHAR as the value. So when we try to edit the tables which are having VARCHAR type columns it does not select the value at the options. > > >I can modify the logic by splitting the $selected by "(" and solve the issue. Is there any better solution you can suggest. If there any please let me know. Thank you. > I did a bisecting in the official branch (using "git bisect" command) and found that 48149c261c633baf517455079a2524a9a9aac6a0 (message: "Use already calculated values", by Michal) is the first bad commit. Hope this helps. -- Aris Feryanto

4 4

Re: [Phpmyadmin-devel] Date-time picker
by Aris Feryanto 23 Aug '11

23 Aug '11

On 23 Agu 2011, at 02:57, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: > > On 23 Agu 2011, at 02:29, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: > >> 2011/8/22 Tyron Madlener <tyronx(a)gmail.com>: >>> On Mon, Aug 22, 2011 at 8:23 PM, Madhura Jayaratne <madhura.cj(a)gmail.com> wrote: >>>> Hi Aris, >>>> The icon to open the date-time picker in table-insert and table-search pages >>>> has gone missing. >>>> It seems like condition if ($.datetimepicker != undefined) in function.js >>>> (line 688) is causing this. Was this condition added to prevent some JS >>>> errors or can we remove it? >>>> Also, the date-time picker does not seem to display the month anywhere or >>>> change the year at the top when the arrows on either side of it are clicked. >>>> >>> >>> Piotr added this line with commit >>> 84cc7837f5da69c588f7503da0acc9512ff29619, though I don't quite know >>> why. >>> >> >> I was seeing a JS error on server Status page, because the script was >> trying to use $.datepicker which is there loaded on demand: .datefield >> and .datetimefield elements exist there but they should be initialized >> only when Monitor tab is used (timepicker's .js file is then >> dynamically loaded). >> > > I think the checking should be done with "$.fn.datetimepicker" instead of "$.datetimepicker". > > And about the month and year navigator, I found that it is firstly not working after addition of PMA_formatJsVal() function by Michal. But, I'm still not sure what's wrong with this. > After investigating a bit, I found that line 99 in js_escape.lib.php should be: 97: $result .= '['; 98: foreach ($value as $id => $val) { 99: $result .= PMA_formatJsVal($val) . ","; 100: } the PMA_formatJsVal should take $val instead of $value as the parameter. -- Aris Feryanto

2 1